GitLab

If reading the SW resources from the disk cache fails, we should evict
the worker or else we will keep getting the same failure.

This patch unsets the worker from the live registration, and then
deletes the registration if the SW was the stored version.

BUG=448003

Review URL: https://codereview.chromium.org/1098083003

Cr-Commit-Position: refs/heads/master@{#327000}

This patch fixes the regression which is caused by the following CL.
https://chromium.googlesource.com/chromium/src/+/3315eb5fe7bcb9300995dae3326de2d2c5f3c44a

Since the Styx URLs are updated in that CL, we need to use DriveApiUrlGenerator::GenerateDownloadFileURL to create a download URL to pass a cast device.

BUG=477733
TEST=can cast a video

Review URL: https://codereview.chromium.org/1055403004

Cr-Commit-Position: refs/heads/master@{#326999}

BUG=

Review URL: https://codereview.chromium.org/1096203008

Cr-Commit-Position: refs/heads/master@{#326998}

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/1088903011

Cr-Commit-Position: refs/heads/master@{#326997}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9de7917..2f6785b

TBR=

Review URL: https://codereview.chromium.org/1066873004

Cr-Commit-Position: refs/heads/master@{#326996}

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/596/steps/compile/logs/stdio

..\..\base/win/shortcut.h(51,3) :  warning(clang): [chromium-style] Complex constructor has an inlined body.
ShortcutProperties() : icon_index(-1), dual_mode(false), options(0U) {}
                      ^
..\..\base/win/shortcut.h(32,1) :  warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
struct ShortcutProperties {
    ^
2 warnings generated.

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1100403003

Cr-Commit-Position: refs/heads/master@{#326995}

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/1077323003

Cr-Commit-Position: refs/heads/master@{#326994}

Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.

Ran the following command:
for x in $(git ls-files | grep -E "\.(cc|h|mm)$") ; do perl -0777 -i -pe 's/,[ \n]*(user_prefs::)+PrefRegistrySyncable::UNSYNCABLE_PREF//igs' $x ; done && git cl format

There are still some occurences that need to be manually fixed.

BUG=476800

Review URL: https://codereview.chromium.org/1102733002

Cr-Commit-Position: refs/heads/master@{#326993}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8daf7c3..9de7917

TBR=

Review URL: https://codereview.chromium.org/1108743002

Cr-Commit-Position: refs/heads/master@{#326992}

This moves all pref registration functions from PrefRegistrySyncable
into PrefRegistrySimple and changes PrefRegistrySyncable to derive
from PrefRegistrySyncable. This is done to consolidate the registration
functions in a single place that can be used by syncable and unsyncable
prefs.

BUG=476800

Review URL: https://codereview.chromium.org/1095673003

Cr-Commit-Position: refs/heads/master@{#326991}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dccf813..8daf7c3

TBR=

Review URL: https://codereview.chromium.org/1083673006

Cr-Commit-Position: refs/heads/master@{#326990}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6682798..dccf813

TBR=

Review URL: https://codereview.chromium.org/1104863004

Cr-Commit-Position: refs/heads/master@{#326989}

Blink rebaselines for SK_SUPPORT_LEGACY_COLOR32_MATH have landed.

BUG=480013
TBR=reed@google.com,mtklein@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/1088083004

Cr-Commit-Position: refs/heads/master@{#326988}

BUG=466848

Review URL: https://codereview.chromium.org/1097083004

Cr-Commit-Position: refs/heads/master@{#326987}

BUG=480013
TBR=mtklein@google.com,reed@google.com

Review URL: https://codereview.chromium.org/1095513004

Cr-Commit-Position: refs/heads/master@{#326986}

  since browsing_data/ is now under components/

BUG=471287
Test=None, internal only change without visible side effects.

Review URL: https://codereview.chromium.org/1056793002

Cr-Commit-Position: refs/heads/master@{#326985}

renderer and test do not need to depend on it and
compositor_impl_android.cc does not use content_provider_in_process.h
either.

BUG=338338
R=avi@chromium.org

Review URL: https://codereview.chromium.org/1101403002

Cr-Commit-Position: refs/heads/master@{#326984}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/283b587..5d23c38

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1103973003

Cr-Commit-Position: refs/heads/master@{#326983}

BUG=

Review URL: https://codereview.chromium.org/1067583004

Cr-Commit-Position: refs/heads/master@{#326982}

It contains information of how the user closed the "Save password?" bubble in the past. Basing on this data two different algorithms are to be implemented so the bubble isn't so annoying for the users.

BUG=431739

Review URL: https://codereview.chromium.org/1083293004

Cr-Commit-Position: refs/heads/master@{#326981}

This CL uses the MockConnection for bump scrolling browser test.
This will make the test more resilient to network failures.

BUG=478331

Review URL: https://codereview.chromium.org/1086563005

Cr-Commit-Position: refs/heads/master@{#326980}

This makes the new trybots actually build the same targets
as the waterfall bots, rather than 'all' (which doesn't
work at the moment).

TBR=phajdan.jr@chromium.org
BUG=477879

Review URL: https://codereview.chromium.org/1078983006

Cr-Commit-Position: refs/heads/master@{#326979}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/130444f..283b587

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1053673009

Cr-Commit-Position: refs/heads/master@{#326978}

The bug is in Apple's CL_extractCSSMKeyNSS, specifically when it allocates some
memory directly at the top of the function. Move it out of the Chromium bugs
section and cite openradar.

BUG=481286

Review URL: https://codereview.chromium.org/1102673006

Cr-Commit-Position: refs/heads/master@{#326977}

Store the output of View::OnPaint as a PaintCache object, and when the
view has not been invalidated, use that cache output instead of doing
work to build a recording.

Performance data as follows when the loading spinner is going:

Before impl-side (TOT): 0.13ms / paint
With impl-side (no slimming paint): 0.22ms / paint
With impl-side and slimming paint (this patch): 0.17ms / paint

So this gets us some of the way there. I need to investigate why it's
not doing more.

R=piman@chromium.org, sky
BUG=466426

Committed: https://crrev.com/7f686cdcff81d6779b962e98e529a7360be2809c
Cr-Commit-Position: refs/heads/master@{#326592}

Review URL: https://codereview.chromium.org/1101783002

Cr-Commit-Position: refs/heads/master@{#326976}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/be357282..d3c652f0

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1103963002

Cr-Commit-Position: refs/heads/master@{#326975}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8e71d38..130444f

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1107643003

Cr-Commit-Position: refs/heads/master@{#326974}

This was broken in #326948; NaCl doesn't build in component debug yet ...

TBR=sigbornf@opera.com
BUG=

Review URL: https://codereview.chromium.org/1104913002

Cr-Commit-Position: refs/heads/master@{#326973}

This CL has just two files which got some extra "while I'm in there" cleanup while doing mechanical fixups across the codebase.

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

BUG=417463

Review URL: https://codereview.chromium.org/1106043002

Cr-Commit-Position: refs/heads/master@{#326972}

IsOriginSecure() implements web platform feature [1] and it'd be
more natural to provide this at content-layer.
Also ServiceWorker actually wants to call this in content layer
for browser-side security check.

https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.

This CL moves IsOriginSecure() from
chrome/common/origin_util.{h,cc} to
content/{public/,}/common/origin_util.{h,cc}

and adds a following method to ContentClient so that ChromeContentClient
can add chrome-level schemes (and whitelisted origins, this is to be
implemented in crbug.com/441605).

  // Gives the embedder a chance to register additional schemes and origins
  // that need to be considered trustworthy.
  // See https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.
  virtual void AddSecureSchemesAndOrigins(std::set<std::string>* schemes,
                                          std::set<GURL>* origins) {}

BUG=362214, 441605
TEST=content_unittests:URLSchemesTest.IsOriginSecure

Review URL: https://codereview.chromium.org/1101033003

Cr-Commit-Position: refs/heads/master@{#326971}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9432a893..be357282

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1092973005

Cr-Commit-Position: refs/heads/master@{#326970}

BUG=430156,345874
TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1103023003

Cr-Commit-Position: refs/heads/master@{#326969}

Instead build our own simplified version, so we don't need to depend on
webkit/common/gpu.

This should help ease the transition of
https://codereview.chromium.org/920443003.

Tested on Android (with Nexus 5 device) with the following command
lines:

$ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android
$ ninja -C out_android/Debug android_webview_apk android_webview_test_apk
$ export CHROMIUM_OUT_DIR=out_android
$ build/android/adb_install_apk.py --apk=AndroidWebView.apk --debug
$ build/android/test_runner.py instrumentation --test-apk=AndroidWebViewTest \
  --test_data webview:android_webview/test/data/device_files --debug

BUG=338338
TEST=see above
R=boliu@chromium.org

Review URL: https://codereview.chromium.org/1083843002

Cr-Commit-Position: refs/heads/master@{#326968}

BUG=470984
TEST=

Committed: https://crrev.com/163a4a63af5e56801395eed067a69e501e7b51a5
Cr-Commit-Position: refs/heads/master@{#326691}

Review URL: https://codereview.chromium.org/1097663003

Cr-Commit-Position: refs/heads/master@{#326967}

Cr-Commit-Position: refs/heads/master@{#326966}

Cr-Commit-Position: refs/heads/master@{#326965}

BUG=480980

Review URL: https://codereview.chromium.org/1097353004

Cr-Commit-Position: refs/heads/master@{#326964}

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001

for details

BUG=

Review URL: https://codereview.chromium.org/1106503003

Cr-Commit-Position: refs/heads/master@{#326963}

media_cast_mode.{cc,h}
A cast mode represents one way that the current WebContents (i.e., tab) may be presented to a media sink.

media_sink_with_cast_modes.{cc,h}
Contains information on a MediaSink and the set of cast modes it is compatible with.

Also includes strings, unit tests and .gyp/.gn updates.

BUG=464208

Review URL: https://codereview.chromium.org/1066683008

Cr-Commit-Position: refs/heads/master@{#326962}

Previously, telemetry read the whole '/proc/timer_list' file just to parse the
first occurence of "jiffies". In case the file is big and telemetry is run
against remote device, this can create a big delay for transferring the file
to host device.

This patch modify it so that telemetry just use
'grep jiffies /proc/timer_list' to get the only lines that contain 'jiffies'.

Context: https://groups.google.com/a/chromium.org/forum/#!topic/telemetry/SblQqF0tHbc

Try job runs:
./tools/perf/run_benchmark --browser=trybot-all-android page_cycler.top_10_mobile --also-run-disabled-tests
https://codereview.chromium.org/1100233003

./tools/perf/run_benchmark --browser=trybot-all-mac page_cycler.intl_ja_zh
https://codereview.chromium.org/1106833004

./tools/perf/run_benchmark --browser=trybot-all-linux page_cycler.intl_ja_zh
https://codereview.chromium.org/1102673005

Review URL: https://codereview.chromium.org/1106043003

Cr-Commit-Position: refs/heads/master@{#326961}