- 24 Apr, 2019 40 commits
-
-
Matthew Denton authored
Glibc's system() function switched to using posix_spawn, which uses CLONE_VFORK. Pepperflash includes a sandbox debugging check which relies on us EPERM-ing process creation like this, rather than crashing the process with SIGSYS. So whitelist clone() calls, like posix_spawn, that include the flags CLONE_VFORK and CLONE_VM. Bug: 949312 Change-Id: I3f4b90114b2fc1d9929e3c0a85bbe8f10def3c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568086 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#653590}
-
John Budorick authored
Should allow luci-migration to experiment on this despite the rename. Also removes a no-longer-necessary similar configuration for android-marshmallow-arm64-rel's old name. Bug: 731988 Change-Id: Ie806043618101a943f9e8fcf6b24fd85f5fc187b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580759 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#653589}
-
Mike Wittman authored
This struct is no longer used in the test. Bug: 909957 Change-Id: I517f3647778971b51283343811e928d92e595b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579912 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653588}
-
Yi Gu authored
The test is not failing anymore. Update the test expectation to reflect that. See: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fthreaded%2Fexternal%2Fwpt%2Fanimation-worklet%2Fplayback-rate.https.html Change-Id: Ibf9fa97ab202a9c34852a292bdeeb8a5eaf55ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582048Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#653587}
-
Mike Wittman authored
Coalesces all the unwinding scenario tests into the same part of the file. Bug: 909957 Change-Id: I5cc7cd00dc298e1c5adf1d9ad4d1585f5495b256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580142 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#653586}
-
Henrique Ferreiro authored
As advised in [1], after porting all uses of Foo::Create() to MakeGarbageCollected<Foo>() in //third_party/blink/renderer/core/svg, this CL removes the unused factory methods. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I5e98359a98907fadb56915c5a23bada3e633fc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574804 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653585}
-
Kevin Ellis authored
Previously a finished animation would fire the finished event on the next animation tick. This is not to specification, as the finished event should trigger immediately (https://drafts.csswg.org/web-animations/#finishing-an-animation-section). The discrepancy with the spec manifested as test failures when the state of an animation is updated after finishing. In some cases, the animation no longer registers as finished at the time of the next tick and the finished event is dropped. Bug: 772060, 772048, 771977 Change-Id: Ie4161face4e6d5ed9b07bee86fef68b718233d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572803Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#653584}
-
Ian Kilpatrick authored
This allows us to reuse layout results when affected by clearance. We can't do this when: 1. The "old" clearance offset isn't equal to the layout results offset. 2. The difference between the constraint's BFC-block-offset, and the clearance offset shrinks (e.g. a margin may affect the final position). I'm not sure if (1) actually should be a DCHECK. Bug: 635619 Change-Id: Ic92063882914d4da7a4b168783ec2f2af82ec1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574836 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#653583}
-
Mike Klein authored
I suspect the rebased path is tripping up GOMA? Change-Id: If6984fdbd4f3ac1bf673bf810ea28bd16a860175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582043 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#653582}
-
Henrique Ferreiro authored
As advised in [1], after porting all uses of Foo::Create() to MakeGarbageCollected<Foo>() in //third_party/blink/renderer/core/svg, this CL removes the unused factory methods. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I6a9d7dcc5a4c00497d35987bb91cfef69a95784a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576564 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653581}
-
kylechar authored
Remove some usage of deprecated callback types in base/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Bug: 714018 Change-Id: Idb7bf334fb06a407bf65e4ffb4cc2e19dd8a5195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572809 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653580}
-
Sky Malice authored
Bug: 955174 Change-Id: Id6a01cb3f237a088add8062717d8354b77cefa52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577932Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#653579}
-
Alan Cutter authored
We intend to launch PWA Omnibox install in 76 so update expiry to be 3 milestones later. Bug: 907351 Change-Id: Ib6f59f1184f5a0a046a488fa2570d026cf5f69ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580987 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2695bdcbd7bb..70001899ab44 Created with: gclient setdep -r src-internal@70001899ab44 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I2847fdc9273c5cd29dc3d9bf3efff15e312192b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582008Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653577}
-
PKH authored
R=pshmakov TBR=yfriedman BUG=None Change-Id: I93cc93ac9fc95cc9965617e16aed38c8cee4e6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568776 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#653576}
-
Daniel Bratell authored
gn check --check-generated reported a missing build dependency and this fixes that. An example of a reported error is: ERROR at //out/Default/gen/ui/latency/mojo/latency_info.mojom-forward.h:44:11: Can't include this header from here. ^---------------------- The target: //ui/latency/mojo:interfaces is including a file from the target: //ipc:ipc Since the header isn't actually used, the simple fix is to remove it, though that revealed some other code that was missing includes of their own. Bug: 938893 Change-Id: I8e2648d5e681ee9640282eab31028a102cdc96eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550467Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#653575}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I12580470b68aeec1331019be33c96847592b10c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576563 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#653574}
-
Peng Huang authored
Bug: 944194 Change-Id: I9afec626d7cd98c31130360a8103ac9e13fef619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582044 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#653573}
-
Marc Treib authored
Before this CL, this was broken if kStopSyncInPausedState was enabled: Entering "Sync paused" would shut down the Sync machinery, but exiting that state didn't start it up again. This CL fixes that by making SyncAuthManager notify the SyncService when exiting "Sync paused", so that the SyncService can then decide if it should start up again. This CL also updates SyncAuthTest.SyncPausedState so that is passes both with and without kStopSyncInPausedState. Bug: 954195 Change-Id: I9412408b1c3b868a71574d1f70a49782636d8de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581959 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#653572}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/505f9c976576..8044f5ea87ef git log 505f9c976576..8044f5ea87ef --date=short --no-merges --format='%ad %ae %s' 2019-04-24 hjd@google.com Add merged protos to Bazel build Created with: gclient setdep -r src/third_party/perfetto@8044f5ea87ef The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I821b008f0424ddb3836853b142754c42ba3b46d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582006Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653571}
-
Sébastien Séguin-Gagnon authored
If we receive a shared tab when the user is not on a visible WebState (e.g. Tab Grid or Settings Page), we register as observers to 2 things: 1- The WebStateList in case the user creates a new tab, or activates a different tab. 2- The active but not visible WebState, in case the user comes back to it. When either is triggered, we'll show the infobar on the relevant WebState and then stop observing these objects. Bug: 944602 Change-Id: I33d1505fd639b37ed82ef22c24151b6bc8a1c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574118 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#653570}
-
Henrique Ferreiro authored
This CL moves the missing logic from Create() factory methods to the corresponding constructors in core/html and ports third_party/blink/renderer/build/scripts/templates/element_factory.cc.tmpl to MakeGarbageCollected. Bug: 939691 Change-Id: I0f3e98071cdbbf6ad92cc816f20003311a278233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578610 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653569}
-
Maksim Moskvitin authored
Bug: 922900 Change-Id: I61d54db699e00a99ddbbcc95a6516411ab520ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552806 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653568}
-
Henrique Ferreiro authored
This CL removes `inline` specifiers from constructors in core/html classes to prepare for porting third_party/blink/renderer/build/scripts/templates/element_factory.cc.tmpl to MakeGarbageCollected. Bug: 939691 Change-Id: Ic6ccd6ad5f38382453ae11d19720ae7012061659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578546Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#653567}
-
Gabriel Charette authored
Disable flaky TwoClient(Passwords|CustomPassphrase)SyncTest.SetPassphraseAndThenSetupSync on OS_CHROMEOS R=treib@chromium.org Bug: 956012 Change-Id: I138bc34165986d185a530e11accd0f60a22b5559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582040Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#653566}
-
Aditya Keerthi authored
This reverts commit e9dec932. Reason for revert: Bug 955953. Original change's description: > ThreadPool: PlatformNativeWorkerPoolWin should use CallbackMayRunLong for blocking tasks > > The Windows Thread Pool API provides a CallbackMayRunLong method to > indicate that a callback may not return quickly. The thread pool can use > this information to better determine when a new thread should be > created. > > This CL teaches PlatformNativeWorkerPoolWin about ScopedBlockingCall in > order to determine whether a callback will return quickly. A > BlockingObserver is registered before running a task in the work > callback. If the task contains a ScopedBlockingCall, the observer is > notified, and will call CallbackMayRunLong on the appropriate > PTP_CALLBACK_INSTANCE. > > Bug: 756547 > Change-Id: If04d2c5e01b00960dc510e94ff89525036c2ae67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574229 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653252} TBR=fdoray@chromium.org,adityakeerthi@google.com Change-Id: I91aa15b2dbc47288bacdf42c840dd57f484b7d16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582179Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653565}
-
David Roger authored
This reverts commit 252ccf31. Reason for revert: the test was marked "Slow", and should not longer fail. Original change's description: > Disable flaky test serviceworker-proxied/thorough/auth-other-https.html > > The test is timing out. > > TBR=ricea > > Bug: 955883 > Change-Id: Ia780e55b9f3629e91037a1d3795d832925e0fbfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581340 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653523} Change-Id: I8e028991c25343e0cf85bf8bc94ea17fcbdf7619 Bug: 955883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581559Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653564}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/923ad6b5efb0..2695bdcbd7bb Created with: gclient setdep -r src-internal@2695bdcbd7bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=cmumford@chromium.org,gab@chromium.org,droger@chromium.org Change-Id: I6cf79de7cbee0c43346607570f8eb2525240f2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582003Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653563}
-
Ting Shao authored
When send response info to client of resume type ServiceWorkerNewScriptLoader. OnStartLoadingResponseBody() is also called no matter the body is empty or not. Bug: 648295 Change-Id: Id97ab5e3965e5860e7172098291f10b1bfe4a151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577928Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ting Shao <ting.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#653562}
-
Antonio Gomes authored
... now that it was OnionSoup'ed [1]. [1] crrev.com/1576468 R=haraken@chromium.org BUG=787245 Change-Id: I73cd73537ec02f9eda9798d4e34c3d4341c7753c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582139 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#653561}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99694fa3..2723b186 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06542346a786dd304223243983948f9a191c16ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582039Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653560}
-
Allen Bauer authored
Updated usages to a visible changed callback. Bug: 938501 Change-Id: I01fe4f9f21f3f5b40fedb05edde0331afce97604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505848 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#653559}
-
Michael Ludwig authored
Skia uses two sources for its bounds during a saveLayer call: the current clip and a user-provided bounds hint. SkiaRenderer calculates the final filtered bounds for the combination of the RPDQ's visible_rect and the backdrop_filter_bounds of the quad, and it used to provide those bounds as both a clip and the hint. It turns out that Skia will automatically adjust any provided hint bounds to account for how the filters transform the data, so the bounds were being doubly-affected by the filter transforms, leading to extra clipping in the case of css3/filters/effect-reference-composite-hw.html where the image filter included a translation. Since we precalculate the correct bounds and use it as the clip, Skia already has enough information to use a smaller offscreen buffer for the filtering, and there's no real need to provide a separate hint with the SaveLayerRec. Bug: chromium:955612 Change-Id: Ice1680fca8c58fd9147e02b106ceefdfb1ead36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579659Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#653558}
-
Michael van Ouwerkerk authored
Bug: 924118, 956031 Change-Id: I7876e83dff4bf0cf2a68dd3926760f295c3126de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578549 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#653557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e5598c5d7828..505f9c976576 git log e5598c5d7828..505f9c976576 --date=short --no-merges --format='%ad %ae %s' 2019-04-24 eseckler@google.com Merge "startup writer: Don't hold lock while grabbing new trace packet." 2019-04-24 hjd@google.com Merge "trigger_perfetto: Add trigger_perfetto binary" Created with: gclient setdep -r src/third_party/perfetto@505f9c976576 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie606ba62f1c954b3fef7366095072e2531490a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653556}
-
Olivier Robin authored
1fc9cc0d0e1dfafb8d29dba8d01f09587d870026 [Breakpad iOS] Add a callback on report upload completion. 8c70c504b241f918e41f28a3102f5ca03475082b Make breakpad_unittests work with Chrome's test runner instead of gtest's ebab5970b027c8c41eccf67a83883b4bfb736505 Use correct c++ standard library in Xcode project. Bug: 954175,949098 Change-Id: Ifdc99129956e08dda9feaf8cc7e51fc90ac8184b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581343 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653555}
-
Lowell Manners authored
Rather than calling IdentityManager::Shutdown explicitly, perform the Shutdown logic as part of ~IdentityManager(), so we don't need to remember to call it. This means that IdentityManager's dependencies will be shutdown later than they were before this CL, but this shouldn't matter (tm) since the dependencies are wholly owned by IdentityManager. Bug: 945385 Change-Id: I061e78f90f9754716a8f537116dd55d2c769589b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578613 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#653554}
-
Alex Clarke authored
It's dangerous to post a task with a RenderProcessHost pointer because the RenderProcessHost can go away before the task is run. Bug: 863341 Change-Id: I9a5e3ae068dd42ea5a68d6e4afcf77d7486eeac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581580 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653553}
-
Javier Ernesto Flores Robles authored
Improves the style of the actions to be like the UX mocks. Bug: 951358, 951300 Change-Id: I535fd2ba711321d782d1ff0c5bb41781523aef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578745 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#653552}
-
Julie Jeongeun Kim authored
This CL replaces the type of SVGDashArray with base::RefCountedData<WTF::Vector<Length>> from RefVector<Length> to avoid using RefVector. Bug: 955618 Change-Id: I00fe7db4e700657f5f64c9811678d361e8a4d6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580694Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#653551}
-