- 05 Dec, 2017 40 commits
-
-
proberge authored
Some extensions make a request to "/" which confuses the extension content verifier and causes it to mark the extension as corrupted. Bug: 791929 Change-Id: Id594bd714048d33ddcf88fa86b26ce0a7696503c Reviewed-on: https://chromium-review.googlesource.com/809225 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521777}
-
Alexei Svitkine authored
IsUsingSecondaryPassphrase() shouldn't be called if sync service isn't initialized, according to its docs. BUG=792104 Change-Id: I6320d7cfed2dfe924ef99f2d5d87c6579347bd9a Reviewed-on: https://chromium-review.googlesource.com/809190Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521776}
-
Andrew Grieve authored
And some minor clean-up. No behavior change. Change-Id: Ia80a0c2a673e7a500267b591d857ba32ff8e53b9 Reviewed-on: https://chromium-review.googlesource.com/809226Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#521775}
-
kylechar authored
Add a class that helps build valid CompostiorFrames for tests. Also convert some tests to use the builder and update existing helper functions. Bug: 758707 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I293ef25799d2db398e905f34e5eb0650a3525677 Reviewed-on: https://chromium-review.googlesource.com/796931Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#521774}
-
Devlin Cronin authored
ExtensionService::UninstallExtensionHelper is a wrapper around ExtensionService::UninstallExtension. However, it doesn't really add additional functionality (apart from gracefully handling the case of an extension not being installed) and causes ambiguity about which uninstall method to use. (Additionally, it is unnecessarily static, since it in fact takes an ExtensionService object...) Remove ExtensionService::UninstallExtensionHelper so that there is only a single method (UninstallExtension) for uninstalling extensions. Bug: None Change-Id: If3a7d064c56dce62b4330b2d968fc84cd09432c7 Reviewed-on: https://chromium-review.googlesource.com/792128 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521773}
-
Dirk Pranke authored
At the moment we can't assume that the Python `coverage` module is installed everywhere we might want to run the presubmit tests in //testing/buildbot. The right fix for this is to add coverage to the .vpython spec, but in the meantime this disables the check if it would fail. R=kbr@chromium.org, jbudorick@chromium.org BUG=662541 Change-Id: If71bfe7774788776865c8f1f9ecf38aafaddc308 Reviewed-on: https://chromium-review.googlesource.com/809464Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521772}
-
Alexandr Ilin authored
This CL makes following changes to the Startup.FirstCommitNavigationTime3 histogram: * Do not record the histogram multiple times per session * Start recording from the application start time instead of the foreground time * Record the histogram only for ChromeTabbedActivity * Ignore foreground state, there will be separate histogram for this purpose * Discard error, same document and non http(s) pages The CL also renames the histogram to Startup.Android.Experimental.Cold.TimeToFirstNavigationCommit The rationale behind the recording the histogram from the application start time instead of the foreground time: The current metric doesn't cover the important part of the startup latency because the ForegroundStartTime is measured after the native library is loaded. That's a lot of important data missed. We're exploring various ways to speed up the startup including the time of native library initialization. We want to have a metric that will show us these improvements. Initially, this metric was measuring cold startups from the application start but then it was changed. We would like to return to the initial meaning. pasko@ described an evolution of the metric in https://goo.gl/NyvX39 Bug: 778302 Change-Id: I01d7a6a73fbc504e31c1e877b1253fcf69a54ad8 Reviewed-on: https://chromium-review.googlesource.com/788875Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521771}
-
Brian White authored
Previously, when managing a directory of files, only one file was ever processed per call. This wasn't a problem because after each call, another would be scheduled. However, the "independent" files are processed by an outside caller and so if the file ready for it turned out to be invalid, it would see "nothing to be done" and wait an extended period of time to try again. The new version does the validity test during the initial check and immediately advances to the next file if it detects a problem. This means there is always a file to process and never a significant delay before trying the next one. Bug: 760317, 780036 Change-Id: I3fece9e41af3b8d29d0fa80b25141c00f9ae9db2 Reviewed-on: https://chromium-review.googlesource.com/804063Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#521770}
-
Aaron Leventhal authored
Provide friendly-sounding suggestions that are more efficient for screen reader use. For example, read the title of a document before the URL. An example of a friendly suggestion would be "Gmail https://mail.google.com location from history". In order to get the friendly suggestions to be announce or shown on a Braille display, the textfield's accessible text value is replaced with the friendly text, rather than containing the URL only. If the user begins to edit the text or arrow through it, the accessible text/value is returned to the plain URL or search text. In addition, incoming and outgoing cursor/selection offsets are corrected so that assistive technologies can set the location of the cursor (for cursor routing), or retrieve the actual text at the current caret position. The caret/selection indices are offset by the amount of friendly text inserted before the actual text being shown in the text box. Bug: 785436 Change-Id: I7fb9071c2df1a4ab188bc8e7b7001396578b1950 Reviewed-on: https://chromium-review.googlesource.com/784591 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#521769}
-
David 'Digit' Turner authored
Since there is no way to make read-only file descriptors from Linux memfd-based regions, the security guarantees of GetReadOnlyHandle() cannot be maintained with this implementation. Remove it to fall-back on traditional Posix shared regions instead. Bug: 792117, 736452 Change-Id: Ie5eb41fc3c4dd02ebdbb77be8375363ba51f1b00 Reviewed-on: https://chromium-review.googlesource.com/809014Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#521768}
-
Sergey Ulanov authored
PipelineIntegrationTest.ReinitRenderersWhileVideoTrackIsDisabled was disabled on Linux due to flake. It also fails periodically on Fuchsia. Disabling it on all platforms. Bug: 788387 Change-Id: I85e3fc22361b355e0fc12ae26e3746d7bf6620c8 Reviewed-on: https://chromium-review.googlesource.com/809293Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521767}
-
Jonathan authored
Synchronize the FYI and CQ filters, as flakes were recently only added to CQ. Also enable another test which is working. TBR=kylechar@chromium.org TEST=viz_content_browsertests Bug: 760181 Change-Id: If57709368548f82fb8473cb5ce2008de76a4b6f1 Reviewed-on: https://chromium-review.googlesource.com/809230Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#521766}
-
Julia Tuttle authored
Move to the shiny new explicit BindRepeating function and RepeatingCallback type. Bug: Change-Id: I06257e24ade60e7670e0c1d8e23c267f59eb7216 Reviewed-on: https://chromium-review.googlesource.com/806478 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521765}
-
Gregory Chatzinoff authored
Reenable this test since flake seems to have been fixed on FYI bots. Bug: 789943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I184607d3fc25206409c0786d81583c49a9f8471a Reviewed-on: https://chromium-review.googlesource.com/807166Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521764}
-
Takumi Fujimoto authored
We recently renamed mediaRouterMojom to mediaRouter.mojom in media_router_bindings.js, so use of the former gives an error. Bug: 792125 Change-Id: I36c35c67cbd39a684bbe61de1b4c72b67df95bc9 Reviewed-on: https://chromium-review.googlesource.com/809465Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#521763}
-
Sadrul Habib Chowdhury authored
When running with mus, and mus is not hosting viz, aura has to generate the LocalSurfaceId. It needs to make sure the root window always has a valid LocalSurfaceId, because that's what is fed into ui::Compositor, and without a valid id, it never shows anything on screen. BUG=786453 Change-Id: Ie075246937f7e607afdc945ea1cea0b021595e50 Reviewed-on: https://chromium-review.googlesource.com/807886Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521762}
-
John Abd-El-Malek authored
BUG=776589 Change-Id: I74130c4be9037a4f3204fac90180a79c4fe6e026 Reviewed-on: https://chromium-review.googlesource.com/806754Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521761}
-
Sadrul Habib Chowdhury authored
When mus is not hosting viz, ash is still responsible for managing the mirroring. So update the MirrorWindowController as appropriate. Also, do not have mus host viz for ash_unittests --mus. BUG=786453 Change-Id: I964bb030113f1c0e8a5375056687e2c0ffdba53a Reviewed-on: https://chromium-review.googlesource.com/808004Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521760}
-
Maksim Sisov authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... Use a wrapper header ui/gfx/x/x11.h to make our life easier. Bug: 782184 Change-Id: I88e1093b9e3a8195395a23f0fd8291613586972f Reviewed-on: https://chromium-review.googlesource.com/809047Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#521759}
-
Xiaocheng Hu authored
This patch introduces a utility class NGInlineFragmentTraversal, so that we can conveniently retrieve: - ancestors of a given physical fragment in a container - descendants of a given physical fragment - physical fragments in a container with the given layout object The utility class supersedes the existing NGInlineFragmentIterator class. Follow up patches will convert clients of NGInlineFragmentIterator to use the traversal class instead. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7f3f553df18291df50f60075ab84294dd394d86c Reviewed-on: https://chromium-review.googlesource.com/807758Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521758}
-
Maksim Sisov authored
This cl doesn't bring any functionality change, but changes DispatchEventFromNativeUiEvent and its callers to use OnceCallback and BindOnce. Bug: 714018 Change-Id: Ibfbda691fab9ae2e4e597d7b18917312d795fb02 Reviewed-on: https://chromium-review.googlesource.com/808285Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#521757}
-
Kenneth Russell authored
Unfortunately, the project to run these on physical hardware on Swarming didn't make it over the finish line. After offline discussion with the media team, the GPU FYI waterfall will no longer run these tests, though we could reconsider doing so in the future. Note that this CL also removes audio_unittests' isolate from gn_isolate_map.pyl, since the GPU bots were the only bots running these tests on any of Chromium's waterfalls. BUG=416594, 574942 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I49a22a84cface1e1a1b5990dd9c3ef403d09a39f Reviewed-on: https://chromium-review.googlesource.com/808091 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#521756}
-
Mike Reed authored
Needed to land https://skia-review.googlesource.com/c/skia/+/76980 Bug: Change-Id: I07f1647b0d342baebadfa0549f54e5252ee4395d Reviewed-on: https://chromium-review.googlesource.com/809089Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#521755}
-
Devlin Cronin authored
Have WebLocalFrame::CallFunctionEvenIfScriptDisabled() return a v8::MaybeLocal instead of a v8::Local. This is more inline with the patterns v8 uses. Bug: None Change-Id: Id466ff9ba46d40123df77a835a7ec84a7c1442be Reviewed-on: https://chromium-review.googlesource.com/807405Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521754}
-
Alexandr Ilin authored
Bug: 792107 Change-Id: I4bcf739ee7413850d596cc2aff89465341eef7f8 TBR: mdjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/808976 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521753}
-
David Reveman authored
Version 2 provides clients with an interface to keep track of scale factors used by the shell. It provides a full list of supported scale factors and flags to indicate what the current and preferred scale factor is. Version 2 also adds a new request for setting the parent of a top level shell surface and specifying an initial location relative to parent. This also adds a new 'info' client that can be used for testing. The client connects to a compositor and prints all output related properties. Example output: geometry: x: 0 y: 0 physical width: 423 mm physical height: 317 mm subpixel: unknown make: unknown model: unknown transform: normal modes: 1600x1200: 60.00 Hz current preferred device scale factor: 1 scales: 0.500: 0.800: 1.000: preferred 1.200: 1.600: current Test: exo_unittests --gtest_filter=ShellSurfaceTest.SetParent Test: wayland_info_client Bug: 791672, 791681 Change-Id: Iab6869f5b54a6b5970dea40025edea46d0113c2c Reviewed-on: https://chromium-review.googlesource.com/805358 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#521752}
-
Jun Cai authored
This CL fixes the NewTabPageInterceptorTest.NoInterception browser test for network service by using https embedded test server instead of URLRequestMockHTTPJob::GetMockHttpsUrl(). Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4d1f911ec4db21a2f086c09d3d6a99e41ad75230 Reviewed-on: https://chromium-review.googlesource.com/802079Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#521751}
-
Michael Spang authored
This adds supports for system tracing via trace.py. It is disabled by default but can be enable via the --systrace parameter. Requesting system tracing does no harm on devices where it is not available. This requires switching the way data is read back over the websocket, as the "ReportEvents" style cannot return data from secondary tracing agents such as CastTracingAgent. BUG=786091 Change-Id: I8b5b39c047ae03073d90d462a4febf1770a8ccd5 Reviewed-on: https://chromium-review.googlesource.com/804559 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521750}
-
jkereliuk authored
run_all_tests Change isLinux, isMac, isWindows to IsLinux, IsMac, IsWindows Bug: Change-Id: I28bcb3e753a5aaa0432350d6204b51b84d161fdd Reviewed-on: https://chromium-review.googlesource.com/809404Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521749}
-
Peter Beverloo authored
Its only responsibility is to forward calls to a NotificationHandler of a specific type, which should instead be done as an implementation detail of the notification system. Bug: Change-Id: Ia7e541c4b789b68d61209647294e420f9cde0681 Reviewed-on: https://chromium-review.googlesource.com/806220 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521748}
-
chrome://interventionsThanh Le authored
Logs messages of navigation are retained in PreviewsLogger bufffer, and on chrome://interventions-internals until the end of that session even when user history is cleared. Since ClearBlacklist event is triggered whenever history is cleared, removing all log message on the page, and all buffer messages in PreviewsLogger seems like a reasonable solution. Bug: 791774 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0f69f5ec89679826557cdd23bbd1f316957711ec Reviewed-on: https://chromium-review.googlesource.com/807397Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#521747}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/3dddccff31be..4fba4a97bc08 $ git log 3dddccff3..4fba4a97b --date=short --no-merges --format='%ad %ae %s' 2017-12-05 geofflang Include the D3D11 headers on Windows when OpenGL is enabled. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6a00b45125d0d0dec3edff05eb9c73f06d9519e8 Reviewed-on: https://chromium-review.googlesource.com/809290Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521746}
-
Andrew Grieve authored
Change-Id: I969673d9b2806d0215b30a425539ce1b15ee3618 Reviewed-on: https://chromium-review.googlesource.com/803948Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#521745}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e0dc203974cd..6b77e41141aa $ git log e0dc20397..6b77e4114 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 nednguyen Remove Telemetry's iprofiler Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0db325d24eaed93bf31e19b85bebd83480ea536f Reviewed-on: https://chromium-review.googlesource.com/809287 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521744}
-
Max Moroz authored
Bug: 790735 Change-Id: Ibf368a23b402dbe12c03afaed4032267abe52794 Reviewed-on: https://chromium-review.googlesource.com/808991Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#521743}
-
Gauthier Ambard authored
Having two stack views allow the animation to be focused on the location bar instead of having side effects on the buttons on the side. It also makes sure the toolbar is respecting the Safe Area on iPhone X landscape. Bug: 791933, 791944 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6f0b3560c825cdfe67f5aca648ee0a2b96044a0 Reviewed-on: https://chromium-review.googlesource.com/807930 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521742}
-
Justin Novosad authored
BUG=790699 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I432ad3103df1d07732b2629384dc074cb6002a21 Reviewed-on: https://chromium-review.googlesource.com/806692Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521741}
-
Daniel Bratell authored
X11 header files are infamous for creating macros with common names such as None, True, False, Status, Bool, ... To save oursaves the mess that creates, they are now wrapped in a header, ui/gfx/x/x11.h, which puts those symbols in the x11 namespace and removes the global macros. Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida4d26422f44edda1a0120f52ffbaa4e437ab012 Reviewed-on: https://chromium-review.googlesource.com/805814Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521740}
-
Abhishek Arya authored
Also, improve documentation. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: Change-Id: Ic248caf2e7e73d84e29e8ce32689b7bfcd374e16 Reviewed-on: https://chromium-review.googlesource.com/809288 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#521739}
-
Tom Sepez authored
Might fail if run as root as currently written. Make tighter test based on expected ids. Bug: 791696 Change-Id: I55e0febd8de570d4982c369782ce6cf74e2f3f39 Reviewed-on: https://chromium-review.googlesource.com/807248Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521738}
-