GitLab

Similar to NullAudioSink, but I decided not to use FakeAudioWorker
as a generic fake worker since it adds more complexity then we need
for the video renderer sink interface.  I also didn't want to add
pause support or stop callback support to it.

BUG=473424
TEST=new unittest, forthcoming pipeline changes.

Review URL: https://codereview.chromium.org/1116473002

Cr-Commit-Position: refs/heads/master@{#327450}

Had to use WRAPPED_INSTANTIATE_TEST_CASE_P instead to disable this test.

BUG=482121
TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/1117613002

Cr-Commit-Position: refs/heads/master@{#327449}

In Share Dialogue layout xml, the TextView widget is not independent of
the device scale factor i.e. in case of multi-line text for larger font size
preference the text gets truncated. Added ellipsize support to this widget.

BUG=410205

Review URL: https://codereview.chromium.org/1097393005

Cr-Commit-Position: refs/heads/master@{#327448}

BUG=481413

Review URL: https://codereview.chromium.org/1099403008

Cr-Commit-Position: refs/heads/master@{#327447}

This adds histograms that records how often we write to the prefs file. The number of writes is recorded for every 5 minute interval of time spent in Chrome.

To avoid doing any work when Chrome is idle and not recording any writes, we only record metrics at the point when a write occurs. Whenever a write occurs we look to see if the last write occurred more than 5mins ago. If it did, we report the write count for the previous period of time.

The histogram is called:
Settings.JsonDataWriteCount.<pref filename>
e.g.
Settings.JsonDataWriteCount.Local_State

This is in a similar vein to Settings.JsonDataReadSizeKilobytes.*

BUG=476800

Review URL: https://codereview.chromium.org/1083603002

Cr-Commit-Position: refs/heads/master@{#327446}

BUG=171301

Review URL: https://codereview.chromium.org/1111113002

Cr-Commit-Position: refs/heads/master@{#327445}

BUG=466848

Review URL: https://codereview.chromium.org/1061503008

Cr-Commit-Position: refs/heads/master@{#327444}

BUG=466848

Review URL: https://codereview.chromium.org/1106593002

Cr-Commit-Position: refs/heads/master@{#327443}

Cr-Commit-Position: refs/heads/master@{#327442}

This upstreams the bulk of the code necessary to support WebUI in the
iOS web layer. Much of this is forked off of the content/ versions,
which can't be used on iOS.

BUG=464810

Review URL: https://codereview.chromium.org/1110213002

Cr-Commit-Position: refs/heads/master@{#327441}

FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\third_party\libxml\src\libxml.nanohttp.obj.rsp /c ..\..\third_party\libxml\src\nanohttp.c /Foobj\third_party\libxml\src\libxml.nanohttp.obj /Fdobj\third_party\libxml\libxml.c.pdb
d:\src\cr2\src\third_party\libxml\src\include\wsockcompat.h(41): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\third_party\libxml\src\include\wsockcompat.h(41): warning C4005: 'EWOULDBLOCK': macro redefinition
... etc.

(I don't know why we have nanoftp.c and nanohttp.c being built, but that
seems wrong too.)

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1104333003

Cr-Commit-Position: refs/heads/master@{#327440}

Now that we have added PrefRegistry registration functions that do not need to
accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is
redundant and we can remove it altogether.

BUG=476800

Review URL: https://codereview.chromium.org/1092683004

Cr-Commit-Position: refs/heads/master@{#327439}

This CL creates a new target webapp with browser test JavaScript files loaded.
This will enable us to run a JavaScript browser test using a regular chrome
binary to speed up development and debugging.

BUG=

Review URL: https://codereview.chromium.org/1091293004

Cr-Commit-Position: refs/heads/master@{#327438}

Prior to OSX 10.10, the declaration is a method. In OSX 10.10, the declaration
became a property. For simplicity and consistent, always refer to
scrollingDeltaY as a method.

BUG=471823

Review URL: https://codereview.chromium.org/1116563002

Cr-Commit-Position: refs/heads/master@{#327437}

They had a dependency on //device/bluetooth that wasn't specified
and was failing in a shared (component) build.

R=scheib@chromium.org
TBR=brettw@chromium.org, jochen@chromium.org
BUG=463528

Review URL: https://codereview.chromium.org/1117573002

Cr-Commit-Position: refs/heads/master@{#327436}

The code here is from Dmitry's CL:
https://codereview.chromium.org/1107873002/#ps1

And Nikita's CL:
https://codereview.chromium.org/1052683006/

BUG=475567,477402

Review URL: https://codereview.chromium.org/1112583004

Cr-Commit-Position: refs/heads/master@{#327435}

BUG=43122
TEST=hang page(s) and verify strings

Review URL: https://codereview.chromium.org/1107273002

Cr-Commit-Position: refs/heads/master@{#327434}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a73239a..5b6db07

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1112753005

Cr-Commit-Position: refs/heads/master@{#327433}

If shill happens to restart or re-create the wifi device then the wake
on wifi setting will not persist.  To deal with this, always send the
current wake on wifi setting when the network device list is updated
unless the setting hasn't been initialized.

BUG=475199

Review URL: https://codereview.chromium.org/1104183005

Cr-Commit-Position: refs/heads/master@{#327432}

This CL:
- adds a mock implementation of ProxyResolverFactory;
- changes the ProxyService tests to use MockAsyncProxyResolverFactory
  instead of using a LegacyProxyResolverFactor; and
- removes ForwardingProxyResolverFactory and updates the tests that
  used it.

BUG=467403

Review URL: https://codereview.chromium.org/1102463002

Cr-Commit-Position: refs/heads/master@{#327431}

This declaration appears to be completely unused.

BUG=482085
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/1107263004

Cr-Commit-Position: refs/heads/master@{#327430}

Partial revert of 00e86ade

This is a revived version of WebsiteSettingsPopupLegacy, which contains
detailed connection and certificate information, similar to the desktop
website settings popup. The popup is accessed through a 'Details' link
in the page info popup.

BUG=425158

Review URL: https://codereview.chromium.org/1100283002

Cr-Commit-Position: refs/heads/master@{#327429}

BUG=480941

Review URL: https://codereview.chromium.org/1105193002

Cr-Commit-Position: refs/heads/master@{#327428}

Hosts registered through GCD can't be brought online yet, because the
host doesn't know how to use the XMPP credentials it gets from GCD.

BUG=471928

Review URL: https://codereview.chromium.org/1111603002

Cr-Commit-Position: refs/heads/master@{#327427}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e9c60e7..ba9eaab

TBR=pdr@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/1112763002

Cr-Commit-Position: refs/heads/master@{#327426}

This workarounds a memory corruption bug in PowerVR drivers
that cause memory corruption. The bug happens when
EGLImageTargetTexture2DOES is called on an already
defined texture object.

Workaround is to always create a new texture id each time.
This only works if there are no other code saving the
old texture id, and only AsyncPixelTransferDelegateIdle
needed to be updated to not do this.

BUG=480992

Review URL: https://codereview.chromium.org/1105153003

Cr-Commit-Position: refs/heads/master@{#327425}

This means bookmark apps can use proper icons from the web page or the
pages manifest, and have these reflectd on all devices the bookmark
app is synced to.

BUG=480049

Review URL: https://codereview.chromium.org/1066623008

Cr-Commit-Position: refs/heads/master@{#327424}

BUG=461181
R=erikchen@chromium.org, scheib@chromium.org

Review URL: https://codereview.chromium.org/1096383006

Cr-Commit-Position: refs/heads/master@{#327423}

BUG=481801

Review URL: https://codereview.chromium.org/1113723002

Cr-Commit-Position: refs/heads/master@{#327422}

Documented in developer console, avoiding raising an exception, and
on developer documentation page sample.

BUG=154662

Review URL: https://codereview.chromium.org/1107163002

Cr-Commit-Position: refs/heads/master@{#327421}

In a separate CL, route.description was renamed to route.title.

Review URL: https://codereview.chromium.org/1111073002

Cr-Commit-Position: refs/heads/master@{#327420}

Tap-triggered selections should not trigger the selection handles.
If a longpress occurs before a tap-triggered selection, suppress
activation of the selection handles.

BUG=471280

Review URL: https://codereview.chromium.org/1113653002

Cr-Commit-Position: refs/heads/master@{#327419}

When activating Chrome app from another app, often times we are reactivating
the same browser window. In this case, we don't need to update prefs with
a new profile and window position. Avoiding prefs update is good because it
triggers JSON file writing to disk (after a 10 seconds delay).

BUG=482027

Review URL: https://codereview.chromium.org/1105423003

Cr-Commit-Position: refs/heads/master@{#327418}

The session manager is once again providing a RestartJobWithAuth
method to allow callers to directly authorize their request to
restart the browser by providing a unix domain socket ready to be
SO_PEERCREDified in lieu of a pid.

This has the advantage of working inside a PID namespace, while
normal dbus mechanisms do not.

BUG=448821
TEST=integration tests TBD
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/1111653002

Cr-Commit-Position: refs/heads/master@{#327417}

This CL starts finding BLE phone devices that advertise smart
lock services when the screen is locked. It unlocks the
Chrome when such a device is found.

BUG=478073

Review URL: https://codereview.chromium.org/1102473003

Cr-Commit-Position: refs/heads/master@{#327416}

The DumpAccessibilityEvent* tests sometimes fail when
there's an event on a ROLE_SYSTEM_WINDOW, but these
events are out of our control for a non-interactive
test, so just filter them out.

BUG=none

Review URL: https://codereview.chromium.org/1114683002

Cr-Commit-Position: refs/heads/master@{#327415}

Defers unblocking renderer's requests until the asynchronous activity
and tab loading process is complete and we are ready to handle
additional requests.

Adds new android-specific API to resume the requests and web contents
delegate API to allow the deferral for resuming renderer request
handling.

BUG=432562

Review URL: https://codereview.chromium.org/1095913002

Cr-Commit-Position: refs/heads/master@{#327414}

Prior to this change, we were doing static builds.
This will affect the following bots:
  - tryserver.v8:
    - v8_android_chromium_gn_dbg
  - tryserver.chromium.linux:
    - android_chromium_gn_compile_dbg
  - tryserver.blink:
    - android_blink_compile_dbg
  - chromium.webkit:
    - Android GN (dbg)

R=cjhopman@chromium.org
BUG=481714

Review URL: https://codereview.chromium.org/1108973002

Cr-Commit-Position: refs/heads/master@{#327413}

suspend state and waking it up.
Make ProcessManager inherit from EventPageTracker.
Add new WakeExtension method to ProcessManager.

R=kalman@chromium.org,mfoltz@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1096313003

Cr-Commit-Position: refs/heads/master@{#327412}

The 'gn_all' target in src/BUILD.gn didn't actually build everything,
which could be confusing. This patch renames the target to 'both_gn_and_gyp'
which should make the intent clearer, and reworks the accompanyhing
targets in both the GN and GYP builds to match.

R=jam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1104213005

Cr-Commit-Position: refs/heads/master@{#327411}