GitLab

Since r168759 we use bilinear filtering for animated images. There
are complaints about the drop in image quality. However we don't want to
spend a lot of CPU cycles doing high quality animations for upscaling.
This change is a compromise for animated images: we do a cheaper
mipmapping for downscaling and bilinear for upscaling. There is a
noticable quality improvement.

This change implements InterpolationMedium for GraphicsContext. It used
to be equivalent to InterpolationLow and is now a higher quality option.
All GraphicsContext::drawSomething() methods have |useLowQualityScale|
removed. This gives a much cleaner code.

I also discovered/fixed a couple small issues with interpolation levels:
* It is apparent now that InterpolationDefault means InterpolationHigh
  on desktop and InterpolationLow on Android.
* Default for canvas elements used to InterpolationMedium but it
  really meant InterpolationLow.
* There is a bug for rendering images in canvas that InterpolationNone
  should be used but it has been InterpolationLow all along. I didn't
  fix in this change but added a FIXME.

The new interpolation level does not affect non-animated images. There
is no need to rebaseline any pixel test. I added a test GIF file that
loops two identical frames. This is used to test the image quality.

BUG=353251

Review URL: https://codereview.chromium.org/201513003

git-svn-id: svn://svn.chromium.org/blink/trunk@169585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes GraphicsLayerPaintInfo::offsetFromSquashingCLM
from an IntSize to a LayoutSize and changes
SquashingState::offsetFromAbsoluteForSquashingCLM from an
IntPoint to a LayoutPoint. This also adds a
subpixelAccumulation field to GraphicsLayerPaintInfo; this
gets computed at the same time as
GraphicsLayerPaintInfo::offsetFromRenderer.

BUG=327387

Review URL: https://codereview.chromium.org/143283011

git-svn-id: svn://svn.chromium.org/blink/trunk@169584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The BasicShape ellipse and circle functions now report a syntax error
if the "at" keyword is not followed by a position.

The existing parsing tests have been updated to include this case.

Ported over from http://trac.webkit.org/changeset/165835

BUG=353774

Review URL: https://codereview.chromium.org/203413006

git-svn-id: svn://svn.chromium.org/blink/trunk@169583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Most of the code there was no-ops.

R=eae,eseidel
BUG=

Review URL: https://codereview.chromium.org/204963002

git-svn-id: svn://svn.chromium.org/blink/trunk@169582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346399
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/203743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch ensures the compositing layers are up-to-date
when calling elementLayerTreeAsText and layerTreeAsText
from tests. Before, elementLayerTreeAsText had a
DisableCompositingQueryAsserts which this patch removes.
layerTreeAsText previously updated updateCompositingLayers
but that was not sufficient; this patch adds a tighter
assert and calls updateLayoutAndStyleForPainting to fully
update.

BUG=

Review URL: https://codereview.chromium.org/202523004

git-svn-id: svn://svn.chromium.org/blink/trunk@169579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This captures following spec chagne: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
The essential part of the change is in HTMLImportsController.cpp.
Anything else is to make it work with redirect.

The problem here is that allowCredentials flag is held both
by ResourceLoaderOptions and ResourceRequest and these two
can go out-of-sync. This change tries to make them in sync.

Such a state duplication should be resolved eventually, but
that is another story.

BUG=348671
TEST=import-cors-credentials.html
R=dglazkov@chromium.org, japhet@chromium.org, abarth

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169496

Review URL: https://codereview.chromium.org/196043002

git-svn-id: svn://svn.chromium.org/blink/trunk@169578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change tells the HTML parser know that lifecycle callbacks,
that is triggered through Microtask checkpoint, can create resources that
blocks scripts.

It also streamlines the unblock notification from Document to the parser
into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets()
and didLoadAllImports() checks resource readiness and invokes the unified notification.

TEST=custom-element-style-block.html
BUG=346408
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/202813002

git-svn-id: svn://svn.chromium.org/blink/trunk@169577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The repainting in this test is correct in all cases, but due to timing
issues the actual repaint rects are not consistent from run to run or
across platforms.

Therefore, remove any text output for repaint rects and leave this as
just a pixel test.

BUG=353934,345027

Review URL: https://codereview.chromium.org/204873002

git-svn-id: svn://svn.chromium.org/blink/trunk@169576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test is testing some paint-dependent behavior (see issue 353827)
and should behave identically whether or not testRunner.display() is
called.  However, without the testRunner.display() calling into paint,
it misses some invalidations that need to be there for correctness.

BUG=345027,353827

Review URL: https://codereview.chromium.org/197883025

git-svn-id: svn://svn.chromium.org/blink/trunk@169575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch cleans up InspectorStyleSheet after the InspectorStyleSheet
and InspectorStyleSheetForInlineStyle implementations were separated.
It does the following changes:
- remove InspectorStyleSheet.checkPageStyleSheet as it is never used
- inline InspectorStyleSheet.ruleIndexByRule
- inline method InspectorStyleSheet.ruleIdByStyle into InspectorStyleSheet.styleId
- introduce single implementation for lineEndings in InspectorStyleSheetBase
- eliminate method InspectorStyleSheetBase.reparsestyleSheet

BUG=341506

Review URL: https://codereview.chromium.org/203633003

git-svn-id: svn://svn.chromium.org/blink/trunk@169574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch unlocks the text autosizing multipliers when
the document has finished parsing. This is necessary
to avoid weird effects when layout changes significantly
during page load. Resetting multipliers allows for a fresh
autosizing pass to take into account the whole document.

In particular this patch fixes issues with overlines on
http://forum.xda-developers.com and partially addresses
inconsistent font size on www.drudgereport.com
(see referenced bugs for details).

BUG=346786,131566

Review URL: https://codereview.chromium.org/189113014

git-svn-id: svn://svn.chromium.org/blink/trunk@169572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The previous logic could fail in some cases when the heuristic specified for the identity of the layer to squash
into did not match exactly the choice used later in assignLayersToBackings. The new code is a bit cleaner also.

BUG=261605

Review URL: https://codereview.chromium.org/195893026

git-svn-id: svn://svn.chromium.org/blink/trunk@169571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/203193008

git-svn-id: svn://svn.chromium.org/blink/trunk@169568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Matches a planned change to the spec:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25094

Chromium side of this change: https://codereview.chromium.org/203303006/

BUG=245025

Review URL: https://codereview.chromium.org/204013006

git-svn-id: svn://svn.chromium.org/blink/trunk@169567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an element enters fullscreen, main frame's content size may
not be equal to that of the fullscreen renderer. As a result, the
fullscreen layer is scrollable. This might cause some unnecessary
computations and some wierd artifacts:

For example, on android phones, the edge glow effect may come after
scrolling the fullscreen video page several times, rather than coming
immediately.

This CL sets the scroll clip layer to NULL, so we won't be able to scroll it.

BUG=352183

Review URL: https://codereview.chromium.org/200943002

git-svn-id: svn://svn.chromium.org/blink/trunk@169566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For some reason having this annotation leads to linker errors on the
oilpan asan build.

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str'

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str1'

Kostya, do you have any ideas why this might break the asan build?

R=kcc@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204673002

git-svn-id: svn://svn.chromium.org/blink/trunk@169564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make myself an OWNER for the screen_orientation module.

R=abarth, eseidel
NOTRY=true

Review URL: https://codereview.chromium.org/199413031

git-svn-id: svn://svn.chromium.org/blink/trunk@169563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink side cleanup.
related to crbug.com/344319

Review URL: https://codereview.chromium.org/203603007

git-svn-id: svn://svn.chromium.org/blink/trunk@169562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

IDBIndex.h -> IDBObjectStore.h -> IDBIndex.h
IDBRequest.h -> IDBCursor.h -> IDBRequest.h

BUG=353954
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/203773012

git-svn-id: svn://svn.chromium.org/blink/trunk@169561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are no const methods which modify these fields.

BUG=

Review URL: https://codereview.chromium.org/196483005

git-svn-id: svn://svn.chromium.org/blink/trunk@169560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353954

Review URL: https://codereview.chromium.org/203223014

git-svn-id: svn://svn.chromium.org/blink/trunk@169559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add Element::subResourceAttributeName() virtual function to distribute the code
to each HTML class, instead of having a complex function with a lot of branching
to determine the subresource attribute name of an Element.

R=tkent, adamk

Review URL: https://codereview.chromium.org/202633009

git-svn-id: svn://svn.chromium.org/blink/trunk@169558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353994

Review URL: https://codereview.chromium.org/196383036

git-svn-id: svn://svn.chromium.org/blink/trunk@169557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Marker identifiers can be better stored as AtomicString (like for instance clip-path identifiers) since
they wil llikely share the same value as an id attribute.

Review URL: https://codereview.chromium.org/203723007

git-svn-id: svn://svn.chromium.org/blink/trunk@169556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=lushnikov@chromium.org, lushnikov, pfeldman

Review URL: https://codereview.chromium.org/203433002

git-svn-id: svn://svn.chromium.org/blink/trunk@169555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Uin32Array already has subarray method that returns a new view for the same array buffer.

BUG=None
R=alph@chromium.org

Review URL: https://codereview.chromium.org/204563002

git-svn-id: svn://svn.chromium.org/blink/trunk@169554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/196423025

git-svn-id: svn://svn.chromium.org/blink/trunk@169553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch keeps highlightPosition method on SourceFrame for backwards compatibility with corresponding virtual methods on View.

R=lushnikov@chromium.org, lushnikov, pfeldman

Review URL: https://codereview.chromium.org/204323003

git-svn-id: svn://svn.chromium.org/blink/trunk@169551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce InspectorStyleSheetBase, inherit InspectorStyleSheet and InspectorStyleSheetForInlineStyle from it.

BUG=341506

Review URL: https://codereview.chromium.org/202103002

git-svn-id: svn://svn.chromium.org/blink/trunk@169550 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r169450 has resulted in multiple failures of existing code where functions
annotated with @this are passed as arguments along with their receivers.

The cases include:
- Array.prototype.forEach and other iteration-with-callback methods.
- RemoteObject.prototype.callFunction[JSON], whose functionDeclaration
  can be evaluated on any Object (but expect a certain type thereof).
- WebInspector.Object.prototype.{add,remove}EventListener, which accepts
  the callback receiver as its third argument.

This patch introduces receiver specification detection in these cases,
or resorts to IGNORE in ambiguous situations.

R=aandrey, sergeyv, vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/203443010

git-svn-id: svn://svn.chromium.org/blink/trunk@169549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

overridden for explicit destructor dispatching.

The |finalize| name is too short and makes sense in other places
in the code. We rarely need to override finalizeGarbageCollectedObject
so it is fine that the method name is long.

Concretely, fileapi Stream has a finalize method that currently
gets called instead of the destructor. That leads to crashes because
the Stream destructor is not called and therefore the Stream is
no unregistered as a ContextLifecycleObserver and a call is made
on the already dead stream when the Document dies.

R=erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org
BUG=352755

Review URL: https://codereview.chromium.org/199273005

git-svn-id: svn://svn.chromium.org/blink/trunk@169548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spaces are are neither in the Ps, Pe, Pi, Pf and Po sections of UNICODE, so they should not be
considered when determining the length of the first-letter pseudo-element. This change will make
Blink inconsistent with WebKit (which consider spaces, without it being specified by the CSS spec.
It will make Blink consistent with other engines such Trident (IE11) and Opera.

R=eae@chromium.org, tkent@chromium.org
BUG=340688
TEST=Update existing test to treat spaces according to this change, and move it to use reftests.

Review URL: https://codereview.chromium.org/198013006

git-svn-id: svn://svn.chromium.org/blink/trunk@169547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also moved the simple ViewportStyleResolver onto the heap. Next will change ImmutableStylePropertySet to transition types.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815

Review URL: https://codereview.chromium.org/204373003

git-svn-id: svn://svn.chromium.org/blink/trunk@169546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutUnit misuse, often from improper conversion to other types,is a 
constant source of bugs in Blink. This is the second patch with the goal 
of making such error-prone conversions explicit in the hopes of forcing 
developers to think through these conversions while writing their patches.
These conversion sites were discovered by toggling the float conversions
to explicit and finding the compiler errors.

BUG=350474

Review URL: https://codereview.chromium.org/200023002

git-svn-id: svn://svn.chromium.org/blink/trunk@169545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move BitmapImageTest.cpp, GIFImageDecoderTest.cpp and JPEGImageDecoderTest.cpp.

BUG=353585

Review URL: https://codereview.chromium.org/203543002

git-svn-id: svn://svn.chromium.org/blink/trunk@169544 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor refactor, that removes an unused private member function valueChanged.

Review URL: https://codereview.chromium.org/204333002

git-svn-id: svn://svn.chromium.org/blink/trunk@169543 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, pfeldman, vsevik
NOTRY=true

Review URL: https://codereview.chromium.org/202763006

git-svn-id: svn://svn.chromium.org/blink/trunk@169542 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to determine if it could be made readonly. The getter is
measured to learn the relative usage, and is most likely above any
threshold for removal.

BUG=none

Review URL: https://codereview.chromium.org/203193010

git-svn-id: svn://svn.chromium.org/blink/trunk@169541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org,haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/201083004

git-svn-id: svn://svn.chromium.org/blink/trunk@169540 bbb929c8-8fbe-4397-9dbb-9b2b20218538