GitLab

According to the specification, executing a javascript: URL in a
document does not commit a new document. Indeed, following
https://html.spec.whatwg.org/multipage/browsing-the-web.html#javascript-protocol
executing a javascript: URL request gives a response whose status is
204, and processing a response with status 204 does not commit a new
document:
https://html.spec.whatwg.org/multipage/browsing-the-web.html#process-a-navigate-response
In particular, executing a javascript: URL does not change the
document's URL. So if we create a new (empty) iframe and execute right
away some javascript: URL in it, the URL of the iframe document will
be "about:blank".

On the other side, a document with URL "about:blank" will usually not
send any Referer header, since the algorithm for determining the
outgoing referrer goes through the stripping section
https://w3c.github.io/webappsec-referrer-policy/#strip-url which
returns `no-referrer` for a local scheme.

As a consequence, we should always expect the Referer header of an
outgoing fetch request from an `<iframe src="javascript:...">` without
custom referrer to be empty.

This CL adjusts the referrer policy inheritance WP test to that.

Still, we want to test that the referrer policy is inherited correctly
for javascript: URLs. For doing that, we add a custom referrer to the
outgoing fetch request, and we check that the content of the received
Referer header corresponds to the custom referrer modulo the inherited
referrer policy.

Change-Id: Ib3fe0808d3f8a1790e3f565cf2b1648fd2ea6c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464930
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821284}

The css-pseudo specification lists which properties applies to which
pseudo elements. For ::marker and ::first-letter we were already using
the CascadeFilter. This CL uses the filter for highlight pseudo elements
like ::selection and ::target-text, which share the same set of
properties which apply.

This means we stop retrieving resources for CSS properties which don't
apply to these pseudo elements. Additionally, block all resource
fetching for the ::target-text element since resource fetching can be
used by an external stylesheet in combination with a text fragment url
to detect text content on a page.

Bug: 1136817
Change-Id: I8b19db8535882e6b20f6319cd2a9f5219e7c9538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489657
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821283}

Bug: 1109316
Change-Id: I797c98ff77d57ab47dfb95eecfe6d70000f3409d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500561
Auto-Submit: Caroline Rising <corising@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821282}

This adds OnGraphCreated test seams to the browser harness, as well as
a utility function for running a lambda synchronously in the graph
(a common operation in tests).

Change-Id: I4c10dbba34bc8c1d81722ac3780491079a8cadf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493687Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821281}

Using wpt-import in Chromium 6d17cf58.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I166d60117fcd1e0292503f434a2594759419ba5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502848Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821280}

Bug: 1142027
Change-Id: Ie2fb4d4631f3d8507b404d6641f89170e35d98e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496290
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821279}

This reverts commit c756c75c.

Reason for revert: Suspected cause of crbug.com/1142873

Original change's description:
> [iOS] Fix tab strip views when using FullscreenProvider
>
> When the FullscreenProvider is used, the layout of the browser views is
> slightly different. Instead of having the web content views start from
> the bottom of the toolbar, the web content extends all the way to the
> top of the BrowserContainerViewController, behind the tab strip.
>
> This means that the prior approach of making all the top background
> views clear does not work when using FullscreenProvider. Instead, this
> CL uses the following approach: set these background views to have
> the same background color as the tab grid. As soon as the panning
> gesture starts, make them clear so the tab grid shows through and the
> animations appear correctly. At the same time, move the web content
> views down so they don't obstruct the animations either.
>
> Bug: 1094335
> Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Robbie Gibson <rkgibson@google.com>
> Cr-Commit-Position: refs/heads/master@{#821200}

TBR=marq@chromium.org,rkgibson@google.com,mouraroberto@google.com

Change-Id: I2b026d35000d34b29de9235ed2752273f6f7dd33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1142873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502574Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821278}

Now we are using AttestationClient directly instead of passing through
CryptohomeClient.

BUG=b:158955123
TEST=build ok.

Change-Id: I0275f2ee7515dd907c13f3fdfb0e9ca2da23e3d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497391
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821277}

Now we are using AttestationClient directly instead of passing through
CryptohomeClient.

BUG=b:158955123
TEST=build ok.

Change-Id: Ibd93c72f8a5eb46a9d346d6ef381bcb3a8cbb811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497389
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821276}

Change Button, ImageButton, LabelButton, and
ColorTrackingVectorImageButton to always focusable on non-Mac platform
and accessible only for Mac. This will remove the need to override these
buttons' focus behavior for normal use cases.

This CL explicitly set some button's focus behavior when they don't want
to platform default focus behavior. This CL also removes the DCHECKs
added earlier to show the changed behavior.

Bug: 1001103
Change-Id: I97ebea9c477e6155e40b09007254a51be9ee5125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499166Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821275}

Move a few of the editor screenshot files into c/b/share/.

This eliminates the DEPS on those files.

Bug: 1022172
Change-Id: Ibe12b1d4aadae983d74e348ea5279af4230610eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481928Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821274}

This reverts commit f89b2b5b.

Reason for revert: test is timing out on windows. See https://crbug.com/1142869

Original change's description:
> Enable ChromeSitePerProcessTest.LaunchExternalProtocolFromSubframe on windows.
>
> Enabling test to see if it is still flaky on Windows.
>
> Bug: 980446
> Change-Id: I6f1b0dce68cce9bd359ebe315ee8782b26888c66
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498957
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Auto-Submit: Aaron Colwell <acolwell@chromium.org>
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821188}

TBR=acolwell@chromium.org,wjmaclean@chromium.org

Change-Id: Ie7f5c8d58bc12698c2f22b17a327b2f6f39bcffe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 980446, 1142869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502691Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821273}

In https://crrev.com/c/2498946 the following test was disabled because
it was flaky on emulator:
- GoogleServicesSettingsTest#showSignOutDialogBeforeSigningUserOut

They are re-enabled on other builders.

This issue seems to be problem with espresso being used in emulators
similar to this bug: https://crrev.com/c/1108459

Bug: 1142481
Change-Id: I28fff49d24244af7935729e895fc2f78659ef716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499541Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821272}

This will avoid including this file in a large CL that turns QuotaClient
into a mojo interface.

Bug: 1016065
Change-Id: If029b5362fcc77b7acf8e55206b7143900ff6369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501062
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821271}

This CL was uploaded by git cl split.

R=jwd@chromium.org

Bug: 1142671
Change-Id: I9501b09c902d0741f7bbd92d1ada0ff06bfa5136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500609
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821270}

Despite efforts to address it, this test continues to be flaky on Mac,
so squash the flaky-failures.

Bug: 1137228
Change-Id: I48e4745d4f21977b59cfeba99e73d39126932ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502312
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821269}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I4ffe4940bba5cf5f6789dc5979669c54afd11337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502830Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821268}

Bug: 1142600
Change-Id: Iebabca71d53c9cdc08cd0bfa50927b4bd4513d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500547Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821267}

When ::target-text was introduced, we did not add an extra bit in
pseudo_bits. Add static_asserts to make sure we actually test first and
last public pseudo. Had to add another 8 bits to ComputedStyle.

Bug: 1136817
Change-Id: If8593b5a7022b93f18f4ee7b216e6753b6747076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502629Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821266}

This test seems to have been disabled mostly due to the
TextInputServerCreate Windows error [1], which doesn't manifest anymore
(crbug.com/1123944). Let's try to re-enable it.

[1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8883515428383041104/+/steps/sync_integration_tests__with_patch__on_Windows-10-15063/0/logs/Flaky_failure:_All__x2f_TwoClientExtensionAppsSyncTest.StartWithDifferentApps__x2f_WebApps__status_CRASH_SUCCESS_/0

Bug: 1069843
Change-Id: I9bce6dd03effd2128f9691e887ab68962c898ada
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498485
Commit-Queue: Victor Vianna <victorvianna@google.com>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#821265}

https://chromium.googlesource.com/libyuv/libyuv.git/+log/6866adbec5af..19d71f6b351f

$ git log 6866adbec..19d71f6b3 --date=short --no-merges --format='%ad %ae %s'
2020-10-24 libyuv-ci-autoroll-builder Roll chromium_revision e812106b..df9aecfc (817907:820568)
2020-10-16 libyuv-ci-autoroll-builder Roll chromium_revision 48924233..e812106b (815587:817907)
2020-10-13 fbarchard UVScale down use AVX2 and Neon for aarch32
2020-10-13 fbarchard UVScale down by 4 use SSSE3/NEON
2020-10-12 fbarchard 2x down sample for UV planes ported to SSSE3 / NEON
2020-10-09 libyuv-ci-autoroll-builder Roll chromium_revision ccec2ad0..48924233 (811963:815587)
2020-10-02 fbarchard I420ToARGB prototype added to convert_from.h
2020-10-01 fbarchard scale neon adjust PRFM instruction to co-issue with math

Created with:
  roll-dep src/third_party/libyuv

Bug: None
Change-Id: I3b0edcc78471ee3dc5701f40b07acf6b97560664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502469
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821264}

This CL was uploaded by git cl split.

R=corising@chromium.org

Bug: 1142671
Change-Id: I63425a4accecedcffa4da3e746a0ccf449296336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500611
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821263}

CL:2410419 added support for the WebAuthn credProps extension. I meant
to guard it with the WebAuthenticationResidentKeyRequirement, but
accidentally commented out the relevant line.

Thanks to Shane Weeden for spotting this issue.

Bug: 1117630
Change-Id: I96f6bac63cd3093f333891ba7a54c0c471d304ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500956
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821262}

They were not used anymore.

Bug: 1142522
Fixed: 1142522
Change-Id: I01bf92f378ce85fedb6f972782267d0fbcd57f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498650Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821261}

This one of only two tests using BrowserTestBase::spawned_test_server().
We want to reduce the use of the test server for a variety of reasons,
and removing access from BrowserTestBase is a good way to decrease
visibility of the spawned test server.

Also remove the download-known-size handler from the SpawnedTestServer's
Python code, as this was the only remaining test using that method.

Bug: 492672
Change-Id: Ib4836b9db3beb6a3f1f8598dea63fb262bf24dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498644
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/da4b0932..47c8f45b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie48d69f1766a11d6609734f9e6caf949c64a42fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502668Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821259}

crrev.com/c/2051870 added DOM retargeting usage to
AXLayoutObject::AccessibilityHitTest() so that accessibility hit test
targets an <input> Element instead of its internals. However, the fix
was too aggressive, and caused hit tests to miss Elements inside all
shadow DOM, including those in custom elements (disregarding whether
mode is "open" and "closed", and ignoring non-Element Nodes).

This CL removes DOM retarget usage for accessibility hit test. Instead,
when a Node in a shadow DOM is targeted, if the Node is in a user-agent
shadow tree then the target is changed to the shadow root's host.

Bug: 1111800
Change-Id: I8bcfaea0a113166464efe82f14f986c1bfa0c2c7
Fixed: 1111800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495660Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821258}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc7525b95bfe..64543505bd67

2020-10-27 alcastano@google.com Typecheck elements/ElementsTreeElementHighlighter.js with TypeScript
2020-10-27 wolfi@chromium.org Fix 'learn more' link descriptions for CSP issues
2020-10-27 jacktfranklin@chromium.org Fix bridges presubmit error not failing presubmit
2020-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-10-27 alexrudenko@chromium.org Add icons for global CSS keywords
2020-10-27 mulherje@gmail.com Remove unnecessay "edit expression" option from right click drop down
2020-10-27 sigurds@chromium.org Refactor console.table messages to their own class
2020-10-27 jacktfranklin@chromium.org Fix component bridges and use of legacy interfaces

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1072335,chromium:1139945,chromium:1140516
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id5533679466f06d9ee4ce17fd7ccb4b5cef0c8e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502828Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821257}

This CL adds a new metrics provider for differentiating between types
of Family Link users. Previously, these supervised user types were
indistinguishable in ChromeOS. This metrics provider will enable
filtering UMA metrics by supervision type as well.

This slicing mechanism is for metrics purposes only, and not for any
other features.

Bug: 1136304
Change-Id: Ida750eb188772db29158dce8cf750648ce580805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466338Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821256}

This CL was uploaded by git cl split.

R=chrisha@chromium.org

Bug: 1142671
Change-Id: I32ce49b4eb448c0a18a44ae7a4b570124260466c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500213
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821255}

https://skia.googlesource.com/skia.git/+log/7737a5bd2510..6f87de7c272d

2020-10-27 ethannicholas@google.com Made IRNode smaller

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I102b4414bdc886e4c288ec7a36cae148184ef2e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502493Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821254}

DevToolsReattachAfterCrashTest was disabled on Windows 7 because loading
of debug information was too slow and caused timeouts. This was caused
by symbol_level=1 becoming more verbose (including line numbers and
source files) and dbghelp.dll on Windows 7 seems to be particularly
inefficient. This was fixed a while ago by getting the bots to default
to symbol_level=1. This is the first of a few changes to reenable the
tests that were disabled.

Bug: 985255
Change-Id: I0007cc98e7b9b8ce71f10d32a1de74b7daa2ad39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500315Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821253}

Before this patch, when desktop Chrome directly launched an Android
payment app, it also displayed the browser payment UI, which should not
have been displayed.

This patch makes desktop Chrome never show any browser payment UI when
launching into an Android payment app for app store billing (the only
Android payment app supported on desktop).

After this patch, when desktop Chrome directly launches into Android
payment app, no other browser payment UI is displayed.

Bug: 1140815
Change-Id: Id04156b807176cb5f3d24529a586860b5b8f87b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491494Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821252}

This patch adds the logging of the ratio X/Y where

X is the size of serialized report with all UKM data omitted
Y is the size of the serialized full report

as a percentage to the UMA histogram UKM.ReportSize.NonUkmPercentage.

This is to provide us an estimate on how much of the bandwidth usage
is taken up by UKM data and non-UKM data. (Hopefully the non-UKM part is
small enough and has negligible influence on overall bandwidth usage.)

Change-Id: Ic73349e19736d326b3a585608afec07a855a2687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491423Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Yue Ru Sun <yrsun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821251}

This CL was uploaded by git cl split.

R=chrisha@chromium.org

Bug: 1142671
Change-Id: Icc28a6f36e869729bdd87cbdf26243a9c7fcb71d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500215
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821250}

This test has a pretty brittle expectation of failure for 0 != -0/
This is of course nonsense. (The astute reader will no doubt notice
that 0 does indeed exactly equal -0).

Fortunately there was already the idea of epsilon differences in the
test that were unused. Turning them on fixes the problem and allows up
to delete the expectation.

Also, in testharness assert_approx_equals(Infinity, Infinity, epsilon)
and assert_approx_equals(NaN, NaN, epsilon) were both returning false.
Considering assert_equals(Infinity, Infinity) and assert_equals(NaN, NaN)
are both true, this seems silly.

Bug: 1140535
Change-Id: Ie8a3977b3d97b920903a08a6301705c8c14fc6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498791Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821249}

This CL updates the customSeparator leading anchor according to the
text's leading anchor of each cells.

see: https://drive.google.com/file/d/1fzYGSTxmrU2iGN-GFd_NmXwHXj4i42_M/view?usp=sharing

Bug: 922511
Change-Id: Iddb7d1875ea8f169e7608c5a4f2c59fa2c78e48a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460893
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821248}

Change-Id: Ia1811f4126991402d59ad06e0b2c1c25313ab288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502670Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821247}

Fold

  SVGResourcesCache::ClientDestroyed,
  SVGResourcesCache::ClientWillBeRemovedFromTree and
  SVGResourcesCache::ClientWasAddedToTree

replacing the two former with a more direct RemoveResources(), and the
last with a similar acting AddResources().

Bug: 1028063
Change-Id: Ibf5eba0dc906d75967d9eaddb06ff01025d018e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501844
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821246}

NOTRY=true
TBR=kbr@chromium.org

Bug: chromium:982294
Change-Id: I7a58e763b70225f452b18ff8f2d50e5c4a9d76d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502951Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Auto-Submit: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821245}