- 23 May, 2019 40 commits
-
-
Maksym Onufriienko authored
Added testBookmarkHelpers in smoke_egtest. Bug: 922813 Change-Id: I59b2348545e737c2b756abcc58eb77e07c491c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626012 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662878}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2e8e116faf1..94515755316b git log d2e8e116faf1..94515755316b --date=short --no-merges --format='%ad %ae %s' 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@94515755316b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I996b19cda40dd28e8fb90af3b2111f1341884048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662877}
-
Zhenyao Mo authored
This aligns with WebGL's powerPreference semantic. More importantly, discrete/integrated GPUs might be a good description of Mac dual GPU situation, but it's incorrect on Windows. BUG=966251 TEST=bots R=kbr@chromium.org Change-Id: I2c7f073f06be3c2b2444bf0a81f56f71e656a713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626458Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662876}
-
Luum Habtemariam authored
These files encapsulate useful libCUPS-dependent utils for the CupsProxyService. Also renames type_conversions.cpp -> *.cc. Bug: chromium:495409 Test: TBA Change-Id: If55498960da9608438face8e6b8c4e1cfebfbb42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608720 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#662875}
-
Yuwei Huang authored
* Fix a bug in MuxingSignalStrategy such that it keeps waiting for both strategies to connect instead of giving up and using whatever is available. This essentially rewrites the state transition logic. * Add unittest for MuxingSignalStrategy. Bug: 966632 Change-Id: Ic94b1ef47b5109acd5d603f02cb8659353c02a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628130 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#662874}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b0016cc731ae..93490699ae99 Created with: gclient setdep -r src-internal@93490699ae99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:950188 TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ife5ffed3d4cfea16b113f2f87107c6aaefe8fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627961Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662873}
-
Keith Lee authored
There was a misunderstanding in how OnDisplayMetricChanged's changed_metrics worked. The implementation in ImeController assumed that the DISPLAM_METRIC_MIRROR_STATE will be true when mirroring is occuring. What actually happens is that OnDisplayMetricChaniged will have it's changed_metrics bitflag set to true when the metric has changed value (from true to false or false to true) The implementation has been updated to reflect that and the function documentation was updated to reflect that more clearly. Change-Id: I110b5b1fbee11f1c761b2c5d715b7034d8c44cd6 Bug: 824656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600616 Commit-Queue: Keith Lee <keithlee@google.com> Auto-Submit: Keith Lee <keithlee@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#662872}
-
François Degros authored
Removed member pendingTasks_ and the use of AsyncUtil.Queue through the judicious use of Promises. Fixed potential bug in whenVolumeInfoReady(). Change-Id: Ie3bf3301c3c4b8a723f0740afcebf7f65a96e44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627270 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#662871}
-
James Cook authored
Sub-pages may have parameters (e.g. networkDetail?guid=vpn2_guid) so we need to trim off the query before deciding if it's an OS sub-page. Bug: 966579 Change-Id: I179ccec90edb4155cd09bc44d498ee62f2e077b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628132 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#662870}
-
Dirk Pranke authored
`mb run` (i.e., `python tools/mb.py run`) can be used to run tests under swarming directly. However, it turns out that there were a couple of places where we were swallowing error output, making it hard to understand why things were failing silently :). This CL should fix at least some of those cases, and also tweaks the output a bit to be a bit more readable. Change-Id: If6b412a9afad472b35220cb23721002aaaadcd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623745 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#662869}
-
Caroline Rising authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1627654 Bug: 910739 Change-Id: Ie80bc128250fd4dde9763fd38ce5bcfc58669d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627666 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#662868}
-
Henrique Nakashima authored
This reverts commit b1e5f6ca. Reason for revert: Relanding with fix for chromium.android/android-jumbo-rel (crbug.com/966508) Original change's description: > Use ProfileKey instead of Profile in JNI_PrefetchBackgroundTask. > > Now that the task may run in Reduced Mode, there is not necessarily a > Profile anymore. > > Bug: 933358 > Change-Id: I58d3d69e724ca058b676cc4ff0b2b7ef24c7792e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625392 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662650} Change-Id: I8661080a1d70a252bb462b5cc8e023e0c75e8b51 Bug: 933358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627635Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#662867}
-
Austin Eng authored
This change rolls Dawn and updates Blink code to match the API. Roll src/third_party/dawn 820a04b9ce6b..eea209106803 (1 commit) https://dawn.googlesource.com/dawn.git/+log/820a04b9ce6b..eea209106803 git log 820a04b9ce6b..eea209106803 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 yunchao.he@intel.com Update VertexInput (InputState) to match spec - Part 1 CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: dawn:80, dawn:107 Change-Id: I99e03eb6c57999e9f5a238f2747325def22aa65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627944Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#662866}
-
Wei-Yin Chen (陳威尹) authored
Add unit tests before tinkering around. Bug: 965580 Change-Id: Ia17826cd4368cdfa70695d331369318e0497372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625745Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662865}
-
Ryan Hansberry authored
Create metrics to capture the success rate of user-initiated attempts to reconnect to an already paired device, for both relevant UI surfaces, Settings and System Tray. The distinction of "user-initiated" is key; it's a signal that the user expects that device to be present and connectable, so we can trust with reasonable certainty that most failure emissions to these metrics represent "true" failures or errors in our Chrome or platform stack. Bug: 958452 Change-Id: Ic8f551deff7c4a4cf83c6a974d3d83c5fcb423b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626637 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#662864}
-
Chris Hamilton authored
This endows frame nodes with knowledge of which browsing instance and site instance they belong to. This will be used to apply consistent freezing policy to all tabs in a browsing instance rather than opting them out of freezing entirely like we do now. This adds a new function to content/public/ to allow us to access information about the BrowsingInstance. BUG=960924 Change-Id: Ic4051bb2a4bd5ebac08e4fa5c49d20725b61d66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600153Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#662863}
-
Emil A Eklund authored
Bug: 963967 Change-Id: Icf0a87738a2cfdf5fc23da41d0332eef764ee475 Tbr: crouleau@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625826Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662862}
-
Pedro Amaral authored
In the previous CL (https://chromium-review.googlesource.com/c/chromium/src/+/1625966), I made a new SplitToolbarButton style for the split toolbar buttons. The invisible trash button was given that style but this caused the trash button to have a smaller width and shifted the New Tab button to the left. The invisible trash button should have the same width as the menu button so it should have the same style as the menu button wrapper View. Bug: 966355, 966356, 966357 Change-Id: I32a86f5073bde62700af4e0a86e0360023507765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627067Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#662861}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1b36669db55..4163317283be git log c1b36669db55..4163317283be --date=short --no-merges --format='%ad %ae %s' 2019-05-23 guidou@webrtc.org [PeerConnection::AddIceCandidate()] Use mid to look up contents in remote descriptions 2019-05-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 15b783dc..b82a5015 (662034:662691) Created with: gclient setdep -r src/third_party/webrtc@4163317283be The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:965483,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1cf8742f9890555b89b0322f518db97425939ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627780Reviewed-by:
-
Daniel Rubery authored
This test currently crashes when run in combination with other unit tests because it creates a NetworkService. If another test has already created a unit test and not destroyed it (e.g. through GetNetworkServiceImpl), a DCHECK in the NetworkService constructor fails. Bug: 940082 Change-Id: I74793b6e1c6b962307d14b32bb53f2cbf13738ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626516 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662859}
-
Becca Hughes authored
BUG=966198 Change-Id: I6aa82dea5b426f564bc386c9d5692ab7f43aed30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626534Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#662858}
-
Scott Violet authored
BUG=964460 TEST=covered by tests Change-Id: Ie90a07aa083962d9d04883a2912e034fe248c4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627911Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#662857}
-
Lambros Lambrou authored
This class accepts a refresh token read from the host config. It returns either a new refresh token with updated scopes, or a status code to indicate no upgrade is needed. Bug: 954427 Change-Id: I806abe0b1ebe2a979640cde07b3eb15a14cbe3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627693 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/9674a1a54754..7f4277e21b52 git log 9674a1a54754..7f4277e21b52 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 johnkslang@users.noreply.github.com Merge pull request #111 from Naghasan/codeplay-range Created with: gclient setdep -r src/third_party/spirv-headers/src@7f4277e21b52 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I7ed14d2401f3b5e4f898d2546406390e3d1ae36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627306Reviewed-by:
-
Scott Violet authored
Specifically OnWallpaperPreviewStarted. As this function is called async, it's entirely possible for there to be no active window. BUG=940322 TEST=none Change-Id: I551e7d10a4293ba2e3cb047114661393d873dce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628034Reviewed-by:
-
Emil A Eklund authored
Fix DCHECK in ComputeAbsoluteHorizontal and ComputeAbsoluteVertical that doesn't work when either of the values are saturated yet failed to check one of the values prior to the DCHECK. Also added if DCHECK_IS_ON guard. Bug: 966563 Change-Id: I54b4a3f0b8b94fd86245401c76fc0abe80444671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625819Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662853}
-
Sébastien Séguin-Gagnon authored
The Send to your Devices activity should be offered right next to the copy activity. Bug: 966523 Change-Id: I2e8855fbd0894ed6ff7499f55a8cee8eca4e4a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627657 Auto-Submit: sebsg <sebsg@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662852}
-
Alex Cooper authored
The code has supported updating inlineVerticalFieldOfView for a while, but has always used a hard-coded default. This change exposes the ability for a webpage to update or read this value, and changes the default value to match the specced 90 degrees (pi/2) requirement. As part of this change, magic-window is also updated to adjust this value. Bug: 953412 Change-Id: I583935c487ee58a0a588e5161e66976a3c0e9675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625924 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662851}
-
Hector Carmona authored
Moved icons: - gmail.png - maps.png - news.png - translate.png - youtube.png Bug: 950188 Change-Id: Ib1b5fad4be494dae18517865a11003412c0a1bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626732 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662850}
-
May Lippert authored
Bug: 950007 Change-Id: I6185c0911ebf520a1634cd5c632eadedad7912c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627815 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662849}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/37e000347c2f..63ab0c82ecf5 git log 37e000347c2f..63ab0c82ecf5 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 Max) Gu [FCP++] Filter loading image and text candidate Created with: gclient setdep -r src/third_party/catapult@63ab0c82ecf5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960365 TBR=eyaich@google.com Change-Id: Ib8f6eafc409cafb547f4540a414458ba05efc0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627954Reviewed-by:
-
smut authored
Bug: 966276 Change-Id: I347386b75c3f595050248f33993fc48f893ef2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626808Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#662847}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07a101971791..b8fe7211c465 git log 07a101971791..b8fe7211c465 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 43557651+sparmarNV@users.noreply.github.com Allow arrays of out per-primitive builtins for mesh shaders (#2617) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b8fe7211c465 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Id729f12078936102a548bdd5416955018878d6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627858Reviewed-by:
-
Lucas Tenório authored
The tests were flaky due to a race condition with the HTTPSForwarder initialization. By performing a login before the SetUpOnMainThread exits we can eliminate that problem. Tested on my machine by doing about 80 runs for all tests. Bug: 965369 Change-Id: If86b03f82ad0482d1098aad26613466118b7fcf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627453 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#662845}
-
John Chen authored
On Mac, the --use-mock-keychain is needed by the network service to load the correct keychain. Bug: 960926 Change-Id: Icae42bc00198e6178de923b23598101248e1add1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627937 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662844}
-
Alex Cooper authored
The current implementation of the OpenVRGamepadHelper always adds the optional grip and secondary axes buttons; however, if those buttons are missing and no additional buttons need to be supported, they should not be included. A prime example of this is the vive controller, which has a trigger, a grip, and a touchpad, but no secondary axis button. This is essentially the controller that the new TestGamepadOptionalData test builds. Bug: 964026 Change-Id: I1de93b5bd7bd0d9e75013cf33b8f333e5d70270f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627914Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/35a5a9e7beddb9cec70d7bc1b70a6ac441093f87..2e0d354690064c90ee245c715b92e2bb32492571 This picks up the AMD workaround and the 0-RTT change to help with measurement. Bug: none Change-Id: I89972affc3532a7acd70c90d588d13b94ccef275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627940 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#662842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/617f67de972a..b0016cc731ae Created with: gclient setdep -r src-internal@b0016cc731ae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I566be8b5a2d37de607dbb003f8add5ceee395314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627957Reviewed-by:
-
Tommy Steimel authored
This CL changes MediaNotificationBackgroundTest to be a subclass of testing::Test instead of AshTestBase. This makes the test independent of Ash code and ready to be moved out of Ash. Bug: 959478 Change-Id: I5ca7648abab8ce392c300f9a3dd69f920f24aeb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627652Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662840}
-
Nick Burris authored
Android scrollbars can't be interacted with by user input. This change makes the SolidColorScrollbarLayer explicitly not hit testable to ensure we don't enter any scrollbar scrolling code paths. Also updated a few tests in layer_tree_host_impl_unittest.cc that were using a SolidColorScrollbarLayer as a generic (hit-testable) scrollbar layer, which should instead use a PaintedScrollbarLayer. Bug: 954366 Change-Id: Icae9f43e043c412603d30330386710bf59482fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601348 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662839}
-
