- 10 May, 2019 40 commits
-
-
Xing Liu authored
This CL removes 5dp padding in the checkbox, so it can align with the icons above. Bug: 864785 Change-Id: I6881b0269498eb50bc7b5dd8d337fdedd8527f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604467Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658747}
-
Ovidio Henriquez authored
This change adds a layout change listener to the ItemChooserDialog view so that it renders correctly when the layout changes while it's open. Bug: 616227 Change-Id: I100fcac4d0bddf51dedd5ab1b3b99fa6936709f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604002Reviewed-by:
-
Kurt Catti-Schmidt authored
This change builds upon the functionality for AXPosition added in https://chromium-review.googlesource.com/c/chromium/src/+/1584596 Unit tests were added. Bug: 928948 Change-Id: Id52d39a73725a35a9b041ea2c3172c4a9c522171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594084Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#658745}
-
Matthias Körber authored
Bug: 961755 Change-Id: I80e355db7b0a1ae0fd2fe618d0851a3843d35244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605990 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#658744}
-
Ehsan Karamad authored
When a resource is intercepted at PluginResponseInterceptorURLLoader, it lets MimeHandlerViewAttachHelper override the response (which injects a static HTML page that embeds a GuestView). At this stage, the attach helper post the creation of MimeHandlerViewEmbedder class to UI (the MHVE will monitor the set up of MimeHandlerView). This opens up room for race: if the resource loading finishes sooner and ReadyToCommitNavigation is called before MimeHandlerViewEmbedder is created then the MimeHandlerView won't load. This CL, fixes this problem by deferring load until MimeHandlerViewEmbedder is created on UI thread. Bug: 659750, 961731 Change-Id: I8b6e5cc0fb6035464384b50fd182cb00a73ec4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605162Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#658743}
-
Yuwei Huang authored
Currently both CreateGrpcAsync.*Request() functions take a unique_ptr of grpc::ClientContext, however it turns out most of the requests don't need to set that. This CL removes that parameter from these functions. Callers who need to change the client context can acccess GrpcAsyncRequest::context directly. Change-Id: Ia00f67e0127526e3210f0c226c2f56d4281750df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606660 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#658742}
-
Ken Rockot authored
This CL introduces a new ServiceProcessHost type that abstracts away launch and lifetime management of service processes so the Service Manager can delegate to its embedder if necessary. This is a precursor to migrating process launching logic from Content into the Service Manager. A new ServiceManager::Delegate interface is also added for embedders to optionally implement, though only the default internal implementation exists in this CL. Bug: 781334 Change-Id: I6390c424d666ddfc68eee4d49fa08ce8a0165bcf TBR: eugenebut@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598322Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#658741}
-
Nicolas Ouellet-payeur authored
This lets admins configure the URL of an XML file which contains rules for the LBS greylist. The XML format is the same as for the `BrowserSwitcherExternalSitelistUrl' policy, except the logic is inverted to avoid confusing double-negatives. The content of this greylist is currently NOT written in sitelistcache.dat, as the BHO doesn't know what to do with it. Bug: 958659 Change-Id: I9074f1de2441a868a317cd3d33aa196f11fc053c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594189Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658740}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/dce7a4bc30c0..1475418902b2 git log dce7a4bc30c0..1475418902b2 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 zoddicus@users.noreply.github.com Change 'target' env to 'source' env in spvc API (#610) Created with: gclient setdep -r src/third_party/shaderc/src@1475418902b2 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I8f3f907e7e42417eea0069ee51fa44f5d6c0b4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658739}
-
Bret Sepulveda authored
This CL modifies tabstrip layout to include group headers, assigns the resulting bounds, and then paints them. Screenshot in the bug. Bug: 905491 Change-Id: I6ba81133eda43f8f3c98ae4158c3fcd00a28d1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546618 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#658738}
-
Vlad Tsyrklevich authored
Add gwp_asan::InstallPartitionAllocHooks() as the external API for embedders to enable PartitionAlloc hooking for GWP-ASan. Bug: 956824 Change-Id: I6df4ad163a602cb73d5ed2195dc7f0a48ca37343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601972 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#658737}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/802c51c55135..be0bae41e328 git log 802c51c55135..be0bae41e328 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 saklein@chromium.org Build API: Add USE flag passing support to the API. Created with: gclient setdep -r src/third_party/chromite@be0bae41e328 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I22f94c905b8be07371b3927ad226adb086f6aaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606106Reviewed-by:
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - disabled - level - live - multiselectable - Breakdown of UI Automation AriaProperties need to be implemented: atomic [part 1] busy [part 1] channel [part 2] checked [part 1] disabled [part 3, this cl] dropeffect [part 2] expanded [part 1] grabbed [part 2] haspopup [part 1] hidden [not implemented] invalid [part 1] level [part 3, this cl] live [part 3, this cl] multiline [part 1] multiselectable [part 3, this cl] posinset [part 4] pressed [part 4] readonly [part 4] relevant [part 4] required [part 1] secret [part 2] selected [part 1] setsize [part 5] sort [part 5] tabindex [part 2] valuemax [part 5] valuemin [part 5] valuenow [part 5] valuetext [part 5] - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification - Link to part 1, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1574834 - Link to part 2, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1576280 - Link to part 3, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1589100 - Link to part 4, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1592640 - Link to part 5, UIA: Fire UIA_AriaPropertiesPropertyId event: CL:1591487 Bug: 928949 Change-Id: If2dff6ee3c40a6a4d5e7bec0b298e599b529f878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589100 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658735}
-
Eric Robinson authored
Adds total time spent in tasks by ad creatives on a page. These metrics mirror the existing metrics that keep track of the percentage of overall time that an ad creative consumes. Bug: 960457 Change-Id: Ie49a22fc48bd74a9c3dfd326b3dcf74869ae7ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599686Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658734}
-
Michael Crouse authored
Bug: 928299 Change-Id: I28cf9ad47f7ca05fe9132b3bb64ee2a346a8fc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555418Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#658733}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9997a830ee55..3f5b5b8f8493 $ git log 9997a830e..3f5b5b8f8 --date=short --no-merges --format='%ad %ae %s' 2019-05-03 absl-team Googletest export 2019-04-29 misterg Googletest export 2019-05-02 daquexian566 Fix -Wsign-conversion error by adding static_cast Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: Ic675ea955f9f6b6ce33b311957ab697bc787c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597689 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#658732}
-
Justin Cohen authored
about:blank?query URLs are expected after fixup. Change-Id: I155245731e7f3623e7f27ad8ba76ddb4cc55fc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582960 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#658731}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cb9bf9ac9dc2..2568cf76ee2c git log cb9bf9ac9dc2..2568cf76ee2c --date=short --no-merges --format='%ad %ae %s' 2019-05-10 bclayton@google.com SpirvShader: Implement OpImageQuerySamples 2019-05-10 bclayton@google.com Assign the DeviceIndex builtIn (ext: SPV_KHR_device_group). 2019-05-10 bclayton@google.com SpirvShader: Fix incorrect use of getPointer() with GetPointerToData() 2019-05-10 bclayton@google.com SpirvShader: Implement OpImageQueryLevels Created with: gclient setdep -r src/third_party/swiftshader@2568cf76ee2c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279,chromium:b/130937460,chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: I8c3ca554c5c2466d96f7e1435ab7a1ae9b9a44a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606077Reviewed-by:
-
Maggie Chen authored
There is a V8 garbage collection perf change with V8HugeMaxOldGenerationSize finch enabled. We want to keep the GC the same while adding support for bigger mas old generation size. The V8 GC fix will be ready soon. Disable the V8 finch testing for now and Re-enable it when the fix is merged in to the new V8 build. Bug: 961272 Change-Id: I89523a086bbfd3cf2ce9299314aee214243845c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604335Reviewed-by:
-
rbpotter authored
Fix CrExtensionsManagerTestWithMultipleExtensionTypesInstalled.* to pass on Mac 10.13 with --disable-blink-features=HTMLImports Reproduced test failure locally on Mac 10.13, and verified test passes with fix. Bug: 925517 Change-Id: I8cabf2fccc3c4a1660373d65d203854e1234664c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604204Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#658728}
-
Alan Cutter authored
This CL adds helper functions for converting Time values into base::Values via string representation. As a side effect we also get TimeDelta and int64_t conversions for "free" as they have identical data representations. This change is to dedupe common logic between PrefService, AppBannerSettingsBanner and a future CL to add the same conversion logic in a web_app::install_metrics namespace. Change-Id: Ie5758a6e395292eb738f89a395df3763ee674739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596149Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#658727}
-
Jérôme Lebel authored
RecordSyncSetupDataTypesHistrogam() is now called by AdvancedSigninSettingsCoordinator when the signed in is confirmed. Bug: 961691 Change-Id: I9f01c37f661e796d44ffa0905956ffb922b55a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605913Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658726}
-
Robert Sesek authored
Bug: 958163 Change-Id: I6e990717c0559d5ff4a087940a15470c72cc9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606422Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#658725}
-
Eric Willigers authored
AppInstallationAcceptanceCallback now accepts a unique_ptr. The type adapter function BookmarkAppAcceptanceCallback is no longer required. Bug: 915043 Change-Id: Ia32ca1f704c5e110da0fe5e677218d1913dce7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600939Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#658724}
-
Bryan McQuade authored
See https://docs.google.com/document/d/1bPWScr35Wv-xPy85JQ3mf12AXJ7AqSFqen6MxxslSJM/edit for details. Change-Id: I10376ff5a34d1025f09372ecc1b34365faec312c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589699Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#658723}
-
Siddhartha S authored
Refactor common code into a function. BUG=925151 Change-Id: Ieed9ec0ce141cc80e174d4c8f2809267656fa96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605157Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#658722}
-
Xiyuan Xia authored
Regression caused by https://crrev.com/c/1603484. The shelf background type is not initialized corresponding to the initial session state. When starting with stub user or an existing user (crash-n-restore), ShelfLayoutManager thinks it paints the default background but ShelfWidget actually paints the login background (i.e. transparent). Bug: 958214 Test: Run chrome with stub user and observer shelf background. Change-Id: I6e33e02e4213052ea90ecb0ae94c3dc8b9568dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604489 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#658721}
-
Nicolas Ouellet-payeur authored
Instead of always saying "Managed by your organization", it now says "Managed by example.com" when the user is logged in to Chrome with a GSuite account. https://i.imgur.com/hK2XL83.png Bug: 959258 Change-Id: I0f524de79d2adc1bdc2957f4973da60bd10b80af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603702Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658720}
-
Zhenyao Mo authored
This is in case build results are deleted in the future. Starting from build 4370, each test is repeated three times to reduce run to run noises. BUG=867155 TEST= TBR=sunnyps@chromium.org NOTRY=true Change-Id: I85d572692965733f4f6708ae2b4f8f7651c0a9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606400Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658719}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f185df0cfd8c..5d29b3945d69 Created with: gclient setdep -r src-internal@5d29b3945d69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:961541 TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I04e56f3b0827a21c8e9a77cd8b29580d5e1aef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606078Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658718}
-
Matthew Cary authored
On Android KitKat, the native library must be extracted manually from the APK file. All library files are extracted, and then after the native library is identified, the unused libraries are cleaned up. This CL changes this cleanup to happen on a java thread rather than doing a PostTask, which waits for native library loading to finish. There is no reason to wait for the native load to do this cleanup, and in addition waiting for native loading has made the EarlyTraceEvent tests flake (see the bug). Bug: 930174 Change-Id: Iad417e6d7e535ff1b735ab955086e913f622fd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605682Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Matthew Cary <mattcary@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658717}
-
Caitlin Fischer authored
When constructing labels for a collection of profiles, it is useful to know whether certain fields, such as email address and first name, can disambiguate profiles. Also (1) changes the name of GetLabelName to GetLabelFullName, (2) adds GetLabelFirstName, and (3) removes HaveSameEmailAddresses. GetLabelFirstName will be used by mobile-friendly LabelFormatters since first names take up less space than full names. This is a separate CL to reduce the size and complexity of the upcoming mobile-friendly-related LabelFormatter changes. Bug: 958333 Change-Id: I971cb78342ed89987765bb16656c302e5bc4d4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594074 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658716}
-
Sergey Ulanov authored
Android's implementation of GetFallbackFont() uses SkFontMgr , so it works on Fuchsia as well. Moved it to a new font_fallback_skia.cc. Also 1. Replaced font_render_params_fuchsia.cc and font_renderer_params_android.cc with font_render_params_skia.cc - the two implementations were almost identical. 2. Enabled test_fonts usage in gfx_unittests on Fuchsia. 3. Now all font-related unittests in gfx_unittests pass on Fuchsia. Updated test filter file accordingly. 4. Updated platform-specific ifdefs for some RenderText unittests to make them pass on Fuchsia. Bug: 952652, 960389 Change-Id: I6bf14bfea7a1649b2ad795c0594265a6051cd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602286 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#658715}
-
Becky Zhou authored
Bug: 957262 Change-Id: I53e0b5e05d630a8f6dece614f1dc6be8666ed429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589056 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#658714}
-
Scott Violet authored
I'm working on a separate patch that seems to be tripping over this. The specific sequence is: . ItemRemoveAnimationDelegate is created for a view. . We're in shutdown, meaning the widget is closing. . ~AppsGridView is called . ~AppsGridView calls RemoveAllChildViews(true). . View::DoRemoveChildView() is called for the view that is animating. . View::DoRemoveChildView() calls AppsGridView::ViewHierarchyChanged(). . This cancels the animation, deleting ~ItemRemoveAnimationDelegate. . ~ItemRemoveAnimationDelegate is called, which deletes the view. . View::DoRemoveChildView() continues on with a now deleted view. The fix is to cancel the animations in ~AppsGridView before calling RemoveAllChildViews(). Doing that means we aren't attempting to delete a view while View is trying to clean it up. As my other patch readily trips over this, I'm not adding a test. BUG=none TEST=none Change-Id: I88f1640ed512d762f4f52efb6748317c048c64a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605220Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#658713}
-
Emil A Eklund authored
Explicitly disable the LayoutNG runtime enabled feature for web_tests if not explicitly enabled to allow the feature to be toggled without having to update thousands of expectations each time. Once stable, results will be updated one bot at a time by explicitly enabling the feature per bot. This logic will be removed once LayoutNG has been enabled for every bot. Bug: 961437 Change-Id: Ia823ba0f92817e0c8ee0250bb4c662f0efdabe4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603528Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658712}
-
Morten Stenshorne authored
[LayoutNG] fast/scrolling/unscrollable-layer-subpixel-size-with-negative-overflow.html is also flaky. The virtual/fractional_scrolling_threaded/ version was already marked as such, but the main test has similar issues. Pass rate is about 80% (tested locally). The width of the yellow box is sometimes off by one pixel. TBR=kojii@chromium.org Change-Id: Id7d7fd54ed1854557e596a3475885dc51ea2dae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605992Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#658711}
-
Daniel Rubery authored
The 99th percentile for DMG, ZIP, and RAR extraction is consistently above 10 seconds, the maximum of the histogram range. So replace these metrics with a larger range, that goes up to 3 minutes. Bug: 948272 Change-Id: I11cef5c3ea2d500d76f90a094274af52c8796c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601064Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#658710}
-
Wojciech Dzierżanowski authored
Change-Id: I42d7b6974fb31a661b1bd02142c4755758609a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604278 Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
-
Asanka Herath authored
This removes the flag from the commandline and about:flags. Whether or not Google Chrome or Chromium uses NTLMv2 -- as opposed to LM or NTLM -- can still be controlled via the 'NtlmV2Enabled' policy. See https://www.chromium.org/administrators/policy-list-3#NtlmV2Enabled for details. Use of NTLMv2 is enabled by default. So the only meaningful value for this policy is FALSE. Bug: 959402 Bug: 953690 Change-Id: If6ad85220404546d69a5b77676705853bd08292d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604312 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#658708}
-
