- 15 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d2b075ce060..f124108e2325 2020-12-15 mtklein@google.com how to use SkArenaAlloc with no friends 2020-12-15 csmartdalton@google.com Get CanvasKit viewer compiling again 2020-12-15 jmbetancourt@google.com implement SkAudioPLayer for Android 2020-12-14 johnstiles@google.com Optimize Gaussian convolution fragment processor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ief714543132e1f33bd4f6aa18a45c7481c1b0846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836955}
-
jchen10 authored
This is the initial implementation of WebGL_webcodecs_video_frame: https://www.khronos.org/registry/webgl/extensions/proposals/WEBGL_webcodecs_video_frame/ It's basically functional on Win, ChromeOS, Android and MacOS. Test: https://www.khronos.org/registry/webgl/sdk/tests/performance/webgl_webcodecs_video_frame/ Bug: 1142754 Change-Id: I41a860e7d1388824ab00863d5fa6d8972822145b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525285Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#836954}
-
Michael Hansen authored
Moves the logic for determining the ShareType into the *Attachment classes. This cleans up some static casts and also allows this logic to be reused when generating the preview for the receive dialog page, coming in a subsequent CL. To avoid a dependency cycle I've moved the ShareType mojo struct definition into its own build target, which required importing new mojo gen files in a number of places. Fixed: 1144942 Change-Id: I7fe151470c9067a918363152d2e0520a08dc0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582523 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836953}
-
Victor Costan authored
This CL updates IndexedDBBackingStore and its inner classes. * Each class is documented as not thread-safe. The obsolete thread safety comment on IndexedDBBackingstore is removed. * Each class' data members are either marked const or GUARDED_BY_CONTEXT with a SequenceChecker. * DISALLOW_COPY_AND_ASSIGN is replaced with deleted copy constructor and assignment. * An unused data member was removed. * Data members initialized with constants in constructors are instead initialized when declared. * Invariant-enforcing DCHECKs are consistently placed at the beginning of methods. This CL introduces no functional changes. Change-Id: I8a38d0f2225ff4b5334fd37891a8216b8bb72930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588292Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836952}
-
Alan Cutter authored
This CL enables the migration from default Chrome apps over to web apps on Chrome OS only. This migration is targeting M89 and will use Finch to control the rollout in stable, all other channels will start migrating immediately. Bug: 1058265 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I5aabdc0efa2057ee77480d2c78ec16df93878ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586167Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836951}
-
Jiewei Qian authored
Cleans up left over code in https://crrev.com/c/2265693. Also adds a test to verify full url is used when launching a web app from intent. Fixed: 1157281 Change-Id: I47597bc93903ab9b8aa80bf3ddfa484676640e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589258 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836950}
-
Kenneth Russell authored
Flaking frequently on SkiaRenderer-Vulkan, causing CQ retries. Bug: 1157136 Change-Id: I64ec1665940b993f135797449d5bfabb7de66874 Tbr: juanmihd@chromium.org Tbr: fserb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592148Reviewed-by:
-
Johann authored
Debian has removed python-pexpect: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=937275 //third_party/pexpect is preferred. Change-Id: I0e3355ce2fdd90860592de908f14e734d9c28d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585263 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#836948}
-
Luciano Pacheco authored
This reverts commit b5ab6427. Reason for revert: crbug.com/1158657: android_sync_integration_tests on Android device Nexus 5X Original change's description: > Rename publicly_routable field in the history APIs to floc_allowed > > What: Rename publicly_routable field in the history APIs to > floc_allowed. The database schema is left unchanged to save the > migration cost. Updated the comment for VisitRow::floc_allowed. > > Why: This bit is expected to be used only for floc. We've decided to > incorporate another opt-out status, and may introduce more status in > the future. Therefore it makes sense to rename to floc_allowed. > > Bug: 1157761 > Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836815} TBR=sky@chromium.org,yaoxia@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ibcb3110a830007f1b659ed25a6722d45734d941a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592171Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836947}
-
WangHui authored
RenderFrameHostImpl::isolation_info_ will be updated according to the isolation_info_for_subresources_ of the NavigationRequest at the end of the commit, so when RenderFrameHost is restored from the cache, the isolation_info_for_subresources_ of the NavigationRequest needs to be updated. Bug:1158333 Change-Id: Iac3109506b6f091cec8f7bd582dfe93afe36bb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589494 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836946}
-
Toby Huang authored
Legacy supervised users (LSU) are deprecated. The login screen hides LSUs to block login. This CL records a metric to estimate the number of dormant LSU cryptohomes in the wild. We want to delete these LSU cryptohomes later. Bug: 1151066 Change-Id: Iac2eb1ca778194c5cd4ccb069a61160b8ed57929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579715Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836945}
-
Giovanni Ortuño Urquidi authored
In theory UseWebUIBindingsForURL could be used to check which WebUIs have bindings and which don't, but in practice this method was implemented as `return UseWebUIForURL()`, meaning all implementations return true if there is a WebUIController for it. This CL removes this method in favor of UseWebUIForURL(). UseWebUIBindingsForURL() was used for: 1. Deciding if we should force a process swap when navigating between two URLs. 2. Deciding if the host was appropriate for the URL. Semantically this change means that we'll force a process swap for all WebUIs with WebUIControllers, even if they don't use WebUI bindings, which is desirable. In practice this was already the case because of the implementations of UseWebUIBindingsForURL(). Bug: 1080384 Change-Id: I06cb5ad503a91582d6a4058b1cc77794bb6f0dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583590Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Taylor authored
This reverts commit 238fa3b0. Reason for revert: Suspected to have broken data channels on Linux due to getrandom syscall, see: https://bugs.chromium.org/p/chromium/issues/detail?id=1157658 Original change's description: > Roll src/third_party/usrsctp/usrsctplib/ 995c0b844..2caaff2b0 (39 commits) > > Fixes some windows compile warnings that were preventing fuzzers > from being added; only minor functional changes since last update. > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..2caaff2b0a1d > > $ git log 995c0b844..2caaff2b0 --date=short --no-merges --format='%ad %ae %s' > 2020-10-02 tuexen Minor cleanup. > 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) > 2020-10-01 tuexen I guess Bitrig support arc4random(). > 2020-10-01 tuexen Whitespace change. > 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. > 2020-09-30 deadbeef Add missing return type to init_random. (#531) > 2020-09-30 tuexen Try to fix the Windows build. > 2020-09-30 tuexen Add Android specific code for the random number generator. > 2020-09-30 tuexen Add platform specifc includes to the corresponding code. > 2020-09-30 tuexen Add a cleanup routine for the random number generator. > 2020-09-29 tuexen Improve the input validation and processing of cookies. > 2020-09-28 tuexen Whitespace cleanup > 2020-09-28 tuexen Improve random number generation on __Fuchsia__. > 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. > 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 > 2020-09-24 tuexen Whitespace changes > 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) > 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) > 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Cleanup. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Fix syntax error on windows. > 2020-09-19 tuexen Add include for getrandom() on Linux. > 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Improve random number generation on Linux and Windows. > 2020-09-19 tuexen Cleanup read_random(). No functional change. > 2020-09-19 tuexen Fix NetBSD related #ifdef. > 2020-09-19 tuexen Whitespace changes > 2020-09-18 tuexen Add license. > 2020-09-18 tuexen Add license statement. > 2020-09-18 tuexen Fox more typos. > 2020-09-18 tuexen Fix typo. > 2020-09-18 tuexen Remove trailing whitspaces. > 2020-09-18 tuexen Improve consistency, no functional change intended. > 2020-09-18 tuexen Check for too short packets when using the receive threads. > 2020-09-18 tuexen Fix mask for ECN bits. > > Created with: > roll-dep src/third_party/usrsctp/usrsctplib > > Bug: chromium:1025302 > Change-Id: I3faeb75f9f12d71b7b6ef3d326ad2e8d8becf3cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430446 > Commit-Queue: Taylor <deadbeef@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813385} TBR=hta@chromium.org,deadbeef@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1025302 Change-Id: I2c4bd6158a0e91ba7863558e1e2d37456fdf1505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586379 Auto-Submit: Taylor <deadbeef@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#836943}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9409d7cfa91..e00b46fe9704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lucmult@google.com,atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041619,chromium:1099017,chromium:1147459,chromium:1156861,chromium:1158073,chromium:1158493 Tbr: lucmult@google.com,atotic@google.com Change-Id: I42b560a5e7a2cb7d8d1d701f4d13fcafc2e50650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591750Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836942}
-
Jason Lin authored
MediaClientImpl needs to register itself as an observer of VmCameraMicManager. Depending on whether the user has customized a flag or not, MediaClientImpl is either constructed before or after `UserSessionInitializer::OnUserSessionStarted(/*is_primary_user*/=true)` is run. The reason seems to be that 1) MediaClientImpl is constructed in a task queue; 2) Customizing a flag causes the browser to be restarted after the user signs in, which changes the execution characteristics. My last attempt (CL 2586286) to fix the registration does not work if the user has customized flags. So, this CL makes VmCameraMicManager a singleton which is always available so that MediaClientImpl can always reliably do the registration in its ctor. Bug: b/167491603 Change-Id: I2b73b59216851f0b8b2533120317e54c98382b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589061 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836941}
-
Rakina Zata Amni authored
Add to WebView allowlist, and modify/add what we log. Bug: 1131832 Change-Id: Ifcbce4c6e882d9052cea3edd8627ae5069438f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589614Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7b94d61efca..3a5f4f619054 2020-12-14 annabelzhou@google.com Add experiment flag for full accessibility tree 2020-12-14 andoli@chromium.org Fixes unshown images larger than 1MB in ImageView If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb228c5dd1731a7be293e8d9958cb7d83b00b5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591459Reviewed-by:
-
Jinsuk Kim authored
A bug causing FullscreenManager to call #onEnterFullscreen more often than #onExitFullscreen makes BottomSheet suppressed. This CL makes sure BottomSheetManager handle suppress token in such a way that the number of the same event calls doesn't matter. Bug: 1157368 Change-Id: I70b951dffc242d8da75fa74bc451a5d0864536d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589143 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836938}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I95551b76ff341c34241115b988ef10117826e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591451Reviewed-by:
-
Asami Doi authored
Originally, the installability check verified whether or not the manifest scope is within a service worker's scope. Today, we want to also check if the page specified by `start_url` in a manifest has a service worker and works well offline. Bug: 1157242, 965802 Change-Id: Ibe0a8a76a34bccecd461d9b106590e00807b531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583674 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Donn Denman authored
Adds a new feature that controls how the tap gesture is handled. When enabled it makes tap do a literal search for the selection without using any page context. This is intended to be paired with one of the features that allow the longpress gesture to be the smart resolving gesture that does look at the page context. Removes support for the the old preserve-tap arm Variations parameter in favor of this new literal-tap Feature. A lot of the refactoring is just changing usage of "longpress" to "literal". We originally hard-coded longpress to be the non-resolving search (aka literal search) but now it can be either tap or longpress. BUG=1152257 Change-Id: Iee1795578b09c6c1c1d70933b3712b725316b59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557337 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#836935}
-
Shane Fitzpatrick authored
Screenshot: https://screenshot.googleplex.com/qpwDQLqPGPtRepp Bug: 1157990 Change-Id: I1f8657dbe94aa6c6886016e9460de53569d18c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587520 Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by:
-
Jinsuk Kim authored
toolbar/ package is being modularized. Adds a DEPS file in toolbar/ to discourage new dependencies on chrome core package. Except for ToolbarManager/ToolbarButtonIPHController not planned to be a part of the modularized target, the rule mandates the toolbar classes not include files from chrome_java. Bug: 1127732 Change-Id: I36b1ed6d6951c92d7f2db4affe14b551843cc143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512498 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836933}
-
Frank Liberato authored
When RTCVideoDecoderStreamAdapter detects that too many frames are pending decode, it resets once and increases the maximum threshold for underflow to allow the DecoderStream to restart. If it runs out of space a second time, then it'll fall back to software. Counting the number of consecutive failures (== without a decoded video frame) isn't meaningful; it can be at most two. It has a similar effect as the consecutive error count, though; after 40 frames input without one decoded frame, it will fall back to software decoding. Bug: 1150100 Change-Id: Ie846a98c4002153cde119a32b5bdb1485ed44fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591457Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#836932}
-
David Black authored
The pinned files section of holding space needs to paint to a layer to avoid clipping the focus rings for holding space item views. That said, it still needs to impose a clipping rect to avoid scrollview contents being displayed outside of the scrollview viewport. Bug: 1152948 Change-Id: Ia14ff0df7dc36650d573d1f9d79f73360c08178b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589043Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#836931}
-
Xinghui Lu authored
See https://crbug.com/1157814#c3 for the reasoning of this change. Bug: 1157814 Change-Id: I33a81991fd108ddaf23f5d796941d1347f17ca9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589016Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836930}
-
Matt Falkenhagen authored
We care more about LargestContentfulPaint than FirstMeaningfulPaint these days. Bug: 1119700 Change-Id: If9502b42366bd342f5c57e89960d86a17d2fa591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586174 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607968714-2c0d8e306c302723844f6b00a98bd81e984a44c7.profdata to chrome-linux-master-1607990340-53c9e3140dd3b8c460ccf491247e5091922518d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icc9eac550e06cf18b7ae798819d923ccaa6788f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592053Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607968714-c306ec7882cc59048926f4cb1ac6492a09bdd2f6.profdata to chrome-mac-master-1607990340-b842078f4ff08f48e84e09068e00677c1a1bb8df.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id8d380aeaa84d23fdcd54d5954ba828524293b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592052Reviewed-by:
-
Utkarsh Patankar authored
Chromium and Google Chrome should use separate registry locations to specify the native messaging host manifest file. Chromium and Chrome already use separate locations on platforms other than Windows. This CL separates it for Windows too. All native messaging extensions that currently work with Chromium use the Chrome registry location. So, retain the Chrome registry location as fallback option for Chromium to maintain backward compatibility. Bug: 1106717 Change-Id: I8889efbfdf238b798d0956812fa73d48b15f14dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569168 Auto-Submit: Utkarsh Patankar <utkpat@microsoft.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836926}
-
Wei Lee authored
Bug: b/175520499 Test: Chrome won't crash after closing page while streaming Change-Id: I28d0c34a0ee8e0cd25fbe5c65e7c860d6f6bb00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589413 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836925}
-
David Maunder authored
By using templates the database is reusable for different protocol buffers. One application is for chrome cart which in the experimental code looked very similar to persisted_state_db. By using templates we can avoid duplicating a lot of code. Bug: 1154499 Change-Id: I65bdaa3142eede152db26cd5629001b815f3b493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570451Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836924}
-
David Staessens authored
This reverts commit e95b4797. Reason for revert: This breaks lower resolution test cases in ARC++/ARCVM. Original change's description: > media/gpu/vaapiWrapper: Don't use hw decoder with hybrid driver for smaller resolutions > > The performance of the decoder with the intel hybrid driver [1] > is worse than a sw decoder especially when multiple decoders run > simultaneously. For instance, a video call app (e.g. Meet) likely > requires us to decode more than 10 smaller resolution videos. > The user experience is better by using sw decoders than the hw > decoder in these cases. > This CL selects sw decoder for QVGA and smaller resolutions by > setting the minimum supported resolution of the hw decoder to > 321x241. This dimension is selected from the fact that the > resolutions of videos in tile layout in Google Meet are QVGA. > > [1] https://github.com/intel/intel-hybrid-driver > > Bug: b:171041334 > Test: tast run webrtc.* > Test: SW decoder is used in https://appr.tc/?vsc=vp9&vrc=vp9&video=minWidth=320,maxWidth=320,minHeight=240,maxHeight=240 > Change-Id: I9b19878aae57587bab921481d7dca5087d7f538b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494521 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832616} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:171041334,b:175509204,b:175515392 Change-Id: I31705d7af2c586f17f4b17722f26cae49d4bd9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588674Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#836923}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84bd4d62..a1714d05 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I79be795b7a7eff69af36b923b10e348f6e7f076e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591687Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836922}
-
Phillis Tang authored
Fix UKM metrics recording to use GetAppEffectiveDisplayMode instead of GetAppDisplayMode to record the actual mode when user is interacting with the app. Bug: none Change-Id: Ia9d0fa5e62d3bc80ed2731ce6595bff919ed9e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591869Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836921}
-
Dale Curtis authored
Previously we assumed all HDR content is 10 bit and all SDR content is 8-bit; this generally works well, but now that the accelerators have a GetBitDepth() method, we should use it. This change utilizes the same mechanism we do for size changes: we get a kConfigChange event on the first decode which has the real size and bit depth information. We still assuem HDR is 10 bit and SDR is 8bit at decoder creation, but if we're wrong we'll now fix that choice during the first config change rather than silently emitting P010 as NV12 /grumble. R=liberato Fixed: 1115846 Test: Updated unittests. Change-Id: Ifa56c65c2fd7bb82d404f6a73a4369b347a7d1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590395 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#836920}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 255c4ec6. With Chromium commits locally applied on WPT: ced49c96 "[AspectRatio] Correctly handle abspos replaced elements with aspect-ratio" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ifbbc45bd18fa58f7dd2cb0ef838f6b936c9c3a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591268Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836919}
-
Jimmy Gong authored
SystemWebDialogDelegate::ComputeDialogSizeForInternalScreen() returns a valid dialog size only if the internal screen is available or if there is no internal screen in the device hardware. There is another edge case where the laptop's lid is closed which makes the internal screen unavailable. We were previously not handling this edge case and returned a (0,0) size for these dialogs. The fix is to return the preferred size for this edge case. Fixed: 1157591 Change-Id: I023dfcde33a1099aa14ac487e9ad109c1b9ad3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590688 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Dale Curtis authored
This uses a base::SingleSamplMetric to log the peak number of instances per RenderFrame. We'll use this value to establish a limit on the maximum allowed. R=sandersd Bug: 1144736 Change-Id: Ic0dac59d8682da0ea3185dcf97e7273bd9e037c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587493 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836917}
-
rbpotter authored
Change-Id: I3a329883d475d30ac4b95d404c8b1abc1b69eb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583842 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836916}
-
