- 27 Sep, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcf01fe4d418..097e2c1cf9b4 Created with: gclient setdep -r src-internal@097e2c1cf9b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I04a15ee6821d0a83fe322fe6636a7d292432360a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828245Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700688}
-
Marc Treib authored
These two types are deprecated and can be removed. Note that SUPERVISER_USER_SETTINGS and SUPERVISED_USER_WHITELISTS are *not* deprecated. This includes removing the ModelType enum entries, removing the fields in the EntitySpecifics proto, and deleting the specifics proto files. Bug: 965503 Change-Id: I53038fdc28ed8518cd99d4a4769b5f1f52d3e94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824882 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700687}
-
Vasiliy Telezhnikov authored
This CL re-enables ETC1 thumbnails for vulkan as we have ETC1 support in |WrappedSkImage|. Bug: 906794 Change-Id: I3da64071970b36bd0e5c17eacc62ef46d0a85d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822023Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#700686}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/711cccd3a162..f13084ded0d6 git log 711cccd3a162..f13084ded0d6 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 lalitm@google.com Merge "trace_processor: add tracks for Chrome legacy instants" Created with: gclient setdep -r src/third_party/perfetto@f13084ded0d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic651c4a76ec492612408e90c2201bbac7d81cbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700685}
-
Miyoung Shin authored
This change converts SmsReceiver mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I8836c05492638350bc53e2bb1c4a4ede9cc2285f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824734 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700684}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1903a35e00e8..bc8049ef0bc6 git log 1903a35e00e8..bc8049ef0bc6 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 ilnik@webrtc.org Reland "VP9 encoder: handle disabled layers correctly" 2019-09-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 42b9d99d..e76bf0b8 (700503:700610) Created with: gclient setdep -r src/third_party/webrtc@bc8049ef0bc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I20f369bb07ebd87e221ef192d3179de890e1cfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828619Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/377dc2ac..791dddd6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie968ecb156900273e7704adb65ea7055406d2e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700682}
-
Mohamed Amir Yosef authored
TBR=mkwst@chromium.org Changge-Id: I766da46a59f69b4ced092bbc03763c4827727bf5 Bug: 949519 Change-Id: I65243fae667d5ca348871b00e14bab179cc54e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828903 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#700681}
-
arthursonzogni authored
TBR=nasko@chromium.org Bug: 995428, 968529 Change-Id: I830ffc2acab8e9b52d06a89f6fb101a237d79d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807309Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#700680}
-
Justin Cohen authored
This appears to have been fixed by iOS within the past year. Disabling this flag so we can test various configurations. Bug: 887497 Test: Test bug on various iOS versions. Change-Id: I70957e4bddfa42e58c28a1445faa2dd71a8c74b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827409 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#700679}
-
Mikel Astiz authored
This information is already sent to other servers such as the one used for omnibox personalization, hence the patch doesn't upload additional information but allows measuring the impact variations have on the sync server and debug errors caused by client-side experiments. Bug: 887521 Change-Id: I3358956639bf96260bb5010279012195086eec37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#700678}
-
Justin Cohen authored
It's possible for there to be pending navigations for a session that is going to be restored (such as for the -ForwardHistoryClobber workaround). In this case, the pending navigation will start while the navigation manager is in restore mode. There are other edges cases where a restore session finishes without trigger it's start, such as when restoring some with some app specific or blocked URLs, or when WKWebView's backForwardList state is out of sync. Bug: 1008026 Change-Id: I2d4d41321a21f8dad8acf72c8e8529ac73ea7d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826890Reviewed-by:
-
Mark Cogan authored
Currently, TabModels create and own their WebStateLists. A Browser creates a TabModel, and then exposes its WebStateList. There are two problems with this. First, TabModel is being actively refactored away. Second, because TabModel is an Objective-C object, this makes it hard to reason about when the WebStateList will be destroyed, which makes things like dangling observers hard to catch (see crbog.com/1001960, for example). This CL changes this ownership. Now, BrowserImpl creates and owns the WebStateList, and it passes a (weak) pointer into TabModel. TabModel's existing -browserStateDestroyed method is called when the Browser destructs, and the contract of that method is that the TabModel should tear down its interactions with the Browser and BrowserState, and it (the TabModel) should be removed soon thereafter. BrowserImpl now also creates and owns the web state list delegate; its current role is just to attach tab helpers each time a web state is added to the list. This used to be named TabModelWebStateListDelegate, but this CL renames and moves it to be BrowserWebStateListDelegate. Various tests need to now create web state lists (and, thus, web state list delegates) to inject into tab models. -browserStateDestroyed is renamed to -disconnect to match other code. Because a test in ios_internal/ uses the existing TabModel initializer, it needs to be kept functional (which involves it creating an internal web state list). This will go away as soon as possible, once this CL lands and the internal test can be cleaned up. Bug: 1001960 Change-Id: I8d8886bbbedc4c701ae0956d0f5e0984812b725b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796358 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#700676}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1a233ab5. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" b5630d76 "Convert NFC client to use BrowserInterfaceBroker" 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie5e9f7fbee44ec6650c2c0105b762abc07bd4656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700675}
-
Lily Chen authored
This test was previously setting a CanonicalCookie that had SameSite set to NO_RESTRICTION (i.e. SameSite=None), but which was not secure. Under CookiesWithoutSameSiteMustBeSecure, this causes the cookie to be rejected. (crbug.com/1002052) This change fixes that test to use a Secure cookie, so that it will still work when CookiesWithoutSameSiteMustBeSecure is enabled. Bug: 1006816 Change-Id: I9eb3942d0af09740c42a41c5e4c8f3ce0fef7959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827748Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#700674}
-
Mohamed Amir Yosef authored
Those varialbes are used from the old parser which isn't used anymore. Change-Id: I00c936090d432572d8bdee70c5312444a37fd3c0 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828958 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: Ib09a8ab819e2160c20c4424173d1e92fb1efc18f Bug: 875768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823843 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
-
Sergey Poromov authored
http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html is failing: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/19952 TBR=szager@chromium.org Bug: 1008826 Change-Id: I81121e049b08a21d70d4126d5b5839302c79998b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827375Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700671}
-
Kuo Jen Wei authored
Consider shelf on left/right or top/bottom side, either width or height of window outer bound equal screen size should be fullscreen. Bug: 1008347 Test: Cases of shelf on left/right or bottom, window resizing related function works as expected. Change-Id: Id381bac95c9287e3febfdebb6ac74333283f7071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828784 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#700670}
-
Robbie Gibson authored
The root cause here was that the image wasn't a template image, so it wasn't being tinted. Bug: 1008381 Change-Id: Ie6f53e08cf3375a5c47f9bac453bf3a8239c11f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827408Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#700669}
-
Mohamed Amir Yosef authored
Change-Id: I5f731f453c85d8575d488316a0ff7137a5c34422 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814832 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Amr Aboelkher authored
A device policy which controls the mono audio accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_mono_audio_enabled policy to True, open System Tray => "Accessibility", check that "Mono audio" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Mono audio" is not displayed in the login screen. Bug: 552439 Change-Id: I3ac0d02fc6dfe31874981fd5b8867ed4b19fb912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815124 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700667}
-
Maksim Moskvitin authored
Both client tag and its hashed version were represented by std::string. Given it makes some confusion and leads to API misuse, hashed version is now represented by dedicated class. Bug: 973409 Change-Id: I08a0a43fc699435d5f9f850b26c0771a267aaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824090 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d1b15f34c87..711cccd3a162 git log 5d1b15f34c87..711cccd3a162 --date=short --no-merges --format='%ad %ae %s' 2019-09-27 fmayer@google.com Merge "Handle error in GetColumnsForTable." Created with: gclient setdep -r src/third_party/perfetto@711cccd3a162 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2abfab3d1da36b0b0c77ad3f218b9517c97a9635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828618Reviewed-by:
-
Maksim Ivanov authored
Add some more DCHECKs into the ExternalPolicyDataFetcher class (and its nested classes) that verify the code is running on the expected task runner sequence. Bug: 727645 Change-Id: Iac0422ac26fa9f419e7f3dcb8d23d8d1df3d4e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823840Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700664}
-
Marc Treib authored
Problem was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1821520 Change-Id: If3e21e47c2b0111bf6e3422f62a14fd45f6e4ad7 No-Tree-Checks: true No-Try: true Bug: 965503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827376Reviewed-by:
-
Marc Treib authored
These types were deprecated long ago. This includes removing the ModelType enum entries, removing the fields in the EntitySpecifics proto, and deleting the specifics proto files. Bug: 965503 Change-Id: I583188ff09f9d27f5e40753d52a3c70468e89c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824261Reviewed-by:
-
Paul Lewis authored
This is the initial patch to test the ESM-exposed behaviors of the Color class. Future patches will add more tests for Color. Change-Id: I0115a2c3818167aab201b864115df89cd2b47c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826787Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#700661}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f506bde16f1..f8bb908702bd git log 7f506bde16f1..f8bb908702bd --date=short --no-merges --format='%ad %ae %s' 2019-09-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 510ca9d616f5..10951a7c9a13 (3 commits) Created with: gclient setdep -r src/third_party/angle@f8bb908702bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I7604486c6cc2d49a8faa81a28ec570beb8101f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828849Reviewed-by:
-
Marc Treib authored
It was unused. Bug: 985290 Change-Id: Ia1d117452e4acfa61c77899abc6bdc92078a512a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828898 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#700659}
-
Marc Treib authored
This data type has been deprecated for a long time (or maybe was never launched in the first place?). This includes removing the ModelType enum entries, removing the fields in the EntitySpecifics proto, and deleting the specifics proto files. Bug: 965503 Change-Id: I81d4498da11f801e20bb5944c406b4fb72fb0313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821520 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Rika Fujimaki authored
If we are not in context when WorldSafeV8Reference instance is created, we can't call DOMWrapperWorld::Current(). Instead, we set |world_| to a value's creation cotext's world. In that case, now that crbug.com/v8/9713 is fixed, all we have to consider is that whether value is IsObject() or not. Bug: 1007504, 1008425 Change-Id: I68b5269af5ad56892767ac872dc6f2bf65b64118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824762 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#700657}
-
Zinovy Nis authored
This reverts commit 8f3eea10. Reason for revert: code bloating Please see for the details: https://groups.google.com/a/chromium.org/d/msg/cxx/TsBWKMJWMAs/jbAs2c5OAAAJ Original change's description: > [clang-tidy] add noexcept for move ctors and operator= in blink > > Bug: 994915 > Change-Id: I2e1bcf286a2d2fa6613e18b5268098a0d258fb2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759163 > Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688676} TBR=jbroman@chromium.org,foolip@chromium.org,mkwst@chromium.org,zynis@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994915 Change-Id: I12b3ecc1186e27809082dc399c6d6864109ce307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804481 Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#700656}
-
Anastasiia Nikolaienko authored
Account Manager is enabled by default now. Merge ChromeOsMirrorAccountConsistencyTestWithAccountManagerEnabled to ChromeOsMirrorAccountConsistency tests. Bug: 1007927 Change-Id: Ic3362561c8a9cc0696b8420994ba087b44015f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824102 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#700655}
-
Sergey Poromov authored
This test if flaky on Win Asan: https://ci.chromium.org/p/chromium/builders/ci/win-asan?limit=200 https://ci.chromium.org/p/chromium/builders/ci/win-asan/7721 TBR=caseq@chromium.org Bug: 930717 Change-Id: I5c0f61ec6646bf0bb27aa0178aab2ff4f9341f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828900Reviewed-by:
-
Sergey Poromov authored
This test consistently fail on many platforms: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/82255 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/3087 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/42946 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/19950 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/56355 TBR=tkent@chromium.org TBR=masonfreed@chromium.org Bug: 1000926 Change-Id: I9e54e6505e936b0adfe0020d9aa02f78b5a18c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826792Reviewed-by:
-
Marc Treib authored
Pretty sure there's more, but this is a start. Bug: 1007942 Change-Id: I559d6b119d269e8aca9ffed2f988f1cdffd4eab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824087 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Carlos Caballero authored
Do not cache if we might decide to show the app banner as we would lose state (e.g. the mojo binding for the render to send the prompt event). If we cache the page and go back we will not restart the pipeline (no DidFinishLoad will trigger) that should be fine as we will only put in cache if no banner needed to be shown. The page will only be cached for a limited time so we can assume that nothing has happened (e.g. page suddenly got a manifest) that would change the outcome of the pipeline. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: Id127a52f2883b771f4dbf7311c48683695261449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824108Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#700651}
-
Miyoung Shin authored
This change converts PaymentManager mojom interface client in blink to use BrowserInterfaceBroker. RenderProcessHost now has a CreatePaymentManager() method, which is called by handlers for frames and workers. Bug: 936482 Change-Id: I17d0d0f7d4de7b804490ac3bbc890aeefced39d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824722Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#700650}
-
Rohit Rao authored
Switches targets to depend on this new target rather than listing "WebKit.framework" directly in libs. This will allow us to switch from system WebKit to a locally-built WebKit by simply updating ios/third_party/webkit/BUILD.gn. BUG=934252 Change-Id: I65cebb8c299b368e31fac979fad4571aad265ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827421Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#700649}
-
