- 23 Jul, 2018 40 commits
-
-
Stephen Martinis authored
This CL enables logic to only retry failed tests for most isolated script tests. The following test suites are affected: * angle_perftests * chromedriver_py_tests * components_perftests * content_shell_crash_test * devtools_closure_compile * devtools_eslint * heap_profiling.mobile.disabled * heap_profiling.mobile.native * heap_profiling.mobile.pseudo * memory.leak_detection * metrics_python_tests * mini_installer_tests * monochrome_apk_checker * passthrough_command_buffer_perftests * performance_test_suite * site_per_process_webkit_layout_tests * telemetry_gpu_unittests * telemetry_perf_unittests * telemetry_perf_unittests_viz * telemetry_unittests * telemetry_unittests_viz * validating_command_buffer_perftests * views_perftests * webkit_python_tests These should all work with this logic; I've tested these manually myself. NOTRY=true NOPRESUBMIT=true Bug: 533481 Change-Id: If3a5a03410fd7f1f597197d98ae3060bd91ff487 Reviewed-on: https://chromium-review.googlesource.com/1141340 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577315}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c7a5d6a83b6..5bc35fd6c631 git log 2c7a5d6a83b6..5bc35fd6c631 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 yunlian@google.com Re-eanble cfi on eve-arcnext Created with: gclient setdep -r src/third_party/chromite@5bc35fd6c631 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9354b2b8cff903b1ab21f5185564db205a8753b3 Reviewed-on: https://chromium-review.googlesource.com/1147061Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577314}
-
Jonathan Ross authored
So TouchInputBrowserTest.TouchHandlerConsume was failing somewhat consistently. However I cannot reproduce the error locally. Nor on trybot runs. I want to re-enable it on the FYI bot Mojo Android to see if it still reproduces, or has happened to be fixed. TBR=fsamuel@chromium.org TEST=TouchInputBrowserTest.TouchHandlerConsume Bug: 855532 Change-Id: Ib6b6bfe013f69b692b8975d70077fed92401299a Reviewed-on: https://chromium-review.googlesource.com/1147070Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577313}
-
Eric Karl authored
Currently, the transfer cache has a large (128MB) memory limit, but no limit on individual entries. As we have the potential to flood the cache with thousands of small entries, causing an explosion of handle allocations, I've added a 2000 element cap. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1245220bca1ea47546be7d28eaea2e494e3468db Reviewed-on: https://chromium-review.googlesource.com/1147311Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577312}
-
Quan Nguyen authored
cros: Fix a views-login bug where clicking Add User too quickly could cause the Gaia screen not to load. With this fix, clicking Add User very quickly will show a blank dialog that gets filled in once the Gaia screen finishes initializing. Bug: 837501 Change-Id: Ia87e4c20f80a08a739afc79f3978be11729db15d Reviewed-on: https://chromium-review.googlesource.com/1147490Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577311}
-
Clark DuVall authored
This is a reland of 574add02 Added DevToolsFrontendInWebRequestApiTest.HiddenRequests to the filter file, will fix it in a follow up. Original change's description: > Reset URLLoaderFactory bindings for web request proxy > > Previously, if a request was made before any web request listeners or > rules were added, the URLLoaderFactory would not be proxied through the > browser process to run the WebRequest code. Now, if it is detected that > WebRequest listeners/rules are added, we reset the bindings so they will > be recreated and proxied through the browser process. > > Observers were added for a few classes so WebRequestAPI can listen to > rule changes. > > Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. > > Bug: 857577 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I7805be86512545b496e30b9693374981fdc2633e > Reviewed-on: https://chromium-review.googlesource.com/1139048 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577036} TBR=rockot@chromium.org,kinuko@chromium.org Bug: 857577 Change-Id: I83f266cfcd572ccbde36405d7cff501f92122b2d Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1147042Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577310}
-
Mustafa Emre Acer authored
This CL adds an infobar for navigation suggestions for IDN URLs that match top domains. The match between the navigated and the suggested domain is made using the ICU skeletons of top domains list in url_formatter. This UI is disabled by default and can be enabled via the IDNNavigationSuggestions feature flag via chrome://flags. Screenshot: https://drive.google.com/open?id=1QloUKbwYIE7QlPX_NRY3Yljt9ZkwtO-S Change-Id: I317a143d363d2a4830ee511f03ede0966312bb57 Bug: 843361 Reviewed-on: https://chromium-review.googlesource.com/1110945 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577309}
-
Fernando Serboncini authored
If a RAF takes too long, OnBeginFrame may flood the task runner with tasks and not allow postMessages to pass. This makes sure that RAFs are executed in the same task queue as postMessages. We also change BeginFrameProvider logic to only disable setNeedsBeginFrame with one frame delay, to minimize the number of mojo calls. Bug: 863962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec4b21d9e41571a9fc2d9880aa26ce45704d8d0c Reviewed-on: https://chromium-review.googlesource.com/1139188 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#577308}
-
Jochen Eisinger authored
Omit them from the profile info cache, and show a profile picker if the default profile is supervised. BUG=866578 R=bauerb@chromium.org,tschumann@chromium.org,msarda@chromium.org Change-Id: Ice583daee39eb1efc987af6a16de256d5bb1fc65 Reviewed-on: https://chromium-review.googlesource.com/1145271 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577307}
-
Koji Ishii authored
This patch supports the rendering of the '-webkit-box-decoration-break' property. This property is used by 0.73% of pages according to UMA. Also cleanup how NGLineBreaker commmunicates margins/borders/ padding to NGInlineLayoutAlgorithm through NGInlineItemResult. The work for line breaker to take this property into account is deferred to future work. Gecko (unprefixed) supports it, while Blink and WebKit (prefixed) takes only the start edge into account, ignoring the end edge. Edge does not support this property yet. Also CSS WG resolved a change in its behavior recently when used in bidi context. It will need a bit more investigations. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8d87db5cd35441133a73fcead67901763026155d Reviewed-on: https://chromium-review.googlesource.com/1146125Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577306}
-
Tibor Goldschwendt authored
Also, add android_app_bundle_module type to build config. Bug: 862696 Change-Id: Ic893f47d44d8dd98ff7e70d3a8e09cbf2ce5a444 Reviewed-on: https://chromium-review.googlesource.com/1135834 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577305}
-
Peter Kvitek authored
This is an initial portion of the set of tests that are going to be converted to JS. Change-Id: I42eecccf4bf1abef520fce21ae940559e2f0ac39 Reviewed-on: https://chromium-review.googlesource.com/1145823Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577304}
-
Jordy Greenblatt authored
Two new BUILD files, namely chrome/browser/chromeos/device_sync/BUILD.gn and chrome/browser/chromeos/multidevice_setup/BUILD.gn Are already in the parent directory's BUILD and we mistakenly added separately as well: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=584 https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=1277 Change-Id: Ia9499d229eb4d6e09f406d784a791b732efaee34 Reviewed-on: https://chromium-review.googlesource.com/1147431 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577303}
-
Khushal authored
R=ericrk@chromium.org Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I453b7fa115932366f9e6210bc6404d05358adb67 Reviewed-on: https://chromium-review.googlesource.com/1147102Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577302}
-
Ian Vollick authored
While VR and AR may one day be able to share code, this will complicate our lives in the short term. With this change I've added an ArRenderer to handle the modest GL work that's required by AR. Bug: 838013 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibdbcb5729a7f70f0c63ef4c72ffd2804ed351eab Reviewed-on: https://chromium-review.googlesource.com/1147218 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577301}
-
Sebastien Marchand authored
- Ignore the title/favicon changes happening during the first few seconds following the transition to the loaded state for a tab, some sites seems update their favicon immediately after loading (e.g. cs.chromium.org) without this being an attempt to communicate with the user. The grace period is controlled by the "TitleOrFaviconChangeGracePeriod" variation of the "SiteCharacteristicsDatabase" feature. - Ignore the audio usage happening during the first few seconds after backgrounding a page: this is something that can happen if a user start some media (e.g. a video on YouTube) and switch to a different tab before the video has actually started to play. The grace period is controlled by the "AudioUsageGracePeriod" variation of the "SiteCharacteristicsDatabase" feature. Bug: 773382 Change-Id: I4790fa976add5840bdb9cb5d78c402cba8577669 Reviewed-on: https://chromium-review.googlesource.com/1145707 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#577300}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b907757c0db1..2bfa78540c37 git log b907757c0db1..2bfa78540c37 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 art-snake@yandex-team.ru Rework of CPDF_Object writing. 2018-07-23 tsepez@chromium.org Remove second argument to CFXJSE_Engine::ToObject() 2018-07-23 art-snake@yandex-team.ru Add support of rebuilding crossrefs with compressed objects. 2018-07-23 tsepez@chromium.org Remove unused CScript_DataWindow::JSDataWindow(). 2018-07-23 tsepez@chromium.org Replace CFXJSE_HostObject::type_ with polymorphic conversion methods 2018-07-23 tsepez@chromium.org Remove second argument to ToJSContext(). Created with: gclient setdep -r src/third_party/pdfium@2bfa78540c37 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7294527ababd458bf60e88b3f32b6ca222aa7287 Reviewed-on: https://chromium-review.googlesource.com/1147340Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577299}
-
Mathieu Perreault authored
Bug: 853780 Test: ntp_render_browsertests Change-Id: I57d4321f6a72d1171066b1578128117c91521bfd Reviewed-on: https://chromium-review.googlesource.com/1145693 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577298}
-
Robert Ma authored
as another test in the same directory. Blink test runner isn't able to handle such duplicate basenames because it relies on filename mangling extensively. Bug: 866520 Change-Id: I0c9671e83dcf9c61bc20f16a43dcace827145024 Reviewed-on: https://chromium-review.googlesource.com/1146989Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577297}
-
Ehsan Karamad authored
MacOSX scrollWheel event already provides the correct behavior. If the event (physical) source has precise deltas and comes from a trackpad or apple mouse then it has bidirectional deltas already and pressing shift key should not swap the axis. If the source of the event is an ordinary single-axis mouse, then the NSEvent already packs |delta_x| instead of |delta_y| (for shift-scroll). Also, it turns out that rails mode should only be used for trackpad. The logic in MosueWheelRailsFilter uses an auto-regressive filter to smooth out rails latching. This state is reset for a kPhaseScrollBegan. However, apple mice would always have a phase of kPhaseNone. Since it never resets it might lead to a large value in one axis (i.e., in y-axis after a vertical scroll phase) and when scrolling in the other direction occurs, the rails mode is set incorrectly. The side effects of this are zero scroll deltas which also fires a DCHECK in mouse_wheel_event_queue.cc: DCHECK(needs_update). To repro use an apple mouse and scroll vertically and then horizontally using the bidirectional wheel. Bug: 862661 Change-Id: I4e5210454fe7352ab0230b312f44e1a374f22f0c Reviewed-on: https://chromium-review.googlesource.com/1134434Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577296}
-
Dan Elphick authored
String::Utf8Length and StackTrace::GetFrame should now be called with an Isolate, which means gin::V8ToString now needs an Isolate hence the cascade of changes. Change-Id: I03f3bb91a2e985626bfa62dc1b4cd0874d00630d Reviewed-on: https://chromium-review.googlesource.com/1146651Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577295}
-
Justin Novosad authored
This reverts commit 56151bcd. This reland fixes the MSAN error from the original CL by making sure the filter_quality field of CanvasResource is always initialized TBR=zmo@chromium.org Bug: 788439 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7dd29f123cbfd75598005532fc5b2135e6bfebc9 Reviewed-on: https://chromium-review.googlesource.com/1147317 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577294}
-
Avi Drissman authored
The shadow around the omnibox results popup eats mouse events. Manually forward events occurring in the shadow area to the underlying widget to fix the tab strip. BUG=864963, 838667 Change-Id: I5c6499f5d024863dad611f8670fb12e1a01ff073 Reviewed-on: https://chromium-review.googlesource.com/1144225 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577293}
-
Dan Elphick authored
This convert one ToString to use the Isolate form in v8_script_runner.cc rather than ToString(Context), as the no-argument form is the more immediate problem. Change-Id: I0d79f29fd937458cbaf8bb0342b8c4efa8b5ee1c Reviewed-on: https://chromium-review.googlesource.com/1146805Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577292}
-
Tommy Steimel authored
This CL re-adds media type UMA metrics to the MediaLauncherActivity. In order to prevent the native initialization issues from the previous CL, this CL uses CachedMetrics to only record once native is initialized. Bug: 861954 Change-Id: I424dc1c6d8d65a031c573375f3cf1686ec1f6614 Reviewed-on: https://chromium-review.googlesource.com/1138978 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577291}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e8a0b2b37d9..1381813c377d git log 9e8a0b2b37d9..1381813c377d --date=short --no-merges --format='%ad %ae %s' 2018-07-23 nednguyen@google.com Increase default timeout limit of setting tsproxy's traffic settings to 20 seconds 2018-07-23 nednguyen@google.com Add '--story-shard-begin-index' and '--story-shard-end-index' flags 2018-07-23 nednguyen@google.com Fix PRESUBMIT errors in catapult Created with: gclient setdep -r src/third_party/catapult@1381813c377d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865250,chromium:866095,chromium:866260 TBR=sullivan@chromium.org Change-Id: I0f4b0a06fa6b8e5312fbbd6f6385910004841801 Reviewed-on: https://chromium-review.googlesource.com/1147060Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577290}
-
Victor Costan authored
This CL is extracted from https://crrev.com/c/1137851 because that CL may uncover brokenness and get reverted. Landing these changes separately minimizes the impact of a potential revert. Bug: 863724 Change-Id: I9b8888faf7a736f086ca5e496f85a78e0754a0c5 Reviewed-on: https://chromium-review.googlesource.com/1145837Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577289}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/94ef424b3160..a76af0ca2e8c git log 94ef424b3160..a76af0ca2e8c --date=short --no-merges --format='%ad %ae %s' 2018-07-23 titovartem@webrtc.org Move base64.h to the proper location. 2018-07-23 titovartem@webrtc.org Fixing py lint errors 2018-07-23 saza@webrtc.org Revert "Add one-stop-shop for built-in AEC toggling in APM" 2018-07-23 saza@webrtc.org Add one-stop-shop for built-in AEC toggling in APM 2018-07-23 buildbot@webrtc.org Roll chromium_revision 5e7b1029..0aff707f (577041:577150) 2018-07-23 peah@webrtc.org AEC3: Added dumping to wav files for the filter outputs 2018-07-23 oprypin@webrtc.org Fix paths that were trying to go above the root by using too many "../.." 2018-07-23 sakal@webrtc.org Remove dead code from videoframe.cc. 2018-07-23 oprypin@webrtc.org Add `is_android` guard to all Android rule usages. 2018-07-23 mbonadei@webrtc.org Fixing -Wsign-compare errors. Created with: gclient setdep -r src/third_party/webrtc@a76af0ca2e8c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0cb33a4564e1a989eba594282c3599353bb8fbd Reviewed-on: https://chromium-review.googlesource.com/1147063Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577288}
-
Dmitry Gozman authored
Inline StartLoad and ShouldContinueForNavigationPolicy into StartNavigation and CommitNavigation, dropping the parts which are not relevant. Bug: 789577 Change-Id: I5d580bdffed64340fc2396f7a6a274d8242fd96f Reviewed-on: https://chromium-review.googlesource.com/1107211 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577287}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df795638b9bd..1c4668d00232 git log df795638b9bd..1c4668d00232 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 benjaminwagner@google.com Blacklist failing test for ANGLE IntelIris6100. 2018-07-23 csmartdalton@google.com ccpr: Blacklist Bay Trail and Sandybridge on Mesa 2018-07-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-23 jcgregorio@google.com Add continuous deploy for skottie and debugger. 2018-07-23 timliang@google.com implemented copy surface as blit for metal gpu backend 2018-07-23 jvanverth@google.com Restrict radial step count 2018-07-23 ethannicholas@google.com fixed a bug with SPIR-V ternaries 2018-07-23 jvanverth@google.com Reland "Reland "Add some optimizations to PolyUtils"" 2018-07-23 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ba365939b90c..94c91a95358b (1 commits) 2018-07-23 halcanary@google.com SkPDF: only draw text with SkglyphRuns 2018-07-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1c4668d00232 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I4fca2a61cbc4906a8718a5323f6ebcdd2cc303b4 Reviewed-on: https://chromium-review.googlesource.com/1147064Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577286}
-
Aaron Leventhal authored
For get_characterExtents(): - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). - The width/height should not be changed to 1 for offscreen objects. TBR=dmazzoni@chromium.org Bug: 864195 Change-Id: Ib8a57bee7f3b70f46c1c6791ea4c5a294c5ccfe5 Reviewed-on: https://chromium-review.googlesource.com/1146877Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577285}
-
Scott Chen authored
This CL changes imports from iron-icons.html to iron-icon.html (without S), as well as moving element imports to where it's used. Bug: 855205 Change-Id: Ibe22c21ec9270258efafd1e06fed73de1d226f2d Reviewed-on: https://chromium-review.googlesource.com/1145598 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577284}
-
Jenny Zhang authored
TBR=xiyuan@chromium.org Bug: 854238 Change-Id: I0268b4fbe9e6bc813fe2e7e5d4dfea72084f4102 Reviewed-on: https://chromium-review.googlesource.com/1145761 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577283}
-
Philip Rogers authored
This test is now passing with BGPT and does not need a failing expectation: fast/canvas/synchronous-create-pattern.html Bug: 853947 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id5bdba3ce5de2b6bb8d10d3a9d9d23bf1095a5dc Reviewed-on: https://chromium-review.googlesource.com/1146778Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577282}
-
Jun Mukai authored
It seems Gtk+3 apps are calling this request, which is currently ignored silently and causes an issue like crbug.com/866189. Bug: 866189 Test: manually on device (see the bug for the reproducible steps) Change-Id: I89f24da5a5bced1459b65cc1ff94f63debca90d2 Reviewed-on: https://chromium-review.googlesource.com/1147255Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#577281}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e3c67f2c332..5ba1e9caeecb git log 7e3c67f2c332..5ba1e9caeecb --date=short --no-merges --format='%ad %ae %s' 2018-07-23 ehmaldonado@chromium.org git cl: Start reporting metrics. 2018-07-23 jbarboza@ca.ibm.com fix fetch on aix 2018-07-23 jdoerrie@chromium.org [my_activity] Fix Filtering of Gerrit Reviews Created with: gclient setdep -r src/third_party/depot_tools@5ba1e9caeecb The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386,chromium:NONE TBR=agable@chromium.org Change-Id: Ibd4f5b58f3b63120cb31a6e1850f60be8287a871 Reviewed-on: https://chromium-review.googlesource.com/1147065Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577280}
-
Adrienne Walker authored
This is the GpuImageDecodeCache equivalent of this change: https://chromium-review.googlesource.com/c/chromium/src/+/1147102 Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59da18646c0817f011a464b7571a9b6abf7b8455 Reviewed-on: https://chromium-review.googlesource.com/1147243Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577279}
-
Zach Helfinstein authored
This change is in preparation for creating the Switch Access context menu, which will behave similarly to the ChromeVox Panel. This is a pure refactor with no functional changes. Bug: 864796 Change-Id: I53c34722b97acca482514132c84894c89171c2a2 Reviewed-on: https://chromium-review.googlesource.com/1144308 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577278}
-
Weidong Guo authored
1. Request 48px arc icon instead of 64px because the latter is not supported. 2. Override OnMetadataChanged() in SearchResultSuggestionChipView to update suggestion chip icon when metadata is updated. Bug: 865532 Change-Id: I24628a60fa93e4b434e9fcf70f703df0ec62785c Reviewed-on: https://chromium-review.googlesource.com/1144649 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577277}
-
Mounir Lamouri authored
Bug: 862358 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I69053e71606a26a0ee7b517768456edbb75120a0 Reviewed-on: https://chromium-review.googlesource.com/1146905Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577276}
-