GitLab

When Instant Start is enabled, the calculateButtonData() is called
pre-native and early exits without calling the
IdentityDiscController#ensureProfileDataCache(). As a result, the
IdentityDiscController misses the event of the onProfileDataUpdated()
and thus doesn't notify its observer StartSurfaceToolbarMediator to
update the visibility of the identity disc button.

To fix the issue, we cache the call of calculateButtonData() from the
Start surface if it is called pre-native. When a new Profile is set, we
check if a cached request exists, and call the calculateButtonData() if
yes. Thus, it guarantees to update the button data if Profile has
updated, as well as to notify Start Surface to update the visibility of
the button.

Bug: 1137535
Change-Id: I3aca4434ecc74850ee226affd3c3425931cf02a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533522Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828362}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f69ec827f69b..70f0ab5795d6

2020-11-17 sigurds@chromium.org Fix usage of style.setProperty
2020-11-17 andoli@chromium.org Refactor ui/Action.js into ui/ActionRegistration.js and update dependencies accordingly
2020-11-17 andoli@chromium.org Remove treeElement property bound to Node intances

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1134103
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0b3dcfb42cbfb87334740272a54cd4b5a701403c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544031Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828361}

When flex did a 2-pass layout (once to determine the intrinsic size, and
a followup to shrink - and the block-size changed, we'd just perform
a simplified layout pass.

The fieldset layout algorithm "stretches" its content to its block-size
upfront. Due to this using the simplified layout pass resulted in an
incorrect layout, never correctly sizing the anonymous fieldset content.

This patch disables the simplified layout pass for fieldsets.

Bug: 1149714
Change-Id: I454a65363c019240dd4b30531009a13e8b596ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544755Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828360}

This CL unifies the size of avatar icons in the Profiles native menu on
Mac with the Chrome profile menu.

Bug: 857064
Change-Id: Ie0336b272506ba10972921261eda8b055372de1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545162
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828359}

Bug: 989958
Change-Id: I2faf1553f355290838b6467e8a0fa1c6baf97531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544025Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#828358}

Realized there were no tests for this action in that context. Also added
coverage for the fix for the associate bug.

Bug: 1140517
Change-Id: Ia16ff23d3dd4c95d35dcefe9d760305f058e5341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544048Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828357}

Design doc: go/bling-phishguard

PASSWORD_REUSE_DETECTION_ENABLED is only defined for !is_ios.
This CL removes the use of this flag in files that are already
not compiled in iOS.

Bug: 1147962
Change-Id: I3ac6fca7db743442645ebe0bde4dda6a5a3fa554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543584Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828356}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome.

Bug: 1113033
Change-Id: Ia64ed766a212bd6399273909a0e4b95d6d07bce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544925
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828355}

Change-Id: I64be99576fe6557dd9adc7c987c3c113254be6fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544076Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828354}

Bug: 1095223
Change-Id: Idf5089542203d6541661d89a0254b958a4960d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543132
Commit-Queue: Yann Dago <ydago@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Auto-Submit: Yann Dago <ydago@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828353}

Bug: 1148561
Change-Id: I77051c7af4f9ca67d954d31d2ce7a596b2b89a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535670Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Alice Gong <alicego@google.com>
Cr-Commit-Position: refs/heads/master@{#828352}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9abde8c3f3a2..90b4c0f76b33

2020-11-17 apolito@google.com add support for main in git_cache

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com
Change-Id: I0195fa990c3524340cc3bec6cfb2ad451ab25d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544029Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828351}

Pass in a base::GUID in lieu of a std::string GUID.

Bug: 1026195
Change-Id: Ie76c20a61bc8b42aeadbf41721b7d2666bef0f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528632
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828350}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome.

Bug: 1113033
Change-Id: I942c8de231523281ee6840aae14d367972c8702a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544754Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828349}

This fixes an issue that I caused by my previous patch where file
handlers are not enabled by default, which is incorrect. It also
addresses a few issue that loyso@ found in my previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2505685

R=phillis@chromium.org

Bug: 1149981
Change-Id: I70221ff76ef576fb6f09ab89d3db0d90ffe30a60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544843
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828348}

Add UMA metrics to connectivity detector.
Also, add some adb logging to make it easier to understand the
functionality of connectivity detector.
Finally, prevent the retry delay from overlflowing.

Change-Id: I3de32e01c20aeef04648685bb074012618e73831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514065
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828347}

https://dawn.googlesource.com/tint.git/+log/20a8d31849c9..8f26453c7db4

2020-11-17 dsinclair@chromium.org Fixup SPIR-V include of builder
2020-11-17 dsinclair@chromium.org Add missing override
2020-11-17 bclayton@google.com writer/spirv: Inherit TestHelperBase from ast::Builder
2020-11-17 bclayton@google.com ast::Builder: Add more builder methods
2020-11-17 bclayton@google.com ast::Builder: Make the interface more fluent
2020-11-16 dneto@google.com spirv-reader: pretend handles are void
2020-11-16 rharrison@chromium.org Stop setting mac_xcode_version in DEPS
2020-11-16 dsinclair@chromium.org Fixup include
2020-11-16 dneto@google.com spirv-reader: better message for unknown SPIR-V type
2020-11-16 dneto@google.com spirv-reader: add conversions for image Dim and Format
2020-11-16 bclayton@google.com Big cleanup now that AST nodes are raw pointers
2020-11-16 bclayton@google.com Replace use of std::unique_ptr<T> with T* for AST nodes
2020-11-16 bclayton@google.com Replace remaining std::make_unique<T> -> create<T> for ast::Nodes
2020-11-16 bclayton@google.com src/transform: Replace std::make_unique<T> -> create<T>
2020-11-16 bclayton@google.com reader/wgsl: Replace std::make_unique<T> -> create<T>
2020-11-16 dj2@everburning.com [spirv-writer] Fixup generation of temporary variable.
2020-11-16 bclayton@google.com reader/spirv: Replace std::make_unique<T> -> create<T>
2020-11-16 bclayton@google.com ast: Remove no-arg constructor for ast::IfStatement
2020-11-16 dj2@everburning.com [spirv-writer] Generate loads for const constructors.
2020-11-16 dsinclair@chromium.org Add language check
2020-11-16 dj2@everburning.com [ast] Add the result_type into the AST dump
2020-11-16 sarahmashay@google.com [validation] add error number to invalid member accessor error: v-0007
2020-11-16 bclayton@google.com ast: Remove no-arg constructor for ast::CastStatement
2020-11-14 bclayton@google.com ast: Remove no-arg constructor for ast::ElseStatement
2020-11-14 bclayton@google.com ast: Remove no-arg constructor for ast::LoopStatement
2020-11-14 bclayton@google.com ast: Add body parameter to ast::Function constructors
2020-11-14 bclayton@google.com writer/wgsl tests: Replace std::make_unique<T> -> create<T>
2020-11-14 bclayton@google.com writer/spirv tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com writer/msl tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com writer/hlsl tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com validator tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com transform tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com inspector_test: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com type_determiner_test: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com ast/types tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com ast tests: Replace std::make_unique<T> -> create<T>
2020-11-13 bclayton@google.com ast/type: Have all tests derive from new TestHelper
2020-11-13 dsinclair@chromium.org [spirv-writer] Generate load of conditionals.
2020-11-13 bclayton@google.com ast: Have all tests derive from new TestHelper
2020-11-13 bclayton@google.com ast: Have all AST types derive from ast::Node
2020-11-13 dsinclair@chromium.org Place the namer into the context object.
2020-11-12 rharrison@chromium.org [inspector] Add Multisampled Texture data extraction

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1147839
Tbr: kainino@google.com
Change-Id: I35d93bb01a6b8d2bec699493e5465c70534728dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543490Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#828346}

Bug: None
Change-Id: I5ce839a67e9b05bc90641c90b7b24944efd68c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542606
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#828345}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome/browser/ui.

Bug: 1113033
Change-Id: Ie4670d92e06d1c02f251590c9a26bb5a9a65a818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545064
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828344}

The original file logger CL did not include PID/TID in the log
output which I had intended to do but didn't include.  This CL
adds that data to each log statement.

Change-Id: I6767db2c8962283ff1f6890466f02eb17c6621d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544747
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828343}

Implement OnPayloadReceived() by:
(1) Verifying that the received payload is represented in bytes rather
    than a file (the phone will never send a file).
(2) Converting the received bytes into a string and passing it to the
    NearbyMessageReceiver interface.

Tweak sending payloads by generating a random payload ID for each
message sent rather than starting a count from 0 for each connection.

Bug: 1149576, 1106937
Change-Id: I2310c17df2cd854648c141cda0066f83089a54d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543682
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#828342}

Specifically, blocking only happens while in CCT and only if a
parameter is supplied along with the intent. The ability to do this
will be restricted to certain apps.

BUG=1149582
TEST=CustomTabActivityTest and NotificationPermissionContextTest

Change-Id: Ieb6d76ff2326406872764973ff31d81d8e088449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538359
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828341}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //content.

R=boliu@chromium.org

Bug: 1113033
Change-Id: Iab77bab240ce5482ad7ae97ae5c37555f15f0241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543250Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#828340}

We use the same CSS style for both now and don't need an independent CSS for the demo dialog.

Bug: b:172388847
Change-Id: Id1f0510c30a09806d0d8487b5e7287bf435c0ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533393Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Jackson Tadie <jacksontadie@google.com>
Cr-Commit-Position: refs/heads/master@{#828339}

We don't use the Service Manager anymore and the relevant bits here
(e.g. download manager) no longer have anything to do with the Service
Manager. To avoid confusion as Service Manager code is removed, symbol
names and documentation have been renamed here.

A few symbols have not been renamed despite having potentially
misleading names now, because they correspond to feature flag strings
which may need to retain their existing values.

Bug: 977637
Change-Id: I017c02f026e52f68e844012883b0d3856c518524
Tbr: carlosk@chromium.org
Tbr: cduvall@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541662Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#828338}

This reverts commit 269f7161.

Reason for revert: Tests are failing on MSAN
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26262

Original change's description:
> cc: Set up a Flag for Displaying Performance Metrics
>
> Set up a feature flag and corresponding state inside cc to enable
> using HUD for displaying performance metrics. Currently when we enable
> the show performance metrics flag we only add WebVitals metrics, which
> comes from Blink. We might want to add other metrics in the future.
>
> R=​sadrul
>
> Bug: 1149385
> Change-Id: I437e113a5fc4f44c6fbaa542c92d1f2da6cbb393
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540570
> Commit-Queue: weiliangc <weiliangc@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#828221}

TBR=sadrul@chromium.org,bokan@chromium.org,weiliangc@chromium.org

Change-Id: Ie5b290290078f669f487f8792020fe4e822798fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1149385
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545250Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828337}

This cl moves the logic for Signin Promo from SignInPreference to
SyncPromoPreference. Briefly the main changes in this cl are:

1. SignInPreference no longer has reference to SigninPromoController.
2. Introduce a new state in SignInPreference to hide it when promos are
   shown by SyncPromoPreference.
3. setChangedCallBack() in SignInPreference has been moved to
   SyncPromoPreference. This callback is used by the MainSettings page
   to hide "Account" category section when signin promo is shown.

Bug: 1110889
Change-Id: I5c0805c30f5bde04cde79d9135aef4fdaf382df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505144Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828336}

Pass in a base::GUID in lieu of a std::string GUID.

Bug: 1026195
Change-Id: Ia7b6395c044e527c8a064cea973bc8bd0b4452e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527853
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828335}

This change re-enables testImmediateAddition and
testImmediateAdditionAfterReload with LegacyTestParams so that the old
code continues being covered.

Bug: 1116744
Change-Id: If46d9dc9fe0e7bef22c987b8da1c2e8c9d711fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542942Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828334}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //chrome.

Bug: 1113033
Change-Id: I169f0d89b0b94559cef80c9fde4d17d49f568433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545024
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828333}

Use local variables to store the title for action injected to the
action menu controller and use "using" clause to reduce length of
the lines in order to improve formatting of the file.

Bug: none
Change-Id: Ia9a46cc8f666757097dd1adf49e8054d3bb74578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544724
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828332}

Bug: 1150014
Change-Id: I39a8506b15e8c966da1c8746724663cd7baf1fd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544922Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828331}

Use testdriver Action API to simulate mouse actions in
html/user-activation/no-activation-thru-escape-key.html.

Bug: 1145677
Change-Id: Id37bbe39be94b096939fe81d0c8053306accecb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537132Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828330}

Run ambient mode UI on each connected display.
RootWindowController construction handles adding ambient widgets
to new displays while ambient mode is running, and destructing them
on display removed.

BUG=b:139953389

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: Ic57c33491098b66c7c0e90ef1f3d12c71f1fc303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516968
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828329}

This change introduces a DiagnosticsUI::BindInterface specialization
for SystemRoutineController

Bug: 1128204
Change-Id: I29edfe0df33a53dcae131e1941c45576f217d5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541572
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828328}

The thread cache was enabled only the DCHECK() builds, because it might
regress memory usage. Enable it unconditionally.

Note to sheriffs: If there is a PartitionAlloc memory regression in
range, this is the likely culprit.

Bug: 998048
Change-Id: Ie7b267cd26dbefee15962d36deb59644562701bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544550Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828327}

Bug: 1141099
Change-Id: Ia236c2e838a38fddb7764fe62195e6d59ee1aeb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540609Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Erik Språng <sprang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828326}

This CL is making consistent the encoding of the unicode literals in
RenderText unitests.

The use of \uXXXX is preferred.

R=msw@chromium.org

Bug: 1085014
Change-Id: Idda342dd8e88b6b748a0b0ac4cb7c6bbbe11d62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543376Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828325}

If CheckedPtr is used in logging.h, we hit an error "logging.h should not include check.h"

Change-Id: I5192d713b67fc14634a879312d86667c22a3976a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543525
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828324}

Generate DIR_METADATA files and remove metatada from OWNERS files for
//components/download

Bug: 1113033
Change-Id: Iafaaa6b893eeef1bf2add1033bf2b12fd39a56e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542947Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#828323}