- 20 Dec, 2019 40 commits
-
-
Eric Karl authored
We had a number of different test SharedImageBackings. Centralize these in one file. Bug: 1003686 Change-Id: I09897394248a4aa560dffb84ce96f459db8d6821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974605 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726980}
-
Andreas Haas authored
This reverts commit dd88bcce. Reason for revert: There was a bug in the CL, that I can only fix after my vacation. Original change's description: > [webgl] Introduce ExtraceDataLengthIfValid helper function > > As discussed in https://crrev.com/c/1970172, this CL introduces a helper > function to check the size of an ArrayBuffer and creates an error if it > exceeds the maximum supported size. > > R=kbr@chromium.org > > Bug: chromium:1008840 > Change-Id: If8eaa8686f9f787484e094e78deaf741cdc436d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972145 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726341} TBR=kbr@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1008840 Change-Id: Ic1a96bd8266a898f9f840cb26c55cfacd368af97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978691Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Andreas Haas <ahaas@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726979}
-
Lijin Shen authored
Some followup mentioned in https://crrev.com/c/1829245. Bug: 1033715 Change-Id: Ic4f1641f9c6f8db0e051788249eee701ea86e791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966246Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#726978}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e10a22d68021..16caad77d2b7 Created with: gclient setdep -r src-internal@16caad77d2b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1028270,chromium:1033098 Tbr: jbudorick@google.com Change-Id: I257efee9a5cd5340a8b1492eb38bcc2796d6c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979329Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726977}
-
Yulun Wu authored
g_browser_process->GetApplicationLocale() should be used over l10n_util::GetApplicationLocale(std::string()). Bug: 1036000 Change-Id: I5ff962526868ddbcbd3f2ac8b095ac99247c396e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978009 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#726976}
-
Victor Hsieh authored
Test: None Bug: chromium:893332 Change-Id: I54730c17b01c5f0af64ee22a6aa60827a1a5674f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979367 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#726975}
-
Callum May authored
The analysis and stack trace are in the filed bug. Bug: 1035593 Change-Id: Ia9d81f872cb27d19ce34a3c1c5e381fc05311dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974618Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Callum May <camay@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726974}
-
Olivier Li authored
Bug: 546640 Change-Id: I9149fdcfba9140a3c6665e058b8439db3d6fa2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978039 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726973}
-
Wenyu Fu authored
Craete feature flags for homepage UI conversion. Bug: 1036470 Change-Id: I1ff3b9d99d2718b3220fa602188060bb11612e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979326 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Donn Denman authored
Restricts the TestTapALot test to < Android Pie and later. BUG=1036414 Change-Id: Ida7f3cf38c6147a32b3a04ee6d57527a503a5a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978837 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#726971}
-
Avery Musbach authored
The functionality of GetSplitviewBoundsMaintainingAspectRatio is only intended for tablet mode, but before the present CL, it also operates in clamshell mode. Like almost all code that is specific to tablet mode, it assumes that there is only one root window (see the header comment on SplitViewController::Get). This assumption causes blatantly broken behavior in clamshell mode. Fixed: 1035186 Change-Id: Ic7f97aaa1a13973e7c3b7bfbee22b41f14597acb Bug: 1035186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978840 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#726970}
-
Khushal authored
The corresponding to patch to apply the workaround in skia is: https://skia-review.googlesource.com/c/skia/+/261211 R=ericrk@chromium.org Bug: 1027981 Change-Id: I1b1cbdd39ebacaf8fe4e1cf61438bbec5306ad39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977697 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#726969}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c15afe488bfa..28b0c5d4b3bb git log c15afe488bfa..28b0c5d4b3bb --date=short --first-parent --format='%ad %ae %s' 2019-12-20 michaelludwig@google.com Pass Arenas* to GrOpsTask and GrOps instead of multiple pointers to each pool type 2019-12-20 csmartdalton@google.com Shorten argument lists in GrMesh::SendToGpuImpl 2019-12-20 reed@google.com move clip-stencil function into GpuDevice Created with: gclient setdep -r src/third_party/skia@28b0c5d4b3bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ia8ef4a6a9bb4f3e6e29e6313843958ad5e67e760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726968}
-
Tim Song authored
The DictationButtonTray is updating its visibility in the constructor, which causes a crash now that we have more complicated visibility logic. Instead move the visibility update to the Initialize() function. TEST=manually verified on device BUG=1036052 Change-Id: I887a47ac2a655994b99d438df1b644d8fe75fd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976857Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726967}
-
Austin Eng authored
TBR=bsheedy@chromium.org Bug: dawn:311, chromium:1035957, chromium:1035590 Change-Id: I873c927beab701ced22ada0babf19b1e60aead28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977736Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#726966}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e730e5b1a28a..1e430429c148 git log e730e5b1a28a..1e430429c148 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 jalyn@microsoft.com Prevent unhandled exception in ObjectPropertyTreeElement Created with: gclient setdep -r src/third_party/devtools-frontend/src@1e430429c148 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1017953 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3f0a5b6e875e751994fe970e6275f63d9d2db7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979237Reviewed-by:
-
Victor Fei authored
Before this change, for ordered set item that exposes hierarchical level and when it has attribute |aria-setsize="-1"|, we intended on setting the set size to UNKNOWN(-1), but we end up setting the set size to be the max of number of elements in the set, largest assigned set size, and set container's size, which we term 'max_set_size_value' here. This change fixes the above issue and returns UNKNOWN size -1 rather than 'max_set_size_value' when |aria-setsize="-1"| according to WAI-ARIA spec on |aria-setsize|: https://www.w3.org/TR/wai-aria-1.1/#aria-setsize Note: WAI-ARIA spec does not explicitly specify that UNKNOWN set size to be returned when |aria-setsize="-1"| only for items that expose hierarchical level, such as tree item and list item. The spec seems to indicate |aria-setsize="-1"| would return UNKNOWN set size for all items rather than 'max_set_size_value'. The current practice which supports |aria-setsize| to override 'max_set_size_value' only for items that expose hierarchical level seems to make practical sense rather adhering to the spec, such as for scenario of flattened tree item structure (CL:1461539). This change includes: 1. Fix in AXTree::ComputeSetSizePosInSetAndCache to properly assign |AXTree::ordered_set_info_map_[item].set_size| when item exposes hierarchical level, such as tree item and list item. (Parent CL:1928639 exposes hierarchical level for list item). This enables |aria-setsize="-1"| UNKNOWN set size to properly propagate to accessibility APIs. 2. AXNode::GetSetSize() to return base::nullopt if calculated set size from #1 is UNKNOWN (i.e. set size is -1) 3. Fix for AxPlatformNodeWin::GetPropertyValue(UIA_SizeOfSetPropertyId) to return default value of 0 for unknown setsize. UIA spec, UIA_SizeOfSetPropertyId: https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids ------------------------------------------- Motivation behind this change: Consider the following case, which is used by Microsoft Word Online, which represents a flat list with list items: 1. item1 2. item2 3. item3 -------------- <div role="list"> <div role="listitem" aria-setsize="-1" aria-posinset="1">item1</div> </div> <div role="list"> <div role="listitem" aria-setsize="-1" aria-posinset="2">item2</div> </div> <div role="list"> <div role="listitem" aria-setsize="-1" aria-posinset="3">item3</div> </div> -------------- The previous behavior Windows Narrator would see the following: "item1, index 1 of setsize=1; item2, index 2 of setsize=2; item3, index 3 of setsize=3;" The new behavior Windows Narrator would see the following: "item1, index 1; item2, index 2; item3, index 3;" Bug: 1033618 Change-Id: Ie572c63f15b141f4744f93aa198d425462301f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963108 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#726964}
-
David Black authored
This is a reland of f5232c5d Original change's description: > Create base class for AssistantUiElement views. > > This is part of a multi-CL effort to clean up the AssistantUiElement > modeling/rendering pipeline. Once complete, UiElementContainerView will > only know about AssistantUiElementViews, not inheriting subclasses. > > More details in the bug. > > Bug: b:145003512 > Change-Id: I6b9b96af2f7f7e73a19785d58104049f287616df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953700 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726629} Bug: b:145003512 Change-Id: Iddef7a132aa8081b08db2e6d0bc46ea8072c818d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979013Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#726963}
-
Kurt Horimoto authored
This agent observes the OverlayPresenters at the kInfobarBanner and kInfobarModal modalities in order to update InfobarBadgeTabHelper state for infobar overlay UI interaction. DidShowOverlay() and DidHideOverlay() are used to update the badge item's presentation state. This BrowserAgent performs some ofthe functionality previously implemented via the InfobarBadgeUIDelegate protocol, which can be deleted once kInfobarOverlayUI is enabled by default. This CL also updates FakeOverlayPresentationContext to execute the presentation callback in ShowOverlayUI(). Bug: 1030357 Change-Id: I153d1a7e7b220587a2582faf29d0942dad6ead2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973104 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726962}
-
Eric Karl authored
A previous patch disallowed creating legacy mailboxes in threadsafe mode, but forgot to update unit test which tried to check this behavior. As tests are now fixed, re-enabling on P-bot (P+ is required for these tests) so we get coverage. Bug: 1034007 Change-Id: I33f36800b9edcecc7df57c20529d874d8a2cbe7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978753Reviewed-by:
-
Clark DuVall authored
This is a reland of 48f0e415 Original change's description: > [WebLayer] Allow passing command line arguments in instrumentation tests > > Switches all test to ContentJUnit4ClassRunner since it already has the > @CommandLine.Flags parsing bits set up. > > This also removes a sleep that was added because we couldn't pass > command line args before. > > Change-Id: Ic7e63c31e24d540af0bbf1dda58e800319a1d844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975075 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726595} Change-Id: I135248418547a1185726f26217e2bbf13320aa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979104Reviewed-by:
-
Nikita Podguzov authored
Include chrome.printingMetrics html documentation to the list of available APIs. Bug: 992889 Change-Id: Icc12e3a7710e032a32d8e632cc0a3dc10a884cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976720Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726959}
-
Zhenyao Mo authored
BUG=1032907 TEST=manual R=kbr@chromium.org Change-Id: Ib55c09a71093b10d55fd31daf49f090da81cf6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975089 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I0e00da773ac5934bea8d938c91a40c0befb722da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979150Reviewed-by:
-
Kurt Horimoto authored
This is a convenience factory method to create fake infobars with a specified type and badge support. Bug: none Change-Id: Ibc1c2df41d154b042a1d5e431450dbc2447f99a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977198 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
BUG=1006204 Change-Id: Ibf37042ed2e5f57671bcba707d83645d4713669e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979255Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#726955}
-
Yves Gerey authored
This cl removes the following dependency: //third_party/harfbuzz-gn (1) -> //components/paint_preview (2) Because for legacy reasons, (1) is rolled into WebRTC whereas for good reason (2) isn't. It will unblock chromium->WebRTC roll: https://webrtc-review.googlesource.com/c/src/+/162503/ currently failing with: ERROR at //third_party/harfbuzz-ng/BUILD.gn:9:1: Can't load input file. import("//components/paint_preview/buildflags/buildflags.gni") Bug: webrtc:11223, chromium:1031164 Change-Id: I67c75b3fc4cd8fa3daf93867f13209f785e7adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978741Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
-
Mason Freed authored
With the [1] CL, the FormControlsRefresh flag was enabled by default for web_tests. To keep testing the disabled case, this virtual test suite will run the tests within the fast/forms directory with the flag disabled. Bug: 1035582 Change-Id: Ie635868c77d202c575ae5c0ce126575cae1d38e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976301 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#726953}
-
Andrew Xu authored
This reverts commit 988f969d. Reason for revert: Trigger the failure of around seven test cases in ash_unittests when enabling the hotseat flag. Original change's description: > overview: Grid bounds do not overlap with hotseat bounds. > > Test: added test > Fixed: 1026962 > Change-Id: I89e51a92bd8596e50099b755e48b355060fdd557 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970434 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725584} TBR=sammiequon@chromium.org,newcomer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I1e222e5aa5fa827c9a8a5d4522700a7e9af7737a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979128Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Andrew Grieve authored
And also unifies the timestamp logging approach across dex.py, compile_java.py, compile_resources.py via a build_utils.py helper. Looks like we should cache png->webp. Here's the output from chrome_apk: I 232916 29 Started D 232916 40 Extracting resource .zips D 232916 427 Applying locale transformations D 232916 598 Applying file-based blacklist D 232916 652 Converting png->webp D 232916 15519 Applying drawable transformations D 232916 16776 Starting: aapt2 link D 232916 16795 Created .res.info file D 232916 18066 Finished: aapt2 link D 232916 18072 Running: aapt2 optimize D 232916 18622 Creating R.srcjar D 232916 19088 Performing sanity check D 232916 19263 Copying outputs I 232916 19417 Job's done. Change-Id: I204cf6ad5e867b2ae83eb2a5f19efb00c14bc7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977060 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726951}
-
Stefan Zager authored
An idiom used by a few of the tests is to loop infinitely waiting for IPCs with the expected payload, ignoring IPCs with unexpected payload. This is a problematic structure, not least because test failures always manifest as a timeout. The loop-until-correct structure is meant to cope with the fact that the render process(es) do not synchronize lifecycle updates with the browser, so there may be race conditions associated with IPCs that are generated in the render process during lifecycle updates. A better way to handle this is to synchronize with the render process by forcing a lifecycle update via requestAnimationFrame; then waiting for all IPCs generated during the lifecycle update to be sent and received. EvalJsAfterLifecycleUpdate is a convenience method that blocks until a render process completes a lifecycle update. Once the browser synchronizes with the render process in this way, it can trigger an update in the render process, and then assert that the very next IPCs received by the browser contain the expected values. BUG=869758 Change-Id: I123d9fbe32015a9605c9d084faddd1bf7d3d8f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975455 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#726950}
-
Eric Stevenson authored
After this change, installing a TrichromeChrome or TrichromeWebview variant via. wrapper script (ex. out/bin/trichrome_chrome_bundle) will result in the required trichrome library version being installed first. The additional APKs don't support incremental install (only used for Trichrome library right now which doesn't support incremental). Uninstall is also not yet supported - it's a bit trickier since we likely want to make sure we don't accidentally uninstall a library that's used by another app on the device. Bug: 921288 Change-Id: Iefc6b5f06836395ef43c9c36a200b06beaac9da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972466 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#726949}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/816132a33463..abc8f2777133 git log 816132a33463..abc8f2777133 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 ianelliott@google.com Vulkan: Disallow multisampling with a sample count of 1 2019-12-20 jonahr@google.com Skip all Metal dEQP tests Created with: gclient setdep -r src/third_party/angle@abc8f2777133 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ib80241afb79f03890bef7fac5a8d7163897c2c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979130Reviewed-by:
-
Evan Stade authored
This moves WebLayer-reusable jsdialog code to //components/app_modal/. Despite the confusing name, this component is where cross-platform app modal and javascript dialog code lives, and the new android/ directory lives alongside views/ (where desktop UI code lives). Later, relevant native code such as JavascriptAppModalDialogAndroid will also be added to //components/app_modal/. To sever dependencies on ChromeActivity, WindowAndroid is given a new method getModalDialogManager(). For ChromeWindow, CrWindowAndroid, and SearchActivity's anonymous ActivityWindowAndroid subclass, this simply passes through to the activity's getModalDialog(). In the future, we may want to move ownership of the ModalDialogManager, but for now ownership is unchanged. Two new strings targets are introduced. . Strings unique to javascript dialogs are moved from //chrome/browser/ui/android/strings to //components/app_modal/android. These strings were and still are duplicates of strings in //components/app_modal_strings.grdp, but including the monolithic components_strings_grd leads to lots of UnusedResource warnings. . Generic strings are moved from //chrome/browser/ui/android/strings to //components/browser_ui/strings/android. These also happen to be duplicates of strings in components_strings.grd, but sharing has the same issue mentioned above. . Blank xtb files (which will automatically be replaced as part of the translation flow) were generated with this script: https://pastebin.com/7dxGc7JW TBR=agrieve@chromium.org,yusufo@chromium.org Bug: 1025256 Change-Id: I9630f511005adf16776bbfd21e195faa226ab9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966700 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#726947}
-
Brian Sheedy authored
Sets up "Linux FYI SkiaRenderer Dawn Release (Intel HD 630)" and its manual trybot counterpart. Bug: 1024385 Change-Id: I2fc6ed1a6692ba7ab8275be9accb07773efdb6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974575 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726946}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ab210f92a84f..6e3a387c0159 git log ab210f92a84f..6e3a387c0159 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 capn@google.com Exclude padding bytes from image size limit Created with: gclient setdep -r src/third_party/swiftshader@6e3a387c0159 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:835299 Tbr: swiftshader-team+autoroll@google.com Change-Id: Iec1192fd76f85c7b4bf69a7f2f62c958f5b11086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979131Reviewed-by:
-
Archana Simha authored
Design Doc: http://go/extensionscheckupmetrics Bug: 1034541 Change-Id: Ie29b858206e2570c13a4442ed53db0c7ec18cc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965996 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726944}
-
Chris Harrelson authored
And in particular, don't do it earlier. Previously we independently pixel-snapped (most of) the various inputs to sticky position offset when committing from Blink to cc. This had two remaining problems: (a) failed to pixel-snap StickyPositionConstraint.{top|left|bottom|right|_offset} (b) possibility of aggregated pixel snapping errors due to pixel snapping multiple inputs and then adding them together. The new approach is much less fragile, and guarantees an integer sticky position offset. It is also likely numerically more accurate. Issue 1035232 was caused by (a). Bug: 1035232 Change-Id: I25bef08ad078e06c65dc0e79dcf460fad219fcdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977142Reviewed-by:Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#726943}
-
Denis Kuznetsov authored
Bug: 1030832 Change-Id: Ib6003711ca80cded6a028c453661778278afae37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978684Reviewed-by:
-
Samuel Huang authored
TBR=agrieve@chromium.org Change-Id: I35897c00fc044f9662640d910324fe941764b498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979250Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
-
