- 20 May, 2020 27 commits
-
-
Nico Weber authored
No intended behavior change. Bug: 1005118 Change-Id: I359a8adfd8d6f5ce5972be10697f2eceadc1a99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207581 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770391}
-
Vincent Boisselle authored
We cannot set the content description in the XML layout because ListMenuButton will override the content description after inflate. We are also not using the setContentDescriptionContext() function as the intermediate to set the content description because we already have our own translated string for the content description: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/android/strings/android_chrome_strings.grd;l=2328;drc=21b75b6a0fdbf4b8ed44d3d7823c25c0b668a852?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 10845970 Change-Id: I361a8c7275d5cec11d10f4e3a33c6a4922ffc653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208602 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#770390}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1033983 Change-Id: Id7c39b162c6646282191f67828b1eb2dd94efac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209501Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770389}
-
Erik Chen authored
The lacros loader was being instantiated at the wrong location. It was called relatively early in the sign-in process, before feature flags are picked up. This means that the lacros loader detected that lacros was disabled, and would uninstall it and delete the user-data-dir. Shortly thereafter, the binary is redownloaded and the user-data-dir is remade. This CL moves the initializer to the right location. Bug: 1084701 Change-Id: I3df9d4e652f2aa28ed42dd83604feb2931f75742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209497 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#770388}
-
Danan S authored
Draggability was never part of the requirements, and making this dialog draggable results in a visual glitch where the dialog appears (but isn't actuallly) duplicated when switching from laptop to tablet mode. Bug: 1072049 Change-Id: I1a1eeae93d1c4c537131371e05531a1fa2c553b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209550Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770387}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3985a19c64c3..fc5bf808e9fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmilka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080903,chromium:1083242 Tbr: kmilka@google.com Change-Id: Ib68f4d485527ea4d383f60afe992aec918e7a202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770386}
-
Josh Nohle authored
We assume that the Instance ID client provides us with a constant Instance ID. Because the CryptAuth v2 server uses this as a device identifier, it must remain constant. Here, we add metrics to track this assumption. There is an open bug (b/155642672) that suggests there *might* be an issue with rotating Instance IDs. Bug: 1083556 Change-Id: I8fefc78202f6cd10a8674fe502063394a4baf43d Tested: Manually verified chrome://histograms Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205003 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#770385}
-
Istiaque Ahmed authored
This CL enables ServiceWorkerTest. FetchFromContentScriptShouldNotGoToServiceWorkerOfPage The test expects fetch to "./sw_controlled_check" to be handled by its registered worker. But this test initiates the fetch a bit earlier than expected, specifically in failure/flaky cases. This CL ensures that the page is being controlled by the service worker before initiating the fetch from index.html. It does so by waiting for oncontrollerchange event to occur. Bug: 1014222 Change-Id: Ib235a6a80957b6f8c22ca5e167e1d37a86cc1850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208027 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770384}
-
Sophey Dong authored
Also extend expiry for SendTabToSelf.AndroidShareSheet.ClickResult since that is the only metric we will continue to track. Bug: 1073159 Change-Id: Ib0874fd264bbafcd785e0f7351f08d9184ee9556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207793 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770383}
-
Shengfa Lin authored
Race condition between page frame events and clear state from session since we are only maintaining state for one frame. If page frame stop loading arrived before session clear and document.readyState is loading, then we are effectively stuck. The fix is to keep track of all frame states so we don't have to clear state from session but instead switch frame in navigation tracker. Bug: chromedriver:3432 Change-Id: I055aeaf6a0bc61dafc3125b7bbceccdcb4c353bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198647Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#770382}
-
Sorin Jianu authored
This is a mechanical change to lexically remove references to --ua and UpdateApps and replace them with --wake and Wake. Bug: 1084010 Change-Id: I1c0a8fa33f160f2d769549026725546c75c54854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209619Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770381}
-
Theresa Wellington authored
Add a new histogram that records 'true' if there is a device owner app installed, which indicates that the device is fully managed/corporate-owned. BUG=1084538 Change-Id: Ia171287b566794121bc5008ffb6d5717952d4ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208538 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770380}
-
John Lee authored
Bug: 1000989 Change-Id: I965f1a0ebc3cffca8a66043e90540cc3740e41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209277Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770379}
-
Clark DuVall authored
getNavigationEntryDisplayUri() says it throws an IndexOutOfBoundsException, but it wasn't actually doing it. Change-Id: I77827cfc71e061feec7663ec4e0e1413c999c43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209567Reviewed-by:
-
Kyle Horimoto authored
We still have some polish work to go, but we should be ready for more feedback now that we've addressed all of the obvious bugs. Change-Id: I52997f9acf6426f39eb7227aebad4d371f00bf5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208025 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770377}
-
Reilly Grant authored
According to hang reports this function performs an RPC call which may take some time to complete. Mark calls with a base::ScopedBlockingCall so that the thread pool knows this task may be busy for a while. Bug: 637404 Change-Id: Ibf15e9b6d7ca59453a40c1282622e9a2b0f11460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209387 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#770376}
-
Virender Singh authored
|cr-icon-button| contains icons, represented by |iron-icon| polymer controls. The icons appear in the accessibility tree of the |cr-icon-button|. The tree looks like this |BUTTON name=Download| - |IRON-ICON| - |SVG/IMG name=''| |BUTTON name=Print| - |IRON-ICON| - |SVG/IMG name=''| As child <svg>/<img> are not interactable and lack name property, it makes sense to remove the svg and image children of |iron-icon| from a11y tree. This change explicitly marks the <svg> and <img> children of |iron-icon| inaccessible by adding aria role as none. Bug:1069531 Change-Id: Idcd7912c865ce08e8871d416b30959ab64ae3d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143183 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770375}
-
Erik Jensen authored
Bug: 1084669 Change-Id: I77ca302c8310d2705aec14241c961d8ae2ac9bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209349Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#770374}
-
Findit authored
This reverts commit 8cff2cd0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 770361 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhjZmYyY2QwYzM1ZWZmZDU2OGUwZGI5OTUwODNhODg4M2JjNmI5NWQM Sample Failed Build: https://ci.chromium.org/b/8879828535463664672 Sample Failed Step: compile Original change's description: > vulkan: enable the possibility of using vulkan c++ binding > > The vulkan.hpp is included in the upstream Khronos vulkan headers > package. It is a vulkan c++ binding generated from vulkan registry. > It is implemented with c++ template in a single header file. > > This change updates gpu::VulkanFunctionPointers to make it compatible > with vulkan.hpp, and adds vulkan_cxx.h which setups several necessary > macros before including <vulkan/vulkan.hpp>. So any code wants to use > vulkan c++ binding just needs to include vulkan_cxx.h. > > This change also adds a test for the vulkan c++ binding. > > Change-Id: I74c7003008082686984b559c729bdecac1b08efd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198140 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770361} Change-Id: Ia0653585ec07d6a36fc55515fdede36dce478c45 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209308 Cr-Commit-Position: refs/heads/master@{#770373}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) <content> element. Bug: 937746 Change-Id: I60d0d1df2ff3b35572f0af7c7bbad6213a47a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209247 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#770372}
-
Anders Hartvoll Ruud authored
Not really part of the MatchedPropertiesCache project, but we are obviously missing a clear() call for the matched_properties_types vector. It looks to me like this could potentially cause non- deterministic crashes in case of hash collisions (operator== makes assumptions about the size this vector), although no such crashes are known. Bug: 1057072 Change-Id: Ia741544fe2e69eba505c57e8315e01786674a56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207153 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770371}
-
Mei Liang authored
This CL modifies the TabSuggestionMessageCardViewModel to build a PropertyModel based on the TabSuggestionAction. In addition, this CL updates the relationship between the shown Message and the available Message in MessageCardProviderMediator. Prior to this change, each MessageType is allowed to live in either the shown Message queue or the available Message queue, not both. After this CL, each MessageType can live in both. The available Message for the same MessageType can be queued up, and each MessageType will have one Shown Message. Change-Id: Icb57147823bbcf81679d38c600d894ed6e47317c Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196845 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770370}
-
Kyle Horimoto authored
After discussions with jessejames@, we should not use internal code names as search tags. Bug: b/156109290 Change-Id: I67d2badcf1af5db66812d189d99a72ecb1ab6ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209611 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Anupam Snigdha authored
This patch contains a new virtualKeyboardPolicy that will let web authors control the virtual keyboard behavior through JS. It only contains the changes to idl and in the next patch I'll add a complete end-to-end implementation describing the working of the new attribute in conjunction with the virtual keyboard show/hide APIs that I implemented in the earlier patches. Explainers and Design Doc: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/VirtualKeyboardPolicy/explainer.md https://docs.google.com/document/d/1I0LUNxK_gP5IaNQsbYN6gL6Zpm71XzduCKkublU5o5Q/edit?usp=sharing Bug: 856269 Change-Id: I5311eefa717827a44654c3cdc59f341d6d8a89b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204848Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#770368}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) distributed nodes concept. Bug: 937746 Change-Id: Ia5c38f31cd999dcd96aa116183a1fa99920c152a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209594 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
Multi-process AW already supports cross-process navigations and swaps processes when navigating to WebUI pages due to our existing WebUI security checks. However, we currently don't lock WebUI processes to origin on AW, due to a blanket exception for all URLs. This CL changes WebUI processes to also be locked to origin on AW, which should better protect them (e.g., by enabling site isolation runtime checks based on process locks). This applies to AW multi-process mode only; in single-process everything is in one process, and there's not much we can do, though this CL does add a test that we can at least navigate to a WebUI page successfully when in that mode. Currently, AW supports just one WebUI page, chrome://safe-browsing, which is what's used in the tests. Bug: 1071464 Change-Id: I246662d3d542a64e0e0bdcd593bbb686bde41d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204517 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770366}
-
Piotr Pawliczek authored
A new unit test for port number. BUG=none TEST=none Change-Id: Id8ef89130f543c5dd7a474d9a1d996aa5655d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207576Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#770365}
-
- 19 May, 2020 13 commits
-
-
Charlie Harrison authored
This CL adds a new mode to print_histogram_names.py to print the added and removed histograms relative to a git revision e.g.: ./print_histogram_names.py --diff origin/master ./print_histogram_names.py --diff HEAD~ This is especially useful for CLs which add lots of histogram suffixes, so that it is easy to learn precisely what histograms are generated by the change. Documentation is also updated to encourage using this tool when using histogram suffixes. Bug: None Change-Id: Ibc1a8cde4216ad49f19a795bbfaa31dc61451705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205330 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770364}
-
James Cook authored
Fix some camelCase_ -> snake_case_ TBR=khmel@chromium.org Bug: none Change-Id: Ie646c43072175ba2122b036ffe97f0374920fada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209613Reviewed-by:
-
Jenny Zhang authored
The flag was set to expire in M83, so it stops showing up from M84. However, we have not launched this feature to 100% user yet. We need to keep it until to we fully launch the feature. Bug: 1082623 Change-Id: I55eef3188ce23432f88ab80feb3ad309cfcfa3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200428Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770362}
-
Peng Huang authored
The vulkan.hpp is included in the upstream Khronos vulkan headers package. It is a vulkan c++ binding generated from vulkan registry. It is implemented with c++ template in a single header file. This change updates gpu::VulkanFunctionPointers to make it compatible with vulkan.hpp, and adds vulkan_cxx.h which setups several necessary macros before including <vulkan/vulkan.hpp>. So any code wants to use vulkan c++ binding just needs to include vulkan_cxx.h. This change also adds a test for the vulkan c++ binding. Change-Id: I74c7003008082686984b559c729bdecac1b08efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198140 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#770361}
-
Martin Kreichgauer authored
Authenticator{MakeCredential,GetAssertion}Blocking meant to free the unmanaged pointers returned by Windows by wrapping them in unique_ptrs. But they assigned nullptr, and the actual pointers were never freed. Also make FakeWinWebAuthnApi ensure callers free all returned pointers before it is destructed. Also fix some doc strings. This is a follow-up to comments in https://chromium-review.googlesource.com/c/chromium/src/+/2197475. Fixed: 1081450, 1084698 Change-Id: Ifc4d228a63f679f1f3cd2f2f75b11c49b4af8d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207736 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#770360}
-
David Munro authored
In addition to the settings UI the disk size can also change during installation. If you uninstall then reinstall Crostini while keeping settings open the UI components aren't reloaded, so we don't refresh the disk size shown in the UI. To handle this case we reload disk info after Crostini is reinstalled. Bug: chromium:1083110 Test: Manual, following repro steps in the bug with and without fix Change-Id: Ic8ad74ca594fb79d6c239286793d2ec976b98db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208152Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#770359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cdfc69c7f0f8..78ef4133f8de 2020-05-19 shrekshao@google.com Fix invalid enums for OES_draw_buffers_indexed 2020-05-19 jdarpinian@chromium.org Enable regenerateStructNames workaround on iOS 2020-05-19 amaiorano@google.com Reland "Add support for GL_CHROMIUM_texture_filtering" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1058744 Tbr: geofflang@google.com Change-Id: I4d1ccac2a0be118a821217964fe5c2fc91852482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770358}
-
Moe Ahmadi authored
There is no way around not giving the header row focus when clicked. If the header is unfocusable, clicking it would close the realbox popup. This CL changes the header CSS rules so that it won't appear as focused when clicked. The header continues to appear as focused when the toggle button receives focus. Bug: 1082516 Change-Id: I5ec63f1adeb4a3f82e621924a5de8bfdacf06136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209564 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#770357}
-
Andrew Xu authored
It is a partial fixing for the issue 1072043, where hotseat still shows after launching an app from context menu. In this CL, when the activated window is not a shelf window, reset |is_manually_extended_| of Hotseat- Widget. Create an end-to-end browser test for this scenario. However, this solution does not cover the edge case of launching an app in a new tab instead of a window. Bug:1072043 Change-Id: Ia94947baecc8d71690e82a7ba4def08f9a7bab7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197343 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#770356}
-
Christopher Cameron authored
This will not be a canvas color space option (there will likely be an explicit extended-srgb and extended-linear-srgb space, eventually). TBR=fserb Bug: 1083693 Change-Id: Ib89e3f9ab0bcd0681ddd5fb4e3a26608fb293df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205002Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#770355}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b63b4ac6933..5e6d789ce47c 2020-05-19 egdaniel@google.com Revert "Remove deprecated flush calls." 2020-05-19 egdaniel@google.com Revert "Fix flush change breaks." 2020-05-19 egdaniel@google.com Revert "Implement submit API to GrContext." 2020-05-19 egdaniel@google.com Revert "Another missed flush call fix." 2020-05-19 bungeman@google.com Avoid GDI measuring modes with CBDT fonts. 2020-05-19 bungeman@google.com Note typeface usage in layers. 2020-05-19 johnstiles@google.com Allow --disableDriverCorrectnessWorkarounds to enable MSAA on Intel GPUs 2020-05-19 egdaniel@google.com Another missed flush call fix. 2020-05-19 egdaniel@google.com Implement submit API to GrContext. 2020-05-19 bungeman@google.com Correct TestTypeface::onCharsToGlyphs signature. 2020-05-19 egdaniel@google.com Fix flush change breaks. 2020-05-19 mtklein@google.com remove support for mips64el/loongson3a 2020-05-19 mtklein@google.com port GrDataUtils to use generic transfer functions 2020-05-19 key.draw@gmail.com try adding some code to example.html 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 97bfcc9529c9 to da218e6af725 (1 revision) 2020-05-19 csmartdalton@google.com Reland GrRectanizerPow2 2020-05-19 egdaniel@google.com Remove deprecated flush calls. 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 60d5d65325e6 to 97bfcc9529c9 (1 revision) 2020-05-19 bungeman@google.com Reland "Cache hb_face." 2020-05-19 jvanverth@google.com Add GrD3DPipelineStateDataManager. 2020-05-19 reed@google.com extract original paths at big size to improve precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:527565,chromium:983926 Tbr: lovisolo@google.com Change-Id: I40d32e2b8166871849d2cf32a4033ae8667744c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209488Reviewed-by:
-
Xianzhu Wang authored
Previously this was needed because scrolling stacked elements under a non-stacking-context scroller would otherwise be forced composited and lose LCD-text if the elements didn't have a opaque background. After crrev.com/c/2194791 we can squash such layers into the scrolling contents layer if possible, so composited scrolling can be allowed without sacrificing LCD text in most cases. In rare cases, a child stacked element will be composited and lose LCD-text if it can't be squashed, but this is the same situation as other indirectly composited layers. It's a bigger win to use composited scrolling than blocking it just for LCD text of the rare cases. Bug: 1080056 Change-Id: I182aa2b9030becf684d9292b9246e4b81b90dd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191313Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770353}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Bug: 1084509 Change-Id: If0ba708aeec31682f1852803930935ca24a5fddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209672Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770352}
-
