- 04 Oct, 2018 40 commits
-
-
Caleb Rouleau authored
The N6 devices in the lab are old and failing. Tests are expiring while waiting to find an open bot. With fewer shards we require fewer devices. Bug: 891848 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic14a808f55d405792429feef73a33d9f2603d5e5 Reviewed-on: https://chromium-review.googlesource.com/c/1260218Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#596493}
-
Trent Apted authored
ObserverList iterators take a WeakRef to the ObserverList to detect the list being destroyed mid-iteration. ObserverList iteration doesn't need the thread-safety guarantees from base::WeakPtr, and there's rarely more than one iterator, or a couple on the stack. ObserverList iteration was identified as a performance concern as part of https://crbug.com/859155. A base::LinkedList can cater for detecting a destroy-while-iterating. This avoids the malloc() performed when the WeakRef is first dereferenced each iteration, which currently dominates iteration cost. We also reduce reference indirection, and reduce pipelining damage of atomics. Sample performance, for the given ObserverList size in Release. Values are nanoseconds to notify a single observer. Old -> New. (Old values improve with ObserverList size due to the malloc() cost being amortized over the list size). ObserverList::Unchecked 0: 22.3 -> 1.0 1: 79.6 -> 3.4 2: 61.6 -> 3.2 4: 50.5 -> 3.1 8: 41.0 -> 3.2 16: 33.6 -> 3.2 32: 30.3 -> 3.3 64: 28.8 -> 3.2 128: 28.0 -> 3.2 ObserverList<CheckedObserver> 0: 17.9 -> 0.8 1: 89.3 -> 12.9 2: 73.1 -> 14.8 4: 62.8 -> 16.0 8: 55.4 -> 18.0 16: 51.8 -> 18.3 32: 49.0 -> 18.3 64: 46.6 -> 18.3 128: 45.6 -> 18.2 Bug: 888973 Change-Id: I5edeb754e8c62d64efbbdecf617d5b33b0933688 Reviewed-on: https://chromium-review.googlesource.com/c/1242568 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#596492}
-
Jordy Greenblatt authored
The current HEAD behavior of the Setup Flow password page is to allow the user to repeatedly request forward navigation while the IPC for a password check is in progress. Then these requests for a queue so that the next time the user changes the contexts of the password input field, the next request in the queue is sent causing an accidental password check/setup attempt. This CL adds a field to the password page to allow it to determine whether it is in the middle of waiting for a password check to complete and if so, prevent any forward navigation attempt (including from the 'enter' key) and disable the button so the user knows it is out of commission while waiting for the IPC response. The CL also removes some now unused code surrounding expired auth tokens which made it harder to follow the logic flow for the IPC and callback: In the original design, the user would enter their password before they got to the start setup page and would therefore have to hold onto an auth token throughout the flow. In particular, it was necessary to set a timeout leading to a callback to erase the token once it was expired. In the current design, however, the auth token is used to complete the setup flow as soon as it is successfully obtained so there is no case in which a user would have time to let their token expire. Bug: 890958 Change-Id: Ia82af98ebaeeed0429c2da114d6e667130100c99 Reviewed-on: https://chromium-review.googlesource.com/c/1260215Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#596491}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I5406060f4386c5ee66cbf34c65e6311c68414eed Reviewed-on: https://chromium-review.googlesource.com/c/1260563Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596490}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbfd101d0207..a664d328ecfc Created with: gclient setdep -r src-internal@a664d328ecfc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaeeced9251bbef817bd76d25979f2dadf72f96a7 Reviewed-on: https://chromium-review.googlesource.com/c/1260150Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596489}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e135eaf8c70a..f8aa25fa1e19 git log e135eaf8c70a..f8aa25fa1e19 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 saklein@chromium.org image_test: adding blacklist support 2018-10-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@f8aa25fa1e19 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8c359e327cc94d72d7c771dbfba7845dee257c53 Reviewed-on: https://chromium-review.googlesource.com/c/1260149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596488}
-
Jinsuk Kim authored
This CL addresses the reported bug by undoing the quick fix http://crrev.com/595608 and lazily initializing Java side TextSuggestionHost properly. Native side still needs to be established eagerly to get the IPC to work. Now Java layer is created before suggestion menu is requested to be shown for the first time. Bug: 884214 Change-Id: I1bbe9b2e3a5898d6dd082f8784951215a4a9ab91 Reviewed-on: https://chromium-review.googlesource.com/c/1256383 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596487}
-
Erik Luo authored
A promise rejection produces an error log. Before, catching the exception turned the log level from error > info. Now, it turns from error > verbose. Screenshot: https://imgur.com/a/hKiFzWg Bug: 393913 Change-Id: Icd903cedfc7980789dcbbed93efbd63ea7210958 Reviewed-on: https://chromium-review.googlesource.com/c/1252381Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596486}
-
Yoshifumi Inoue authored
This patch makes |Element#innerText| not to collapse white space around inline- block for improving interop. Note: The spec doesn't explicitly mention about this. Changes of AX test expectations added missing space after <input>. TBR=dmazzoni@chromium.org Bug: 890020 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I74a47fd5ba3a22ff17d9c36838a81b4277ac47cc Reviewed-on: https://chromium-review.googlesource.com/c/1250825Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596485}
-
Fabrice de Gans-Riberi authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I79d0581a524173b8f96a8df8b8e002cd99074817 Reviewed-on: https://chromium-review.googlesource.com/c/1260515Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596484}
-
rbpotter authored
Print Preview's destination dialog is displaying multiple scrollbars again. Bisected the issue to https://crrev.com/c/1252682 which recommends adding min-height: 0 to inner nested flexboxes. Bug: None Change-Id: I0d33a9cc79c1f74d7f0a2e79fb2e894d47bc38f4 Reviewed-on: https://chromium-review.googlesource.com/c/1260221Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596483}
-
rbpotter authored
Split from https://crrev.com/c/1258508. Bug: None Change-Id: I71d0598723ce6abe4bb00c70def3728bf32d7b85 Reviewed-on: https://chromium-review.googlesource.com/c/1260508Reviewed-by:
-
Annie Sullivan authored
This will ensure that the InputToFirstContentfulPaint metric tracks the full latency when these navigations are initiated via user input. This will also make it easier to debug which types of loads from the renderer are NOT counted as being from user input in a follow up CL. Bug: 889220 Change-Id: I2ae48b5ca9d6230c15a4291d03b64945d312f802 Reviewed-on: https://chromium-review.googlesource.com/c/1258242 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596481}
-
Jinsuk Kim authored
Updates all the callsites of |Tab.getInfoBarContainer| to use |InfoBarContainer.get|, and deletes the api + member variable for InfoBarContainer in Tab. ChromeActivityTestRule.getInfoBarContainer is a new convenience method running ion UI Thread for tests. Bug: 877878 Change-Id: Ic785239e10d9f6376f297cb397632fd997311c9d Reviewed-on: https://chromium-review.googlesource.com/c/1227859 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Peter K. Lee authored
EarlGrey tests will fail if GoogleService-Info.plist is not found and Firebase is enabled. Bug: 848117 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I427c57f297c78e32bebd0e5a5e47934309e76cb7 Reviewed-on: https://chromium-review.googlesource.com/c/1259803Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#596479}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I48e317b989129cf391ece111df72f98eb62504d1 Reviewed-on: https://chromium-review.googlesource.com/c/1226950 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#596478}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/684313d6a319..b250ec16d391 git log 684313d6a319..b250ec16d391 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 vadimsh@chromium.org [git_cl] Don't check .gitcookies when running on LUCI. Created with: gclient setdep -r src/third_party/depot_tools@b250ec16d391 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891755 TBR=agable@chromium.org Change-Id: I3b65bc7a9510860ac30641165980a09b756a61b9 Reviewed-on: https://chromium-review.googlesource.com/c/1260145Reviewed-by:
-
Hajime Hoshi authored
We want to avoid TaskObserver since this binds the current message loop's default task runner and a class tightly. This CL makes MemoryCache not be a TaskObserver and actual pruning is deferred by posting a task. This changes the behavior that the pruning task is enqueued to the end of the task runner. This should not affect actual memory usages so much. This CL also replaces the default task runner usages in the tests with the test task runner since we also want to avoid the default task runner in the test as much as possible. Bug: 870606 Change-Id: I6865ffe2a02800b5106b6da8605e7624498d6316 Reviewed-on: https://chromium-review.googlesource.com/c/1258805Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596476}
-
John Budorick authored
All of the 10.14s are on minis. TBR=lindsayw@chromium.org Bug: 850125 Change-Id: I50d006b529081eef229f09532d65678aabd97870 Reviewed-on: https://chromium-review.googlesource.com/c/1260308Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#596475}
-
wutao authored
The transition animation of Logo view from dots to mic should be to kMic state, not kMicFab state. The difference is that there is a big jump of the dots to kMic state, which is consistent to Android implementation. Bug: b/117184159 Test: manual. Change-Id: Id7ba2fedf683d809d096cdeb644214db92b0f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/1258605Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596474}
-
Kenneth Russell authored
Kai has been a strong contributor for a long time. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I221ad58462f1bfc16334b76a5158fdfaa4fceb5f Reviewed-on: https://chromium-review.googlesource.com/c/1260386Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596473}
-
Alexey Baskakov authored
The test is flaky on Linux TSan builder. Example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/26934 TBR=jdonnelly@chromium.org Bug: 891959 Change-Id: Ia29f4d01145588f97a6e34b1e1fa833186238dfb Reviewed-on: https://chromium-review.googlesource.com/c/1260524Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596472}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I23aa26a0e16bf3809c5b12d161f808582d1b1e88 Reviewed-on: https://chromium-review.googlesource.com/c/1250081 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#596471}
-
Anand K. Mistry authored
In DEBUG builds, the PNaCl translation takes a significant amount of time, causing zip browser test TIMEOUT flakes on the bots. Recover the FilesApp browser test feature used to declare ZipTests and for the zip browser tests, tell the zip-archiver extension to preload the NaCl module before it's needed, so its translation starts as early as possible during zip browser tests. BUG=889703 Change-Id: Ic16a4b4e53a4be88bae8ee5d2c2caa8baaa1487b Reviewed-on: https://chromium-review.googlesource.com/c/1257464Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596470}
-
Ehsan Chiniforooshan authored
The test uses results.FindAllPageSpecificValuesNamed to verify existence of metrics which does not work for TBMv2 metrics. Bug: 891836 Change-Id: Ib1ee4e8081268ad5be846040058db44d013feab3 Reviewed-on: https://chromium-review.googlesource.com/c/1259942 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
-
Daniel Murphy authored
This change adds all of the OnionSoup mojo pointers to StorageNamespace, and creates a new global called StorageController. This inherits most of the functionality of the StorageNamespaceController but adds the necessary mojo pointers. The inspector agents are moved to live in the StorageNamespaces. This facilitates how they will be used after the event dispatching model is changed for onion-souping. Bug: 781870 Change-Id: I0bf0b7fffcf9c6b6870b636954f130b655642a0c Reviewed-on: https://chromium-review.googlesource.com/c/1232195 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#596468}
-
Ned Nguyen authored
Bug: 828472, 828468 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8028741debe7cada46bd94442076716fe4765e5a Reviewed-on: https://chromium-review.googlesource.com/c/1260306Reviewed-by:
-
rbpotter authored
Currently the pdf viewer forwards the keyCode property from key events. However, this property is deprecated, see: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode Add the non-deprecated code property to the list of properties to serialize. Note: this caused a problem with key handling in Print Preview, when Print Preview was updated from using keyCode to code to identify the escape key. Bug: 890724 Change-Id: I259dd36e344f8a5095487b71df8e96d85e3af47b Reviewed-on: https://chromium-review.googlesource.com/c/1256111Reviewed-by:
-
Christopher Cameron authored
Require that the parent of a NativeWidgetMac always be either - an NSView in the NSWindow of another NativeWidgetMac - a nil NSView Remove WidgetOwnerNSWindowAdapter (which enabled this functionality) and BridgedNativeWidgetOwner (the interface it implements). Update tests that happen to use this functionality so that they don't use native view parents. Bug: 859152 Change-Id: I69ea160852be5a44c7e2952445bd1115de72bd8e Reviewed-on: https://chromium-review.googlesource.com/c/1258292 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#596465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75bbf56da825..e135eaf8c70a git log 75bbf56da825..e135eaf8c70a --date=short --no-merges --format='%ad %ae %s' 2018-10-03 selcott@google.com Add eve-arcvm overlay to build config. Created with: gclient setdep -r src/third_party/chromite@e135eaf8c70a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib469af7b755961c4ddf500e183003db507fa9197 Reviewed-on: https://chromium-review.googlesource.com/c/1260214Reviewed-by:
-
Maggie Chen authored
When there is a new swapchain size request, don't recreate a new swapchain immediately. Instead, use the previous swapchain size until the the new size has been requested for 30 frames. Then create a new swapchain with the new size. We can achieve the same onscreen video size by adding this size delta to the transform matrix calculation. Bug:885182 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I846b8bcb0753a9bd9ccce8329354dc55decc1481 Reviewed-on: https://chromium-review.googlesource.com/c/1235316Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596463}
-
Eugene But authored
Add |using chrome_test_util::OmniboxText| to avoid unnecessary linebreaks. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I76ea7cd146bcec18e843ac13e510dbe06a983eea Reviewed-on: https://chromium-review.googlesource.com/c/1260018Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#596462}
-
sczs authored
Since the legacy recent_tabs and history code has been deleted these views are no longer being used. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I27af5f605f9088356b2e59566362be53710d45be Reviewed-on: https://chromium-review.googlesource.com/c/1259425Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/61d8d025d568..80482dc264c5 git log 61d8d025d568..80482dc264c5 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 tsepez@chromium.org Remove unused method CPDF_ActionFields::GetFieldsCount() 2018-10-03 tsepez@chromium.org Remove unused method CPDF_Bookmark::GetColorRef. Created with: gclient setdep -r src/third_party/pdfium@80482dc264c5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If0089a419792fd289f5e9619593c848ae65675dd Reviewed-on: https://chromium-review.googlesource.com/c/1260220Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d422c290779..1395134c3438 git log 4d422c290779..1395134c3438 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Remove more uses of gl::ErrorOrResult. Created with: gclient setdep -r src/third_party/angle@1395134c3438 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0a87ed0d87196bad828168d25be11f2780eb07c8 Reviewed-on: https://chromium-review.googlesource.com/c/1260143Reviewed-by:
-
Amos Lim authored
Replace NullString with EmptyString of interfaces includes CanvasFillStrokeStyles as per the spec of CanvasRenderingContext2D[1], OffscreenCanvasRenderingContext2D[2], and PaintRenderingContext2D[3]. [1] https://html.spec.whatwg.org/multipage/canvas.html#canvasrenderingcontext2d [2] https://html.spec.whatwg.org/multipage/canvas.html#the-offscreen-2d-rendering-context [3] https://drafts.css-houdini.org/css-paint-api/#paintrenderingcontext2d Bug: 497307 Change-Id: Iacfa82976b9c32266f427f4b8d0aa2408473aaf2 Reviewed-on: https://chromium-review.googlesource.com/c/1255083Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#596458}
-
Min Qin authored
Currently we use something like "No permission" for notification text. On download shelf, it is "Failed - No Permission", which is better as user will know download actually failed. BUG=888786 Change-Id: I0e7809d1a06db454cfe43c5df05da58595a02b31 Reviewed-on: https://chromium-review.googlesource.com/c/1259223Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596457}
-
Becca Hughes authored
Switch the content MediaSession code to using the audio focus service on non-Android platforms. BUG=875004 Change-Id: I8171a7351a7d64065564fe5f75937e1abaef8e7c Reviewed-on: https://chromium-review.googlesource.com/c/1207657Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596456}
-
Jered Gray authored
Top-level whitelisting for a URL with a PreviewsType of RESOURCE_LOADING_HINTS doesn't make much sense as the optimizations come from the page hints and the page hints themselves can provide more accurate whitelisting data. Because of this, the existence of top-level whitelisting with a PreviewType of RESOURCE_LOADING_HINTS indicates a bug with the component's hints. We're now DCHECKing if the component's hints include top-level RESOURCE_LOADING_HINTS whitelisting. IsWhitelisted() itself has been split into IsWhitelistedAtTopLevel() and IsWhitelistedInPageHints(). IsWhitelistedAtTopLevel() is skipped if the type is PreviewsType::RESOURCE_LOADING_HINTS. Additionally, some const-related cleanup was done with function calls in PreviewHints and HintCache. Lastly, ResourceLoadingHintsBrowserTest has been modified to test the full hint flow where it sets and uses page hints. Doing this exposed an issue with ResourceLoadingHintsHttpsWhitelistedRedirectToHttps, which was incorrectly passing as a result of some faked data (redirects don't currently work with hints). The test has been disabled until hints are made to work with redirects. Change-Id: I165ccb9ffeba742840a9def15e283a0e254dbb86 Reviewed-on: https://chromium-review.googlesource.com/c/1256007 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#596455}
-
Trent Apted authored
There once was a ScriptExecutionObserver::Delegate, but it disappeared in some past refactoring. The lifetime around ScriptExecutionObserver is quite complex, and relies on base::ObserverList being a SupportsWeakPtr, which we want to stop doing for https://crbug.com/888973. There is now exactly one ScriptExecutionObserver implementation (ActivityLog), and the observer list only ever has exactly 1 or zero observers in it; added and removed in concert with a TabHelper. WebViewGuest also has an ObserverList<ScriptExecutionObserver>, but it never added any observers to it. We can instead make ActivityLog responsible for the lifetime of its callbacks from ScriptExecutor. It already dispenses WeakPtrs to itself. Bug: 888973 Change-Id: Ic773bbcbabea70627b48ef8e0e29ff4e16d1e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/1256398 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596454}
-
