- 03 Oct, 2018 40 commits
-
-
Nico Weber authored
Removes 69 exit time destructors. Since it's test-only this isn't very important, but since it also simplifies the code and needs fewer string conversions at runtime, might as well do it. Bug: 101600 Change-Id: I7474cbcf77fdbb35f350dbfdfee1ed597cadbe50 Reviewed-on: https://chromium-review.googlesource.com/1258301 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596253}
-
Ned Nguyen authored
Bug: 891705 Change-Id: Ied9506803dd2dd09a0bcfbff73274cc96d014715 Reviewed-on: https://chromium-review.googlesource.com/c/1258965Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596252}
-
Sorin Jianu authored
This reverts commit 23d3d537. Reason for revert: It breaks tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests such as failures: PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/1 PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/0 10.12 is affected too: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15611 Original change's description: > mac: Re-enable PageInfoBubbleViewsMacTest. > > Bug: 845389 > Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4 > Reviewed-on: https://chromium-review.googlesource.com/c/1258293 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596204} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: Ied439ffdb5cce7d708c250251d74a8d2c9b98631 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845389 Reviewed-on: https://chromium-review.googlesource.com/c/1259143Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596251}
-
John Delaney authored
The current name "AddCompleteResourcesExpectation" is deceiving. This does not check that exactly a certain number of resources completed, but that at some point, that number of resources had been completed. E.g. an expectation for 3 resources will wait correctly, even if 10 resources actually completed. Rename using minimum to match rest of expectation conventions in file. Change-Id: Ie9edaccf106d8f7c131c1caaa257ebeab32a0459 Reviewed-on: https://chromium-review.googlesource.com/c/1258297Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596250}
-
edchin authored
Bug: 751553 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa724ae915ccb81347a7f82c41de47f64697eeee Reviewed-on: https://chromium-review.googlesource.com/c/1257791Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596249}
-
edchin authored
When using the WKWebView snapshot API, the specified frame should be in the coordinate space of the web view rather than the BVC. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idc5f28745085e36891d77a4005e10f4d3bfd66c5 Reviewed-on: https://chromium-review.googlesource.com/c/1257828Reviewed-by:
-
Guido Urdaneta authored
This CL also covers the MediaStream constructor. In addition, tests are moved to WPT. Bug: 770908 Change-Id: I6db9a86e9ee839efc2b04b00ae8fc57f07d852c3 Reviewed-on: https://chromium-review.googlesource.com/c/1256796 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#596247}
-
Koji Ishii authored
LayoutNG used to apply Subtree paint invalidation for new NGPaintFragment, because fragments are always replaced with new ones. With recent changes to reuse NGPaintFragment, we can start exploring to do less paint invalidations. This patch changes Subtree to FullPaintInvalidation on all objects. There might be cases where we can do even less, but this change: * paint/invalidation test results match better to legacy. * Fixes 4 paint/invalidation/css-grid-layout by not invalidating inline formatting context container. The impact on blink_perf/paint is unclear. It looks like large-table-background-change-with-* and some other tests are flaky, and this change does not seem to have much impacts on blink_perf/paint. Still the paint/invalidation tests indicate we invalidate less with this change. Ran the pinpoint 3 times on the same code. On the first try: https://pinpoint-dot-chromeperf.appspot.com/job/12d257d8e40000 one test regressed by 11.5% while not much changes in others. On the second try: https://pinpoint-dot-chromeperf.appspot.com/job/11f8d4c2e40000 the regressed test above improved by 8.9%, another by 9.2% and 2.5%. On the third try: https://pinpoint-dot-chromeperf.appspot.com/job/1723022ce40000 the two tests above improved by 18%, though fixed-and-many-layers-scroll regresed by 5.6%. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5b0db240c3d9f84ffb7f02d0f7bd7d0aa9b82296 Reviewed-on: https://chromium-review.googlesource.com/c/1250821Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#596246}
-
Florent Castelli authored
Update the test outputs accordingly too. Change-Id: I644199d912c71df0ce2db7dd3292d00ce5a120ec Reviewed-on: https://chromium-review.googlesource.com/c/1256971Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596245}
-
Florent Castelli authored
Bug: 803494 Change-Id: Ic9efe4adba6909f6af3dbcf90d64debeef216480 Reviewed-on: https://chromium-review.googlesource.com/c/1257786Reviewed-by:
-
Tarun Bansal authored
Skip cookie check for origins when sending client hints. The cookie check was initially added when there was plan to allow 3rd party origins to request client hints. Since client hints are now restricted to only first party origins, and client hints are already disabled for origins that do not have JavaScript permissions, this cookie check is considered redundant. Note that cookie check is not required by the fetch or client hints spec either. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I080fa5257abba15724559a39b4b73ac4f2e12e3e Bug: 891370 Reviewed-on: https://chromium-review.googlesource.com/c/1253215Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#596243}
-
Florent Castelli authored
The base function is changing to return an RTCError, so we need to stop overriding the old function. Bug: 891556 Change-Id: Id9d1a90732a07fa3877f5ce50824d920bacf2777 Reviewed-on: https://chromium-review.googlesource.com/c/1257860Reviewed-by:
-
Stephen McGruer authored
Test is flaky-failing on win7, with no obvious recent change to be reverted. Bug: 891510 Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690 TBR=mlippautz@chromium.org Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690 Reviewed-on: https://chromium-review.googlesource.com/c/1258962 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596241}
-
Hans Wennborg authored
../../cc/paint/solid_color_analyzer.cc:155:5: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] Frame() = default; ^ ../../cc/paint/solid_color_analyzer.cc:161:38: note: default constructor of 'Frame' is implicitly deleted because field 'iter' has no default constructor PaintOpBuffer::CompositeIterator iter; ^ Bug: 890307 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9e4cb20394a603e43e3a62264189da29f01da20a Reviewed-on: https://chromium-review.googlesource.com/c/1256827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#596240}
-
Eric Stevenson authored
Includes fix for supporting asserts and invalid locals information. Bug: 843307 Change-Id: Iec4ecb2981e8c895e728127179d3b0eb54f09b14 Reviewed-on: https://chromium-review.googlesource.com/c/1258963Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#596239}
-
Nico Weber authored
It's now redundant with is_mac. The biggest use of it was that it set the buildflag MAC_VIEWS_BROWSER, but I removed all references to that in the last few days: https://cs.chromium.org/chromium/src/ui/base/BUILD.gn?q=%5CbMAC_VIEWS_BROWSER+case:yes Bug: 832676 Change-Id: I9bd74e26a35ddb4dfec786e4b0a6ada24366c951 Reviewed-on: https://chromium-review.googlesource.com/c/1258295Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596238}
-
Shahbaz Youssefi authored
Prior to this commit, the passthrough program cache used EGL_ANGLE_program_cache_control to store binary programs in angle's cache. With support for EGL_ANDROID_blob_cache added to angle, this role is reversed, i.e. the blob cache lives in the application (chrome), with the implementation (angle) storing additional data through callbacks. Bug: angleproject:2516 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I62d5c484580d953013d00e31300285be6b9442ce Reviewed-on: https://chromium-review.googlesource.com/c/1251325Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596237}
-
Geoff Lang authored
ui/gl initialization is now in a sub library, move the dependencies. Require a flag to use ANGLE on Android, this allows ANGLE and the native driver to both work with a given build so we can test on the bots. BUG=726002 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d3e0c4e844dca9e72c363f07e011c710e1a9f57 Reviewed-on: https://chromium-review.googlesource.com/c/1244078Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596236}
-
Rouslan Solomakhin authored
Before this patch, rotating a device with the Payment Handler CCT could result in cutting off the bottom of the CCT, making a part of web content inaccessible. This patch updates the height of the window when configuration changes. The height is never more than the height of the screen available to the activity. After this patch, rotating a device with the Payment Handler CCT will resize the CCT to always fit on the screen, so all web content is accessible to the user. Bug: 890184 Change-Id: I6ddf93f61e08e6a6281192e6a57b703ac18694ce Reviewed-on: https://chromium-review.googlesource.com/c/1252404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596235}
-
Boris Sazonov authored
This CL reimplements SyncAndServicesPreferences.updateDataTypeState to unify configuration of checkboxes. It resolves the issue when all checkboxes become enabled even though requirements for some data types aren't met. Bug: 889015 Change-Id: If9cffded02ce163edd33eaeeba73ddd244b9ce89 Reviewed-on: https://chromium-review.googlesource.com/c/1258007Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596234}
-
Lindsay Pasricha authored
Bug: 852504 Change-Id: I8599be996f3a556228e4abeda0aedff57b3b49b4 Reviewed-on: https://chromium-review.googlesource.com/c/1258290Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596233}
-
Jinho Bang authored
Reason for revert: A crash occurs because two animations runs in the same time. In the current implementation, the ViewStack class seems to be able to run only one animation per one time. So, before one animation finishes, if another animation runs, it might cause a crash. The ShowInitialPaymentSheet() doesn't make animation internally but the GoBackToPaymentSheet() do. So, after retry() calls, if shipping address or contact editor runs, it might cause a crash because two animations runs in the same time. To resolve this issue, this CL adds a parameter to GoBackToPaymentSheet() to control whether animation runs or not. If the `animate` parameter is false, just runs without animation. We don't need to run animation when retry() calls because the payment sheet is already hidden and the processing spinner is showing. Original change's description: > In the current implementation, memory leaks occur becuase the internal > view_stack_ for payment sheet grows incrementally whenver calling > retry(). So, this patch uses GoBackToPaymentSheet() instead of > ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to > reduce stack's size internally. > > Bug: 861704 > Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc > Reviewed-on: https://chromium-review.googlesource.com/1255082 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#595644} Bug: 861704 Change-Id: I5ab64423697aa11de97bf68ec9d9f262d7676bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1258813Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#596232}
-
Oskar Sundbom authored
Bug: 874784 Change-Id: I63e6185605e25bf009de8b319f72a9fd459672c9 Reviewed-on: https://chromium-review.googlesource.com/c/1257915Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596231}
-
Stephen McGruer authored
This test has been flake-crashing on these bots. TBR=mamir@chromium.org Bug: 889505 Change-Id: If527913f0e15f4d298b81c578d17a762f573be0e Reviewed-on: https://chromium-review.googlesource.com/c/1258966Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/416018d455bf..d136b2884e0d git log 416018d455bf..d136b2884e0d --date=short --no-merges --format='%ad %ae %s' 2018-10-03 oprypin@webrtc.org Prevent NaN and Inf values in webrtc_perf_test 2018-10-03 brandtr@webrtc.org iOS: Add numTemporalLayers to RtpEncodingParameters. Created with: gclient setdep -r src/third_party/webrtc@d136b2884e0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b4329c75e61be31294cbe3a0bdcbc7ebeb38368 Reviewed-on: https://chromium-review.googlesource.com/c/1258876Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596229}
-
Xianda Sun authored
The newly added MainThreadScrollingReasons: kWheelEventHandlerRegion and kTouchEventHandlerRegion cannot be displayed correctly on UMA. This CL updates the histogram enum in order to fix this bug. Bug: 861754 Change-Id: Ibd165ffe477cbc405d047bc820c77056d730ec6e Reviewed-on: https://chromium-review.googlesource.com/c/1257549 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596228}
-
Sylvain Defresne authored
Replace them with uses of TestingFactory which is based on base::Callback<> instead of function pointers. This converts uses in /chrome/browser/sync. This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 809610 Change-Id: If489e869a7f9143528ef89411b1a8d7c6e24b79b Reviewed-on: https://chromium-review.googlesource.com/c/1245729Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#596227}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b2bc879189c..55aea84baa53 git log 5b2bc879189c..55aea84baa53 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 egdaniel@google.com Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN." 2018-10-03 borenet@google.com [infra] Also run install_go_deps.sh during go_deps asset creation Created with: gclient setdep -r src/third_party/skia@55aea84baa53 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:862144 TBR=mtklein@chromium.org Change-Id: Iec08865684a554ae2af371c287ec4fce3c7a3885 Reviewed-on: https://chromium-review.googlesource.com/c/1258875Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/bfe29206c269..54ca2cd59219 $ git log bfe29206c..54ca2cd59 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 junyer Make the fuzzer check size before computing rsize. 2018-10-02 junyer Make the fuzzer limit reverse program size and fanout. 2018-09-28 junyer Mention (?m) in the comment about posix_syntax == false. 2018-09-20 junyer Add Clang 7 to the Travis CI matrix. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: Ida46ef13d8b73fb30db7894cd3e8a5b6ab8f739c Reviewed-on: https://chromium-review.googlesource.com/c/1258964Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Paul Wankadia <junyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596225}
-
Aldo Culquicondor authored
This reverts commit 31783d1f. Reason for revert: Crash when opening a new tab. Original change's description: > VR: Remove bottom margin from NTP > > Bug: 884803 > Change-Id: I20378649418949c2d00097ff8ca204972c54b2ab > Reviewed-on: https://chromium-review.googlesource.com/1240169 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Aldo Culquicondor <acondor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595884} TBR=twellington@chromium.org,mdjones@chromium.org,acondor@chromium.org Change-Id: Ifef474e5c9183a32934a1eeb401c2a5e7e3e505f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884803 Reviewed-on: https://chromium-review.googlesource.com/c/1258299Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596224}
-
Reilly Grant authored
With the network service we are deprecating the concept of a net::URLRequestContextGetter. A content::StoragePartition (which owns a network::mojom::NetworkContext) is the right layer of abstraction for expressing what this function operates on. Bug: 792678 Change-Id: I22caa1f85357c2b482f6973365d52bcfa59d02d5 Reviewed-on: https://chromium-review.googlesource.com/c/1257896Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596223}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f6d20f5c09f..b21e4a509d0c Created with: gclient setdep -r src-internal@b21e4a509d0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2892201f3bd103a4438096a7a1dafba8fce561d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258872Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596222}
-
Stephen McGruer authored
This reverts commit 14de2307. Reason for revert: Newly added test WaylandScreenTest.MultipleOutputsAddedAndRemoved fails on ChromeOS ASAN/LSAN; see crbug.com/891718 Original change's description: > [ozone/wayland] Add remove output functionality > > This CL adds a new functionality to the existing WaylandOutputManager > and WaylandScreen classes. Now, it is possible to remove and > change primary displays on hot plugs and removes. > > To test that functionality, a new test has also been added. > > The logic that assigns output ids has also been changed. > Now, we are using numeric names that a Wayland compositor > announces during Global and GlobalRemove calls. That is, > each global object is assigned an unique numeric name, which can > be freely used as an id. > > Bug: 890276, 875161 > Change-Id: I775bdd40a946c9f0c5dde89eba6e36c4615e1f21 > Reviewed-on: https://chromium-review.googlesource.com/c/1254146 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596155} TBR=rjkroege@chromium.org,msisov@igalia.com Change-Id: I8ae1f0fa1df71b464096abd0fcd504c1d4f5f480 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890276, 875161, 891718 Reviewed-on: https://chromium-review.googlesource.com/c/1258914Reviewed-by:
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5f7d23ee54ccad62cf42961fec86ad8b4801a8c9 Reviewed-on: https://chromium-review.googlesource.com/c/1258047 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596220}
-
Aldo Culquicondor authored
These methods don't affect the BrowserRenderer. The task posting is done in VrGLThread instead. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie43b046c71b7293d33316f4029f0fd7710c19869 Reviewed-on: https://chromium-review.googlesource.com/c/1258283 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#596219}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I3173492480955a562415bd8885b6b92fb6cbf5a6 Reviewed-on: https://chromium-review.googlesource.com/c/1256782Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/607f907d47b0..c3bef3e7b028 git log 607f907d47b0..c3bef3e7b028 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 jmadill@chromium.org Allow 'defined' in define in non-WebGL. Created with: gclient setdep -r src/third_party/angle@c3bef3e7b028 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9a293a9b4379033c32c047031d5700c7897d31ec Reviewed-on: https://chromium-review.googlesource.com/c/1258874Reviewed-by:
-
Bailey Berro authored
- Fixes a nullptr dereference crash when SetupKerberos times out. Bug: chromium:891517 Change-Id: Ie9394ec31d1f1c640c313a829bd0d99c9f02e48f Reviewed-on: https://chromium-review.googlesource.com/c/1258216 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596216}
-
Stephen McGruer authored
Test appears to be heavily timeout-flaky, unclear as to why it suddenly became flaky at this time. Bug: 891530 Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 TBR=bokan@chromium.org Change-Id: I1d097662b7a9f6fbb35999d5553224ac4a24a2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1258620Reviewed-by:
-
stkhapugin@chromium.org authored
Deletes all the legacy code that is not used in UI Refresh. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I99f1ee75475187951b96a037e7874c735e459996 Reviewed-on: https://chromium-review.googlesource.com/c/1235717 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
