GitLab

Completely remove the Google Photos option for background
customization. If it's just hidden it will still show up
after the network state changes. It would also be possible
inspect the page and trigger the dialog.

Bug: 869230
Change-Id: I312164ae0648c108709c2809382ff1ca610b8c5f
Reviewed-on: https://chromium-review.googlesource.com/1156882
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579524}

Bug: b/111105039
Test: Manual
Change-Id: I7c39e63c2b65f557f668687bdc34ced2256462f6
Reviewed-on: https://chromium-review.googlesource.com/1149065Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579523}

- Decouple the EmptyViewCoordinator from the underlying model.
- Add back the concept of loading to the View.

Change-Id: I568fcdc32af7aaf42908c56981538c02cc4f61ed
Reviewed-on: https://chromium-review.googlesource.com/1150840
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579522}

Bug: 814906
Change-Id: I3707ab5bf8231ab0b8805bad5b645d3db9e85811
Reviewed-on: https://chromium-review.googlesource.com/1149062
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579521}

Bug: 868024
Change-Id: I4d8b01b7e78fdd9b16b563174af9af41907ee1e5
Reviewed-on: https://chromium-review.googlesource.com/1152289
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579520}

This layout test has been flaky for some time.

TBR=peter@chromium.org

Bug: 869470
Change-Id: I1749a81e5172962126c0ee32afaeb7f78e4fca13
Reviewed-on: https://chromium-review.googlesource.com/1157118Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579519}

The dependency was test-only. Extracted ViewportLayersSetup
helper class to platform/testing to be reused both in animation
and graphics.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icf6b0578ceb99c1f7630e6ef5db1f0c6082cb13a
Reviewed-on: https://chromium-review.googlesource.com/1155750
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579518}

The translate infobar under test is now obsolete with the launch of
Harmony. It appears that the new UI is covered by various other suites
(TranslateLanguageBrowserTest, TranslateBubbleViewTest, and
TranslateBubbleViewBrowserTest).

Bug: 867557
Change-Id: Iab4b7ec611b3383ea6aa1b9dacddaa44d821f185
Reviewed-on: https://chromium-review.googlesource.com/1152527Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579517}

- Large numbers of redundant requests are degrading the performance
  of the SMB FSP
- This CL short circuits those requests while separately we can try
  to eliminate their root cause
- This filters out 2 types of requests
  1) Empty requests. These requests should never even be made since
     they are requests that explicitly ask for no information.
  2) Thumbnail only requests. We never have thumbnail data and always
     provide a hardcoded response.
- By short circuiting them here we can prevent them being sent to
  the service and incuring any network operations.

BUG=chromium:867200,chromium:587231
TEST=build and test

Change-Id: Ibb9eaaa175660106dd6a169781cc2ce4a83dafea
Reviewed-on: https://chromium-review.googlesource.com/1156989Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579516}

Bug: 855690
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I092d9f3bc7fcf5eb507bbc3f4e9f27ce09931532
Reviewed-on: https://chromium-review.googlesource.com/1125296Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579515}

TransferBufferManager registers itself as a MemoryDumpProvider on the
GPU thread, meaning it could be called into from there as long as it's
alive, so we need to make sure it's destroyed on that thread to avoid
data races.

Bug: 866486
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6138bc9520e86fd4277bf7842f6cdd1730d968f3
Reviewed-on: https://chromium-review.googlesource.com/1155982Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579514}

- Leave the UKM in AutofillManager.
- Call DetermineHeristicTypes in AutofillHandler

Bug: 849913
Change-Id: Ic193afbab0ac14595e6c975caf5d2520209be06e
Reviewed-on: https://chromium-review.googlesource.com/1150732
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579513}

Change the DeviceUpdateStagingPercentOfFleetPerWeek to
DeviceUpdateStagingSchedule. Change the proto field for this policy to
a string since a JSON needs to be used now that primitives aren't being
used.

BUG=chromium:858621

Change-Id: Ia6ae8d107c9a9f2fd58042c3f9b2f6956abb8306
Reviewed-on: https://chromium-review.googlesource.com/1135830
Commit-Queue: Adolfo Higueros <adokar@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579512}

Bug: 830892
Change-Id: I3b900e68527f31cfd52cc27d98cfcdd3a22d001b
Reviewed-on: https://chromium-review.googlesource.com/1147497Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579511}

This CL moves the HSTS redirection call in the predictor's preconnect
method into the NetworkService (creating an internal analogue to
GetHSTSRedirectOnIOThread).

Bug: 821027
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5070de29aa219d2c038634c584b15c2a714a128f
Reviewed-on: https://chromium-review.googlesource.com/1152082Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579510}

Change-Id: I3b525852240d23dac3783145682db858b9be2ce7
Reviewed-on: https://chromium-review.googlesource.com/1157065Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579509}

https://skia.googlesource.com/skia.git/+log/74c6ed3d1f17..b303a427c03d


git log 74c6ed3d1f17..b303a427c03d --date=short --no-merges --format='%ad %ae %s'
2018-07-31 benjaminwagner@google.com [Bazel] Reformat public.bzl with buildifier.
2018-07-31 bsalomon@google.com Remove unused GrGpuResourceRef and GrTGpuResourceRef
2018-07-31 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 67c388e6c04e..2eb65034db71 (1 commits)
2018-07-31 timliang@google.com implemented copy surface as draw for metal gpu backend
2018-07-31 csmartdalton@google.com Don't use glFrontFace
2018-07-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader be5fe7797f1e..7f1c3d07e961 (1 commits)
2018-07-31 ethannicholas@google.com Re-re-land "added GrSkSLFP and converted DitherEffect to use it"
2018-07-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms c663954a7567..2925dc93401c (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@b303a427c03d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I6d47979b2ace5bf9ebccd69dfefccd727066e0df
Reviewed-on: https://chromium-review.googlesource.com/1156907Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579508}

Implements showBrowsingHistoryRemovedDialog on
ClearBrowsingDataTableVC.

Screenshots:
https://drive.google.com/open?id=1uMyVYUqzdikwfP7V-ka0xD3ImteYbKO2
https://drive.google.com/open?id=1blljYShc0UYPVOWeuZszFpWk1z3Es8ke
https://drive.google.com/open?id=1J2r0pyARZtMOzjzffdL8B-S1ek8lBwXK

Bug: 868363
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie0a20e07e64a3d14017e87edfa2dc05a874345f1
Reviewed-on: https://chromium-review.googlesource.com/1155479
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579507}

The tests were mistakenly also disabled for simulator in
crrev.com/c/1155793.

TBR=marq@chromium.org

Bug: 869176
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I794468b78f4259ed10e230074c54a5ed0552e1f4
Reviewed-on: https://chromium-review.googlesource.com/1157109
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579506}

Bug: 714962
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I82a2ee42527cd7186173d476826654125bbea876
Tbr: kojii@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1157001Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579505}

 - Add a new html_out_files_polymer2 optional parameter.
 - When specified, causes both the Polymer 1 and Polymer 2 HTML bundles to be
   generated.

The parameter will be used in follow-up CLs.

Bug: 862472
Change-Id: Iaa015d3cc7091b1b2f4e84aa36fae7b039b58846
Reviewed-on: https://chromium-review.googlesource.com/1155474
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579504}

No functional change. This is needed prior to some refactoring.

Bug: 869206

Change-Id: I2db96c903b64b50ac8e33739263cdbb0297bde2f
Reviewed-on: https://chromium-review.googlesource.com/1155910
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579503}

This partially reverts commit 93cd24be.

Reason for revert: This inadvertently changes the definition of
several core session restore metrics when the PageAlmostIdle feature
is enabled.

Original change's description:

> Update SessionRestoreStatsCollector to use TabLoadTracker.
>
> This is necessary in order for it to work when the PageAlmostIdle
> feature is enabled.
>
> BUG=829933
>
> Change-Id: Ic3158a984713ceef849788eaa758ecaa255eba5a
> Reviewed-on: https://chromium-review.googlesource.com/1097421
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567484}

Bug: 829933
Change-Id: I23b54578084ef8c55b5c47d3a29880e15be3afec
Reviewed-on: https://chromium-review.googlesource.com/1153145
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579502}

Added virtual-channel field to be able to filter crash reports by this it.

Bug: internal b/64942730
Change-Id: I5375d574f6095a689e89d0c543df20da2b281b33
Reviewed-on: https://chromium-review.googlesource.com/1026150
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579501}

Add Net.SpdySession.ServerSupportsWebSocket histogram to track server
support of WebSockets over HTTP/2.

Bug: 801564
Change-Id: I1cd63e5bdca17106487c48ce6c1734e4d6591985
Reviewed-on: https://chromium-review.googlesource.com/1152486Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579500}

ContentBrowserClient has had that method for a while, but it hasn't been
used.  I'm adding a use of it, so am implementing it in subclasses.

Bug: 841445
Change-Id: I9826cabdfdb2493d96583c1b7a2c0e2710ec07e8
Reviewed-on: https://chromium-review.googlesource.com/1151456Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579499}

I stumbled onto an obscure failure by calling OfflineContentAggregator from an IO thread, when
it actually needs to be used from the UI thread.
Using SEQUENCE_CHECKER fails under invalid use faster and more clearly.
I chose to add it to OfflineContentAggregator because that's the API I was using at the time.
I chose to add it to TaskQueue because many public offline_pages APIs result in adding tasks,
so it's likely to catch incorrect calls.


Change-Id: I40080b4e56cb000dc30acee36d4aa01d3806a6f3
Reviewed-on: https://chromium-review.googlesource.com/1148998
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579498}

Bug: 621751
Change-Id: I4e13f470fc688cd8ccb073764a14f9d1cea40ea4
Reviewed-on: https://chromium-review.googlesource.com/1155475Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579497}

Original CL:

- https://codereview.chromium.org/281613004

  Don't let tcmalloc read all kinds of env vars at startup.

  The env vars are still used in profiling=1 builds, by such illustrious
  figures as the deep memory profiler bot and willchan. Reading from the
  environment variables uses static initializers, so this change will
  eliminate those static initializers in profiling=0 builds.

  As discussed in the chromium-dev thread "Does anyone use tcmalloc's
  debugging envvars?".

  BUG=94925
  NOTRY=true

BUG=724399,b:70905156

Change-Id: Ic143dfca456a3475be0938af53c0eb4308f457d1
Reviewed-on: https://chromium-review.googlesource.com/1130780Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579496}

And a small refactoring for readability of finding an xhr breakpoint.

I introduced IsEmpty in this PR:
https://chromium-review.googlesource.com/c/chromium/src/+/1154038

Change-Id: I7b02c9d4d4ae1e051688790f5043d8710cf1c692
Reviewed-on: https://chromium-review.googlesource.com/1154190Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579495}

1. Currently expand arrow exists in AppsContainerView, so opening search
   results page will move it off screen. To make it stay where it is and
   fade it out, we need to move it to ContentsView.
2. Make expand arrow focusable only in peeking state.

Demo: https://drive.google.com/open?id=1hgSqEDgEW1wZr5Dxw8WQmGpEosy4sDgP

Bug: 866690,868107
Change-Id: I965703041f498f8ad1e64c6db47718e7bf69c8f8
Reviewed-on: https://chromium-review.googlesource.com/1150900
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579494}

Bug: 807724
Change-Id: I065796ef6b9f954f3e623b0c5db800b24889d95b
Reviewed-on: https://chromium-review.googlesource.com/1155088Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579493}

iOS: https://drive.google.com/file/d/198YXGP4TW8VcZ-scZy6jf-8GPHLRQc2U/view?usp=sharing
Desktop: https://drive.google.com/file/d/1ouJGiWYjg-IfIaMdxKPXGh1sN3EDrYxQ/view?usp=sharing

Bug: 855088
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I92786a9aa33e228297352b9dfaf5730b00daf629
Reviewed-on: https://chromium-review.googlesource.com/1155484
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579492}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: I682964caf24da1b14570dbfacbc59e9257fa1ab2
Reviewed-on: https://chromium-review.googlesource.com/1154222Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#579491}

The related Skia change has rolled into Chromium and the fix in Skia can
now be turned on and rebaselined.

Change-Id: I8a799896bc743932d37ea62ba8e62cc0582fc55a
Reviewed-on: https://chromium-review.googlesource.com/1156627Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579490}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e8e10fdf..8b8cc1cc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2247a14f81593c17916bd8eb32ba3d9e13df235c
Reviewed-on: https://chromium-review.googlesource.com/1156992Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579489}

TBR=marq@chromium.org

Bug: 869477
Change-Id: I74a659e745f2480e2a35535085e837b6b5e5bc73
Reviewed-on: https://chromium-review.googlesource.com/1157066Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579488}

All tests should be using MD for secondary UI by default, so this call
is now a no-op.

Bug: 867557
Change-Id: Ia0d6f774543425c56084894f15f4d262f9071f7c
Reviewed-on: https://chromium-review.googlesource.com/1155632Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579487}

Currently, 50 to 60% of CollectInlines are spent in
ExpandCapacity to reallocate the vector buffer. This patch
makes rough estimation from the number of direct children
to reduce the number of reallocations.

Currently, slow tests such as storage/indexdb/* creates
more than 1,000 items by appending the test results in
<span></span><br> structure. This patch reduces vector
allocation in such cases to once or twice.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2b5b1462dc59091cc534a2f143b54567d31b863a
Reviewed-on: https://chromium-review.googlesource.com/1155268Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579486}

This CL moves mSigninAccessPoint from SigninFragmentBase to
SigninFragment. SigninFragmentBase will be used for as the base class
for the consent bump fragment and for the consent bump there's no notion
of the access point. This CL also reimplements how SigninFragmentBase
determines the text for the cancel button, because it's been using
mSigninAccessPoint.

Bug: 869426
Change-Id: I8361965a9c9df62d86e058b01f4a06f88e7bfbda
Reviewed-on: https://chromium-review.googlesource.com/1156701Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579485}