- 20 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3cfba7f05be4..1ee36c9fa7e5 git log 3cfba7f05be4..1ee36c9fa7e5 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 sugoi@google.com VK_EXT_shader_stencil_export support 2020-02-20 bclayton@google.com Remove rr::Thread 2020-02-20 capn@google.com Support JIT on a separate thread Created with: gclient setdep -r src/third_party/swiftshader@1ee36c9fa7e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2835efb7ad4012213cb41edff4cb6d70b5368e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743284}
-
Nico Weber authored
It existed for Windows, and we currently don't do WPO on Windows. When we bring it back, it'll likely be different from /GL cl.exe-style WPO. Depends on https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/2065789 Bug: 1053958,598772 Change-Id: Ie2ea04ad54f0d3b6711ffb7682fe1ae15662cb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066106 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#743283}
-
Owen Min authored
Policy parsing error or unknown policy error is cause by admin and is not a critial issue for the browser. Lower the log level from error to warning because error level confuses users. Bug: 1054418 Change-Id: I10b7397fc6d3476d1375bdb2e256a91b52f7cbca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067303 Commit-Queue: Yann Dago <ydago@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#743282}
-
Austin Eng authored
Corentin, Austin, and Kai are responsible for WebGPU in Chromium and the integration between Dawn's remoting protocol and Chromium's IPC. Bug: none Change-Id: I2b3b5d9cd6fea6c1d235d52cca144c35479f1522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067220Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#743281}
-
Ella Ge authored
This reverts commit fd191139. Reason for revert: [Sheriff] compile failure https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/157215 Original change's description: >
🛃 Move Client Data header out of ClientManager. > > Bug: 1040143 > Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743100} TBR=mvanouwerkerk@chromium.org,peconn@chromium.org Change-Id: I372b18ffaf679ba933129ce5f3ac65bf0ee8b661 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067717Reviewed-by:Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#743280}
-
Clark DuVall authored
There is a slight difference in the code after refactoring: PermissionContextBase::IsPermissionAvailableToOrigins() now uses PermissionsClient::CanBypassEmbeddingOriginCheck() which checks both if the requesting scheme was chrome-extension or if the embedding origin was chrome://newtab. This is slightly different from the existing logic which only checks for chrome-extension. I believe this should be fine, since content::IsOriginSecure() returns true for chrome://newtab anyway. This small change allows us to use CanBypassEmbeddingOriginCheck() in PermissionContextBase::DecidePermission() as well, and avoids adding another method to PermissionsClient. Bug: 1025609 Change-Id: I674f8ef5fb9f0d0eca1460c9756759cbe457327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063672 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743279}
-
Xiaocheng Hu authored
CSSMathExpressionVariadicOperation::ResolvedUnitType() currently returns kUnknown when its operands have different unit types, which is wrong. When there are both integer and float operands, the returned type should still be kNumber. This patch fixes it by returning kNumber on kCalcNumber category. Note that this follows the approach in binary operations. Bug: 10543262 Change-Id: I2123a4efacc80931556577cd2c657731de6fff01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067283Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743278}
-
Mila Green authored
Bug: 1053729 Change-Id: I7eab41596dd6da5573cf302bcd53ef3e4df1abfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063538Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743277}
-
Caleb Rouleau authored
R=rmcilroy@chromium.org Bug: 1039801 Change-Id: I1a8bf9246f734954f52c05f439aabae80c9ed2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067452Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#743276}
-
rajendrant authored
This is a reland of 653f075d (After deflaking the test) Original change's description: > Clear the subresource redirect hints when navigation is started > > RenderFrames could be reused for same-origin navigations. This causes > the hints from previous navigations to be used in next navigation > until the new hints fetch finishes and updates the hints. This CL clears > the hints. > > Unfortunately this causes race conditions between the image fetch and > the hints update, which causes images to not redirected to compressed > versions. So the image fetches are delayed a bit to circumvent this. > > Bug: 1051283 > Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742326} TBR=mcrouse@chromium.org Bug: 1051283 Change-Id: I0336295bc6120c16e02dd28f787f2edcfe37e9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065984Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#743275}
-
Peter Boström authored
Bug: None Change-Id: I311e0030a68c23060a06ea7520a2580732fa8451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066879 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#743274}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6be40a04209..8308c6058bbb git log c6be40a04209..8308c6058bbb --date=short --first-parent --format='%ad %ae %s' 2020-02-20 treehugger-gerrit@google.com Merge "Check if any process dumps are present." 2020-02-20 fmayer@google.com Use const refs instead of copying strings. 2020-02-20 treehugger-gerrit@google.com Merge "trace writer: Reset last_packet_size_field_ on flush." Created with: gclient setdep -r src/third_party/perfetto@8308c6058bbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06dbbaecb43de179016da8217807ce7c1ffb5172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067530Reviewed-by:
-
Jarryd authored
The storage team will still be interested in usage of the persistent storage pool as the temporary pool has been expanded and usage of that begins to ramp up. Bug: 1053114 Change-Id: Ifb3e4180710c12884485a1456c7702e86c6e8966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062454Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743272}
-
Felicia Lim authored
Bug: 1053572 Change-Id: I60c36728362994815fb376cefe5d623c2bcb3d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065855Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743271}
-
Tim Volodine authored
Extend the expiration date of the BatteryStatus.NumberBatteries* histograms for various platforms. In particular: BatteryStatus.NumberBatteriesLinux BatteryStatus.NumberBatteriesMac BatteryStatus.NumberBatteriesWin BUG=1052924 Change-Id: I1767db7e40ad78513665ce39d41fe7d2dc797b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062429 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This CL migrates all the remaining trivial or trivial-ish overrides of DialogDelegate::Accept and DialogDelegate::Cancel in //cbuiv, which are the bulk of the remaining instances in the codebase. Each of these classes falls into one of these five patterns: "Pattern 1": Dialog is already given one OnceCallback per exit path at construction, so pass them on to DialogDelegate. "Pattern 2": Dialog is given a single OnceCallback, so wrap it in a lambda and make one binding of that lambda per exit path. "Pattern 3": Dialog does something large on an exit path, so leave an OnDialog{Accepted,Cancelled} method and bind that. "Pattern 4": Dialog calls directly through to methods on some other object, so bind those methods on that object directly. "Pattern 5": Dialog does something small on an exit path, so bind a lambda inline the constructor for that. * arc_data_removal_dialog_view.cc: Pattern 2 * virtual_card_selection_dialog_view_impl.cc: Pattern 4 * critical_notification_bubble_view.cc: Pattern 3 * download_in_progress_dialog_view.cc: Pattern 2 * media_galleries_dialog_views.cc: Pattern 5 * print_job_confirmation_dialog_view.cc: Pattern 2 * request_file_system_dialog_view.cc: Pattern 2 * external_protocol_dialog.cc: Pattern 3 & 4 * folder_upload_confirmation_view.cc: Pattern 2 * hats_bubble_view.cc: Pattern 2 * ime_warning_bubble_view.cc: Pattern 2 & 5 * login_handler_views.cc: Pattern 5 * cloud_services_dialog_view.cc: Pattern 3 * native_file_system_directory_access_confirmation_view.cc: Pattern 2 * native_file_system_permission_view.cc: Pattern 2 * native_file_system_restricted_directory_dialog_view.cc: Pattern 2 * deep_scanning_failure_modal_dialog.cc: Pattern 1 * prompt_for_scanning_modal_dialog.cc: Pattern 1 * profile_signin_confirmation_dialog_views.cc: Pattern 5 * uninstall_view.cc: Pattern 3 Three of these dialogs (ExternalProtocolDialog, FolderUploadConfirmationView, and NativeFileSystemDirectoryAccessConfirmationView) were depending on the old default-close behavior, so these dialogs now have explicit close handlers. Bug: 1011446 Change-Id: I7f9a1e8dadcff26b429ce5d67ecc7ca068a0f0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062702 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743269}
-
David Tseng authored
Bug: 1052860 Change-Id: I7db938fa7c69d14874a46a55ac624b56cbd90dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062668Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743268}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I560590deae1b7cfd731b678d371a3c04bfe62d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067286Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#743267}
-
Chris Blume authored
Previously, in [1] prefers_raster_in_srgb was set to false by default and never enabled. The plan was to launch this first disabled, then on Android when the conditions were right, and later expand to other platforms. This CL expands prefers_raster_in_srgb to Android. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2045053 Bug: 955158 Change-Id: Iba9654cb57b71294b2018eef483356f99616c379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055410Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#743266}
-
Eugene Zemtsov authored
This feature has no effect anymore. Fullscreen detection is always active. Change-Id: I65170aee908610a3dc2244bb18b27ae503c6824e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065728Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#743265}
-
Kent Tamura authored
Similar to crrev.com/742068, this CL moves the code of LayoutMenuList::ComputeIntrinsicLogicalWidths() to LayoutBox as DefaultIntrinsicContentInlineSize() in order to make LayoutNG transition easier. This CL has no behavior changes. Bug: 1040828 Change-Id: I1c54c35009027b24bf8d991676b2c69025b2978e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065692Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#743264}
-
Ahmed Fakhry authored
This CL makes the following changes to enable renaming desks from their mini views in overview: - DeskMiniView is no longer a button, - Instead, the DeskPreviewView is now the button, clicking on which will activate its associated desk, - A newly-added DeskNameView is a Textfield that replaces the old desk label. - Desk names can either be: * Default: i.e. not set by users, of the form "Desk 1", "Desk 2", ... etc. Those are changed as desks are added or removed according to the desk's position in the list. * Modified: i.e. set by users. Those remain the same during the desks' lifetime until user changes them again. This CL does not implement restore yet. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=1040980#c13 BUG=1040980 TEST=Manually, added new tests: - ash_unittests --gtest_filter=DesksEditableNamesTest* - ash_unittests --gtest_filter=DesksOverviewHighlightControllerTest.ActivateDeskNameView Change-Id: I1cbd3cb883cd56d0458c0e3b0cc0de297e5ee641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058125Reviewed-by:James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#743263}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eed27fa60f1b..d427e39ac716 Created with: gclient setdep -r src-internal@d427e39ac716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053588 Tbr: jbudorick@google.com Change-Id: Ic67d69ab76aedd1c76069a170fa09faec4ac1963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743262}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d55c50771361..7aa682406ad4 git log d55c50771361..7aa682406ad4 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 John.Emau@microsoft.com gclient: setdep writes binary for windows newline support Created with: gclient setdep -r src/third_party/depot_tools@7aa682406ad4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0d4c2d2cc4e4edc7828139eadbe3d093b9e0aa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067524Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c80274e041d6..adfb1574077d git log c80274e041d6..adfb1574077d --date=short --first-parent --format='%ad %ae %s' 2020-02-20 nigi@chromium.org Roll third_party/icu/ dbd3825b3..9f4020916 (1 commit) 2020-02-20 nigi@chromium.org Roll tools/clang/ f2e1fa017..81bf7cada (1 commit) 2020-02-20 nigi@chromium.org Roll build/ 1bee638a8..d4d44f882 (14 commits; 1 trivial rolls) 2020-02-20 nigi@chromium.org Roll tools/clang/ 42fbdfef1..f2e1fa017 (5 commits) 2020-02-20 thestig@chromium.org Retain corresponding layoutitem in CXFA_FFDocView::SetFocus(). 2020-02-20 nigi@chromium.org Roll base/trace_event/common/ 618bcf7a2..dab187b37 (3 commits) 2020-02-20 thestig@chromium.org Retain corresponding layoutitem in CXFA_FFWidget::LoadWidget(). 2020-02-20 tsepez@chromium.org Initialize CFX_BreakPiece members in header. 2020-02-20 tsepez@chromium.org CFX_TxtBreak::EndBreak_SplitLine() always returns false. 2020-02-20 thestig@chromium.org Improve comments in public/fpdf_transformpage.h. 2020-02-20 tsepez@chromium.org Always retain corresponding layoutitem in CXFA_FF*::On*() methods 2020-02-20 nigi@chromium.org Roll v8/ cd3414532..07a0ee92d (540 commits) 2020-02-20 nigi@chromium.org Roll base/trace_event/common/ 81c050f85..618bcf7a2 (3 commits) Created with: gclient setdep -r src/third_party/pdfium@adfb1574077d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:982193 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ie64d776fe446722d73b9a39a94d9d1495ff1d237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067528Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b0ed557a98e..5725e9b55494 git log 7b0ed557a98e..5725e9b55494 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 egdaniel@google.com When glSync is not available on android fake it out with EGL for our tests. 2020-02-20 bsalomon@google.com GrFP::coordTransformsApplyToLocalCoords() -> GrFP::isSampledWithExplicitCoords() 2020-02-20 jlavrova@google.com Bugs 2020-02-20 fmalita@chromium.org [skottie] Clip overflowing paragraph lines 2020-02-20 herb@google.com Revert "Multi-threaded strike cache" 2020-02-20 herb@google.com Multi-threaded strike cache Created with: gclient setdep -r src/third_party/skia@5725e9b55494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I2627d18c972631a537a30b8f0d7c0c8a7036714f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067526Reviewed-by:
-
Ian Struiksma authored
Fixed 2 issues: ebags site failing due to wpr fuzzy matching failure: Re-recorded to get cleaner recording (changed files ebags.wpr & ebags.test) nordstrom and other sites missing DeterministicTimeSeedMs: This led to sites perhaps failing (and in the case of nordstrom indeed failing due to time change. Added a timestamp into the wpr archives for the 16 sites that didn't have it. reverted nordstrom.test back to expecting a 2019 date as well. Diff: Binary files apple.wpr and current/apple.wpr differ Binary files barnes_and_noble.wpr and current/barnes_and_noble.wpr differ Binary files bed_bath_beyond.wpr and current/bed_bath_beyond.wpr differ Binary files bodybuilding.wpr and current/bodybuilding.wpr differ Binary files booking.wpr and current/booking.wpr differ Binary files crate_and_barrel.wpr and current/crate_and_barrel.wpr differ Binary files dell.wpr and current/dell.wpr differ Binary files ebags.wpr and current/ebags.wpr differ Binary files ebay.wpr and current/ebay.wpr differ Binary files expedia.wpr and current/expedia.wpr differ Binary files hotels.wpr and current/hotels.wpr differ Binary files just_fab.wpr and current/just_fab.wpr differ Binary files nordstrom.wpr and current/nordstrom.wpr differ Binary files qvc.wpr and current/qvc.wpr differ Binary files talbots.wpr and current/talbots.wpr differ Binary files ticket_master.wpr and current/ticket_master.wpr differ Binary files timberland.wpr and current/timberland.wpr differ nordstrom.test current/nordstrom.test 238c238 < "expectedValue": "7", --- > "expectedValue": "8", Bug: 1054446,1038779 Change-Id: I4d360bd34fc0b0a7d375e70139f54380199e42da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067322 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#743258}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b330ea6b491e..f949a10e516b git log b330ea6b491e..f949a10e516b --date=short --first-parent --format='%ad %ae %s' 2020-02-20 hob@chromium.org Reland "Create VulkanImageWrappingTests for dma-buf images" Created with: gclient setdep -r src/third_party/dawn@f949a10e516b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996470 Tbr: cwallez@google.com Change-Id: I9fec9770ebf31f167be505891ac3efcb3648b6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067517Reviewed-by:
-
Anastasia Helfinstein authored
TBR=katie@chromium.org Bug: None Change-Id: Ie10bb733e58e34141dbd9ae347f7e17bddd73e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067261Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#743256}
-
Victor Costan authored
AppCacheUpdateJob::ContinueHandleManifestFetchCompleted() takes a boolean argument. Based on its value, one of two completely disjoint blocks of code is executed. This CL extracts the two disjoint blocks of code into two separate methods, HandleFetchedManifestChanged() and HandleFetchedManifestIsUnchanged(). This is intended to make AppCacheUpdateJob easier to read. This CL does not introduce any functional change. Change-Id: I60938b9bdab2006a540070c5f13b54ffc16887c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066155 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743255}
-
Reilly Grant authored
This change adds an NFC permission check in NfcHost and ensures that the Mojo connection passed to the renderer is scoped to the lifetime of the RenderFrameHost which brokered it. This ensures that if the renderer navigates or the tab is closed the NFC connection will be broken immediately, even if for some reason the NfcProxy in the render process is not garbage collected. The connection is also closed immediately if the user revokes NFC permissions. Bug: 1047838 Change-Id: I73d05c112674a82dd15146403e4ad03765ee1fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051384 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743254}
-
David Trainor authored
Stable rollout is happening now, so we need to extend these a few more months to make sure it goes smoothly (check for errors, evaluate adoption & success criteria, etc.). Bug: 1039340 Change-Id: Icbd4ee821a26bb240273ce5ba7b8bc7e6b705a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062637Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Nate Fischer authored
This represents sample rate as a per mille (out of 1000) integer. This has the advantage that embedders can express sample rates precisely (ex. 100 vs. 0.1). It also simplifies test logic. Sampling is still determined by hashing client_id, so this should not have a significant impact on metrics volume. This may have a minor impact due to rounding differences. This does not change the rates themselves, only their representation. This also simplifies the AndroidMetricsServiceClient interface, removing some methods and un-exposing others from subclasses (removing the 'virtual' declaration). Bug: 1037951, 1042518 Test: run_components_unittests -f AndroidMetricsServiceClientTest.* Test: run_android_webview_unittests -f AwMetricsServiceClientTest.* Test: start up WebView lots of times, compiled with stable & beta Test: channel, and manually confirm rate we're in-sample Change-Id: Idd52235f231cd93d97901c5d09a08bf05e71cd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053793 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743252}
-
Ken Rockot authored
Bug: 955171 Change-Id: I8d157312f8f063093d95e534868ffdfe27d34fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067458 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Stephen Chenney authored
Various Rendering Core histograms are set to expire soon. Extend them another year or 2 more milestones. Bug: 1053092,1043743,1043742 Change-Id: I6e34ae87ec4c76834d4ede35033e95a78b84aa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062289 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Gavin Williams authored
Change-Id: Ia5d45b58f20535aad7d303db20de345be5daef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067277 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#743249}
-
Evan Stade authored
Perhaps "content-modal" dialog would be another way to decsribe them. These are used for javascript dialogs, except onBeforeUnload (as per shared logic). There are TODOs sprinkled throughout, including: - accessibility (such as that handled by Chrome's TabObscuringHandler) - Embedder APIs: - to tell the embedder that a tab modal is showing, so they can modify their UI (Chrome disables the app menu) - for an embedder to inform WebLayer of focus events, which is used for juggling z-order (important for accessibility) - for an embedder to allow WebLayer to handle system back (so the dialog dismisses on back, rather than the page navigating) Bug: 1045499, 1025256 Change-Id: I2e694f09bbab9302375925e9148aac18f2985b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052267Reviewed-by:Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#743248}
-
Findit authored
This reverts commit 38d5e420. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 743212 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzhkNWU0MjBmZTcyYzBiYjY2YzlmNzY4N2Q0NWU5MzhjNzdlMDBkZgw Sample Failed Build: https://ci.chromium.org/b/8887906576420062352 Sample Failed Step: browser_tests Sample Flaky Test: MetricIntegrationTest.FirstInputDelay Original change's description: > Add FirstInputDelay integration test > > This CL adds a test for FID that tests equality between the JS value and > the value reported in UKM and in UMA. > > Change-Id: I00de8c947895700d86788ee4a95ea228458bb25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067077 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Steve Kobes <skobes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743212} Change-Id: I7eae1f24fb72da933586cb32b4b1cad24ade9844 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067353 Cr-Commit-Position: refs/heads/master@{#743247}
-
Bettina authored
Bug: 1054179 Fixes: 1054179 Change-Id: I890ab97f3390861e64196d6064450a5244cfdd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065332 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743246}
-
Peter Boström authored
This is explicitly done for the Extensions menu, but affect two pin icons in ash too. Bug: chromium:943702 Change-Id: I4a04afd6d41df4a9f0487dd0359539c69f7d5a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065910Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#743245}
-
