- 20 Jan, 2021 40 commits
-
-
Dale Curtis authored
Missing ()s around print(). Bug: 941669 Change-Id: Iafb67f9f3b04e068bb91310612b8e64eaeb25b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#845030}
-
Azeem Arshad authored
This CL adds the RequestInstalledProfile method in hermes Euicc client. A corresponding method is also added in FakeHermesEuicc client. The fake client behavior simulates how installed profiles will be listed in hermes. Cellular services will be created in shill for non-pending profiles but profiles won't be listed until after a call to RequestInstalledProfiles. This also renames the RequestPendingEvents method to RequestPendingProfiles. Bug: 1093185 Change-Id: Id8f24b6540031deb23ae6ddc088cfb8aa73a65b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638515Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845029}
-
Bartek Nowierski authored
We already have USE_PARTITION_ALLOC_AS_MALLOC, which serves the same purpose. Change-Id: I689386a830115a4b1c5632b4e75639365e57d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631893Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845028}
-
Minoru Chikamune authored
Before this CL, SVGImageChromeClient uses per-thread CompositorTaskRunner. After this CL, SVGImageChromeClient will use per-ASG CompositorTaskRunner. Bug: 1105403 Change-Id: I8aee7c032baa96e3d86bfa255d1e76f0464f2cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626684 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845027}
-
Michael Crouse authored
Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845026}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611078768-634fb3ae1c67578f99ad9e12394867d392a20265.profdata to chrome-mac-master-1611100586-c8c655fcd161c65cbf56bbbf122c093bef715f90.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14e56c0006f8887bd46fc01d6e8258586b35158e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845025}
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in //chrome/browser/signin since blink::mojom::ResourceType is deprecated[1]. It adds IsFetchLikeAPI() to ChromeRequestAdapter to check if the request has |is_fetch_like_api|. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: Ic83985731cd724f42447a73521b17a56219d29c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636895 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#845024}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610775681-262289403e7fd8444a73878a73a9f9f97304c245.profdata to chrome-linux-master-1611100586-44f5728e7d171615fda2c2af633f569a7b45f05a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4e18715e339b984027ec924a1ebcd1bcd55ca975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639353Reviewed-by:
-
Shahbaz Youssefi authored
Bug: 1143408 Bug: angleproject:2930 Bug: angleproject:3481 Change-Id: I7344df11f5e8999e73b564dba78dc2ae3ad7ed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637955Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845022}
-
Dominick Ng authored
BUG=1151969 Change-Id: Ic9f451aee91e8473104996ca4194510577e0524f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632106 Auto-Submit: Dominick Ng <dominickn@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Adam Langley authored
This change changes the wording for the caBLE UI when doing caBLEv2 serverlink. The dialog now contains a link (“Didn't get it?”) which triggers a new dialog state that instructs the user to connect the phone via USB cable. BUG=1002262 Change-Id: I292fe39455cbef296ec6088a7d4ff8a309ff066b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630740 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#845020}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I284d1d412b8bcc6a2aca7a34f86b9a4b1d49b2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638241Reviewed-by:
-
Minoru Chikamune authored
Before this CL, AnimationWorkletMutatorDispatcherImpl uses per-thread CompositorTaskRunner. After this CL, AnimationWorkletMutatorDispatcherImpl will use per-ASG CompositorTaskRunner. Bug: 1105403 Change-Id: Ib65e3a6f25be4455611aff91cb2fe83b86b6f13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631553Reviewed-by:
-
Yuta Hijikata authored
This removes cflag complete-member-pointers from lacros build to make it consistent with ash-chrome (a.k.a chromeos-chrome). This is in preparation to switching lacros-chrome to target_os="chromeos" from target_os="linux". Once the switch is completed, the !is_chromeos_lacros condition should be removed as suggested in the comment. Bug: 1052397 Change-Id: I4440c311407adf9e932ac32e44648c4433c6a9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631895Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845017}
-
Anqing Zhao authored
To support the deprecation of Chrome App, we need to provide new web APIs to replace the existing chrome.enterprise.deviceAttributes. They are added into navigator.device.* namespace and only available to trusted applications. (see go/web-api-navigator-device-dd) PRD: go/pwa-api-devices DD: go/pwa-api-devices-dd Bug: 1132865 Change-Id: Ib01ec58c94843d70bebe1515ae0ffac7eb4f2272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505139 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845016}
-
Findit authored
This reverts commit 88602533. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 844989 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg4NjAyNTMzNzZjMzhjMDkwZDU4NWJkYTRiMjBiODAxZTNhYTNjZTMM Sample Failed Build: https://ci.chromium.org/b/8857616434338832304 Sample Failed Step: compile Original change's description: > Add [[clang::nomerge]] attribute to ~CheckError(). > > To disable merging multiple ~CheckError() destructor for accurate crash logs. > > Bug: 1153188 > Change-Id: If6d153661667a63f13b645f6d284eb3d5ea3a300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611331 > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Zequan Wu <zequanwu@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844989} Change-Id: I8909aed272fc0c480f07a6c607f1ca5f65343c9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639533 Cr-Commit-Position: refs/heads/master@{#845015}
-
Sorin Jianu authored
This allows the Configurator::InitialDelay function to return sub-second values for unit-testing and functional-testing of //chrome/updater. The code in the CUS service was changed to convert from double to a TimeDelta. Also, the Configurator code was changed to parse a literal to double. Where possible, the type was changed from int to double. In general, the standard conversion from int to double is used (for instance in unit tests). It's possible that there might be cases where a truncation from double to int occurs (because these call sites were missed) but this should not create an issue at runtime because the values involved in the initial delay are small. Bug: 1144151 Change-Id: I66d00c4d4c7bdf241465129619a6c20fd8c895db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635022Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845014}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7e836cee99b..e0fe62adaa3e 2021-01-20 mtklein@google.com use fourth arg in store128 2021-01-19 johnstiles@google.com Add GrSL enums for uint3 and uint4. 2021-01-19 herb@google.com pull out clip code that will be shared 2021-01-19 jlavrova@google.com Include placeholder widths in minIntrinsicWidth 2021-01-19 brianosman@google.com Reland "Support indexing by loop variables in SkVMGenerator" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I875cb4f5a316d4303112058bdf251f4e9b3d35b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638250Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e75ecf38f24b..7acbae90a490 2021-01-20 tsepez@chromium.org Only instantiate XFA when installing FormFillEnv. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Idde10cefa91870e1b58f0da267211f94758ac783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637090Reviewed-by:
-
Edward Lesmes authored
Bug: 1167342 Change-Id: I28b78f16f53c8b997c1d30c53ff9049135be5d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634012Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#845011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6bed55becc6..06576b56764f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128105,chromium:1150968 Tbr: yhirano@google.com,dbertoni@google.com Change-Id: I8a1fca691c1139e85a555b0c2dbeb62bc1162f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845010}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611078768-7ecf7fe9cdf533d2ba0fd4fcea641cfa29b8dba9.profdata to chrome-win64-master-1611089910-e382f188ebed1bc5635a69a9ec6a180850db4c4f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic4087f2c5fe23ffd8cbedae8c3394716a8ca068d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637087Reviewed-by:
-
Michael Thiessen authored
Implements LaunchCauseMetrics for the Search and Bookmarks widgets. Bug: 1163961 Change-Id: I87427a11be245fbb990377cf02da00b408c8fe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635447Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845008}
-
Sorin Jianu authored
Change-Id: I7a62bd6ff4a0758f6d0553463021280313499385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588288 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Jing Wang authored
1. Uprev mojo api of grammar check from chromeos. The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2611147 this change need to be submitted after it. 2. The new api will return correction fragments, so update the service client accordingly, now the grammar correct results are parsed from fragments. 3. Don't show grammar error when the proposal is to delete the whole sentence, i.e. when result->candidates.at(0)->text.empty() is true. 4. Update unit tests, in ServiceConnectionTest, move LoadGrammarModel test before soda test so that it won't crash. Bug: 1132699 Test: Passed unit tests, also manually tested on nocturne. Change-Id: I85529f3a26f134e5eea7785bae5ac9c7f9e776f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612788 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#845006}
-
Caitlin Fischer authored
The server-side config shows that this study has ended. Bug: 1126640 Change-Id: I49732d19f6bd15e020cda40c6745094a6ac25478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632205Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845005}
-
Fabrice de Gans-Riberi authored
In https://crrev.com/c/2613649, a call to google_apis::SetAPIKey() was added in the main() function. However, there is no AtExitManager registered by that point, resulting in a crash in builds with dchecks enabled. This moves the call to google_apis::SetAPIKey() to be done in WebEngineMainDelegate::BasicStartupComplete() instead. Bug: 1168325 Change-Id: Iee034fb20c7d4d8563cbd9973943d87339619b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638634 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845004}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6181c222..69c461e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2c946eb187217d7150ecefe9c0fec90262a020f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845003}
-
Andrey Kosyakov authored
... for a user-agent override to be applied. BUG=1070568 Change-Id: Ifba5b72b15d9edd2f14e9a0c7f9860e15fa6f3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628313 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#845002}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611078768-a6f5b9bbbe47c14760aa754313a33dbc3d6dd128.profdata to chrome-win32-master-1611089910-6a1c1563417281aed9ef8f312b971a0aa6f126b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d23f2eed17a8d05e7de6f6d0fe1b573dcf555fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637536Reviewed-by:
-
rajendrant authored
Fixed: 1165194, 1165048 Change-Id: I59df4e483b19762baad1c005adf8a5e31de93c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634862 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Zhenyao Mo authored
This reverts commit c2dd88a3. Reason for revert: broke Meet on Mac Canary, crbug.com/1168301 Original change's description: > Remove the enabling of RTP data channels. > > This is the minimum change to prevent the use of RTP datachannels in Chrome, > designed to be easily rolled back if needed. > > Feature link in Chrome dashboard: > https://chromestatus.com/feature/6485681910054912 > > Bug: webrtc:6625 > Change-Id: I19c78f703c8e322d8fa21c120c255942cd2bbd3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632953 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844489} TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:6625 Change-Id: I3cea1636b68ee206c5107a1a8d2c55404236028e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638598Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844999}
-
Luciano Pacheco authored
This is a preparation to run the foreground page as JS modules. Bug: 1133186 Change-Id: Iad424b0d91985015bc1cf746866c996c3334fe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637167 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844998}
-
Hiroki Nakagawa authored
This CL... - adds "Trigger" in the terminology section in README.md. - adds how to watch relevant code changes in README.md. - removes the no_state_prefetch directories from the WATCHLISTS entry for prerendering. The new prerendering implementation deviates from the NoStatePrefetch implementation. Probably watchers are no longer interested in changes for them. Bug: 1126305 Change-Id: Ia07a60f1ae0c6f26de54c4cfa75dadf64386b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636979 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#844997}
-
Victor Costan authored
The method currently follows an unfortunate maybe-async pattern established in //net whereby operations may either report an outcome synchronously by returning a net::Error other than net::ERR_IO_PENDING, or report the outcome asynchronously by invoking a callback. This CL changes the method to unconditionally run the callback with the operation outcome. This is intended to simplify the mental model and control flow around the method. Change-Id: I4337cb5e93820596510b02c0b6bde75a6f3111f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632853Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844996}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/tether. Bug: 1148570 Change-Id: Ic3b780c5714af71aae25691f77aad3fb69f5986d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638571 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#844995}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I1023b188d5cd372654f9f843e23f8000792885b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639394Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844994}
-
Sam Goto authored
The idp_endpoint property today of the .well-known/webid response is now taken as an absolute URL, which makes it inconvenient for deployment. In this CL we resolve the idp_endpoint URL as a relative URL to the file that it is contained in, allowing both absolute URLs and relative URLs to co-exist. Bug: 1141125 Change-Id: I224274634e5eaf7f7d66d044931fe5823f346829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631295 Auto-Submit: Sam Goto <goto@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844993}
-
Jan Krcal authored
This CL fixes a regression that (for both the old and the new design), light mode illustrations are used when in dark mode. This happened by moving the dark mode css into one selector in the beginning. This CL moves that till the end of the css to get precedence over the light mode css specified before. Bug: 1167092 Change-Id: I04783bb5aa34794c107cc846017accb140dea692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632680 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#844992}
-
Dale Curtis authored
A review of similar Blink classes shows we should be returning nullptr during the ::Create() method if there are exceptions. I've updated the fuzzers to handle a null return value here now. Fixed: 1167511, 1167532, 1167534 Change-Id: Idbbfaeac2e93eb1f4b8f02ad880724ac5454eac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638397 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844991}
-
