- 06 Jan, 2021 40 commits
-
-
Collin Baker authored
This reverts commit 3482d6ea. Reason for revert: foreign-object-scale-scroll.html failing https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests Original change's description: > [blinkpy] Re-enable a few more tests that were blocked on crbug.com/997202 > > Bug: 997202 > Change-Id: I670d9134fc8770c58f8688366a16830ba9a6435e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575454 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840635} TBR=kevers@chromium.org,smcgruer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ife0806922968b2f63b83e6ee9edd271cca86c5ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612272Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840712}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iaf1ae3de53d63ed588047d95dc6758c236734f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611451Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#840711}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3fcecc11721e..e61dbc5cf5aa 2021-01-06 tmathmeyer@chromium.org Add new properties to media tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If044999edadbeaf2b4dea461325acf03b1b7dedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612832Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840710}
-
Leonid Baraz authored
Key pair is generated by the test; production server will retrieve private key from KeyStore, and client will use a hardcoded public key that matches the Keystore key. Bug: b:170054326 Change-Id: I676dc48871af75e6a1733ee1d345460e6708d38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611901 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#840709}
-
Collin Baker authored
Bug: 1163577 Change-Id: Ic2fdffaea5c8d2e892c20e7ad91e7da9ae75a352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611410Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#840708}
-
Dominic Farolino authored
R=tbansal@chromium.org Bug: N/A Change-Id: I60b210735b1659b3a1a3354f2a3639dbea3162d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613236Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#840707}
-
Elly Fong-Jones authored
This change: 1) Fixes two broken links in the document 2) Removes code fragments from the markdown headers, which gitiles can't render Bug: None Change-Id: Iec8f63a049818aaf8c8f6dec88e7a1a342b58919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611454Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#840706}
-
Tom Anderson authored
The event queue is never cleared, so if any events are requested, they'll leak memory. This CL adds a check to ensure no events were ever pending. It's added as a CHECK(), not a DCHECK(), since we want to receive crash reports if users with untested GPU drivers ever hit this. Change-Id: I2aa2fd9f88a1637deff5e81996de71c1d5956e0f Bug: 1158170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602704 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840705}
-
Matt Reynolds authored
Blocks access to certain proprietary functionality. https://github.com/WICG/webhid/pull/47 Bug: 1163593 Change-Id: I42dc674242823da0534456341f8bbbcdb38a5fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612486 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#840704}
-
Collin Baker authored
The test is flaky on ChromeOS debug and ASAN builders. Bug: 1163575 Change-Id: Icde3cd9a8e3bbaadd7db7e914daa676ec94fbadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612287Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Feature is fully launched and histograms are no longer needed. Fixed: 1153727 Change-Id: If95d1aafe776b9ff94bbf1f9871772c79d9d4dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605569 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#840702}
-
Ana SollanoKim authored
flow items 1. Function ResolveOutOfFlowItemGridLines: The column and row span of the grid area for the out of flow item is obtained through GridPositionResolver, and the grid lines of the out of flow item are computed. 2. Refactor of CacheItemSetIndices: For in flow items, computation of the set indices remains the same. To compute the indices for out of flow items we take into account the following: a. If both the start and end line of the out of flow item are not 'auto', then the indices are computed as if they were in flow items. b. If either is 'auto', then its value is kNotFound. c. If either is attempting to create a new line in the grid, then they are treated as 'auto'. 3. Helper method ComputeOffsetAndSize: the computation of the offset and size of each item was generalized to include the cases where either or both of the set indices are auto in out of flow items. Additionally, inline and block edges are computed. Bug: 1045599 Change-Id: I15b680d1866cdb81b42d626bcd6948ae1b7132ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567573 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#840701}
-
Sorin Jianu authored
Bug: 1163382 Change-Id: I1ab7013e108e8d7a39ebf73b55606c7043a43654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612507 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#840700}
-
Sushma Venkatesh Reddy authored
We need to ensure that libgav1::kSuperResScaleNumerator is 8 so, a static_assert is added to guard it. Bug: b:175897728 Test: NA Signed-off-by:
Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com> Change-Id: I32352d2c8f6c7051f4d7bf2dfbaad134dcc7634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611502 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#840699}
-
François Beaufort authored
This CL has no functional changes. Change-Id: I19fb4d5803f6c1ac552605491d330199599ec09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613045Reviewed-by:
-
Shimi Zhang authored
We already have the handle direction information in OnSelectionBoundsChanged(), so we don't need much modification to it. Instead, we just need to check if there is an end that equal to the previous one to decide we should show magnifier for which end. Magnifier needs to know about which selection boundary was changed, so we could show Magnifier for that boundary, this change fixes the case that when the boundary is changed, the Magnifier wasn't moved to the correct boundary. Bug: 1157372 Change-Id: I6fd7b4f1b145aef733120225ed94a1be91f20bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601111Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840697}
-
Alex Ilin authored
This is a reland of 9b04f2c2 Original change's description: > [profiles] The profile picker supports the force signin policy > > This CL removes the restriction that disables the profile picker if the > force signin enterprise policy is enabled. > > Force signin dialogs will be hosted by the profile picker if the > corresponding feature is enabled. > > Bug: 1156096 > Change-Id: I19ec58afc7a451fbd868eae5e3d8d13899e78719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595412 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840575} Bug: 1156096 Change-Id: I6fa37f9374cbbdfe413d835bc2e858b6374d37f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613147Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840696}
-
Ian Clelland authored
This flag was previously used to control a collection of semi-related features to do with policies-for-performance and layered APIs. Import Maps are no longer dependent on this flag. The various policy flags (unoptimized images, unsized media, layout animations, document.write, synchronous scripting and vertical scroll) have been moved to an 'Experimental Policies' runtime flag instead. Feature Policy reporting is left, but is no longer implied by this flag. Change-Id: I57eb42da8c73b69a2220bc2dd6f877f66ac4507c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597845 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840695}
-
Alexander Surkov authored
Support --chrome/--chromium/--firefox selectors. You can do out/Default/ax_dump_tree --chrome. Bug: 1160279 Change-Id: Ibc9310a58d479a505134d17534c810aeb5d3f16c AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598576Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#840694}
-
Jarryd authored
* Add method to get a test file path * Add method to read and parse a csv file * Move test cases into platform specific csv files * Pass in test cases to parameterized test using new methods Follow up work: * Implement a way to ignore tests per-platform - this will allow us to move the common test shared on all platforms except CrOS into the "all" test file, and remove it only on CrOS. Bug: 1145240 Change-Id: I06518f51cd7d40c844753694be5d580ddf4fdd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599760Reviewed-by:Daniel Murphy <dmurph@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840693}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609923503-082d3636d9b7f0ebc97af69fa1fe05452441e219.profdata to chrome-win32-master-1609945018-bd62f654af21e53a7b023fe22e6c76c3ab0d03ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4bbd699761f6b8e10373e67b6f9b7d8f66e308cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613234Reviewed-by:
-
David Maunder authored
Speedup: 6011ms -> 1404ms (76.64% speedup) Bug: 1163254 Change-Id: I812fae55b008b331c4ad07d2f0e36d85da221cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611867 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#840691}
-
David Roger authored
This CL changes the way DiceInterceptedSessionStartupHelper adds the account on the web. Previously it was mostly waiting for the reconcilor to trigger, and making sure that the process is not stuck (by forcing calls to list accounts). The new behavior is more proactive: when the profile is new, it blocks the reconcilor and forces a call to multilogin directly. The advantages are: - it is easier to control and hopefully it should be less brittle. - it should be faster: * the previous flow was doing an extra /ListAccounts call after the reconciliation, which is now removed * the previous flow was using MergeSession while the new flow uses multilogin, which should be faster on desktop (no need to fetch an access token) When the profile is not new, it's not possible to simply use multilogin, as there may already be accounts in the profile. The reconcilor is still used in this case, as it has the logic to handle this. Note: it would be possible to use MergeSession instead of Multilogin, as this would work for all profiles (including existing profiles). However MergeSession is now discouraged and thus we avoid adding a new usage here. This CL also improves histograms. Bug: 1151313 Change-Id: I4871eb123eb37081595164bd5280adf2b0b1290b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600909 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840690}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cee13faaf357..ca7d9ee2a720 2021-01-06 fmayer@google.com Merge "Remove AHeapProfile_initSession from public header." 2021-01-06 treehugger-gerrit@google.com Merge "Fix skipped test being marked as [FAIL] in logcat." 2021-01-06 treehugger-gerrit@google.com Merge "ui: Make "f" slice focusing work for instant events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I747179222ee780c8601fd810932c1e655db10c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611207Reviewed-by:
-
Nick Diego Yamane authored
The case where the entered surface in a drag session (through wl_data_device::enter event) is suddenly destroyed at client-side, was not being properly handled, causing use-after-free crashes. This fixes it as well as adds a unit test to prevent future similar regressions. Bug: 1143707 Test: ozone_unittest --gtest_filter='*WaylandDataDragControllerTest.*' Change-Id: I0fb0b7abbc257398c3a114f1c2d438ecc8d9adf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593572 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#840688}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8ef860714479..a8b962b78978 2021-01-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 481852c5 to 38610c88 (120 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I4daf7fec2227c9fb8fea83f3d818a10da267ac1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611123Reviewed-by:
-
James Hollyer authored
To support the new XBox Series X controller over usb we simply need to recognize the device id as an XInput device. The reports are identical to an XBox One controller so we recognize it as one and it works. This does not work on macOS because the device seems to need some initialization that is not provided by macOS. Bug: 1147578 Change-Id: I494835535d4e3f9dd4bbed657fef2f3e15acbeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612116Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#840686}
-
Reilly Grant authored
In all implementations this method does the same thing as Disconnect() but doesn't accept a callback parameter. This patch unifies them. Bug: 1151533 Change-Id: I64b78257af1e1971a6ab2fb5b70592726eb9f7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597830 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840685}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609934346-02960af12c9c6cfb124c9f1bb5033b3eb2b936e3.profdata to chrome-win64-master-1609945018-70431859900ba317039e4e8fedf6f4732373dd6e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a6a72f369610e59e004623f021576a45c6ab1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613233Reviewed-by:
-
adamta authored
Animates the NTP's fake omnibox to adjust its width and add a separator when the NTP is scrolled. Refactors headerSynchronizer and moves it from ContentSuggestionsCoordinator to NewTabPageViewController. Refactored synchronizer includes additionalOffset property to compensate for offset header in the refactored NTP. The omnibox sticking to the top of the NTP will be added in a follow-up CL. Bug: 1114792 Change-Id: Iebb1e7ae9a23772bf03d8cfedb5aed3b0ca16762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611286Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#840683}
-
Jeffrey Cohen authored
Bug: 1161331 Change-Id: I0377693c7cd63bef7d986b7474df1722c2119c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601049Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840682}
-
Colin Blundell authored
This CL incorporates Chrome's adjustment of subresource filter page activation decisions based on content settings within WebLayer. To do so, we have the shared SubresourceFilterSafeBrowsingActivationThrottle directly invoke the logic in question rather than having ChromeSubresourceFilterClient do so. That change necessitates some others, also made in this CL: - WebLayer brings up ProfileInteractionManager. - SubresourceFilterClient provides an accessor for ProfileInteractionManager. - SubresourceFilterSafeBrowsingActivationThrottle calls the adjustment logic via a new Delegate interface rather than doing so via SubresourceFilterClient. This interface is implemented by ProfileInteractionManager in production while allowing for porting of tests that provide custom (or nil) stub logic. We also add browsertests of this interaction in //weblayer. Note that this CL does not do any incorporation of the relevant *UI* for content/site settings of ad blocking in WebLayer; that will be followup work. Bug: 1116095 Change-Id: I394e62f12d5209a4302ffa57de9095c861b59613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603574 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#840681}
-
Nazih Almalki authored
Change-Id: I16c2ff2d6aea8a8b2195b6e4c77cd4c143821658 Bug: https://crbug.com/956695 Change-Id: I16c2ff2d6aea8a8b2195b6e4c77cd4c143821658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611308 Auto-Submit: Nazih Almalki <nalmalki@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#840680}
-
Victor Costan authored
Chrome's googletest version exports testing::DoAll to the global namespace. The master version does not. This means that Chrome does not compile with the master version of googletest. This CL fixes Chrome's tests that use testing::DoAll without a "using" statement, unblocking rolling googletest. Bug: 1163396 Change-Id: I9778cee59dc4476bcd586a8592949068f696b6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611843Reviewed-by:
-
Yue Li authored
Bug: b/175747630 Test: None Change-Id: I48729ab6e3105a829f1338517cb1796bd70a8e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612517 Auto-Submit: Yue Li <updowndota@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#840678}
-
Brian Sheedy authored
Removes expectations for the webgl_conformance suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 1155766, 1018028, 1110111, 979444, 1105129 Bug: 685232, 772037, 825338, 1023745, 478572 Bug: 931006, 951628, 626524, 630860, 898674 Bug: 829389, 680754, 750896, 825416, 737018 Bug: 680754, 829389, angleproject:4539, 728670, 690248 Bug: 653533, 415609, 617148, 992224, 703779 Bug: angleproject:3741, angleproject:2939, 1020295, angleproject:3481 Bug: angleproject:2926, angleproject:4569, 1017162, 974347 Bug: angleproject:4286, 599272, 928926, 1108676, 1154745 Bug: 1018028, 886970, 635081, 992313, 871352 Bug: 948218, 1027776, 1059760, angleproject:4846, 1021428 Bug: 524144, 596622, 703779, 918995, 550989 Bug: 965594, 1028639, 1060632, 1081973, 1143323 Bug: 907512, 733599, 611943, 709704, 1098311 Bug: 920737, 912161, 793050, 818041, 1135659 Bug: 716496, 891456, 934545, 1043431, 1135785 Bug: 912161, 891456, 798117, 606096, 912161 Bug: 891456, 478572, 845411, 845438, 995652 Bug: 981579, 906724, 1081973, 1136106, 1145830 Bug: 1042897, 1114284, 1119939, 1102991 Change-Id: I6fc4058996d2c20513310f174256c5b7cfe388af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593183Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#840677}
-
Tanmoy Mollik authored
Adds a histogram that records number of android accounts present on device even if the user isn't signed in. Bug: 1025410 Change-Id: Ide66597ea3da5857e6f7ccd5bec018b54ebc03e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607306Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840676}
-
Hongbo Song authored
UKM privacy review: https://docs.google.com/document/d/1DpX7LvTIAzXPP3KUOlEeGpwrzAH3eVFH0vE0w3-RNpM/edit?usp=sharing Change-Id: Ie175254aa965ec7529506eebea4f90fdaba462f4 Bug: 1139533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533590Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#840675}
-
Willie Koomson authored
This change modifies ArcVmClientAdapter to start ARCVM before login (to implement mini-ARC). Among the changes are: - Starts mini-ARCVM with a generic user kArcVmDefaultOwner - Sets correct owner id during UpgradeArc() - Stops VM if UpgradeArc() fails - On StopArcInstance(), checks if mini-ARC or full ARC is running - Update unittests BUG=b:144542975 TEST=ArcVmClientAdapterTest unittests TEST=tast run <DUT> arc.Boot.vm crostini.Basic.buster_amd64_stable TEST=build and flash. On login screen, check chrome log and syslog to make sure ARCVM has started successfully. Check guest logcat and make sure init is blocked on arcvm-boot-notification-client. After login, check that instance is upgraded successfully and Play Store is able to start. Change-Id: I190a9ede041b53f0dbcb1773ea82b2e0ac51ae54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354623Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#840674}
-
Tibor Goldschwendt authored
We are still using them. Specifically, this CL extends the following histograms: * NewTabPage.BackgroundService.Collections.RequestLatency* * NewTabPage.BackgroundService.Images.RequestLatency* * NewTabPage.CustomizedShortcuts * NewTabPage.CustomizeLocalImageBackgroundAction * NewTabPage.CustomizeShortcutAction * NewTabPage.LogoDownloadOutcome * NewTabPage.LogoDownloadTime * NewTabPage.LogoImageDownloaded * NewTabPage.LogoShownTime2 * NewTabPage.Modules.ShownTime * NewTabPage.Modules.Usage* * NewTabPage.Promos.RequestLatency2* * NewTabPage.RecipeTasks.RecipeClick * NewTabPage.RecipeTasks.RelatedSearchClick * NewTabPage.ShoppingTasks.ProductClick * NewTabPage.ShoppingTasks.RelatedSearchClick * NewTabPage.TileTitle* * NewTabPage.URLState Fixed: 1151982, 1156215, 1151981 Change-Id: Id31e792fe3d4b205ea8d1fd1ea5f17d9c5f4157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611634 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
