- 04 Nov, 2019 40 commits
-
-
Dana Fried authored
This is a prerequisite to fix the issue with restored tabs not always creating a renderer in response to incrementing video capture count. Bug: 1020782 Change-Id: Iba656d0fb3810073ea92212b28a309f16dbf922f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896305Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712299}
-
Matthew Mourgos authored
This ensures that hotseat background blur is disabled when the blur features is disabled. Bug: 1017526 Change-Id: I291a55a3a7b47492b3c12f6f67239224a322ec5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888404Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712298}
-
Khushal authored
Currently MSAA is controlled using a global switch for all layers which is enabled based on whether currently painted content on any layer has slow paths. Switching this state tears down all tile resources, both on pending and active tree. As such this switching can be quite expensive since we need to re-raster the entire visible viewport and causes jank, because the active tree can not be redrawn until its tiles are ready. For a long scrolling page where only some content of a layer has slow paths, this switching can occur each time this content scrolls in and out of the interest rect. Avoid the above by allow MSAA to be applied on a per layer basis. Since the decision changes only when the painted content of a layer is updated, which should already be invalidated in that case, this avoids any unnecessary raster invalidation. R=ericrk@chromium.org Bug: 1013758 Change-Id: I00678d21abb09b00c1246246076ee1a4e50d1822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891746 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712297}
-
Matt Jones authored
This patch allows dialogs to show above the bottom sheet if the content is using a custom scrim lifecycle. This implies that the user is allowed to interact with the web page while the sheet is open. Bug: b/143869922 Change-Id: Ie2836b6f6f650df6f6061c0f67b49eede3de57e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897858 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#712296}
-
Simeon Anfinrud authored
Initialize() and Finalize() are no longer needed. We can use the constructor and destructor instead. Bug: Internal b/138210964 Test: cast_base_unittests Test: internal cast tests Change-Id: Iadaf1999e129167fd94f3d504aac914ab3838f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896760 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712295}
-
Antonio Gomes authored
This CL is a preparation step to being able to move this file to Blink, and then removing the whole directory. Basically: - it removes WebRtcAudioRendererTest inheritance to AudioDeviceFactory, since it is used solely to override AudioDeviceFactory::CreateAudioRendererSink(). Instead of the explicit override, which is called by explicitly by AudioDeviceFactoryTestingPlatformSupport::NewAudioRendererSink(), the CL just creates the needed media::AudioRendererSink instance directly in AudioDeviceFactoryTestingPlatformSupport::NewAudioRendererSink() and return it. - the rest of the CL adapts expectation checks related to WebRtcAudioRendererTest::MockCreateAudioRendererSink() with using AudioDeviceFactoryTestingPlatformSupport::MockNewAudioRendererSink() and some gtest tricks (eg testing::SaveArgs<>, and testing::InvokeWithoutArgs). This way all original checks are kept! R=guidou@chromium.org Change-Id: If517cb2ea413359bcd80ca3e25e3d91b1e3a12ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888555 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712294}
-
rbpotter authored
Try computing the root directory for source files based on the path to polymer.py instead of the current working directory. This is more similar to the path logic in optimize_webui.py. Since so far this bug cannot be reproduced locally, this fix is speculative. Bug: 1021119 Change-Id: I8176283912650f0f44df05308d119d32c3fedc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898101Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712293}
-
Dana Fried authored
Previously, the placeholder image could be shown for a frame or two while the hover card is sliding between tabs, while we're waiting for the uncompressed version of a cached thumbnail image. This change keeps the old image around instead (leading to a more smooth hover card transition as a side effect). Change-Id: Iecc3f7f31616906c7c9a9d9b62cea31b67cf5f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896240Reviewed-by:
-
Andrew Grieve authored
It contains fixes for the patches we've made to it, and has also added support for JDK 11. Bug: 693079 Change-Id: I0b9c9c0e5ed396ea3994c931513fd6a5af617454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882304 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712291}
-
Tricia Crichton authored
Added LocationContextTests to READY_TO_RUN_FILTER because the function is now implemented in W3C mode. Bug: chromedriver:3180 Change-Id: Id56ec483c2534a0df8bfda71284962c62b7e70a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898172Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#712290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/486508d8c322..5364042c0287 git log 486508d8c322..5364042c0287 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 engeg@google.com paygen: Add a max concurrency option to MemoryConsumptionSemaphore 2019-11-04 lamontjones@chromium.org Increase paygen cache size Created with: gclient setdep -r src/third_party/chromite@5364042c0287 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7123a5408f2e4f9f10d3d9a59e265e16aeafa520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712289}
-
Tricia Crichton authored
Changed the javascript used for GetPageSource to elminate the double lookup of documentElement to resolve issue when the document is unloaded between checking for documentElement and accessing outerHTML. bug: chromedriver:3196 Change-Id: Ie51e575dee144e279fe215da45b8f3ab4725c6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898105 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
-
khmel@chromium.org authored
This allows compare side by side various tracing results and has UI to execute simplified tracing for the overview mode. BUG=b/143532713 TEST=Locally Change-Id: Id0589b5724937441d857e95b547fd3f40d6b6bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897913 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712287}
-
Yi Xu authored
After adding the virtual bot gpu-threaded-compositing, the related flags "--enable-accelerated-2d-canvas" and "--enable-threaded-compositing" are never added properly in VirtualTestSuites. So this virtual bot is not needed for any tests to run or test any special configuration. Change-Id: Ifda247630d94397d0abe40cd59f1ea1272ef7361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898108 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712286}
-
Nate Fischer authored
No change to logic. This renames android_webview::CookieManager methods for consistency: * Use "allow" instead of "accept," for consistency with the network::CookieManager * Use "get" and "set" prefixes for clarity This lets the Java layer be an adapter between the frameworks API method names and the C++ method names. This also adds documentation for SetAllowFileSchemeCookies, explaining why it must be synchronous and what exactly the method guarantees. Fixed: 1020604 Fixed: 1020607 Test: autoninja -C out/Default system_webview_apk (it compiles) Change-Id: If67f226ad771f6fff298b370d4da47770410efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898388Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712285}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0460f06e10cf..c78356feca93 git log 0460f06e10cf..c78356feca93 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 treehugger-gerrit@google.com Merge "processor: Add back ifdefs around json-related cc files" Created with: gclient setdep -r src/third_party/perfetto@c78356feca93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I3228d7e3aabf45cd79839f6caa1ddefdc0c988d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898291Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I955a8cfa9675281a4db60712622980df408a7989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898335Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#712283}
-
chrome://inspectDale Curtis authored
Using a hidden query parameter to do this is a pain. I can never remember if it's trace, tracing, #trace, #tracing, etc. :| bmeurer@ says patches welcome on Twitter, so let's test that :) https://twitter.com/bmeurer/status/1189053658983522305 TEST='trace' links appear by default on chrome://inspect. Change-Id: Id56f97b913652664e0bd7f88ba2b95183fa2b5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896237 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#712282}
-
Matt Menke authored
Merge source include blocks with identical predicates. Also, merge some includes that appear in both linux+android and ios+mac into single blocks. Bug: None Change-Id: Idbcf30822ed23a56951dc2814e073af944682577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893969Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712281}
-
Victor Vasiliev authored
Also, roll src/net/third_party/quiche/src/ 4c908f06d..dfbd3df88 (1 commit) https://quiche.googlesource.com/quiche.git/+log/4c908f06d53c..dfbd3df88865 $ git log 4c908f06d..dfbd3df88 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 vasilvv Create an interface to queue up incoming streams in the client. Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I2fedd99a0a4ce27ccae1a31665a28b9e2f84355a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896861 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#712280}
-
Dale Curtis authored
This reverts commit ef04b24c. Reason for revert: Broke android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6284 Original change's description: > Android: Add @CheckDiscard to proxy native wrappers. > > This will cause compile errors for proguard_enabled builds if generated > proxy native classes aren't fully inlined and removed. > > An example where this would happen is caching the result of > WrapperClassNameJni.get() in a member variable. > > Example errors: > Item void org.chromium.base.MemoryPressureListenerJni.<init>() was not discarded. > Some JNI wrapper classes were not fully optimized. > org.chromium.base.MemoryPressureListenerJni should not appear in a release .dex file. > Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. > ... > > Item void org.chromium.base.library_loader.LibraryPrefetcherJni.<init>() was not discarded. > Some JNI wrapper classes were not fully optimized. > org.chromium.base.library_loader.LibraryPrefetcherJni should not appear in a release .dex file. > Common causes include storing a @NativeMethods class as a member variable or passing a JNI method reference to a function instead of using a lambda. > ... > > Bug: 993421 > Change-Id: I488640859a939d41eed2e44bb01904062942257d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894151 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712239} TBR=agrieve@chromium.org,estevenson@chromium.org Change-Id: I183f15b134a8ba22cc37738c1b00635fb1d9105a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898298Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712279}
-
Yue Li authored
Adjust the order of method calls in OnStartFinished. Replace the early return with a DCHECK. Bug: None Test: Manual Test Change-Id: Ib269c1b98410f6b28ef2805409c1dd9a3d9115b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896244Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#712278}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Id66a601842ad7a66e33c92e65ff9c2f4f36cad37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897483Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#712277}
-
Avery Musbach authored
The present CL modifies SplitViewDragIndicators to have an interface based on workflows, so it is like SplitViewDragIndicators takes responsibility for getting the visuals right, and the code that uses it just needs to provide accurate information about window dragging. The change is primarily a matter of renaming things, but I think it will dramatically improve code readability. Bug: None Change-Id: Ib069db6963a20dcd9c2cf2b15bdf4cebe651e887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896358 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712276}
-
Rayan Kanso authored
Adds a feature flag for using icons in the Contacts API. Also adds all of the piping between blink & mojo, and updates the web tests. Bug: 1020564 Change-Id: I854b1a077792b007f631180d857a8f5abdbb6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895339Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#712275}
-
Jonathan Backer authored
Normally, SkiaOutputSurfaceImplOnGpu is responsible for making a GL context current before any calls into DirectContextProvider (e.g. ImplOnGpu::CopyResult, ImplOnGpu::PerformDelayedWork, ~ImplOnGpu). One exception to this is if there is an asynchronous GLRendererCopier readback in flight as ~ImplOnGpu is called (e.g. for tab picker on Android). Specifically, if either ReadPixelsWorkflow::Finish or ~ReadPixelsWorkflow has not been called yet. This CL does 2 things: 1) It does a glFinish() to guaranteee that ReadPixelsWorkflow::Finish will be called before ~ImplOnGpu finishes. This may cause some jank, but it is the simplest method to avoid a leak of GPU resources for in flight readbacks. 2) It does a MakeCurrent in DirectContextProvider::Destroy to make sure that a context is current when ~GLPixelBufferRGBAResult is called (see [1]). [1] https://cs.chromium.org/chromium/src/components/viz/service/display/gl_renderer_copier.cc?rcl=ec3242c55275c8f1c2ea6ac2a0211c391eba7ddc&l=543 Bug: 1020558 Change-Id: I5092594b879efaedd65f2ed9ee3fce297930d294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898126 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#712274}
-
Dale Curtis authored
BUG=1019671 TBR=mlamouri Change-Id: I26e2ac7d14c49a39fb3a368769dba06903871db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898097Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5883a44b60c6..5cbb77739e8d git log 5883a44b60c6..5cbb77739e8d --date=short --no-merges --format='%ad %ae %s' 2019-11-04 timvp@google.com Vulkan: Increase Fence Wait Time 2019-11-04 j.vigil@samsung.com New end2end test to print EGL information 2019-11-04 timvp@google.com Fix Platform methods list Created with: gclient setdep -r src/third_party/angle@5cbb77739e8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I4b3aa8ebb41cc281b943b327d80cd42e41a03097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898290Reviewed-by:
-
Michael Spang authored
Display sizes with zoom are wrong as the overscan insets are not scaled according to the device scale factor that's actually in effect. This caused ash to draw parts of the shell UI outside of the root window whenever both overscan and zoom are active. Fixed: 1020028 Change-Id: I832a8a8d2dc0c2a4f1702824124759e9d3844917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892056Reviewed-by:
-
Ce Chen authored
provider unittest. Its function base::FieldTrialList::BackupInstanceForTesting() causes flakiness in chrome linux tsan test, e.g. https://screenshot.googleplex.com/NF0rm8HZPhn https://screenshot.googleplex.com/NvL2qn78tLk I've put https://crrev.com/c/1888691 in patchset1 as a reference for code review (in case the previous CL is reverted). Change-Id: Ib34273087bc142df3efd122d13b08879f4b81a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895869Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#712270}
-
Manu Cornet authored
This is a pure refactoring and has no expected user-visual effect. Change-Id: I3d634ec9ca4afbdbaf2341b77027be4ece65502f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894161Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#712269}
-
Andrew Xu authored
Bug: 1021258 Change-Id: Iadc9feebeec1b868bc631f23fe1019c281282073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898467Reviewed-by:
-
Eric Roman authored
(1) HexStringToString() -- decodes into a std::string (2) HexStringToSpan() -- decodes into a span<uint8_t> This enabling simplification for callers that were round-tripping through an std::vector<uinit8_t> simply to make use of the hex decoder. Change-Id: I5a574872c397eaaff13810f3b1e8449b00949a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891452Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#712267}
-
Roberto Carrillo authored
R=sajjadm,liaoyuke Bug: 1020404 Change-Id: I28e27f40aebbc9743da1fa7cc42deb03f77cee13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894619Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712266}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4f27fdc. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" 44cf2759 "[LayoutNG] SVGs with percentage dimensions on child-initiated relayouts" 9b5b02c3 "Support for Canvas and CanvasText system color keywords" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0339d639d76dc078a6fedf4c11a98932f467781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898169Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712265}
-
Elly Fong-Jones authored
The primary goal of this change is to make it easier to reason about the behavior of ExtensionInstalledBubbleViews. In aid of that, this change makes most of the state of ExtensionInstalledBubble (all of it, actually, modulo browser_ not actually being able to be const) const, which guarantees client classes that that state does not change on a given ExtensionInstalledBubble. To achieve that, this change: 1) Defers construction of ExtensionInstalledBubble in ExtensionInstalledBubbleObserver until the extension is actually installed and ready for the bubble to be shown; to do this, the observer class now stores some state needed to construct the bubble later. 2) Factors away ExtensionInstalledBubble::Initialize, moving initialization of every member into a (private) constructor of ExtensionInstalledBubble, since const members can only be initialized this way. 3) Adds a few helpers in an anonymous namespace that compute various bits of derived state ExtensionInstalledBubble needs to store, for use in the constructor's initialization lists. 4) Modifies ExtensionInstalledBubble's browser test to no longer use the now-gone ::Initialize method. One wrinkle is that much of the state of ExtensionInstalledBubble depends on the extension's ActionInfo, but the bubble doesn't need to and shouldn't store that ActionInfo. As such, this change adds a new private constructor that accepts an ActionInfo, and has the public constructor delegate to it, passing in the appropriate ActionInfo. The next CL in this series will make use of this newfound const-ness in ExtensionInstalledBubbleViews. Bug: 1011446 Change-Id: Ib4677914ce74e6cc19570fe006c1bdc948781b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894879 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712264}
-
David Munro authored
Bug: chromium:930901 Test: Launch a container, check metric was emitted. Change-Id: I387b0c3c23637befa9d7d7c26ae167e68f715f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895013 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#712263}
-
Kevin Bailey authored
When an Omnibox line goes to state button-selected, we called OnTemporaryTextMaybeChanged(). We did this because it happened to call SetAccessibilityLabel() and wasn't harmful in the general case. But it turns out to be harmful in some corner RTL cases, so this narrows it to solely the accessibility call. This required adding a sibling virtual method to OnTemporary...() of OmniboxView::SetAccessibilityLabel(). This only affects desktop platforms. Change-Id: If09b6870415522ce69caaf746186b7867611b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895967Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#712262}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0ffe16169665d8ce813c1c919c1a32c6e31fccd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898289Reviewed-by:
-
Christopher Grant authored
This library now pulls in code with partition tags, but isn't itself a partitioned library. This generates build warnings. Work around this by making libchromefortest.so a partitioned lib, but throw away its partitions, as they aren't needed. Bug: 870055 Change-Id: I34813e00b573a28c94c91d1eeaf7573b601e5b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896769 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#712260}
-
