GitLab

This reverts commit 3166ebf7.

Reason for revert: Causing compile failure
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871331944681332016/+/steps/compile/0/stdout

Original change's description:
> Remove unnecessary min_sdk_version from //chrome
> 
> Having these causes apks to disable dex merging, making builds a bit
> slower.
> 
> Bug: None
> Change-Id: I33903834529b5c2e1fec43cb81c3d076ca899055
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367648
> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800658}

TBR=agrieve@chromium.org,pkotwicz@chromium.org

Change-Id: Iaa31715b3e3421a10a87ce0d7699ecd8f5d5dc71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368316Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800665}

crrev.com/c/2339787 refactored the UMAs tracking VAAPI errors, but
had a few naming inconsistencies/mistakes. This CL fixes those.

Bug: b:162962069
Change-Id: I820565cb94c61b33be73b0f8301205a0c3308a8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367734Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800664}

This change implements the following edits to the Fetch spec:
https://github.com/whatwg/fetch/pull/560
https://github.com/whatwg/fetch/pull/1076

Existing web tests cover the new functionality.

Bug: 847428
Change-Id: Ie63704769e99d4b8d26d8903edf4cc4e3466c124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339761
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800663}

Modules currently have a fixed height of 150px. The
Kaleidoscope module is taller so we should update
the height to match.

Change-Id: Ic6cd15e6b9ec9b66a52d69a9ded7e85430687128
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364772
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800662}

This histograms_index file will be used by the histograms expiry job. As
we split up histograms, we need a way to locate all available histograms
xmls and thus we need this index file.

This cl also adds a PRESUBMIT check to make sure this index file is
up-to-date.

Bug: 1116807
Change-Id: I59844e10a15f053e9435f1a6c9bb85445ddf8718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368140
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800661}

When a user highlights an active desk in overview mode, ChromeVox
announces "Desk 1 (Active Desk) ...". However, when a user highlights
an inactive desk, ChromeVox announces "Desk 2 ...".

To make it more clear that the inactive desk is inactive, this CL adds
an indication that the desk is inactive. I.e. ChromeVox now announces
"Desk 2 (Inactive Desk) ...".

Test: manual
Bug: 1111988
Change-Id: I7e47ecd923fbfd2d7f8fe86531a03c87419cf23d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364558Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800660}

... CompromisedCredentialsManager

Bug: 1108422
Change-Id: I750c63612bb68b9156b89fe2f7b4961f324a3067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367099Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800659}

Having these causes apks to disable dex merging, making builds a bit
slower.

Bug: None
Change-Id: I33903834529b5c2e1fec43cb81c3d076ca899055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367648Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800658}

This reverts commit f05ab16d.

Reason for reland: Repro'ed locally. Increased -Xmx flag.

> > > Original change's description:
> > > > Add -noverify to build commands to improve runtime (local builds only)
> > > >
> > > > The flag is guarded by treat_warnings_as_errors=false so that it
> > > > will apply only to local developer builds.
> > > >
> > > > Results from //tools/android/build_speed/benchmark.py base_java_sig:
> > > > With change:
> > > > base_java_sig: 68.0s avg (68.8s, 67.2s)
> > > > base_java_sig: 68.4s avg (68.6s, 68.2s)
> > > >
> > > > Without change:
> > > > base_java_sig: 69.4s avg (69.3s, 69.5s)
> > > > base_java_sig: 69.7s avg (69.7s, 69.7s)
> > > >
> > > > time out/Debug/bin/run_base_junit_tests:
> > > > With Change:
> > > > real 0m22.741s
> > > > real 0m23.543s
> > > >
> > > > Without change:
> > > > real 0m23.176s
> > > > real 0m24.328s
> > > >
> > > > Bug: 1117222
> > > > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299
> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > > > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#799285}
> > >
> > > TBR=wnwen@chromium.org,agrieve@chromium.org
> > >
> > > Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1117222
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493
> > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#799471}
> >
> > Bug: 1117222
> > Change-Id: Ib43bfe72869def7da43b237360df0e155149a963
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363975
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Commit-Queue: Peter Wen <wnwen@chromium.org>
> > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#800233}
>
> TBR=wnwen@chromium.org,agrieve@chromium.org
>
> Change-Id: I0d617bcfc7a311bfae743445fccaaab26364511e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1117222
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368541
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800435}

Bug: 1117222
Change-Id: I48b3b0349490241cca1d7d7aa33004ed55bf887f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368928
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800657}

Bug: 1109373
Change-Id: If658d897a110ffc266b1dc96648fa7b626aa3466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367977Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#800656}

The hyphenation language alias map in AOSP was updated and
moved to native in CL[1]. This patch changes the map in Blink
to match the one in AOSP.

[1] https://android.googlesource.com/platform/frameworks/base/+/f90c9b6437304d95344a1b29448ed1a0f2b95f76


Change-Id: I47471a93d4c56f9623b37dd25182f28f392ba46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359309Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800655}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ce9f3a41..6733ced7

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65578a87505dbff42d25e6ee31a520dd317b72b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367400Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800654}

Bug: 1108422
Change-Id: Ib42812e5f4af6e4d5b346b9612cd03b4713091f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367723Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800653}

Adds the --code-review-system flag to the Android test runner and adds
the necessary code to handle it for use with Gold. This is necessary
because we will be specifying 'gerrit-internal' when running tryjobs
for internal CLs so that Gold knows where to comment if new images are
generated.

Bug: 1077274
Change-Id: I5ce089a511275afed0c06378d9d49e977e330f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366072
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800652}

NOTRY=true

Change-Id: Ic72612b4fded10735379978d3e828aba80888b85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369355
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800651}

Followup from https://chromium-review.googlesource.com/c/chromium/src/+/2361025

Bug: 1116706
Change-Id: I337b41b74d9a74c825d6b83a25eab29891c83008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363705
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800650}

AAC streams require bistream conversion, but it wasn't enabled in
FuchsiaAudioRenderer. As result AAC streams demuxed with FFmpegDemuxer
were failing to play (i.e. when using src="<file>" instead of
MediaSource)

Bug: 1119504
Change-Id: Idf64438ea5127d185c70cfec5272eacaa8521928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363845
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800649}

- Refactor ShareTargetType into public
- Introduce ShareTargetType to advertisement class
- Handle encoding/decoding the device type
- Set device type when creating an advertisement in the browser process
- Pass device type to browser process via mojo advertisement
- Set device type in ShareTarget

Bug: 1114667
Change-Id: Iaa728c231ec5ab53dcf8b3796528a78e39c3a5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367679
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800648}

https://chromium.googlesource.com/catapult.git/+log/7a2e3f83964f..12559f038590

2020-08-21 johnchen@chromium.org [Catapult] Update Node and npm version for tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1119563
Tbr: zhanliang@google.com
Change-Id: I5ec1c46e1beced1af7612167ce76d29be3dbdd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368149Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800647}

On 1909 Windows builds, it looks like the touch injection APIs are
very flaky and thus leading to increased flakiness in the VK API
tests that use touch gesture to show/hide VK and test the VK policy.
In this change I've rewritten all the tests using simulated touch
gesture APIs that don't use system touch injections.

Bug: 1108551

Change-Id: I936f4835cc3688b865ec8f1587c4d8a6eaba2a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368158Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#800646}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I7e61d433f8a1debaba49f52db5a5c71d3cb39cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368441Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800645}

Previously, our query would select all of Internals>Network>* and then
subtract bugs with one of the out-of-scope components. The problem is
this filters out bugs that contain both an in-scope and an out-of-scope
bug component.

The new queries use an additive approach that names each of the
in-scope components directly.

NOTRY=true

Change-Id: I8526c49a38d45d41caa4d53b3c6103d281e7f4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367983Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800644}

enable_run_ios_unittests_with_xctest ensures that the test target
type is ios_xctest_test. However, ie/ ios-beta-device, the unit
tests are actually not run with --xctest flag on.

To allow flexibility, we'll pass the --xctest flag in testing/
buildbot/ if needed, instead of mandating this, and to comply
with downstream behaviour.

Bug: 912681
Change-Id: I36769420792e7959a3e8873551b6968c770d1c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368492
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#800643}

Bug: 1115755
Change-Id: I481a8f6498188681216d13df32ee41436cd1306c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358056Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800642}

This is a reland of feab4f74

Original change's description:
> cros: Add alternate keys for interacting with window cycler (alt+tab).
> 
> Currently a user can only cycle the window cycle list using alt+tab or
> alt+shift+tab. Also, the user can only confirm their selection by
> releasing the alt key.
> 
> This CL improves the interactivity of window cycler by introducing the
> following changes. Pressing the left and right arrows now move the
> selection while the window cycler is open. Pressing enter or space
> now confirms the selection.
> 
>       WindowCycleControllerTest.KeysConfirmSelection
> 
> Test: WindowCycleControllerTest.LeftRightCycle,
> Bug: 1067327
> Change-Id: I03682c5545bf82415b9e71a4814bf5c1b0c196bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358586
> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800423}

Bug: 1067327
Change-Id: Ie05f898abe3565fca603b70450bf3a6d92a9caf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368467Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800641}

Follow-up to:
https://chromium-review.googlesource.com/c/chromium/src/+/2343314
Ensure x11::Connection is only used on a single thread

Due to the above changes, content_shell now uses more X11 connections
per instance than previously. On machines with hugh numbers of cores,
this was causing run_web_tests to crash as the tests it ran tried to
more connections at a time than the default limit (256) of its Xvfb
instance allowed.

Bug: 1120107
Change-Id: Ie31fb509e91a9d7828b5f26f2b3885f857c56e24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368420
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800640}

Removes all references except for md5 and base64.

Bug: 1120190
Change-Id: I33f8f8c6966e22c92b1e6e31e468b23cf6a95354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368422Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800639}

Bug: b/165829625.
Test: manually.
Change-Id: Iabee17198e1887b7498bb01e45c03a133f0df800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352518
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800638}

Using wpt-import in Chromium b4c47b9a.
With Chromium commits locally applied on WPT:
3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()"
9f52c7e4 "COOP: add reporting to redirects"
f3b221b0 "[COOP] access reporting: Extend report.body.type values."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I29ed553bd0719a460d24f8dbac093d2f16c22370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368997Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800637}

First this change gives CupsPrintersManagerFactory access to the both
the OffTheRecord(OTR) and non-OTR guest profile when logged into Guest
mode. Before, using GetBrowserContextRedirectedInIncognito, only the
non-OTR recording guest profile was available to
BuildServiceInstanceFor.

Second, this change filters to only create CupsPrintersManager with the
OTR profile when in Guest mode. The OTR profile is needed by the
UsbPrinterNotificationController to open the System Web App(SWA)
Settings page to configure USB printers. There is a check
(https://osscs.corp.google.com/chromium/chromium/src/+/master:chrome/browser/ui/browser.cc;l=471)
that only OTR guest profiles are allowed to open SWAs.

For the other profile users in CupsPrintersManager, there's no impact
for using the OTR guest profile vs. the non-OTR guest profile.

Fixed: 1116062
Change-Id: Icbc000f36f178cbf30f1a85dbbe94b16cfe1f3b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368234
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800636}

It has been passing since crrev.com/c/2365132 which avoids raster
translation for layers without text. For the test, the layer is the
scroll corner layer.

TBR=wangxianzhu@chromium.org

Bug: 1116681
Change-Id: Id917ef6e094218de552719205362a8cd1a4da027
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367451Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800635}

TBR=bling-team@google.com

Change-Id: I9a3d0673a97fcf4062ea827c9eca1b81e3dc5411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368507Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800634}

This CL does the following things:
(1) Implement a helper function to return the clipboard data's
main type.
(2) Create custom views for menu items.

Note that no UI change is introduced by this CL.

Bug: 1112888
Change-Id: I226411dfc6ccfa4cc7fa59f3adbc7f510f7c7dcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355015
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#800633}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d7508751f4e1..662c01bba296

2020-08-21 tvanderlippe@chromium.org Remove ProtocolProxyApiWorkaround
2020-08-21 tvanderlippe@chromium.org Add durations for individual presubmit steps
2020-08-21 tvanderlippe@chromium.org Update TypeScript to 4.0.2
2020-08-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-08-21 tvanderlippe@chromium.org Manually update DevTools Chromium DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1116989
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6f2e34f6ea6ddd34ee83aec3d540ec6591025887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369170Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800632}

study.

Bug: 973801
Change-Id: I52143c3144fbeea6d822bad965513b0bb3551bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364953
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800631}

LayoutThemeDefault::ActiveListBoxSelectionBackgroundColor were defined,
but not actually used as
LayoutTheme::ActiveListBoxSelectionBackgroundColor (and friends) weren't
virtual. This patch removes these unused functions.

Additional simplify some of the bool switches by:
 - Moving the default behaviour into LayoutTheme
 - Removing PopsMenuByAltDownUpOrF4Key which always returned true.

There should be no behaviour change.

Change-Id: I8b28f2b22dbf986d9d4ba3e02e8ae9c5b5c2a2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369332Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800630}

This CL batches signin.SigninHelperTest.

Bug: 1120258
Change-Id: Ie2b907c070437a2f76005c181763c78db7ea75e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367860
Auto-Submit: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800629}

Change:
Move the following references into CPRImpl, and provides PRImpl with
getters to access them:
* mRenderFrameHost
* mPaymentRequestOrigin
* mPaymentRequestSecurityOrigin
* mTopLevelOrigin
* mMerchantName
* mCertificateChain
* mIsOffTheRecord

Acronym:
CPRImpl = ComponentPaymentRequestImpl
PRImpl = PaymentRequestImpl

Bug: 1102522

Change-Id: I7e501efed0ab8b4ddc061cebe5170e19be99ab73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357630Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800628}

Separating the branch configuration by file has been rather unwieldy and
would only get worse when it is necessary to maintain a 3rd subset of
builders for LTS. This puts the information about what branches the LUCI
resources are applicable to with the resource.

Bug: 1119446
Change-Id: I1c8622b7084fd332ae16fcdc9afe5d6e30dc1811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365915
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800627}

The nested loop process the native events but not the tasks which looks
like a hang if not inhibited.

Bug: 806174, 1120381
Change-Id: Ie298b16a4e0f8cdd6c4ba398d71a7fee02b9d46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369253Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800626}