Commits · 67783d7e77f801a654ec249053abf4996aece0ac · eriksson monteiro / tangled

26 Apr, 2014 40 commits

Remove --disable-accelerated-video and GPU_FEATURE_TYPE_ACCELERATED_VIDEO · 67783d7e

piman@chromium.org authored Apr 26, 2014

These are just compositing triggers. GPU_FEATURE_TYPE_ACCELERATED_VIDEO
is completely ignored, and there's no reason to disable the compositing
trigger since FCM is always on in production.

BUG=362164

Review URL: https://codereview.chromium.org/240253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266354 0039d316-1c4b-4281-b951-d872f2087c98

67783d7e

Cleanup: Mark some CrOS resources as platform-specific. · b726dab1

thestig@chromium.org authored Apr 26, 2014

Review URL: https://codereview.chromium.org/258693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266353 0039d316-1c4b-4281-b951-d872f2087c98

b726dab1

Suppress Errors for chrome.alarm.get · ec57ccfd

robliao@chromium.org authored Apr 26, 2014

Removed the error signalling to prevent log spam from the runtime.lastError
checks for non-existent alarms.

BUG=367136

Review URL: https://codereview.chromium.org/258793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266352 0039d316-1c4b-4281-b951-d872f2087c98

ec57ccfd

gpu: Refactor and cleanup CHROMIUM_copy_texture implementation. · 032c6a30

reveman@chromium.org authored Apr 26, 2014

This removes duplicate shader code, makes it easier to support
additional texture targets and implements on demand initialization
of shaders.

BUG=366710

Review URL: https://codereview.chromium.org/255763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266351 0039d316-1c4b-4281-b951-d872f2087c98

032c6a30

Fullscreen/immersive mode is allowed in touch view mode, the shelf gets hidden... · a4b3d6b5

skuhne@chromium.org authored Apr 26, 2014

Fullscreen/immersive mode is allowed in touch view mode, the shelf gets hidden and an edge swipe brings the shelf back.


Allowing immersive / full screen mode in maximize mode

BUG=359606
TEST=ash tests and visual

Review URL: https://codereview.chromium.org/247363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266350 0039d316-1c4b-4281-b951-d872f2087c98

a4b3d6b5

This CL does small refactoring extension_toolbar_model.cc before removing... · 5ba3b6cf

limasdf@gmail.com authored Apr 26, 2014

This CL does small refactoring extension_toolbar_model.cc before removing NOTIFICATION_EXTENSION_UNLOADED and NOTIFICATION_EXTENSION_LOADED.

BUG=354046
TEST=browser_tests --gtest_filter=ExtensionToolbarModelTest.*

Review URL: https://codereview.chromium.org/256783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266349 0039d316-1c4b-4281-b951-d872f2087c98

5ba3b6cf

cc: Move scheduling logic out of OutputSurface · 3dc0c774

brianderson@chromium.org authored Apr 26, 2014

This moves the vsync throttling enabled/disabled
logic and the synthetic/emulated BeginFrame logic
out of OutputSurface and moves it to the Scheduler.

This then allows us to also remove the retroactive
BeginFrame logic from OutputSurface since the
Scheduler also has retroactive BeginFrame logic.

BUG=246861
BUG=251909

Review URL: https://codereview.chromium.org/221833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266348 0039d316-1c4b-4281-b951-d872f2087c98

3dc0c774

CoreAnimation: Fix download shelf pattern phase · b5556b29

ccameron@chromium.org authored Apr 26, 2014

We should consider having cr_setPatternPhase make
the call to cr_viewBeingDrawnTo, but that has some
layering issues (base versus chrome), and fixing them
would be merge-unfriendly.

TBR=avi
BUG=363750

Review URL: https://codereview.chromium.org/250703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266347 0039d316-1c4b-4281-b951-d872f2087c98

b5556b29

Cleanup: Remove a bunch of unused resources from apps_debugger. · 1924a5e5

thestig@chromium.org authored Apr 26, 2014

Review URL: https://codereview.chromium.org/257823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266346 0039d316-1c4b-4281-b951-d872f2087c98

1924a5e5

Update .DEPS.git · 19554b14

chrome-admin@google.com authored Apr 26, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266345 0039d316-1c4b-4281-b951-d872f2087c98

19554b14

Introduce NonBlockingDataTypeController · a74bfd94

rlarocque@chromium.org authored Apr 26, 2014

The NonBlockingDataTypeController tracks the sync state of
a non-blocking data type and sends signals to its components from the UI
thread.  It is responsible for enabling and disabling sync for a data
type according to user preference and the availbility of the sync
backend.

This CL also includes some changes to the NonBlockingDataTypeProcessor,
which is currently just a stub of what will eventually become
non-blocking sync's model thread component, so that it can be used in
testing NonBlockingDataTypeController.

BUG=351005

Review URL: https://codereview.chromium.org/249843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266344 0039d316-1c4b-4281-b951-d872f2087c98

a74bfd94

Roll android_tools deps to the latest. · 599bdcf9

fdegans@chromium.org authored Apr 26, 2014

Applied IsSystemLibrary patch from aosp.
https://android-review.googlesource.com/#/c/91371/

BUG=

Review URL: https://codereview.chromium.org/254813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266343 0039d316-1c4b-4281-b951-d872f2087c98

599bdcf9

Fix mojo_test_apk build. · 75e99d72

qsr@chromium.org authored Apr 26, 2014

The apk builder doesn't like the EMPTY file in the apk directory, moving
it to .empty solves the issue.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/251373007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266342 0039d316-1c4b-4281-b951-d872f2087c98

75e99d72

Add GN template for generated extensions API targets. · 30c409f3

rockot@chromium.org authored Apr 26, 2014

This adds a new GN template for generating static extensions API
library bundles from sets of schemas. It also adds invocations of
the template for core extensions and apps API targets.

BUG=None
TBR=kalman

Review URL: https://codereview.chromium.org/256453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266341 0039d316-1c4b-4281-b951-d872f2087c98

30c409f3

Fix tabs.cc static initializer issue. · e03dab6c

dbeam@chromium.org authored Apr 26, 2014

R=oshima@chromium.org
TBR=oshima@chromium.org
BUG=362633
TEST=green tree (specifically sizes)

Review URL: https://codereview.chromium.org/259953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266336 0039d316-1c4b-4281-b951-d872f2087c98

e03dab6c

KeySystems: IsSupportedContainerAndCodecs() ignores empty codec. · 90e0914b

xhwang@chromium.org authored Apr 26, 2014

In IsTypeSupported() call, when the codec string in the mime type contains extra
commas, e.g. ",vorbis", an empty codec will be passed into
IsSupportedContainerAndCodecs. In this case, we should ignore that codec instead
of assuming it's not empty.

BUG=362769
TEST=Layout test crash is fixed.
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/254913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266335 0039d316-1c4b-4281-b951-d872f2087c98

90e0914b

Updating trunk VERSION from 1960.0 to 1961.0 · 2f68b644
chrome-release@google.com authored Apr 26, 2014
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266330 0039d316-1c4b-4281-b951-d872f2087c98
```
2f68b644

fixed wrong error type for bug 340752 · 0f7f6c8f

zhaoqin@google.com authored Apr 26, 2014

- replace "UNADDRESSABLE ACCESS" with "UNINITIALIZED READ"

TBR=bruening@chromium.org
BUG=340752

Review URL: https://codereview.chromium.org/256913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266328 0039d316-1c4b-4281-b951-d872f2087c98

0f7f6c8f

Update .DEPS.git · 48a3dac9

chrome-admin@google.com authored Apr 26, 2014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266327 0039d316-1c4b-4281-b951-d872f2087c98

48a3dac9

Revert of NaCl: Update revision in DEPS, r13018 -> r13078.... · 4e55d84e

tonyg@chromium.org authored Apr 26, 2014

Revert of NaCl: Update revision in DEPS, r13018 -> r13078. (https://codereview.chromium.org/249153003/)

Reason for revert:
Breaks official build on chromium.perf waterfall.

FAILED: cd ../../native_client/src/shared/gio; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py -t ../../../../out/Release/gen/sdk/ --arch x86-32 --build glibc_nso --root ../../../.. --name ../../../../out/Release/gen/tc_glibc/lib32/libgio.so --objdir ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib "--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. ../../../src/third_party ../../../.." "--compile_flags=-m32 -fPIC -fomit-frame-pointer -fasynchronous-unwind-tables  -O2 -g -Wall -fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__ \"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\" \"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ \"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\" \"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\"" "--link_flags=-m32 -B../../../../out/Release/gen/tc_glibc/lib32  " "--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-32-so.gio_lib.source_list.gypcmd"
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crtbeginS.o: No such file or directory
collect2: ld returned 1 exit status
../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o ../../../../out/Release/gen/tc_glibc/lib32/libgio.so -Wl,--as-needed ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o -m32 -B../../../../out/Release/gen/tc_glibc/lib32 -shared -Wl,-soname,libgio.so
FAILED: Command '['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++', '-o', '../../../../out/Release/gen/tc_glibc/lib32/libgio.so', '-Wl,--as-needed', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gprintf.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-32-so/gio_lib/gio_mem_snapshot.o', '-m32', '-B../../../../out/Release/gen/tc_glibc/lib32', '-shared', '-Wl,-soname,libgio.so']' returned non-zero exit status 1
FAILED: cd ../../native_client/src/shared/gio; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=gio_lib; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/../../native_client/src/shared/gio; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release; export TEMP_DIR="${TMPDIR}";python ../../../../native_client/build/build_nexe.py -t ../../../../out/Release/gen/sdk/ --arch x86-64 --build glibc_nso --root ../../../.. --name ../../../../out/Release/gen/tc_glibc/lib64/libgio.so --objdir ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib "--include-dirs=../../../../out/Release/gen/tc_glibc/include ../../../.. ../../../src/third_party ../../../.." "--compile_flags=-m64 -fPIC -fomit-frame-pointer -fasynchronous-unwind-tables  -O2 -g -Wall -fdiagnostics-show-option -Werror " --gomadir "" "--defines=__linux__ \"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS BLINK_SCALE_FILTERS_AT_RECORD_TIME \"NACL_LINUX=0\" \"NACL_ANDROID=0\" \"NACL_OSX=1\" \"NACL_WINDOWS=0\" GOOGLE_CHROME_BUILD ENABLE_RLZ \"USE_LIBJPEG_TURBO=1\" ENABLE_ONE_CLICK_SIGNIN \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_INPUT_SPEECH ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" DISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY SYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE \"ENABLE_EGLIMAGE=1\" \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGIN_INSTALLATION=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_FULL_PRINTING=1\" \"ENABLE_PRINTING=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_MANAGED_USERS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" \"NACL_TARGET_SUBARCH=32\" \"NACL_TARGET_ARCH=x86\" \"NACL_BUILD_SUBARCH=32\" \"NACL_BUILD_ARCH=x86\"" "--link_flags=-B../../../../out/Release/gen/tc_glibc/lib64  " "--source-list=../../../../out/gypfiles/native_client/src/shared/gio/glibc-x86-64-so.gio_lib.source_list.gypcmd"
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crti.o: No such file or directory
/Volumes/data/b/build/slave/chromium-rel-mac-builder/build/src/out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/../lib/gcc/x86_64-nacl/4.4.3/../../../../x86_64-nacl/bin/ld: cannot find crtbeginS.o: No such file or directory
collect2: ld returned 1 exit status
../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++ -o ../../../../out/Release/gen/tc_glibc/lib64/libgio.so -Wl,--as-needed ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o ../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o -B../../../../out/Release/gen/tc_glibc/lib64 -shared -Wl,-soname,libgio.so
FAILED: Command '['../../../../out/Release/gen/sdk/mac_x86/nacl_x86_glibc/bin/x86_64-nacl-g++', '-o', '../../../../out/Release/gen/tc_glibc/lib64/libgio.so', '-Wl,--as-needed', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gprintf.o', '../../../../out/Release/obj/native_client/src/shared/gio/gio_lib.gen/glibc-x86-64-so/gio_lib/gio_mem_snapshot.o', '-B../../../../out/Release/gen/tc_glibc/lib64', '-shared', '-Wl,-soname,libgio.so']' returned non-zero exit status 1
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/60425/steps/compile/logs/stdio

Original issue's description:
> NaCl: Update revision in DEPS, r13018 -> r13078.
> 
> Chromium NaCl scripts now uses package_version to extract.
> 
> Now that we have split up the toolchain into multiple tars, we should
> use the package versioning script to manage which tars to extract.
> Unfortunately, currently the SDK uses different directory names compared
> to what the NaCl toolchain directories normally use, so we also must map
> and move the toolchain directories to the SDK ones.
> 
> BUG=365817
> TEST= trybots
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266284

TBR=mseaborn@chromium.org,jvoung@chromium.org,bradnelson@chromium.org,noelallen@chromium.org,dyen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=365817

Review URL: https://codereview.chromium.org/250933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266326 0039d316-1c4b-4281-b951-d872f2087c98

4e55d84e

[Telemetry] Enable adb root on devices. · 1f636d35

tonyg@chromium.org authored Apr 26, 2014

The perf bots aren't hitting this explicitly anywhere and provision devices
seems like the right place for it.

This method outputs a warning, but doesn't fail hard, if root cannot be enabled,
for instance on a user build.

BUG=366697
NOTRY=True

Review URL: https://codereview.chromium.org/255713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266325 0039d316-1c4b-4281-b951-d872f2087c98

1f636d35

Break CrOSTest into subtests. · 20546a32

achuith@chromium.org authored Apr 26, 2014

BUG=None
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/257803010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266324 0039d316-1c4b-4281-b951-d872f2087c98

20546a32

linux: In diff mode, print files with init function that calls 0 initializers. · ffba31a6

thakis@chromium.org authored Apr 26, 2014

clang writes two of these for some reason, and due to the script not
printing these it took me a while to figure out why clang has initializers
for two more files.

BUG=360311
NOTRY=true

Review URL: https://codereview.chromium.org/251873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266323 0039d316-1c4b-4281-b951-d872f2087c98

ffba31a6

Parse DEPS file manually if execfile fails. Some DEPS files pull in a bunch of... · 1a7ff50d

simonhatch@chromium.org authored Apr 26, 2014

Parse DEPS file manually if execfile fails. Some DEPS files pull in a bunch of libraries, so execfile fails. If it does, we'll manually parse out revisions from the vars section.

NOTRY=true
BUG=366392


Bisect could not reproduce a change in the not/valid metric.

Confidence in Bisection Results: 0%

To reproduce locally:
$ echo android-chrome

Tested commits:
         Depot                                        Commit SHA                                    Mean       Std. Error       State    
     android-chrome                    0000000000000000000000000000000000000000                     1.00         +-0.00                  
        chromium                       0000000000000000000000000000000000000000                     0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265919        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265917        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265912        0.00         +-0.00                  
        chromium         http://src.chromium.org/viewvc/chrome?view=revision&revision=265904        0.00         +-0.00                  
     android-chrome                    0000000000000000000000000000000000000000                     0.00         +-0.00                  

Average build time : 0:00:00
Average test time  : 0:00:00

WARNINGS:
  !!! Due to build errors, regression range could not be narrowed down to a single commit.
  !!! Tests were only set to run once. This may be insufficient to get meaningful results.
  !!! Confidence is 0%. Try bisecting again on another platform, with increased repeat_count or on a sub-metric that shows the regression more clearly.

Review URL: https://codereview.chromium.org/256593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266322 0039d316-1c4b-4281-b951-d872f2087c98

1a7ff50d

add 4 unittests to chrome_tests.py · ed47974f

zhaoqin@google.com authored Apr 26, 2014

- add cloud_print_unittests, cacheinvalidation_unittest,
  libaddressinput_unittests, and libphonenumber_unittests
  to chrome_tests.py so they can run under Valgrind or Dr.Memory.

R=bruening@chromium.org, thakis@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/251683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266321 0039d316-1c4b-4281-b951-d872f2087c98

ed47974f

Use AudioProcessing::Initialize(). · 7150b56a

ajm@chromium.org authored Apr 26, 2014

Use this in place of the deprecated set_sample_rate_hz(). Similarly,
switch sample_rate_hz() to input_sample_rate_hz().

TESTED=apprtc sounds as expected with constraints enabled/disabled.

Review URL: https://codereview.chromium.org/259663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266320 0039d316-1c4b-4281-b951-d872f2087c98

7150b56a

Fixed screen capture confirmation dialog to be either system- or window-modal... · ca5e056c

zelidrag@chromium.org authored Apr 26, 2014

Fixed screen capture confirmation dialog to be either system- or window-modal depending on where it got initiated from. Previous implementation created window-modal with no parent window which allowed it to hide underneath its browser window.

Fixed handling of window-modal dialogs. Modal dialogs and their toplevel parent windows weren't properly activated on events (i.e. mouse click) that happen in toplevel parent windows area but outside of the modal dialog.

TEST=added WindowModalityControllerTest.EventsForEclipsedWindows, manual: start go/present/<whatever>, try to alt-tab away from the pop up dialog, try to eclipse it with another browser window
BUG=366956

Review URL: https://codereview.chromium.org/252673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266319 0039d316-1c4b-4281-b951-d872f2087c98

ca5e056c

Fix style in PasswordManager and PasswordAutofillAgent .cc files · a9e390c4

vabr@chromium.org authored Apr 26, 2014

This CL contains only style-related clean-up.
The purpose is to allow other CLs (like https://codereview.chromium.org/231283003/) make whole-file clang-format without inducing many unrelated changes.

Putting Ilya in TBR, because of https://codereview.chromium.org/231283003/diff/200001/components/autofill/content/renderer/password_autofill_agent.cc#newcode280

TBR=isherman@chromium.org
BUG=347927

Review URL: https://codereview.chromium.org/254573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266318 0039d316-1c4b-4281-b951-d872f2087c98

a9e390c4

Non-SFI NaCl: Clean up seccomp for syscalls which return EPERM · 0a4b8695

hamaji@chromium.org authored Apr 26, 2014

- getegid, geteuid, getgid, and getuid now return EPERM
  instead of raising SIGSYS. This simplifies the test code.
- Define a macro for sandbox tests for syscalls which return
  EPERM to reduce the size of not interesting test cases.
- Pass five zeros after syscall number to syscall() so that
  tests will not be flaky due to uninitialized values on stack.

BUG=359285
TEST=nacl_loader_unittests, trybots

Review URL: https://codereview.chromium.org/248633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266317 0039d316-1c4b-4281-b951-d872f2087c98

0a4b8695

Fix SPS/PPS insertion logic in MP4StreamParser. · 4ddd37d8

acolwell@chromium.org authored Apr 26, 2014

The code that inserts SPS & PPS NAL units into keyframes wasn't properly
handling frames that start with AUD NAL units. This patch adds code to
make sure the configuration data is inserted after the AUD NAL units as
the H.264 spec mandates.

I've also added AVC::IsValidAnnexB() DCHECKS to verify that our
code generates proper Annex B data that conforms to the NAL unit
ordering rules outlined in the spec. These DCHECKS caught the old bad
behavior and should help prevent future regressions.

BUG=364925
TEST=AVCConversionTest.NALUSizeTooLarge, AVCConversionTest.NALUSizeIsZero, AVCConversionTest.ValidAnnexBConstructs, AVCConversionTest.InvalidAnnexBConstructs, AVCConversionTest.InsertParamSetsAnnexB

Review URL: https://codereview.chromium.org/246853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266316 0039d316-1c4b-4281-b951-d872f2087c98

4ddd37d8

Undo the recent stress changes to the context loss test. · 1f85e262

kbr@chromium.org authored Apr 26, 2014

The underlying infrastructure isn't ready for this to crash the GPU
process 30 times in a row. Change back to running this test once to
address continued flakiness on the bots.

BUG=365904
NOTRY=true
TBR=bajones@chromium.org

Review URL: https://codereview.chromium.org/252793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266315 0039d316-1c4b-4281-b951-d872f2087c98

1f85e262

Mojo: Fix incorrect PLOG in raw_channel_win.cc. · b4ac96e2

viettrungluu@chromium.org authored Apr 26, 2014

Oops.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/257763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266314 0039d316-1c4b-4281-b951-d872f2087c98

b4ac96e2

Revert 266297 "1. Handle the case of empty embedder_extension_id..." · 9ca50c9f

rmsousa@chromium.org authored Apr 26, 2014

This change introduces static initializers (the two
static const std::string Type constants).

Static strings should be declared as char * instead.

> 1. Handle the case of empty embedder_extension_id in    guestview.h.
> 
> 2. Introduce a template class GuestView<T> to handle the    *guestview-specific functions in guestview.h:
>    . Rename GuestView to GuestViewBase, introduce GuestView<T> class, and move *ViewGuest-specific functions to     GuestView<T>:
>         -- FromWebContents<T>(...)
>         -- From<T>(...).
>    . Introduce a template member function As() in      GuestViewBase to replace all of the As*View functions.
> 
> 3. In each derived *ViewGuest class , e.g., WebViewGuest &    AdViewGuest, define a static variable to show its view type    (string).
> 
> 
> BUG=351824
> 
> Review URL: https://codereview.chromium.org/237533008

TBR=hanxi@chromium.org

Review URL: https://codereview.chromium.org/252773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266313 0039d316-1c4b-4281-b951-d872f2087c98

9ca50c9f

Replace the internal '-mllvm -tsan-blacklist' flag with the user-visible -fsanitize-blacklist. · 3227d8f2

glider@chromium.org authored Apr 26, 2014

NOTRY=true
TBR=earthdok@chromium.org
BUG=

Review URL: https://codereview.chromium.org/254773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266312 0039d316-1c4b-4281-b951-d872f2087c98

3227d8f2

Avoid syncing chrome reference build and LayoutTests to speed up sync. · 715cafda

prasadv@chromium.org authored Apr 26, 2014

Assuming this might also fix 'Out of Memory' issue on Windows bisect bot
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/253573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266311 0039d316-1c4b-4281-b951-d872f2087c98

715cafda

Remove abandoned method. · 3731ebcf

eustas@chromium.org authored Apr 26, 2014

BUG=

Review URL: https://codereview.chromium.org/259503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266310 0039d316-1c4b-4281-b951-d872f2087c98

3731ebcf

Add a chrome://flags item "allow-insecure-websocket-from-https-origin" · 7fe71f07

tyoshino@chromium.org authored Apr 26, 2014

There're web apps served over HTTPS but are using insecure WebSockets.
To improve security, we're going to prohibit that, but should provide
an option to turn off the check until everyone finishes fixing their apps
to get ready for stopping use of insecure WebSockets from HTTPS origin.

The shield page action allows users to manually turn off mixed content
check, but for apps designed to open new windows frequently, this
workaround is too bothering.

So, we'll provide a chrome://flags item which turns off the mixed
content check (only for WebSocket). This flag is scheduled to go away
when everyone should be ready for accepting this security check.

This CL depends on this Blink side CL:
https://codereview.chromium.org/246893014/

BUG=85271

Review URL: https://codereview.chromium.org/248863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266309 0039d316-1c4b-4281-b951-d872f2087c98

7fe71f07

Remove touch layout · c942858d

oshima@chromium.org authored Apr 26, 2014

Re removed touch resources, but didn't remove the code that changes the layout. This CL removed all touch layouts.

BUG=362633

Review URL: https://codereview.chromium.org/247193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266305 0039d316-1c4b-4281-b951-d872f2087c98

c942858d

Refactor the interface for the CrxDownloader to take a callback. · 1b6587dc

sorin@chromium.org authored Apr 26, 2014

To be consistent with the rest of the artifacts in the component updater,
the non-blocking calls for the CrxDownloader take a callback to be called
when the non-blocking call completes.

This change allows adding further callbacks besides the completion
callback, such as a callback to be called when download progress is made.

This change is a pure refactoring and it should be a NOP in terms of
existing functionality.

BUG=366388

Review URL: https://codereview.chromium.org/250383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266304 0039d316-1c4b-4281-b951-d872f2087c98

1b6587dc

Do not bail out early from TiclInvalidationService for managed profiles · b878bc10

bartfab@chromium.org authored Apr 26, 2014

There is no need to explicitly check whether the profile is managed when
trying to start the TiclInvalidationService. The service will refuse to
start up anyway because managed profiles never have a signed-in account.

BUG=358696
TEST=Manual

Review URL: https://codereview.chromium.org/258503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266303 0039d316-1c4b-4281-b951-d872f2087c98

b878bc10