GitLab

This CL puts tester android-go-perf in lightweight mode with '--skip-perf'.

In this case the tester will no longer upload the perf data.

Bug: chromium:1045256
Change-Id: Ib5e09994a03d6e46e6e5439ed283e3a2275715bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271774Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#785891}

When reading unions, the raw bytes are memcpy()ed into the destination.
This works for XCB where structures are usually laid out as they would
appear on the wire.  However, XProto makes some changes (padding bytes
are hidden, length fields are hidden when possible, etc), so this
approach will not work.

This CL changes RandR NotifyEvent to use a switch instead of a union.
Since we have the switch variable available, there's no reason not to.

Furthermore, there are only 5 uses of union in all of xcbproto: the one
removed here, one in xproto (which I've checked is safe), and 3 in Xkb.
All of them have switch variables, so we can change all of them over
and get rid of unions altogether, which I'll investigate in followups.

This fixes a buffer overflow when resizing a VM while Chrome is running,
but also exposes a second issue: we're calling XRRUpdateConfiguration()
without having initialized Xlib's Xrandr, so the Xlib event is nullptr
causing a crash.  I'll investigate a fix for that in a followup.

R=nickdiego

Bug: 1102059
Change-Id: Ieac8807257eab6a90a9eab26b192f7444ddfa0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283940
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#785890}

Updates the expires_after attribute for 138 histograms that show
frequent access in the past 90 days.  These are the 90% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-01-03.

TBR=chromium-metrics-reviews@google.com

Change-Id: I59f8a8a48fbfe88c340443590f0cb5a317352c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285006Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#785889}

Update test expectations for Android.

Bug: None
Change-Id: I4617c9b4f1a2691f5c3d8bcb519d8698d4079b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277879
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785888}

... instead of WebMediaStreamSource.

BUG=704136
R=guidou@chromium.org

Change-Id: I19a2e7ad7109db1404f9f563e8b01548432388da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283572
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785887}

This reverts commit 74002934 and re-lands bb015801 (#785246) with
a fix to prevent the breakage I missed last time that affected
the ANGLE CQ.

Original CL's description:

> Remove //chrome/test wrapper targets for angle.
>
> //chrome/test defined two targets (angle_perftests and
> standalone_angle_unittests) that were simply wrappers around the
> corresponding targets in ANGLE that added some data dependencies.
>
> By moving those data dependencies into ANGLE, we no longer need
> the Chrome-side targets, and removing them unblocks the
> wrapper script work I'm doing in bug 816629.

TBR=jmadill@chromium.org

Bug: 816629, angleproject:3162
Change-Id: I2a56802a4301892f4b4a9f84ba0882a64e23e0cd
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:linux-angle-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283378Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#785886}

Prior to this change, font-size:0 was ignored for <select>
options and option groups.

Fixed: 1102414
Change-Id: I93389cbe5258095896f6846077c9df2c18410947
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283051
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785885}

Bug: 1088488
Change-Id: I3ed287c91bf94384844008dfae943f8e902d80b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283931Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785884}

Bug: None
Change-Id: I4b9c55779915bf5e4101d5c9e67011824ae3b310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252846
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785883}

UI is enabled with #global-media-controls-seamless-transfer flag

Bug: 1096242
Change-Id: I8134a437dbda07d32291ae91fb9707fe0df39418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270880Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/master@{#785882}

This change is to verify that there is no difference in reported metrics
for checking if the app is pinned to the taskbar with or without
the additional check that the shortcut exposes the unpin from taskbar
shell verb. Once this is verified a subsequent change will go in to
remove the shell verb check.

Bug: 1094395
Change-Id: Ibe70e7b2b54ae5bd9f4cdcccb20af7cb93e9f2da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277105
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785881}

This CL ensures the profile picker main view is updated if any of the
profiles's state changes.

Bug: 1063856
Change-Id: Ic93292b9f094b7202ceb1a25831310b25c77c997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279894
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785880}

Bug: 1099903
Change-Id: I8e6261064f4dc2bafd7484480d5b324b22edda49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271058Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785879}

Change-Id: I7e4a3d562a3cbda06950c455554a1da33b6f7e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284092
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785878}

UAF could occur in the following situation:
- Layout manager is set on View.
- View has child views added.
- View is destructed.
- After at least one of the child views is deleted, during a callback,
  a layout-related method such as CalculatePreferredSize() is called.
- Layout manager queries host view's children's properties.
- Child view is already destroyed, so pointer is invalid (but not null)
  resulting in UAF.

I have seen a crash randomly in debug mode which seems like it is
probably tied to this potential UAF at least once, which is why I'm
submitting this change.

Bug: 1102731

Change-Id: I7436ea9da0d1106178e9d43ed08e6e82f41a283e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284448Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785877}

In the following CL ax::mojom::IntAttribute::kTextAlign was added and
exposed for IA2 text-align :
https://chromium-review.googlesource.com/c/chromium/src/+/2264456

This CL exposes the new attribute for UIA via ITextRangeProvider::
GetAttributeValue, UIA_HorizontalTextAlignmentAttributeId.

Bug: 1090995
Change-Id: I7a1d0f86e20c49cad7d8ef867d7f01905ac08803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283770Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#785876}

MediaFoundationCdmFactory is a media::CdmFactory implementation that
can create MediaFoundationCdm to be used on Windows platform.

NOPRESUBMIT=true

Bug: 999747
Change-Id: I197bc876bab5006d915d8bc0c0ae43641200746d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278589
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785875}

Bug: 1100301
Change-Id: I6e21dee0a10b359f5b8d3571146f36b62892887f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284163
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785874}

This CL fixes a  crash when a RenderWidgetHostView is already destroyed
by the time the query IPC is processed.

Bug: 1101001
Change-Id: I046abacf6334fcfd56e3ea2bca07fdb24b5fff4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283824
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785873}

The drag and drop client is supposed to set event flags according to the
current state of modifier keys (i.e., Ctrl, Shift, and Alt).  It was
not implemented in Ozone, but migration of Linux/X11 to Ozone requires
that.  This CL adds the methods that allow the DDDClientOzone to get
these flags from the platform.

The issue has been found by a test that broke at the attempt to use
DesktopDragDropClientOzone in place of DesktopDragDropClientAuraX11.

Bug: 990756
Change-Id: I2657383011a1bf9d716bb5bfa90dbcf010bba48f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279975
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/master@{#785872}

TBR=tkent@chromium.org
NOTRY=true

Bug: 1102887
Change-Id: I86a8b82ed734eba08bdde7aa02e0f70d1b0a8b9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284847
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785871}

Bug: None
Change-Id: Id707947db395ea3c25b418b52520630fa479d5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283310Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785870}

It's already enabled for base_unittests on these bots. This enables it
for all of their tests.

Bug: 1057152
Change-Id: Ibef7bb40dc591fca55ee121e0d46835c4447bcef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283576Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785869}

By default, `media::DecoderSelector` uses a decoder prioritization
function that tries to balance power and performance with a resolution
-based hardware decoder cutoff. This CL adds a default-disabled feature
to instead use a function that prioritizes nothing, which is useful
for testing.

Bug: 684792
Change-Id: Iac0dc0e12fd9f5a41f344eefcbe002b4a1e84724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278702
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785868}

Bug: 1007815
Change-Id: I62c3b0bd99b685e7cea30244d88c8196d3646854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284141
Auto-Submit: Steve Kobes <skobes@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785867}

These are deleted either because they are already covered by tests
elsewhere or are no longer useful.

See this spreadsheet for more details:
https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing

Bug: 898955
Change-Id: Ie4548e0a8b3e27704b0342838364b29b1078a5b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279790
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785866}

mojo js binding: mojo js template interface_definition should generate !Promise instead of Promise for annotation

Bug: 1100700
Change-Id: I51a5b0babe4557baa070fde216fdbc2264f021a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276665Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785865}

The new direct Vaapi VideoDecoder doesn't have tracing, this CL adds the
first such meas, for the Decode() call, similar to
https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/vaapi/vaapi_video_decode_accelerator.cc;l=446

Bug: 1040291
Change-Id: I25b70cecb48435cd5539cbf927c0f2547d584649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283249
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785864}

Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease
of causing memory leaks.

Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo)
does not work if we are copying to different interfaces.

Also replace QueryInterface(foo.GetAddressOf()) with
QueryInterface(IID_PPV_ARGS(&foo)).

NOPRESUBMIT=true

Bug: 914910
Change-Id: Ib574cb4d93ec9e6b1134d2916058fa792aaec862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271525Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785863}

email address is @google.com.

Change-Id: I35a217fbec4995125afb42cce4332c507fdbd78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276811
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785862}

- Sandbox the iframe and sanitize the input used.
- Remove special 'synchronous' testing flag (not needed).
  - Multi-line quote requirement also no longer needed.
- Change default reader list
  - (replace deprecated Bloglines service with Newsblur).
- Deflake and re-enable the RSS extension tests.
- Up the version by two (from 2.2.3 to 2.2.5, since 2.2.4
  is live already).

Bug: 340354, b/137075999
Change-Id: I6eac37fae9e2228aeabe68ccf1fd34b9b36ac6ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264059
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785861}

WPT Import https://crrev.com/c/2252278 introduced a bunch of Mac10.10
timeout expectations. It appears the timeouts were caused by one-off bot
slowness.

Bug: 1096604
Change-Id: Ibcd38cd1e0c6435cf0231962e73e570e70b2d247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283414
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785860}

Bug: 688960
Change-Id: I8da036e642476b1eff6d0247f5bce3c2113c36e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268957Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785859}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8bf8ca6dc7f2..8c03d5d9bcc5

2020-07-07 sigurds@chromium.org Update heavy ads issue strings
2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in networkPanel.css
2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in media/playerPropertiesView.css
2020-07-07 aerotwist@chromium.org [CSS Overview] Adds checks for null / undefined
2020-07-07 tvanderlippe@chromium.org Fix stylelint errors in network/networkLogView.css
2020-07-07 jacktfranklin@chromium.org Fix component _bridges generation for TypeScript 4
2020-07-07 petermarshall@chromium.org Revert "Add E2E tests for Breakpoint test cases"
2020-07-07 leese@chromium.org Add helpers for debugging and snippet tests
2020-07-07 jacktfranklin@chromium.org Fix test_helpers on Python 3
2020-07-07 pfaffe@chromium.org [wasm debugging] Add a js_type to evaluator results
2020-07-07 tvanderlippe@chromium.org Remove e2e-test build files from .gitignore
2020-07-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-07-07 tvanderlippe@chromium.org Fix stylelint reports in inline_editor/cssShadowEditor.css
2020-07-07 johanbay@gmail.com Fix stylelint-config-standard issues in color_picker/spectrum.css

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1083142,chromium:1083146,chromium:1088463,chromium:1094436,chromium:1095617,chromium:1102704
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id88b50084ed4c7ee17b34047eeb2fcc769afa10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284949Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785858}

This reverts commit e1b47a15.

Reason for revert: crbug.com/1102888

Original change's description:
> Enable RespectMacLCDTextSetting by default in M86
> 
> Bug: 1079418
> Change-Id: Ib48fbedd92a01f161b954c614f081f91a5ad89f0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283246
> Auto-Submit: Philip Rogers <pdr@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#785697}

TBR=creis@chromium.org,pdr@chromium.org,chrishtr@chromium.org

Change-Id: Id373e62f49f0b4091d7516e6996eaffb4574a4b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1079418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285247Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785857}

The old screenshot was taking on a linux-chromeos build, so it
said "Personalize your Chrome device". This is confusing, since it
isn't clear if "device" should be part of the translated string.

Update screenshot so it shows "Personalize your Chromebook", which
is a better example of how it would appear. (The string already
contains a DEVICE_TYPE placeholder.)

Bug: b/159155720
Change-Id: If041bafcec392cfd0b896b528208865ae9c80500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284965
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785856}

`IdentifiabilityStudyState` was using a separate instance of
`IdentifiabilityStudySettings` to access the externally supplied study
parameters. Instead it now uses the global singleton.

Why do this? There really should be only one settings object. Having the
`IdentifiabilityStudyState` rely on the authoritative instance which is
the same one that the renderer and the rest of the reporting
infrastructure also relies on. In turn, this means that race conditions
involving setting up the global instance are much more visible and are
immediately caught by tests.

Existing tests exercise the functionality being changed here.

R=pauljensen@chromium.org

Bug: 1100424
Bug: 973801
Change-Id: I102495c70faa03378a392aecf9ab6b8c36364ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275478
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785855}

Bug: 1102606
Change-Id: I1f26284306d832fa2fe1ad6578bca6c6eb193843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284005Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@google.com>
Cr-Commit-Position: refs/heads/master@{#785854}

These have not been SVG-specific for quite some time, so keeping them
separate from the "basic" (HTML) named colors does not offer any
advantage.

Bug: 1102816
Change-Id: Ia2fd62e150aa99054cc8110f2e4ede0706a238d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283354
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785853}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fb40750b..22f9d885

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic1278eec37b8d86f460c5440af40e8b5daf45ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283509Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785852}