- 30 Aug, 2019 40 commits
-
-
Roman Sorokin authored
Bug: 954572 Change-Id: Ic682f73b52a24c1acb0e40df200e0724160d2e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774447Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692033}
-
sebsg authored
This reverts commit f5a9a694. Reason for revert: Findit Identified this as the culprit for consistent failures on Linux ChromiumOS MSan Tests. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14900 as an example: Consistent failures: browser_tests failed because of: LocalNTPCustomBackgroundsThemeTest.CustomBackgroundOverridesThemeAttribution InfoBarsTest.TestInfoBarsCloseOnNewTheme ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToPreviousTheme InstantThemeTest.ThemeChangedWhenApplyingNewTheme ...1 more failure(s) (5 total)... non_viz_browser_tests failed because of: LocalNTPCustomBackgroundsThemeTest.CustomBackgroundOverridesThemeAttribution InfoBarsTest.TestInfoBarsCloseOnNewTheme ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToPreviousTheme InstantThemeTest.ThemeChangedWhenApplyingNewTheme ...1 more failure(s) (5 total)... content_browsertests failed because of: RenderFrameHostImplBrowserTest.VisibilityScrolledOutOfView Original change's description: > [Cleanup] Move complex color calc out of searchbox_extension.. > > In this CL the logo and shortcut color calculation is split into 2 parts. > The color calculation based on the theme is moved to themes, and > defaults are moved to ThemeProperties. > The logo and shortcut colors can be overridden when custom background is > set. This logic is moved to instant_service. > > NTP text and logo_alternate logic is also moved out of > searchbox_extension. > > Bug: 983717 > Change-Id: I12b938ba8a833bd920cf224171163781889989a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759150 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691869} TBR=pkasting@chromium.org,estade@chromium.org,gayane@chromium.org,ochang@chromium.org Change-Id: I9759af11051eec26d2423acc5c3b88311d309a04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778184Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692032}
-
Maksim Ivanov authored
Replace strings hardcoded into the HTML code with the proper i18n calls. Bug: 964069 Change-Id: If9b4de625a52fa32f7bc9c243e376b92fcc7bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750162Reviewed-by:
-
Roman Sorokin authored
Failing in ASSERT_TRUE in setup functions does not stop tests. Bug: 995784 Change-Id: I165b3844b8aabeda4c238c722c610913c0c80574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771410 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
redatawfik authored
1- Create a new protocol "CreditCardScannedImageDelegate" which receives an image from Credit Card camera scanner. 2- Create a mediator "CreditCardScannerMediator" which conforms to "CreditCardScannedImageDelegate". 3- Implement "processOutputSampleBuffer" method in the mediator such that it takes an image and process it using text recognition in Vision API. 4- Create helper methods in "CreditCardScannerMediator" to parse text output and extract card number an expiration month and year from it. Bug: 984545 Change-Id: Ib76da1cb0edb0e0fa09b12b4c02ed95a83c53e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760926Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#692029}
-
Andrew Grieve authored
Noticed my test stack wasn't symbolizing when I ran the script with PWD=$SRC/out/Debug Turns out the stack script calls os.chdir() at some point, so need to save --output-directory as an absolute path. Also updated other paths passed as flags to use abspath(). Change-Id: I91fe857fa1af5c94b2783b0f4083f4d4ef927e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776611 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#692028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa94b48e0166..f24c9f2dff49 Created with: gclient setdep -r src-internal@f24c9f2dff49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib70751ec1ff0f12ece916f343ffa45ae0f949cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692027}
-
Hirokazu Honda authored
VideoFrameFileWriter cannot save frames in ALLOCATE mode because the video frame cannot be mapped. This CL fixes the failure in FlushAtEndOfStream_Allocate with --output_frames option. Bug: None Test: video_decode_accelerator_tests with --output_frames Change-Id: I9ea023c182d010fa65621c428c6291912ffd6db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777844 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#692026}
-
Hirokazu Honda authored
This CL introduces an option, --save_images, to save processed images in ImageProcessor test. The usage documentation of image_processor_test will also be shown with --help. This CL enables VideoFrameFileWriter to save memory based VideoFrame, not only DmaBuf-backed VideoFrame. Bug: 917951 Test: image_processor_tests --save_images on atlas Change-Id: I4b4d87bb564873fac0f1a0f51f3a4296a2d9bb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774011 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Skip making the closePinDialog() JavaScript call when the state says that no JavaScript calls are allowed. This may happen inside the GaiaScreenHandler destructor if the security token PIN dialog is active. Before this CL, the implementation was trying to close the active PIN dialog, which was causing a crash. Part of the example stack trace: base::debug::CollectStackTrace() base::debug::StackTrace::StackTrace() base::debug::(anonymous namespace)::StackDumpSignalHandler() <unknown> gsignal abort std::__terminate() __cxxabiv1::failed_throw() __cxa_throw std::__Cr::__throw_length_error() std::__Cr::__vector_base_common<>::__throw_length_error() std::__Cr::vector<>::__emplace_back_slow_path<>() chromeos::BaseWebUIHandler::CallJS<>() chromeos::GaiaScreenHandler::CloseSecurityTokenPinDialog() chromeos::PinDialogManager::CloseActiveDialog() chromeos::PinDialogManager::RemovePinDialogHost() chromeos::GaiaScreenHandler::~GaiaScreenHandler() chromeos::GaiaScreenHandler::~GaiaScreenHandler() content::WebUIImpl::~WebUIImpl() content::WebUIImpl::~WebUIImpl() content::RenderFrameHostManager::ClearWebUIInstances() content::WebContentsImpl::~WebContentsImpl() content::WebContentsImpl::~WebContentsImpl() views::WebView::SetWebContents() views::WebView::~WebView() views::View::~View() chromeos::OobeWebDialogView::~OobeWebDialogView() views::View::DoRemoveChildView() views::View::RemoveAllChildViews() views::Widget::~Widget() views::(anonymous namespace)::BubbleWidget::~BubbleWidget() Bug: 964069 Test: enroll a "target_os=chromeos" build, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, wait until PIN dialog appears, close Chrome by clicking "x", check that there was no crash Change-Id: I3f2f927830d71209c61c7e4b66250d16bb1039ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750003 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBDatabase interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ifb57fede8ff8e4a97d863c067a068bcb27bccf32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774280 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#692023}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71acc9d6..321c5840 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2c2d2b700e91fdae4ba036c7cd16f638b3471e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778001Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692022}
-
Dominic Farolino authored
This CL introduces a flag specifically for NetworkIsolationKey changes made to cross-origin main-resource prefetches. We'd like to implement these changes incrementally and not have them enabled implicitly under the SplitCacheByNetworkIsolationKey flag. A future CL will actually put this flag to use, and remove more instances of the SplitCache feature detection. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ifd465d343b76e6533fffed46cfae1d2486fb078f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775890 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#692021}
-
Mohamed Abdelhalim authored
Remove the manual reset of navigation_handle in NavigationRequest's destructor. Bug: 916537 Change-Id: Iddab8818f172ae1d0679e8e68619895f4ed861d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776057Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692020}
-
Jan Wilken Dörrie authored
This change makes the TouchToFillController a member variable of the ChromePasswordManagerClient and updates affected code accordingly. Bug: 957532 Change-Id: Ia5aff08a0fb2cf85d4fb30c1e42abcbd4e3230c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737326Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#692019}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBDatabaseCallbacks interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I7bb92e5f5dc5894e33b3fa63edbf893a52c2af61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768589 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I7d39618f9a51680f9de3b747192f93cc4667de08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776035 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#692017}
-
Nico Weber authored
Also mark minimizing a repro case as optional and move it later in the process. Bug: none Change-Id: I23213e22c6635f8f48dae5a9cda85b068005c2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776859 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692016}
-
Benoît Lizé authored
Anonymous memory can be tagged (on OS X) or named (on Android). Add tags and names for BlinkGC and PartitionAlloc, to ease memory investigations and debugging. Example output on Android, by looking at /proc/[PID]/smaps: 34c02000-34c04000 ---p 00000000 00:00 0 [anon:partition_alloc] Name: [anon:partition_alloc] Size: 8 kB KernelPageSize: 4 kB MMUPageSize: 4 kB Rss: 0 kB Pss: 0 kB Shared_Clean: 0 kB Shared_Dirty: 0 kB Private_Clean: 0 kB Private_Dirty: 0 kB Referenced: 0 kB Anonymous: 0 kB AnonHugePages: 0 kB Swap: 0 kB SwapPss: 0 kB Locked: 0 kB VmFlags: mr mw me ac 34c04000-34dfc000 rw-p 00000000 00:00 0 [anon:partition_alloc] Name: [anon:partition_alloc] Size: 2016 kB KernelPageSize: 4 kB MMUPageSize: 4 kB Rss: 984 kB Pss: 984 kB Shared_Clean: 0 kB Shared_Dirty: 0 kB Private_Clean: 0 kB Private_Dirty: 984 kB Referenced: 980 kB Anonymous: 984 kB AnonHugePages: 0 kB Swap: 0 kB SwapPss: 0 kB Locked: 0 kB VmFlags: rd wr mr mw me ac Bug: 998048 Change-Id: I82b5ccdf5979fec920043aa62169607625aa7dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774286 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692015}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBCursor interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I80027402a0bce5dcf568cbbcb4229385cd9d6ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768471 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Corentin Wallez authored
TBR=kainino@chromium.org BUG=chromium:478572 BUG=chromium:606096 BUG=chromium:772651 BUG=chromium:798117 BUG=chromium:951628 Change-Id: I482a2ec48cd38da8f92462e2621a781c9fb3a9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777921Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692013}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I4198e9a7925d1db42b74041343666284534cfbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778181Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692012}
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: I469dd58d19543b5f046664eca0cd9cdc323fbae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760925 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692011}
-
arthursonzogni authored
Add tests about a document entering the BackForwardCache and immediately receiving inflight messages sent before it has been frozen. These messages causes the document to become not cacheable. The problem is that it is already in the BackforwardCache. This documents the "current" behavior. Not the "correct" behavior. The tests are written to be fixed. Bug: 996267 Change-Id: I37cf1055c53f4e976039b47463e087ca10c058bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763760 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Mike West authored
Bug: 959789 Change-Id: I021a74e2ece606c317d2c9f0114508e7405f096d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776361 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692009}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBTransaction interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I590546db15cd0df4441df2ec516130a8dade88e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768709 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Antonio Gomes authored
This is phase 1.8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: If4aca474d0ed17a742d9eae301ae38a6f7c88b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776658 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#692007}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1aadfed445c47c683bcbe8149f334a5142fa8ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692006}
-
Finnur Thorarinsson authored
Use Back arrow for both Normal and Search mode. Add padding to the Close button to the right of the search window. Bug: 988276, 860467 Change-Id: I4eb65d19d685d1b4f19d6b06576c44371c10eedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776032Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#692005}
-
Kent Tamura authored
Use foo.mojom-blink-forward.h instead of foo.mojom-blink.h in headers related to execution_context.h This CL has no behavior changes. Bug: 242216 Change-Id: I8e2f01fbb1aed4ba70d7e52ee48019367b5bc1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777781 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#692004}
-
redatawfik authored
1- Change parent class of "AutofillAddCreditCardViewController" to "AutofillEditTableViewController". 2- Set "AutofillAddCreditCardViewController" as a delegate for TableView Cells. 3- Add a check for type of the TableView cells in "AutofillEditTableViewController". Bug: 984545 Change-Id: I82296c8defbcd20b4b04d0c6465bb5127a52428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771913Reviewed-by:
-
redatawfik authored
1- Add Method "updateCellForItemType" which update TableView cells with received text. 2- Update only cells which there is received data from scanner for it. Bug: 984545 Change-Id: Iddf9d7002bb18f0416c170d39f492831bac21f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774633Reviewed-by:
-
Rika Fujimaki authored
You should be careful not to use a wrong context, which leads to a leak of information. Currently, we can get a context from scattered ScriptValue without consideration, but we would like to prevent it. Instead of from ScriptValue, you can get a context via - ScriptState::GetContext() using ScriptState passed from binding code - ScriptState::GetContext() using ScriptState stored on a C++ object - Isolate::GetCurrentContext() Also, we add GetScriptState() in InternalResolver to get a script_state from instead of from ScriptValue. It is safe because InternalResolver is only used internally. Bug: 998994 Change-Id: Iaa5a936635279566abe4801d4f15774eb628e83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772793Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Rika Fujimaki <rikaf@google.com> Cr-Commit-Position: refs/heads/master@{#692001}
-
Marina Sakai authored
Split |kCrossOriginAttributeTable| into two tables; one is for attributes, which should be accessor properties, and the other is for operations, which are data properties. Currently cross origin attributes are implemented as data properties, but will be converted to accessor properties in following changes. Bug: 809011 Change-Id: If95e6a402c532648ffd406b1ee451df92807375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775689Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Two flags are still needed until at least M-79. I now maintain what they guard. Bug: None Change-Id: If5d7c766b29c3e3ddeeeee31c7b4cb8e25a7c7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776037Reviewed-by:
-
Leszek Swirski authored
Required to land the changes in https://crrev.com/c/1777702 Bug: 999473 Change-Id: I4e2738d76027e6e08d80d39595a3a83e40858eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777721 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#691998}
-
Michael Lippautz authored
- Provide BindingTestSupportingGC that can be used to call various types of GC. - Avoiding including v8_binding_for_testing.h in production code. - Fix clients that relied on transitively including V8TestingScope. Change-Id: I64733749389817bbc3eda3cf90003a587e0bf33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776362 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The "doom installing worker" was introduced at a time when we didn't have timeouts for starting a worker or for lifecycle events. The purpose was to prevent the job queue from being stuck forever on a bad worker. Now that we have these timeouts, we can remove the mechanism. This also aligns with the spec, as seen in the passing WPT test. A previous attempt was made at https://chromium-review.googlesource.com/c/chromium/src/+/560633/. That attempt added a timeout timer for the job queue, but was reverted due to crashes with it. I considered adding a timeout timer here too, but it seems to have little utility considering the job should only be stalled by a worker stuck in starting or install. If there is another failure, it's a bug and timing out might not actually help. Bug: 723037, 999027 Change-Id: I0c6248db5a2e834f986218e61cec82e4b8e0f4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776156Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691996}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.CacheStorage interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I194ae2b5dd8d3fc75d6363baf39e46f7b01628a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774925 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691995}
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: Ic2a84e8f329c2b790dcd0b996439942974255b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760745Reviewed-by:
-
