- 25 Sep, 2018 40 commits
-
-
Xianda Sun authored
This CL merges the two metrics because of their similarity. Apart from that, MainThreadScrollingReason does not collect metrics when a scroller is composited but still blocked on main thread due to event handlers. We really care about the reasons that make scrolling slow, so we should also collect composited but blocking cases and the two similar metrics can be merged. Bug: 861754 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I295d94f7ca3892dbfde34e4c61db0d95af92b1fe Reviewed-on: https://chromium-review.googlesource.com/1226828Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594047}
-
Xiyuan Xia authored
After crrev.com/c/1233174, failures/time outs in the associated bugs are gone. Enable more tests in single process mash. Bug: 877496, 884389, 884393 Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c Reviewed-on: https://chromium-review.googlesource.com/1243194Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594046}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/90a12b3d4d1d..903514f95445 git log 90a12b3d4d1d..903514f95445 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 dj2@everburning.com Roll DEPS for spirv-headers (#1920) 2018-09-25 stevenperron@google.com Get KillNameAndDecorates to handle group decorations. (#1919) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@903514f95445 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie14884f18ca4f72d143854865b69dc49dbf71426 Reviewed-on: https://chromium-review.googlesource.com/1243608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594045}
-
Robert Sesek authored
Bug: 832676 Change-Id: I3d5d3db47c3a1e1ba3f8604ac6ab4ca7857887cf Reviewed-on: https://chromium-review.googlesource.com/1243728 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594044}
-
Chris Palmer authored
Bug: 705605 Change-Id: I7a056679917692e3ce326ac1553b2be110c9fdc5 Reviewed-on: https://chromium-review.googlesource.com/1239159Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594043}
-
Xianzhu Wang authored
We didn't set output clip for some effect nodes because the effect may interleave with the current clip. This causes PaintChunksToCcLayer and PaintPropertyManager go through the complex code path to deal with interleaving effects and clips even if they don't interleave. Now set output clip except when there are non-contained fixed-position descendants which may escape the current clip. The benefits are: 1. PaintChunksToCcLayer and PaintPropertyManager will go through the more optimized path if they see output clip for an effect, and will generate more efficient paint operations and cc paint property tree and layers. 2. In BGPT, this avoids bugs of PaintPropertyManager in the code path handling interleaving effects and clips in cases that clips and effect don't actually interleave. Thus the scope of the bugs will be much smaller, and we will just focus on the real cases of the bugs. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4a767b78ccb13a3672dfb6397d888208f3c3b960 Reviewed-on: https://chromium-review.googlesource.com/1239418 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594042}
-
Fredrik Söderquist authored
This method is never called for a LayoutObject which has a "linked" resource (<pattern>), so remove the handling of |linked_resource_|. Change-Id: I8c57804ecb58f4b7e286e427f0b7de84909286b8 Reviewed-on: https://chromium-review.googlesource.com/1243807Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#594041}
-
Fredrik Söderquist authored
This uninlines MaskUnits() and MaskContentUnits() in LayoutSVGResourceMasker as well as ClipPathUnits() in LayoutSVGResourceClipper - reducing unnecessary includes/dependencies. Also streamline LayoutSVGResourceFilter::ResourceBoundingBox a bit by using the FilterUnits() accessor, and remove the redundant null-check on the element. Change-Id: I658b7626627ac38fc8b43bfd54630adb778233e8 Reviewed-on: https://chromium-review.googlesource.com/1243117Reviewed-by:
-
Daniel Rubery authored
The opt-in on DownloadFeedbackDialogView is very low, so remove it. At the same time, refactor logic for reporting. The safe browsing preferences are now checked within the DownloadProtectionService. Bug: 827567 Change-Id: I1bed2d912b53504246f21a803f0095cd15ead125 Reviewed-on: https://chromium-review.googlesource.com/1238563Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#594039}
-
Koji Ishii authored
This patch re-uses NGPaintFragment when corresponding LayoutObject is the same. Because paint system uses the address of DisplayItemClient as the identifier, doing so not only reduces 2 alloc/free for each NGPaintFragment (one for itself and another for children vector) but also allows paint system to identify changes in NGPaintFragment. Before this patch, all changes are handled as "disappear" + "appear" pairs. [blink_perf.paint] are mostly positive, up to 18.8%. Not all tests are positive though, probably because the overhead to compare LayoutObject is visible when no re-use is possible. This patch is also the foundation to optimize paint invalidation further. Still a good amount of invalidations are done by subtree. By identifying NGPaintFragment for the same node, we can tune the invalidation types to smaller ones. [blink_perf.paint]: https://pinpoint-dot-chromeperf.appspot.com/job/13b534a7640000 Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3079a7baefda7730521ec58715a7571669c9bfb4 Reviewed-on: https://chromium-review.googlesource.com/1237697 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594038}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/media_galleries. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 874080 Change-Id: I517572321e5fd315216e74d83ecf541a8fc57667 Reviewed-on: https://chromium-review.googlesource.com/1191415Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#594037}
-
David Tseng authored
In Blink, select (default action verb) often equates with 'click'. A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select. ChromeVox calls do default and triggers undesirable side effects. Bug: 889018 Test: manually on Gmail. Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a Reviewed-on: https://chromium-review.googlesource.com/1241843 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594036}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/297caafc5805..d37570b325e2 git log 297caafc5805..d37570b325e2 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c5e68abdea9e..9a20cc9744b3 (1 commits) 2018-09-25 mtklein@google.com FuzzPath -> FuzzNicePath Created with: gclient setdep -r src/third_party/skia@d37570b325e2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I57f83780b3f999db86e832f6a78d892d4e415d2d Reviewed-on: https://chromium-review.googlesource.com/1243607Reviewed-by:
-
Sarah Hu authored
Bug: 888704 Change-Id: I9167e623424c48de14dd1b5eeddf4ffd966d7d12 Reviewed-on: https://chromium-review.googlesource.com/1244077Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#594034}
-
Nico Weber authored
Bug: 832676 Change-Id: I5ea07707d3603cbe5ef88d098d96cdd41be05d0d Reviewed-on: https://chromium-review.googlesource.com/1243976Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594033}
-
Morten Stenshorne authored
This implements the basics for a layout algorithm for the FIELDSET element. It doesn't yet contain min/max calculation, legend inline alignment, or block fragmentation support. Nor do we attempt to paint/hit-test/etc anything correctly. Painting is likely to require some rather persuasive code on the legacy side, especially if we want to get paint layers right (for scrolling or e.g. relatively positioned legends). This new implementation is not enabled by default, but can be enabled via the (new) LayoutNGFieldset runtime flag. There has been some recent spec work for FIELDSET / LEGEND [1], and we aim to accommodate for all of that. Among other things it's been decided that a fieldset may be a flex or grid container. We are also expected to support multicol and scrollable containers. None of these things are supported by legacy layout. The NG implementation is designed to handle all of that (although, with this CL, it handles none of them). This is the reason why we need an anonymous fieldset content wrapper child, which contains all the fieldset contents. The rendered legend is placed on the outside of that. This is both for convenience reasons and pure necessity. Necessity: The legend is expected NOT to scroll together with the contents if the fieldset is scrollable. That'd obviously look silly. Conveniece: Taking the legend out from the fieldset contents means that none of the other layout algorithms (block layout, multicol, flex, grid) need to support legends in their own peculiar ways. A fieldset element generates a fragment with up to two child fragments; first the rendered legend (if any), then the fieldset content (if any). Given this markup: <fieldset> <legend>leder</legend> <div>hosen</div> </fieldset The fragment tree will look like this: +--------------------+ | Fieldset container | | (FIELDSET DOM node)| +--------------------+ / \ / \ +--------------------------+ +-------------------+ | Fieldset content wrapper | | Rendered legend | | (anonymous) | | (LEGEND DOM node) | +--------------------------+ +-------------------+ | | | | +-----+ +-------+ | DIV | | leder | +++++++ +-------+ | | +-------+ | hosen | +-------+ The fieldset content wrapper can be a regular block container, or, eventually, a scrollable container, a multicol container, a flex container, or a grid container. Fieldset padding is applied on the anonymous wrapper, NOT on the fieldset container. The reason for this is that padding is on the inside of the scrollport (if any), so since the wrapper establishes the scrollport (in order to exclude the legend; we don't want it to scroll with the rest), the padding needs to go there as well. At the same time, the legend needs to take fieldset padding into consideration, so some extra code is required for this. [1] https://github.com/whatwg/html/pull/3934 Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If952215459016e8528b2d94b74bca1c76e2fb4d6 Reviewed-on: https://chromium-review.googlesource.com/1236221Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#594032}
-
Jialiu Lin authored
Reocrd content area sizes when a new browser window is opened and when the user resizes a browser window. This is part of preliminary metrics collection for vision-based phishing protection. Bug: 882942 Change-Id: Ib6db98bf13193784b89029f467906ed4e0b3ffc4 Reviewed-on: https://chromium-review.googlesource.com/1228957 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#594031}
-
rbpotter authored
- Expand line heights & add margin so that the header is the right height and the focus highlight for "Manage" doesn't get cut off. - Set min-height 0 on the list container flex child so that it can shrink. Otherwise, odd bugs occur since it stays the height of the content. Bug: 888411, 888412 Change-Id: I4d61b7c5c2e41bacc29695f3588c20070182c16a Reviewed-on: https://chromium-review.googlesource.com/1241973Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594030}
-
Sidney San Martín authored
Change-Id: I2f8dc2f9041bf2fe9115b33b6c9dc6046b386f95 Reviewed-on: https://chromium-review.googlesource.com/1237055Reviewed-by:
Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594029}
-
Sidney San Martín authored
Change-Id: I6dfd6d01c727c3bcc894b83612df1cc66f11e7e5 Reviewed-on: https://chromium-review.googlesource.com/1243997 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Bill Budge authored
- Moves metadata caching messages from RenderMessageFilter to a new Mojo API. - Adds CodeCacheHostImpl to implement the messages in the browser process. Bug: chromium:867347 Change-Id: If8b0181a501ead11a5e0adbeef162b263b3f6ac0 Reviewed-on: https://chromium-review.googlesource.com/1217885 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#594027}
-
Ian Clelland authored
Feature Policy is properly associated with a document, rather than a frame. This series of CLs moves both the feature enabled check and the reporting methods from Frame/LocalFrame to SecurityContext/Document. This mechanical CL renames the existing methods to mark them as deprecated. Follow-up CLs will implement the new methods and change call sites to use those instead. Bug: 888668 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3511a6299c9582175412463d43521c3578db27c2 Reviewed-on: https://chromium-review.googlesource.com/1240857Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#594026}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates Android's ContextualSearchDelegate and the respective unittests away from URLFetcher. Bug: 773295,872875 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifd2f3afd0db3ceaf75f6a8f972259c656ec7db69 Reviewed-on: https://chromium-review.googlesource.com/1221729 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594025}
-
Michael Lippautz authored
Garbage collection needs to be finalized before unsetting the EmbedderHeapTracer pointer. Otherwise, an already running GC may not be properly finalized and the GC is left in a undefined state which the subsequent follow up GCs discover. Bug: 843903 Change-Id: I4dc73005174a1b99dfda96ef379fe62bf5b34dbe Reviewed-on: https://chromium-review.googlesource.com/1243247Reviewed-by:
-
Devlin Cronin authored
ExtensionBuilder has SetManifestKey(), but "version" is pretty common (and fairly core to the extension object), so add a convenience method for setting it. Add a quick unittest for the same, and update a smattering of places that previously used SetManifestKey(). Bug: 832958 Change-Id: I55de79360e698f8f9983c24a0e0d5fdb8b3fff9b Reviewed-on: https://chromium-review.googlesource.com/1242196Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594023}
-
Nico Weber authored
LocationBarViewMac is replaced with a stub for now, since a bunch of tests need a non-null object. Bug: 832676 Change-Id: I71a2baddb540c24bc129141a0f08a1dfc5856aff Reviewed-on: https://chromium-review.googlesource.com/1242135 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
danakj authored
Currently both methods branch on making a widget for main-frame or a non-main-frame (but in both cases a local root). Instead have callers to these decide what they are doing, as they already know if they are making a main frame's widget or not, and call the appropriate method after splitting. The result is RenderWidget::CreateForFrame() is not called for main frames, but WebFrameWidget::CreateForMainFrame() is. And RenderWidget::CreateForFrame() is called, along with WebFrameWidget::CreateForChildLocalRoot() for non-main-frames. This makes RenderFrameImpl's interaction with the RenderView and its RenderWidget far more explicit and direct, instead of having RenderWidget pull things off many levels of plumbing from the RenderFrameImpl, when it can use things directly. Some TODOs added about questionable DeviceScaleFactor things, and where we should like to create RenderWidgets in the future, instead of pulling them off RenderView, probably. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: I220a892f6f4a1c9f73f196e31766c07f13bac33e Reviewed-on: https://chromium-review.googlesource.com/1229417 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594021}
-
Aga Wronska authored
A few of the demo setup screens are instances of regular OOBE screens. After resume the information about demo mode is not preserved. It results with resuming screen in regular OOBE flow and can cause error state. Bug: 879291 Test: Manuall + WizardController browser tests Change-Id: I47176b8d0d801141ca05ee710028b9a019f77e54 Reviewed-on: https://chromium-review.googlesource.com/1232953Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#594020}
-
Chris Lu authored
Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: I370379e55e962695a8eabf609972ca5dc39bd211 Reviewed-on: https://chromium-review.googlesource.com/1239535Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#594019}
-
David Grogan authored
Before this, auto margins were always resolved as 0 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38f45a656d993aa12ee5afff720d4db3239bbb45 Reviewed-on: https://chromium-review.googlesource.com/1220398 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74c179bb9bb9..b36a4816a546 git log 74c179bb9bb9..b36a4816a546 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Add OpenGL line segment rasterization. 2018-09-25 fjhenigman@chromium.org Vulkan: work around vkCmdCopyBuffer bug. Created with: gclient setdep -r src/third_party/angle@b36a4816a546 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I3e9bd5449538329cc8b497355d67757c0c5ab837 Reviewed-on: https://chromium-review.googlesource.com/1243543Reviewed-by:
-
Mikel Astiz authored
Now that sessions have their own KeyedService, we can migrate away from ProxyModelTypeControllerDelegate, which was needed before for the subtle reason of avoiding a dependency cycle during initialization of ProfileSyncService. This removes a transitional state and simplifies reasoning about the datatype's state (controller and bridge are always in a consistent state). Bug: 883199 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia52284c8eb61314486807a626580dbe132401051 Reviewed-on: https://chromium-review.googlesource.com/1243086 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#594016}
-
rbpotter authored
Fix this test to pass with Polymer 2. Bug: 875452 Change-Id: Ic2f9c38409f3659b0b4cfee7abe51e2ea562903f Reviewed-on: https://chromium-review.googlesource.com/1239717Reviewed-by:
-
Christian Fremerey authored
Add an API to the video capture service that allows observers to register and receive events whenever virtual devices are added or removed. Design Doc: https://docs.google.com/document/d/1CW6wslQFvV9FMIMkpyCzh2TcASr7LLXrawAtlgSecg8/edit?usp=sharing Test: services_unittests --gtest_filter=VideoCaptureServiceDeviceFactoryProviderTest* Bug: 885256 Change-Id: I49dfe298bc4d19d9b4b417ec658b899b4898ce1f Reviewed-on: https://chromium-review.googlesource.com/1237378Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594014}
-
rbpotter authored
- Make cr-input full height of radio button so there is no border area where the hand pointer appears. - Ignore pointer events on link container when disabled. - Fix bug where "----" was considered valid input in pages. Bug: 884603, 887823, 888493 Change-Id: Ie9b7f2c42b12d7e2a7026f405b1a61b774578589 Reviewed-on: https://chromium-review.googlesource.com/1242037Reviewed-by:
-
Xi Cheng authored
1) Change DetermineImageDirectory() from being a private class member to being in the anonymous space; 2) Make RegisterTemporaryImage() early return when there is no image data. 3) Clean up the headers. Bug: 888276 Change-Id: Ib7006121d279bfc8147ad6ae71382a95b94d05be Reviewed-on: https://chromium-review.googlesource.com/1239728 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#594012}
-
Francois Doray authored
This method is invoked when all the frames in a process are frozen. In an upcoming CL, we will empty the working set of a process when all its frames are frozen. Bug: 885293 Change-Id: I3f3d15ccb605d47f71cbfb30dd8e88121c70dbe2 Reviewed-on: https://chromium-review.googlesource.com/1236461Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#594011}
-
Christian Biesinger authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iabb07283ec32b93bd9ec0a4ace317645410c8a64 Reviewed-on: https://chromium-review.googlesource.com/1236932 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Adding item/cell to display a cell with a image on the left, a multiline title and an optional multiline detail text. This item/cell is used in crrev.com/c/1231333 to show sync error from: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3e63bc1501_10_15 See: https://drive.google.com/open?id=1i0FEUwRI4RsRIYYHjxoqFyFxk3q7JfMZ Collection cell catalog: https://drive.google.com/open?id=16G_97-5oZZV1TKrxM3JYqXXISTXn-hTV Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ieb3c5f0fcb814d5d8808a096e2a01d280aafa151 Reviewed-on: https://chromium-review.googlesource.com/1236338 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#594009}
-
Avi Drissman authored
BUG=887925 TEST=WebContentsImplBrowserTest.JavaScriptDialogsNormalizeText Change-Id: Ibea163e5cc8822c427d2278717b5d1c8316d6be4 Reviewed-on: https://chromium-review.googlesource.com/1243226Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594008}
-
