- 28 Feb, 2020 14 commits
-
-
Rohit Rao authored
BUG=1024115 Change-Id: I01f1a5f11710a6956cd17ada97b462c250c64d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079391 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745265}
-
Varun Khaneja authored
1. Notifier::OnStartSlowCheck(), PauseReadingBodyFromNet(), and ResumeReadingBodyFromNet() were added with the assumption that Safe Browsing checks mostly return synchronously (except a tiny percentage) so calling PauseReadingBodyFromNet() in only those few cases was a good precautionary measure. 2. The "precaution" was against overzealous AVs that may warn the user if we cache an unsafe resource; note that the resource is not used until Safe Browsing confirms it is SAFE. 3. On mobile, since connection is usually slower, we did not enable this "precaution". That's a very good indication of how good this "precaution" is :) 4. Now, with SafeBrowsingRealTimeUrlLookup enabled, a larger percentage of navigations are going to hit PauseReadingBodyFromNet(). 5. This would have been fine by itself but due to the special handling of PDFs and some other special types, as described in 1056696#c9, this completely breaks the loading of those types. 6. The "precaution" does not seem worth the breakage. See https://crbug.com/1056696#c9 and https://crbug.com/1056696#c12 for full details. R=xinghuilu Bug: 1054978,1056696 Change-Id: I0f6f48831733996e0ab91a0c0c1ab240a1923c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079338 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745264}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/cd2eb2e2d632..21be4b46c82c git log cd2eb2e2d632..21be4b46c82c --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Set use_system_xcode GN arg to false on mac Created with: gclient setdep -r src/native_client@21be4b46c82c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056008 Tbr: mseaborn@chromium.org Change-Id: Icf83007415e00161295761b3730d7b78b90c4c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745263}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d2040a6f973..78da538aed52 git log 4d2040a6f973..78da538aed52 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rnk@chromium.org Revert "Vulkan: Disable global merge for volk" 2020-02-27 jmadill@chromium.org Capture/Replay: Capture DrawBuffersEXT. 2020-02-27 jmadill@chromium.org Fix out-of-bounds read in test. 2020-02-27 jonahr@google.com eglGetConfigAttrib validation missing extension check Created with: gclient setdep -r src/third_party/angle@78da538aed52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: geofflang@google.com Change-Id: Ia8d67711c2e59d0511bee0a76c06f00a663fd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079347Reviewed-by:
-
liberato@chromium.org authored
We'd like to know "is user watching video" vs "is user scrolling around the page" when recording power. So, we allow any fullscreen-like experience to count, rather than just strictly full-screening the media element. While this is still not exact, it's much closer to what we want. Bug: 1017787 Change-Id: Idb022eb10a9f5e51f0fdef58c3a11ab5e9f40849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070836Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#745261}
-
dpapad authored
This UI is never shown to the user anymore. It was originally deleted at r704421, but that CL was later reverted at r704423. Bug: 991764 Change-Id: I37ba605350522a6d86188f21db2d058beaa0627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079050 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#745260}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9db20bb3437e..a4b47b52e653 git log 9db20bb3437e..a4b47b52e653 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Increase sampling from 0.2 to 0.5 Created with: gclient setdep -r src/third_party/catapult@a4b47b52e653 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: oysteine@google.com Change-Id: Iedd03c66de6b4d0cd01f9d78c755d41448adf687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079349Reviewed-by:
-
Allen Bauer authored
Bug: 1056761 Change-Id: I0f477c21d315ae707825b43daf8a1cbfb11eb72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078996 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745258}
-
Toni Barzic authored
The test was flaky because it was clicking the home button while the hotseat was animating from hidden to extended state. If the mouse events came in the right time, they would be eaten up by the hotseat widget. This means that home button would not change the home launcher state, and the hotseat would remain extended. This should not be an issue any longer: * Today, the default hotseat state with spoken feedback enabled is kExtended, so the hotseat is not animating when test tries to click the home button. * Hotseat widget has since been fixed not to consume events while it's animating. BUG=1020806 Change-Id: I791810ed34eb890b834a93b1a0f26e63d54f3207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079536Reviewed-by:Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#745257}
-
Miguel Casas authored
Intel Display Controller does not support AR30/AB30 framebuffers, but only their opaque XR30/XB30 versions. This CL adds a provision for these formats to |prefer_opaque| when importing a buffer. This CL was split off crrev.com/c/2072621, and is used for supporting high bit-depth framebuffers for HDR composition. Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 776093 Change-Id: Iacd0414ea0f0a9dd359796c982ed60d0ee74a737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078655 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#745256}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/729310aa1810..e3e07bf979ea git log 729310aa1810..e3e07bf979ea --date=short --first-parent --format='%ad %ae %s' 2020-02-27 marinaciocea@webrtc.org Introduce frame transformer interfaces for Insertable Streams Web API. 2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4f8e062e..4ed2234c (744969:745105) Created with: gclient setdep -r src/third_party/webrtc@e3e07bf979ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8beef0caf9307b33b2776aeea6b43c528ac354ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079531Reviewed-by:
-
Josh Simmons authored
is used The CONTEXT_MENU enumeration value was incorrectly being emitted when Quick View was opened via the Selection Menu. The correct SELECTION_MENU enumeration is now emitted. Bug: 1046997 Change-Id: I24f8ec60308c323fbd22dff734e0d07e26c17ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071163 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#745254}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f0b41d4e7f8..0e413afc9bc3 git log 2f0b41d4e7f8..0e413afc9bc3 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 lalitm@google.com Merge "tp: cleanup json and fuchsia trace flags" 2020-02-27 ddrone@google.com Merge "Fill ChromeLatencyInfo args using proto descriptor" Created with: gclient setdep -r src/third_party/perfetto@0e413afc9bc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I875ef1c35043b369ac0bce8c5dd99768ce313fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079337Reviewed-by:
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I959c0e21765c968910f3d64faa4102fc86d032ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066491Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745252}
-
- 27 Feb, 2020 26 commits
-
-
Anastasia Helfinstein authored
Previously, there was a bug in Switch Access where the user could set two commands to the same key, leading to ambiguity in expected behavior. This change adds validation, and un-sets any commands previously set to a key. Bug: 1056310 Change-Id: I61569cdcdca13a38923db1d34b0577fc02ec1a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075054 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#745251}
-
rbpotter authored
In Polymer 3/JS modules, there is no settings global namespace and undefined variables cause an error, so the edit dictionary page cannot simply check the global settings.languageSettingsPrivateApiForTest. Instead, use the LanguagesBrowserProxy in the edit dictionary page to get languageSettingsPrivate, and add a way to set this value in the TestLanguagesBrowserProxy so that it can be overridden for tests. Bug: 1026426 Change-Id: I8aa69ac6a3272b74195ca6bb9c1b41ad0b3bdd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076787 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745250}
-
tby authored
Note this doesn't affect TopCat. Tested manually, as this behaviour is a bit tricky to isolate from the rest of the launcher search setup. Change-Id: Ifa2f3c7cfdf2c3de39ac48f159dc584762322293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076041Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#745249}
-
Zhaoyang Li authored
This reverts commit 95ba7404. Reason for revert: This change caused ios_showcase_eg2tests_module failures since https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2803. Original change's description: > [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal > > Showcase should not depend on //ios/chrome/app (except for the hooks). > The dependencies were unnecessary and can be safely removed (after the > removal of one stale #include). > > After this CL, there is no dependency on //ios/chrome/app:app_internal: > > $ gn path out/Debug-iphonesimulator --all \ > //ios/showcase:ios_showcase_egtests \ > //ios/chrome/app:app_internal > No non-data paths found between these two targets. > > Bug: 870935 > Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744923} TBR=sdefresne@chromium.org,edchin@chromium.org Change-Id: I15a0b32382ac1ff8133b99adb9a317e965a8cf86 Bug: 870935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079148Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#745248}
-
Katie D authored
TBR=pfeldman@chromium.org Bug: 1013003 Change-Id: I2ac37d06ef9cedc90f250509148ddb37bacd2728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079534Reviewed-by:
-
Thomas Lukaszewicz authored
Fixed a bug in ExtraInsetsBorder where the ExtraInsetsBorder was composing the original border but neglecting to set the color in its own Border superclass. This resulted in the border painting correctly but returning the incorrect placeholder color when asked for its color through the Border's API. Added unit test to guard against regression. Bug: None Change-Id: I71613ed468384dc3780e2acb76a43351e96d3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069498 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device power page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ied133db18f986ab7a78d9d120d5e162403a8a0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067460 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745245}
-
Jeff Yoon authored
Bug: 1055330 Change-Id: I5b6adc215b87f4fee4652e22f71d32d5c62d6a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078732Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#745244}
-
Eric Orth authored
In HostResolverManager::RegisterResolveContext(), perform an initial cache "invalidation" (in this case, more of an "initialization") to load the current DnsSession (if there is one) into the ResolveContext. This will allow DoH requests and other transaction operations requiring per-context state to work if the context is created after the last config load or connection change. Bug: 1022059 Change-Id: I6c6eddd9ae992430b5c72f00caf03e9694be56a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068833Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#745243}
-
Aaron Gable authored
These testers are triggered by "Android arm Builder (dbg)". Unfortunately, these testers all have very limited capacity, e.g. only 3 hosts for "KitKat Tablet Tester" (http://shortn/_FgzmFPwSjC). In addition, it is not strictly necessary to run these testers on the branches, as they are not run as part of Branch CQ; only the compiler is mirrored onto CQ as "android_compile_dbg". This CL removes these testers from the branched CI configuration. In order to ensure that they continue to be appropriately triggered on master, it adds a munger which ensures their scheduler tasks have the appropriate names. In order to ensure that their absence doesn't break the branch builders, it adds a generator which creates no-op jobs with the appropriate names. Bug: 1049150 Change-Id: Ie87bfc88580811e357feaaea0aeda9412e001f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076703Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#745242}
-
Sam Maier authored
Bug: 1044330 Change-Id: Iebf1ec10f334cd0ecef416c5e02fa533e01de3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079135 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#745241}
-
Michael Thiessen authored
In order to avoid loading the native library really early for use cases like the SearchActivity, which caches a URL and uses it immediately on Activity creation, we can serialze and deserialze GURLs. See https://chromium-review.googlesource.com/c/chromium/src/+/2071376/6/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestion.java#244 for more context. The serialization is quite simple, as GURL is comprised of ints, bools, and a string. Further, if the version changes, instead of having to be backwards/forwards compatible, as long as the GURL is the last token and the delimiter doesn't change, the GURL can simply be re-parsed from the spec at a small startup cost due to having to load the native library early. Bug: 783819 Change-Id: I4ac94c44e8041612d672ad52a92c83247e20c37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076400Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#745240}
-
Tommy Li authored
NTP realbox does not have the UI facilities to handle keyword matches, especially of the explicitly-substituting form "google.com search terms here". This discourages their appearance in the same way Android does, by disallowing exact keyword matches. I think this will suppress them to the exact same extent they are suppressed on Android. Bug: 1021793 Change-Id: I75784f58f4474f166e0bcd05ebd871d77ff5e7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079335Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#745239}
-
David Schinazi authored
Change-Id: If72b48f88132780f79f90c29117d240e099fc2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079149 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#745238}
-
Cathy Li authored
This is a reland of 21245a70 TBR=twellington@chromium.org Original change's description: > [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec > > Change-Id: Ib77234174ece4facb35596808fd964a18db04311 > Bug: 1054944 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744352} Bug: 1054944 Change-Id: I5f6c81e1740e418307c3365bd13969769d99472a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078794 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#745237}
-
Johannes Henkel authored
"Tweaks for emitting JSON" https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2071518 TBR=caseq Change-Id: I6dc2c9270805b8dca1bca453939459bfcbff2a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072854Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#745236}
-
Henrique Nakashima authored
Bug: 1012975 Change-Id: I9dc088b3a6b6bfcc50675668c52ae7157124c1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079336Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745235}
-
Dan Harrington authored
- Added interface class, FeedNetwork, that can be faked for tests - Added FeedNetworkImpl implementation. This copies largely from FeedNetworkingHost, but implements a slightly different interface. - I've changed the package for feed wire protos to feed_wire, since long chains of namespaces aren't great for C++. Java imports remain unchanged. Bug: 1044139 Change-Id: I7a430d80629087df52a1f77ac757a6ebd62ac933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032089 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745234}
-
Varun Khaneja authored
This reverts commit f493cb2e. Reason for revert: The change doesn't cover all affected files and I have a more comprehensive patch coming soon. Bug: 1054978, 1056696 Original change's description: > Disable full url check for pdf files. > > Bug: 1054978 > Change-Id: I6bcd7fe1b30134acd6dd123805c4ce283a707ed5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072591 > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744488} TBR=vakh@chromium.org,xinghuilu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1054978 Change-Id: I0a97986fe633acfda86a7610e434d596666075cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079145Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie492e30a75fdf07a134adcc600ae05f7b7c0f989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078553Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#745232}
-
Mark Schillaci authored
This CL creates a throttling/debouncing effect in Android that will limit the number of events being sent by Chrome. We decided to go with an approach that is a mix between a typical "throttle" and "debounce". We want to ensure: 1. No solitary (first) event is delayed 2. The last event sent is accurate 3. No two events of the same type are fired in a given timespan When we are ready to fire an event of a type that has not been fired before, then we send it without any delay. We record this time to start a timer, and we enforce the rule that no event of the same type can be sent within that delay window (200 ms). When an event of a duplicate type is sent in that window it is queued to be sent after the delay. Any subsequent events would replace the event in the queue but not modify the delay time. This ensures we never delay an initial event, the final even sent is the final event received, and no two events of the same type can be sent in any 200 ms timespan. Bug: b143730839 Change-Id: If17e946ee394b22da0a9e6c290a725dcaf9bac34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067443 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745231}
-
Kent Tamura authored
HTMLOptionElement's InsertedInto() and RemovedFrom() called MenuListSelectType::UpdateTextStyleAndContent(), which updates a Text node in a UA shadow tree. It triggered a DCHECK failure about IsSlotAssignmentRecalcForbidden(). We should not update the DOM tree in these functions. This CL moves the logic of the InsertedInto() and the RemovedFrom() to HTMLSelectElement::ChildrenChanged() and |HTMLOptGroupElement:: ChildrenChanged()|. As for kAllChildrenRemoved such as |select.innerHTML=''|, ChildrenChanged() had no ways to know removed nodes. This CL adds ChildrenChangedAllChildrenRemovedNeedsList flag, and ContainerNode provides a list of removed nodes if the flag is true. This CL also updates comments on Node::InsertedInto(), Node::RemovedFrom(), and ContainerNode::ChildrenChanged(). Bug: 1056094 Change-Id: I5a28a371b8bacd6551f17acfaf681032d615f1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074840Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#745230}
-
David Bokan authored
This CL fixes an issue introduced in https://crrev.com/c/1999288. Scrollers can set |user_scrollable_horizontal| (or vertical) to false to indicate that the user shouldn't be able to scroll them This corresponds to |overflow: hidden| in CSS (which can still be programmatically scrolled). In several places, compositor code checks these bits and, if false, clears the requested scrolling delta in the disabled axis. The bug in the CL above was that, now that the scrolling paths were consolidated, we moved this "user_scrollable" adjustment from the update animation curve to happen as part of the common path in ScrollUpdate so that it would happen for all kinds of scroll modalities in one place. However, this adjustment is too simplistic for viewport scrolling. Scrolling the outer viewport must use the cc::Viewport class which will distribute the scroll between both inner and outer scroll nodes. The outer viewport may have user_scrollable=false, corresponding to the documentElement having |overflow: hidden| but we should still be able to scroll the inner viewport if the user zooms in. The above adjustment prevents that since it clears the delta. (I suspect this issue existed prior to this in the "update existing animation" case but is hard to hit since pinch-zoom and animated wheel scrolling aren't a common combination). The solution here is to move these adjustments to the point of node scrolling. This means that we'll adjust the delta right before applying a scroll to an individual ScrollNode. This ensures the entire delta is sent to the viewport which has special cases for dealing with the double nodes. Bug: 1055790 Change-Id: I2e9849b15c512003352299fc82e58817a98ef778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072407 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#745229}
-
Yue Li authored
Bug: b/150238588 Test: Running the test locally for 20+ times Change-Id: I320c8a3c0d1f2e2cfc0155de950632649025c633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076795 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11efa18eca9f..dbb0a25d1fab git log 11efa18eca9f..dbb0a25d1fab --date=short --first-parent --format='%ad %ae %s' 2020-02-27 senorblanco@chromium.org Skia-Dawn: update for recent GrRenderPass::onDraw* changes. 2020-02-27 bsalomon@google.com Fix NVPR with explicitly sampled FPs. 2020-02-27 mtklein@google.com add metadata to calculated bounds Created with: gclient setdep -r src/third_party/skia@dbb0a25d1fab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I22cb2c0c4aa687f85e4b25085da778fc51bb1281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079282Reviewed-by:
-
Christopher Thompson authored
Bug: 1055906 Change-Id: I974c8cc5993299a6611c4bd14f515c865d9bef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073218Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
