GitLab

Bug: 32486634
Test: CQ
Change-Id: I0b915491c79ff05cb63e874973e5842af0add252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063152Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Yilong Yao <yilongyao@google.com>
Auto-Submit: Yilong Yao <yilongyao@google.com>
Cr-Commit-Position: refs/heads/master@{#742899}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9e2a2ae74ddf..0cf5b5b69d21

git log 9e2a2ae74ddf..0cf5b5b69d21 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 kahinds@microsoft.com High contrast support for the Security Panel

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@0cf5b5b69d21

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1048378
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8d71d30d64d01913f99d796200c0f2da7d5da19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742898}

The Pixel 4 has wide color gamut enabled. However, a CL [1] accidentally
caused the Pixel 4 to look muddy. This was because it no longer set the
color space on the texture.

For Android, when using the scanout usage for shared images, we always
use the AHardwareBuffer backing. The GL backing was setting the color
space, but the AHardwareBuffer backing was not. And in our wide color
situation, those shared images were using scanout.

This CL sets the color space of a shared image with AHardwareBuffer
backing.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1977969

Bug: 955158
Change-Id: Id811457e6198ba2b9cbe9667817edc385aa5ef4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065430Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742897}

Extend the expiry date for
WebAudio.OfflineAudioContext.SampleRate384kHz and
WebAudio.ConvolverNode.ImpulseResponseLength.

Bug: 1053180, 10531819
Change-Id: Iba98dfe64cd50751cf15dc4d15fa0d8e812a6450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062889Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742896}

This CL replaces .mojom.h includes with .mojom-forward.h in some
sub-directories of chrome/browser to reduce the pre-processed size
of header files and shorter build time. The sub-directories are following,

  - chrome/browser/prefs
  - chrome/browser/previews
  - chrome/browser/printing
  - chrome/browser/profiles
  - chrome/browser/profiling_host
  - chrome/browser/push_messaging

This CL has no behavior changes.

Bug: 1001360
Change-Id: Iccdf29a73e1673cb17a84f33770e722614e3dd12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061920Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742895}

This CL:
1- Updates the tabStripLegacyCoordinator to use Browser
   instead of TabModel.
2- Update TabStripController to use Browser instead of tabModel:
  - Change methods & variables to be more suitable to the usage of
    webStateList.
  - Change the type of indices related to the WebStateList to int.
  - Get the dispatchers from the browser instead of getting them
    from the initializer.
  - Remove initializeTabArrayWithNoModel, as there was no way to
    provide the controller no TabModel earlier, which means that
    was a dead code.
  - Updates the test to use TestBrowser instead of the fake tabModel.

Bug: 1049918, 1048683
Change-Id: I4183ce90df9dafd0182c4fa9f03834f21f507cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043077
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742894}

This reverts commit 6d514087.

Reason for revert: b/149569123

Original change's description:
> [Chromecast] Refactor and Simplify CastWebView
> 
> CastWebView forces too much indirection from the underlying page/window
> functionality, so some forwarding methods have been removed in favor of
> calling the members directly. This is presently not ideal, but will be a
> great improvement once the CastWebContents and CastContentWindow are
> surfaced as mojo interfaces via CastWebService and their lifetimes can
> be tracked independently.
> 
> The CastWebService API has been simplified so that clients no longer
> need to provide a SiteInstance when creating CastWebViews. The renderer
> preloading logic, which was previously disjoint from CastWebView, has
> now been incorporated.
> 
> Merge-With: eureka-internal/331288
> 
> Bug: internal 77879457
> Test: CQ, manually verify on display assistant device.
> Change-Id: I72fc57f0669783f61076626962d47b72d93463f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968257
> Reviewed-by: Yuchen Liu <yucliu@chromium.org>
> Commit-Queue: Sean Topping <seantopping@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740143}

TBR=sanfin@chromium.org,seantopping@chromium.org,yucliu@chromium.org,lijiawei@chromium.org,mdellaquila@google.com,zxliang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: internal 77879457
Change-Id: I9a6445b7a76e681e2f9c7e155c18058481e88684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065850Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742893}

MontionNotify XEvents coalescing logic has been accidentally lost after
the PlatformEvent migration CLs have landed (crbug.com/965991), what
leads to some performance hit/regressions. This patch adds it back as an
attempt to address regressions reported at crbug.com/1051325. Even
though the numbers the report seem quite noisy and unstable, [1] shows
that this was the major cause for such perf regression.

R=thomasanderson@chromium.org

[1] https://pinpoint-dot-chromeperf.appspot.com/job/172c2f5a620000

Bug: 1051325, 965991
Change-Id: Ib5d06867d97633c3593584222571b8d910deb304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062098Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742892}

SSLUITest no longer relies on extensions methods to installs web apps.

Bug: 1052722
Change-Id: I2a091b370d729494dc06594f592e7d278b9825de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063514
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742891}

Bug: 1051951
Change-Id: I15a292404566c71ad1a508bf9e03ff0dd96fffd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056747
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742890}

Change-Id: I531edc4cbae26cac9ac4dc256d2fcd938c13f3d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062642
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742889}

This metric tracks time spent in DOMSnapshot::captureSnapshot calls.

Drive by: subtracted v8 compilation duration from tasks duration
when calculating other tasks duration. This ensures correct stacking
known activities.

Change-Id: I79c6926d516c02717b68ea426e3e99a7d9fd665e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062691
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742888}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22b9a1c0f1f7..e7fe1d07ef46


Created with:
  gclient setdep -r src-internal@e7fe1d07ef46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I22170260fbf52f10e64a5705c4fbfe896a77f941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065394Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742887}

https://android.googlesource.com/platform/external/perfetto.git/+log/638948939287..c08fcf30d513

git log 638948939287..c08fcf30d513 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 primiano@google.com Integration test: don't force-disable ftrace on test runs

Created with:
  gclient setdep -r src/third_party/perfetto@c08fcf30d513

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:149717312,chromium:149802754
Tbr: perfetto-bugs@google.com
Change-Id: Iec8beca2375b46a203c61a7e4e585b5c7cdc8b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065389Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742886}

https://pdfium.googlesource.com/pdfium.git/+log/1217cd17daba..d15d718e8d5e

git log 1217cd17daba..d15d718e8d5e --date=short --first-parent --format='%ad %ae %s'
2020-02-19 tsepez@chromium.org Protect owning layout item in all UpdateFWLData() overrides.
2020-02-19 nigi@chromium.org Roll third_party/binutils/ 01aa7745b..ffd1fdb90 (1 commit)
2020-02-19 nigi@chromium.org Roll tools/memory/ f7b00daf4..89552acb6 (1 commit)
2020-02-19 nigi@chromium.org Roll third_party/instrumented_libraries/ 4dca59c6a..bb3f1802c (1 commit)
2020-02-19 tsepez@chromium.org Pass spans to UTF8Decode() in cfx_seekablestreamproxy.cpp

Created with:
  gclient setdep -r src/third_party/pdfium@d15d718e8d5e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1040329,chromium:1052786,chromium:1053617
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I38b0499a67c4f681302621455ddd7dca9011c4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065391Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742885}

Previously, this check was only made in the renderer process, which
isn't quite as trusted. Checks like this should all be done in the
browser process.

Bug: 1034023
Change-Id: I5c9303f0f2947f65467780550da797b0cef8a568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064828
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742884}

This change updates the expiration date on Bluetooth histograms expiring
after M82 to expire Jan. 31, 2020. These histograms need to be checked
if they are still useful to keep around.

Bug: 1052936, 1052937, 1052935, 1052934, 1052933, 1052932, 1052931
Change-Id: I06c21f8dc1ea17bef50b229df1be828e45ee89e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062905
Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742883}

Apply the same functionality that SBER has for user
with Enhanced Protection for download protection.

Bug: 1054092
Change-Id: I8f1d0fd86768a6fb54f1d3a337fc552c4791bf5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064811
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742882}

If the user drags the volume slider, the volume is changed many times in quick succession. We are only interested in logging the final change, so this timer ensures that an event is only logged after a small pause.

Bug: 1014839
Change-Id: I102f1cc4b1309a5ef59dc943dd76055e9960d98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063611
Commit-Queue: Rachel Wong <wrong@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742881}

Mostly replace "export" (which is a keyword) with "foo_export" (used
in the example at the top of the file). No behavior change in
practice, but a bit cleaner.

And replace MSVC_HACK with DLLEXPORT, since that replacement is only
used when __declspec(dllexport) is in use. (Actually, use EPXORT_DLLEXPORT
for now because nacl.)

No behavior change.

Bug: none
Change-Id: I8e140bc38823d168af6b71a88ee9f7a66c604b7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062881Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742880}

This is a follow-up for crrev.com/c/2031429 which disabled the
optimization of descendant background paint phase, and
crrev.com/c/2042262 which disabled the optimization of paint invalidation
for empty contents. The CLs caused no regression based on UMA results, and
acceptable regression for several perf tests, so we decide to move
forward to remove these regressions and implement the simplest solution
of hit testing of transparent backgrounds in CompositeAfterPaint.

Bug: 1049440
Change-Id: Ib21a02d893bffe724c0b2db0bb6e46953e8d0a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063251
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742879}

The elide for notification buttons was disabled to fix a
relatively smaller bug. Need it enabled for
correct functionality with longer labels.

Bug: 1043643
Change-Id: Ia38f5586d636e1e06033ed468275d2dfe28bf6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065549Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742878}

Bug: 1049675
Change-Id: Ide9d8a6fccbb53573d57c3232de2f7d5d3986647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065349
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742877}

This CL continues the process of separating the strings into specific
files. Strings used by both Chrome OS and Chrome browser settings sync
page are removed from setting_strings.grdp and added into
shared_settings_strings.grdp.
This effort was started in parent 2042733.

Bug: 967883
Change-Id: I69805e86cce0806841dad8d17d44d8707728b802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050877
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742876}

This ensures that utility processes don't end up starting with a
different on disk binary than is currently running.

This works by adding a new "--no-zygote-sandbox" command line flag
which is set in ZygoteCommunication based on a construction flag. It's
used to launch the zygote without the setuid and namespace sandboxes;
which sounds scary, but is already the case today for utility processes
with specialized sandboxes (net, ime, audio, soda).

Within the ZygoteMain this functions as if "--no-sandbox" was specified
to the Zygote and skips its sandbox setup. The actual sandbox is later
applied by UtilityMain().

Bug: 22703,1049234
Change-Id: Ib61e7c71c6ee43e2ab518fa0ed109bea36677bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047932Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742875}

Extend this UMA expiry date until Chromium M90.

Tbr: slangley@
Bug: 1046009
Change-Id: Ibb6856cd8ffa907927cee2950bf9e9cd2639363b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065248Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742874}

Change-Id: Iafa88f696ee5a5b7c51cf7a65a9f210c8e2ea4aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065568
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Jason Lin <lxj@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742873}

Changes in response to post-commit comments on:
 * https://crrev.com/c/2050212
 * https://crrev.com/c/2049003
 * https://crrev.com/c/2050049

Bug: 1007822,1007821,1007823,1007825,1007826,1007828
Change-Id: I5124ef2169f62c14f00fd451ae8f2f40c5739d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063613
Commit-Queue: Joey Scarr <jsca@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742872}

https://chromium.googlesource.com/openscreen.git/+log/3aa23228350c..f14fa29a7b1d

git log 3aa23228350c..f14fa29a7b1d --date=short --first-parent --format='%ad %ae %s'
2020-02-19 btolsch@chromium.org Add unsigned long long ByteSwap support

Created with:
  gclient setdep -r src/third_party/openscreen/src@f14fa29a7b1d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Ic4330bc60659c46ffb1df80ae1bd2b54d705cf05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065395Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742871}

Bug: 939235
Change-Id: I61f938a9af5357de1d151ab056138b8614a5f029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059703
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742870}

Browser type app can also support tabs and should allow
tab accelerators (select next tab, select tab N, etc)
when tabs are being used.

Browser::SupportsFeatures(Browser::FEATURE_TABSTRIP) provides
the logic to detect when tabs are supported.

Bug: 1033334
Change-Id: I2e97d5d59f3b21233394c3c382fdc1fcefae3438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062022
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742869}

The installer/upgrader web page has its own closing logic to handle esc
key. The dialog code has logic to make sure that it is not forced close
on esc key so that the web page can have a chance to handle it. But this
behavior is broken by CL https://crrev.com/c/1877088. This CL fixes it
by implementing the new ShouldCloseDialogOnEscape() method.

Bug: 1053376
Test: manual
Change-Id: I4cbd9f9e0a6cfec53ff6c7a54c35b326361c5063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060367
Auto-Submit: Jason Lin <lxj@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742868}

1) Rename InstallManager::InstallWebAppFromSync to InstallBookmarkAppFromSync.

2) Move the check we introduced here:
https://chromium-review.googlesource.com/c/chromium/src/+/1981239
to WebAppInstallManager::InstallBookmarkAppFromSync() so web apps team owns it.

3) Demote DCHECK(provider) to if(provider) to avoid crashes for legacy
or bizarre profiles with bookmark apps data in them.
If you try to run chromeos-on-linux binary for a profile data dir created
by chrome-linux binary, you get the "bizarre" profile.

This CL doesn't introduce any behavior changes.

We will implement migration of bookmark apps arriving from the sync
server in follow up CLs under crbug.com/1020037 task.

Bug: 1020037
Change-Id: Ic7861734b6bbcb9fe228eb513782251ba8b4ff32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060220Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742867}

Using wpt-import in Chromium 870e8fca.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I836194645a83a8e3c55201d8d8642d0c65d94c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064891Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742866}

Extend this UMA expiry date until Chromium M90.

Tbr: slangley@
Bug: 1052985
Change-Id: I533e5995923e380069d40396725e9c06f1988f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065188
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742865}

Bug: 634140
Change-Id: I8f539e99b1a48bdff96e1d100be4e2cdb8ea9be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054470Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742864}

Bug: 149759085
Test: run integration tests
Change-Id: Ie5e146a26afed1d71a8d303fd940446f01cedc7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064773
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742863}

Previously most parts of the code would check if origin policy was enabled, but one part would check if origin policy was enabled *or* if experimental web platform features was enabled. The intention is to have experimental web platform features imply origin policy, which can be done through content_switch_dependent_feature_overrides, and then only having to check if origin policy is enabled.

Bug: 751996
Change-Id: I2da004e77ecc8b72e426b8c62ab944837a92d6a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063046Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742862}

This ensures that every utility process sandbox type actually results in
the created process being sandboxed. This has always been important, but
will become slightly more important when we start spawning from an
unsandboxed zygote.

This works by creating a SandboxStatusService mojo service which is test
only and exposes it on created utility processes. The test then simply
creates a utility process with every sandbox type ensures the sandbox
status is non-zero for types which should be sandboxed.

R=rsesek

Bug: 22703,1049234
Test: It's all tests!
Change-Id: I512f7aa77c20ba66e66cf448bfdabf5865a487e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055993Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742861}

Fix reference links and bullet lists to render in md_browser.py, and add
some paragraph breaks for readability.

Bug: 1045064
Change-Id: I48e69df7019a6c43cbb0d44f453fefefd721b9c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063137Reviewed-by: Tom McKee <tommckee@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742860}