- 07 Oct, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 181fcf74. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I73071fffd365d907f534a7ef984340c13235819a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844393Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703249}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5e9d4ee99ea1..23d6a0e668bf git log 5e9d4ee99ea1..23d6a0e668bf --date=short --no-merges --format='%ad %ae %s' 2019-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 135e3e35ea87..4b97a1108114 (1 commits) Created with: gclient setdep -r src/third_party/angle@23d6a0e668bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I25840131d002ef731947ea2e8708df06f3050f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844233Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703248}
-
Mario Sanchez Prada authored
This file was out-of-sync after recent migrations, let's fix it. Bug: 955171, 978694 Change-Id: Id6a85b66c50cd36d64bf9b4d8e1c04860959a48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844973Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703247}
-
Patrik Höglund authored
Tbr: rogerta@chromium.org Bug: 1011193 Change-Id: I3a3abad10e5b75a7e5c0bb1aadf6ea7415e0fd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844976Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703246}
-
Fredrik Söderquist authored
This adds a |is_updating_intervals_| flag to SMILTimeContainer, and sets it in UpdateIntervals() and when calling Reset() on the sandwiches. When this flag is true SMILTimeContainer::ScheduleIntervalUpdate() will not schedule an update since UpdateIntervals() (in both cases) will handle the update. This should allow getting rid of the SVGImage::ScheduleTimelineRewind() hack. Bug: 998526 Change-Id: Iad31f2684db40dc71f254d7d19f57a4538272a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841332 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703245}
-
Benedikt Meurer authored
Previously the DevTools UI would strip out //# sourceURL=... and //@ sourceURL=... lines from the script in the frontend no matter where they showed up in the source code, which means that all the positions after this line will be off by 1 between frontend and backend. It's generally also very confusing to developers that we're removing code from the script before showing it. In general, we should just display exactly the code that the developer wrote (similar to Firefox DevTools and Safari WebInspector), however there's quite a bit of internal logic relying on the special handling of sourceURL comments (at the end), for example when it comes to snippets. So meanwhile we only remove the comments when they are found at the end of the source code, which is where tools put them. Bug: chromium:1003497 Change-Id: I4404e2f7b6b61d50f85e44bbd9e0ae56675670af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840512 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703244}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8fa0f1a6567c..c18c9ff6bc30 git log 8fa0f1a6567c..c18c9ff6bc30 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 stevenperron@google.com Handle OpKill better (#2933) 2019-10-04 greg@lunarg.com Generate null pointer by converting uint64 zero to pointer. (#2935) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c18c9ff6bc30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I31896afdb0faf401a9cb53270856885b14e67a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844073Reviewed-by:
-
Kenichi Ishibashi authored
To generate better trace log for performance investigation. Bug: 1011214 Change-Id: I7dc2e5d0c06674e1e11322d3d41975f040b68825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844522 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703242}
-
Colin Blundell authored
This value has no meaningful usage in the codebase. Its removal has ripple effects: - chrome_extension_messages.h is no longer needed and is removed - cast_extension_messages.{cc, h} are no longer needed and are removed This CL is part of the ongoing effort to eliminate the legacy IPC system. Change-Id: Icc8a679d0da0f58df99f9692ba2be5ebee42966b Bug: 1007300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834091 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#703241}
-
Dave Tapuska authored
These definitions are no longer needed. BUG=978694 Change-Id: Ia066b668bc60754101d0e267e9669f082a7bb5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842036 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#703240}
-
Rohit Agarwal authored
This reverts commit ca5efa8e. Reason for revert: A regression bug was crbug.com/1009377 created because of this CL. Original change's description: > Restart in the profile type that invoked it. > > If the user started the browser in incognito mode and > triggered a restart in regular mode, the browser was started > in the incognito mode. Similarly, if the user started in the > regular mode and triggered a restart in the incognito mode, > the browser was started in the regular mode. > > The fix is to find the profile type that invoked the restart. > Then use this type to modify old switch arguments which are used > to create the new cmd line arguments for restart. > > Bug: 999085 > Change-Id: Ide6e86aabb90b5a333ec10ea23e3add62a3d0e34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789582 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694717} TBR=vasilii@chromium.org,rhalavati@chromium.org,roagarwal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 999085 Change-Id: Ie3351c13cdb8f01f1e5c5088c7c6e72f936d569f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839793Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703239}
-
Patrik Höglund authored
This should be re-enabled when the root cause is found. Tbr: mythria@chromium.org Bug: 1011515 Change-Id: I563e102241896021f1b0837953db00c958097aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844953Reviewed-by:
-
Ewann authored
-call |-removeEmptySections| in |-setEditing:animated:| before resetting the property. needsSectionCleanupAfterEditing needs to be removed when dropping iOS 12. Bug: 998491 Change-Id: I38cef305e1763120b402f1904f21c29c48ce024a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832273Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#703237}
-
Yuki Shiino authored
Bug: 1011723 Change-Id: Ib87b425eebfb43234f54b5d696856a59b9b33cb1 Tbr: aaronhk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844753Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#703236}
-
Patrik Höglund authored
Appears someone attempted to disable this, but it's DISABLED, not DISABLE. Tbr: emaxx@chromium.org Bug: 1011606 Change-Id: I00e8dc774029c811fbce4ab4874135f749ff5013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844812Reviewed-by:
-
Peter Kasting authored
Also other misc. cleanup, e.g. use make_unique more. Bug: 82078 Change-Id: Ibe4384e74b905d4fc60392edf258663ddc6bc5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844339 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#703234}
-
Andreas Haas authored
We want to reduce direct uses of WTF::ArrayBuffer and co in the context of a refactoring. R=hongchan@chromium.org Bug: chromium:1008840 Change-Id: I3d5ec9c4484821cb9954ecbcafb27091e597d03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828906Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#703233}
-
Kenichi Ishibashi authored
This CL introduces yet another variant of FetchClientSettingsObject which is used for passing FetchClientSettingsObject between blink and content. For now it is only used for dedicated workers but we plan to use WebFetchClientSettingsObject for service workers too. Ideally WebFetchClientSettingsObject shouldn't be needed. Once the Onion Soup is done we should just use mojom::FetchClientSettingsObject. This CL does not change existing behavior. Bug: 937177 Tbr: kinuko@chromium.org Change-Id: I224eadeca49ac4a18c3fdf4ef8507e7eb2be4d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843995 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703232}
-
Francois Buergisser authored
Currently, the picture size is set to the CAPTURE buffer but CAPTURE buffer references the picture size of the OUTPUT buffer. If the picture size if set to CAPTURE, Hantro will ignore it and use the OUTPUT picture size which is not set, therefore using the minimum size available (48x48). This patch sets the picture size to the OUTPUT buffer instead of the CAPTURE buffer following the initialization specification for m2m stateless video decoder [1]. [1] https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-stateless-decoder.html#initialization BUG=chromium:1009935 TEST=ran video_decode_accelerator_tests with test-25fps.h264 and test-25fps.vp8 on veyron_minnie-kernelnext. Signed-off-by:
Francois Buergisser <fbuergisser@chromium.org> Change-Id: Ib343d8a0b177470aa39018141170212c1f524979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832851Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#703231}
-
Hiroshige Hayashizaki authored
Initially we considered forbidding scripts moved between different *context* documents, but it might be be helpful for code health to also forbid scripts moved between different *element* documents. In order to investigate its feasibility, this CL adds a use counter for such scripts. Bug: 721914 Change-Id: I09a984dab98f615ee9a75d72edb1220cba42627f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843509Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#703230}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e92ee0ae0d32..d9301feae3fd git log e92ee0ae0d32..d9301feae3fd --date=short --no-merges --format='%ad %ae %s' 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5549ef0451f9..5e9d4ee99ea1 (14 commits) 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6021fbd09b1c..036463457e5f (8 commits) 2019-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 24e29940..78225ef2 (481 commits) Created with: gclient setdep -r src/third_party/skia@d9301feae3fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I1c028318152cf8e89307011cd9a261abbef4161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844209Reviewed-by:
-
Koji Ishii authored
Ran rebaseline-cl twice but this test doesn't stabilize only on Mac10.10. TBR=yukishiino@chromium.org NOTRY=true Bug: 1011453, 1010662 Change-Id: I147d1c81d3a5c4be0a36c173109cd25ddb67a22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843799Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#703228}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7eb4caf5..523df09a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7c72a0e1d2043de6dbdb2683e824e3e14ca0279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1f4e5bcb19ea..1167bff3e9a6 git log 1f4e5bcb19ea..1167bff3e9a6 --date=short --no-merges --format='%ad %ae %s' 2019-10-06 wl@gnu.org * src/sfnt/sfwoff2 (reconstruct_glyf): Fix reallocation. 2019-10-06 wl@gnu.org Improve memory debugging. 2019-10-06 wl@gnu.org docs/DEBUG: Document environment variable `FT2_KEEP_ALIVE'. Created with: gclient setdep -r src/third_party/freetype/src@1167bff3e9a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Idbeb0c24828d6bf779664f0778c0805ed8373415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844196Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#703226}
-
Chromium WPT Sync authored
Using wpt-import in Chromium da0efe3e. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" 69c11064 "[WPT/upgrade-insecure-requests] Regenerate files" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ie8f3ff9b2682db625b275e78ed02dac29e6cb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844032Reviewed-by:
-
Maksim Sisov authored
It is no longer needed to have a post task when frame type is changed. That workaround was added in https://codereview.chromium.org/2597733002 to fix these tests (see also see https://codereview.chromium.org/2594533003): TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest TwoClientThemesSyncTest.CycleOptions_E2ETest SingleClientThemesSyncTest.NativeTheme As these tests pass now, remove the workaround and just use DWTHPlatform::FrameTypeChanged impl. Bug: 990756 Change-Id: Ibb10a5b925116ede7e6f73cefea3891f0dc7c35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834087 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#703224}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: Ia22f86a9f020c4f9421b1f2e3c963cf24ed08391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844002 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yang Guo authored
DevTools frontend is moving to a separate repository and pulled into a separate path. It would be nice to have this test not point to a non-existent path (even though the file does not exist either). Change-Id: Id5ce7cd3057617fd5880968cb7aab3ec064fe5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840235 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Canon Mukai authored
The previous version of DecompressionStream accepted only Uint8Array as its input, so I added change to accept ArrayBuffer and other ArrayBufferView like Int16Array. I also added a test. Bug: 999091 Change-Id: I8c153c3f639cb4e9b8563128e4cce1e6c6597cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831920Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#703221}
-
Alexandre Courbot authored
SetInputFormat() and SetOutputFormat() use the V4L2 queues. Make sure they are acquired before calling these methods. This bug slept in because I forgot to specify --use_vd to the unit test. Bug: 1003223 Test: video_decode_accelerator_tests --use_vd passes on Kevin. Change-Id: I3847c9ba947739e673a106a7d2d3139b1ec432b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844519 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#703220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a703cbaf0526..0c59193cb7ce Created with: gclient setdep -r src-internal@0c59193cb7ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If27c5766744ba6192e48c5f9ce0ee4c97db2ffaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844357Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703219}
-
Adam Rice authored
It's a nuisance for modules/ OWNERS to have to review CompressionStream CLs, so add a specific OWNERS file. TEAM and COMPONENT are the same as StreamsAPI for now, until we need something more specific. BUG=999091 Change-Id: I7a09a310f0ce52027f070f818948981278b678c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844521Reviewed-by:
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I282e3e334670f66fc2d5e4b9060fa619a9d57d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843999Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#703217}
-
Mikel Astiz authored
During trusted vault passphrase, the existence of pending keys should be signaled using OnTrustedVaultKeyRequired() instead of OnPassphraseRequired(). This patch fixes the calling site in NigoriSyncBridgeImpl::Init() and refactors the code to centralize all calling sites to prevent similar issues in the future. Bug: 1010189 Change-Id: I408279ff56c8e21aae05c498cf1238e1827b2ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840632 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#703216}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7d9c0d86c82..e92ee0ae0d32 git log a7d9c0d86c82..e92ee0ae0d32 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e92ee0ae0d32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ie8d9527446110f203bc1d0b1804d9620f68b554e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844336Reviewed-by:
-
Yutaka Hirano authored
This is a follow up change for https://crrev.com/8ee3f7e6d3a79b15824b6e286eb71c0a96c4d879. See its CL description for details. I forgot to migrate a callsite in https://crrev.com/c/1830252, so I'm doing that here. Bug: 961614, 1006292 Change-Id: I74f2817d9958fb2cb7e265c0069590fea2f2844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844516 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c9256e16303a..4102985e1427 git log c9256e16303a..4102985e1427 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4102985e1427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I7bf03dec074e978f6b06e762c90b6a44d40da13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844433Reviewed-by:
-
Alexandre Courbot authored
V4L2Queue::SetFormat(), which has just been introduced, has a serious bug: it always tries to set the format on the CAPTURE queue. This error slept in because I forgot to test with --use_vd. Bug: 1003223 Test: video_decode_accelerator_tests --use_vd passes on Kevin. Change-Id: Ibfb9684e66ea0d1f64801935ad6bc2c5460c03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844518 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 1edbfe77. Reason for revert: The revert causes a build breakage. https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/14339 Original change's description: > Revert "media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method" > > This reverts commit 173e2342. > > Reason for revert: Suspicious about causing failures at: > https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/16980 > > Original change's description: > > media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method > > > > Having information about the format currently set on a queue is > > valuable, e.g. to validate queued buffers. Rewrite the output queue > > format setting method of V4L2SliceVideoDecoder into an equivalent method > > of V4L2Queue, and use it from there. > > > > Bug: 1003223 > > Test: video_decode_accelerator_tests passing on Kevin. > > > > Change-Id: Iaaf56809a46a0c193bf890c73b4bcfac4988374f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839319 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > > Auto-Submit: Alexandre Courbot <acourbot@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#703198} > > TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org > > Change-Id: I57a064a5b334aa2eba7175ae958dddc188c2120f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1003223 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844007 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703210} TBR=yukishiino@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I6e8bb1f11f1fe536d063bd82881abd3b8d35685f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844008Reviewed-by:
-
Yuki Shiino authored
This reverts commit 173e2342. Reason for revert: Suspicious about causing failures at: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/16980 Original change's description: > media/gpu/v4l2: add rudimentary V4L2Queue::SetFormat() method > > Having information about the format currently set on a queue is > valuable, e.g. to validate queued buffers. Rewrite the output queue > format setting method of V4L2SliceVideoDecoder into an equivalent method > of V4L2Queue, and use it from there. > > Bug: 1003223 > Test: video_decode_accelerator_tests passing on Kevin. > > Change-Id: Iaaf56809a46a0c193bf890c73b4bcfac4988374f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839319 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Auto-Submit: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703198} TBR=akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: I57a064a5b334aa2eba7175ae958dddc188c2120f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844007Reviewed-by:
-
