- 04 Mar, 2015 33 commits
-
-
weiliangc authored
In single process mode with impl-side-painting, browser and renderer would both try to set number of raster worker threads, which causes DCHECK. This CL makes sure there won't be duplicate call to set number of worker threads in single process mode. R=enne BUG=314185 Review URL: https://codereview.chromium.org/971943002 Cr-Commit-Position: refs/heads/master@{#318995}
-
morrita authored
ChannelDelegate::GetWeakPtr() was called from the UI thread but it was racy as the weak ptr is also used in the IO thread. This CL turns ChannelDelegate a ThreadSafeRefCounted so that we can pass ChannelDelegate itself to the task runner, instead of using its weak ptr on the UI thread. This change also turns some TaskRunner declarations to SequencedTaskRunner to access its DeleteSoon() API from ChannelDelegate. TBR=creis@chromium.org R=viettrungluu@chrormium.org, agl@chromium.org BUG=460243 Review URL: https://codereview.chromium.org/955813002 Cr-Commit-Position: refs/heads/master@{#318994}
-
pkotwicz authored
BUG=None TEST=None Review URL: https://codereview.chromium.org/872033002 Cr-Commit-Position: refs/heads/master@{#318993}
-
garykac authored
We're updating our build to ensure that all html files are auto generated and jscompiled. This html file is being removed now (rather than updated to be jscompiled) because we intend to remove the It2MeHelpeeChannel code in the near future. BUG= Review URL: https://codereview.chromium.org/979483002 Cr-Commit-Position: refs/heads/master@{#318992}
-
dtu authored
BUG=461551 TEST=None. R=eakuefner Review URL: https://codereview.chromium.org/973893002 Cr-Commit-Position: refs/heads/master@{#318991}
-
reveman authored
GpuMemoryBuffer implementations should not depend on GLImage. This moves the capabilities and size checks needed for compressed formats to the ImageFactory interface. BUG=462541 Review URL: https://codereview.chromium.org/968283002 Cr-Commit-Position: refs/heads/master@{#318990}
-
anandc authored
BUG= Review URL: https://codereview.chromium.org/973293003 Cr-Commit-Position: refs/heads/master@{#318989}
-
dfalcantara authored
Got replaced by a different function. BUG=457427 Review URL: https://codereview.chromium.org/972253002 Cr-Commit-Position: refs/heads/master@{#318988}
-
felt authored
This ensures that both infobars and bubbles are tested by creating both DownloadTest.TestMultipleDownloadsInfobar and DownloadTest. TestMultipleDownloadsBubble. The correct UI (infobar or bubble) is forced with a switch. BUG=438758 Review URL: https://codereview.chromium.org/976823002 Cr-Commit-Position: refs/heads/master@{#318987}
-
kaznacheev authored
BUG=439285 Review URL: https://codereview.chromium.org/975193002 Cr-Commit-Position: refs/heads/master@{#318986}
-
mgiuca authored
This adds null checks for the result of StartPageService::Get in a few places where it was missing. Review URL: https://codereview.chromium.org/970863003 Cr-Commit-Position: refs/heads/master@{#318985}
-
robliao authored
BUG=463337 Review URL: https://codereview.chromium.org/969283002 Cr-Commit-Position: refs/heads/master@{#318984}
-
jamesr authored
'gn check' for ui/gl:* in an android build currently fails with the error message: ERROR at //base/android/jni_generator/jni_generator_helper.h:11:11: Include not allowed. ^------------------------- It is not in any dependency of //ui/gl:surface_jni_headers__jni_Surface The include file is in the target(s): //base:base which should somehow be reachable from //ui/gl:surface_jni_headers__jni_Surface This target does not produce files that compile, so checking includes is less useful. R=brettw@chromium.org Review URL: https://codereview.chromium.org/961033003 Cr-Commit-Position: refs/heads/master@{#318983}
-
jiayl authored
TBR=tommi@chromium.org BUG= Review URL: https://codereview.chromium.org/978683002 Cr-Commit-Position: refs/heads/master@{#318982}
-
maniscalco authored
AttachmentService and SyncData no longer need to provide a drop method beecause model type code can drop attachments using its AttachmentStore. BUG= Review URL: https://codereview.chromium.org/973513002 Cr-Commit-Position: refs/heads/master@{#318981}
-
zmo authored
https://chromium.googlesource.com/angle/angle/+log/586465264..019304886 BUG= TEST=gpu bots R=jmadill@chromium.org Review URL: https://codereview.chromium.org/970363002 Cr-Commit-Position: refs/heads/master@{#318980}
-
dpranke authored
This picks up a bug fix for the analyzer to handle multiple toolsets the same way that ninja does. It also picks up a couple of stray changes that were landed after the migration to Git. TBR=scottmg@chromium.org, sky@chromium.org BUG=461811 Review URL: https://codereview.chromium.org/973273002 Cr-Commit-Position: refs/heads/master@{#318979}
-
chrome://networkstevenjb authored
BUG=455499 Review URL: https://codereview.chromium.org/972223002 Cr-Commit-Position: refs/heads/master@{#318978}
-
stevenjb authored
This fixes clang builds with the simple chrome workflow: cros chrome-sdk --board=link --clang Unfortunately there are not currently any builders with this configuration. BUG=462767 Review URL: https://codereview.chromium.org/967693002 Cr-Commit-Position: refs/heads/master@{#318977}
-
eakuefner authored
This CL fixes the help command of benchmark_runner, which broke after the local environment switch. R=dtu,nednguyen Review URL: https://codereview.chromium.org/979573002 Cr-Commit-Position: refs/heads/master@{#318976}
-
servolk authored
BUG=none Review URL: https://codereview.chromium.org/973263002 Cr-Commit-Position: refs/heads/master@{#318975}
-
changwan authored
On Webapp, touch gestures are offset by the size of the toolbar, even when the toolbar is hidden. This occurs because we assume that the previous content offset can never be 0, ending up not calling onVisibleContentOffsetChanged() callback. We can fix it by initializing previous content offset as NaN. BUG=459275 Review URL: https://codereview.chromium.org/970813003 Cr-Commit-Position: refs/heads/master@{#318974}
-
gunsch authored
R=lcwu@chromium.org,erickung@chromium.org BUG=internal b/19550765 Review URL: https://codereview.chromium.org/974623002 Cr-Commit-Position: refs/heads/master@{#318973}
-
hanxi authored
https://codereview.chromium.org/718203005/ <webview> tag will not support declarative content script API anymore. Instead, we would like to support dynamically add/remove content scripts, which are similar to content scripts for Chrome Extension. BUG=461052 Review URL: https://codereview.chromium.org/975133002 Cr-Commit-Position: refs/heads/master@{#318972}
-
oshima authored
BUG=36454 R=dnicoara@chromium.org Review URL: https://codereview.chromium.org/970133004 Cr-Commit-Position: refs/heads/master@{#318971}
-
newt authored
BUG=463638 Review URL: https://codereview.chromium.org/972303002 Cr-Commit-Position: refs/heads/master@{#318970}
-
amistry authored
Constructing the SpeechManager creates a WebAudio instance which creates an audio output stream that prevents ChromeOS from suspending. This code is supposed to be dead and is slated for removal. This change gets rid of the usage and is intended to be mergable into the M42 branch. BUG=450081 Review URL: https://codereview.chromium.org/966983003 Cr-Commit-Position: refs/heads/master@{#318969}
-
rdevlin.cronin authored
Update the closure compiler extern for the developerPrivate API to have enum definitions, now that enums are exposed on the api object. Update chrome://extensions to use these enums. BUG=463184 BUG=461039 Review URL: https://codereview.chromium.org/974903004 Cr-Commit-Position: refs/heads/master@{#318968}
-
twellington authored
Display the "updates no longer supported" warning for devices < JELLY_BEAN on the About Chrome settings page. BUG=438861 Review URL: https://codereview.chromium.org/964873004 Cr-Commit-Position: refs/heads/master@{#318967}
-
sergeyu authored
There are some issues with the VideoDecoder renderer in M42 chrome, particularly on ARM. Don't use it there. BUG=459103,463577 Review URL: https://codereview.chromium.org/967733006 Cr-Commit-Position: refs/heads/master@{#318966}
-
sriramsr authored
This change is needed to support the use of the exclusive access bubble from extensions. There are two scenarios under which the bubble will be used to: - Display the bubble when keyboard lock is in effect. - Display the fullscreen/mouse lock UI from Hosted app (not hooked up in this CL). Exclusive access controllers such as fullscreen and mouse lock are updated to no longer access Browser* object directly, but instead use new ExclusiveAccessContext and ExclusiveAccessBubbleViewsContext interfaces. These are implemented by BrowserView and will in the future be implemented by NativeAppWindow. Review URL: https://codereview.chromium.org/877413004 Cr-Commit-Position: refs/heads/master@{#318965}
-
alexst authored
BUG= Review URL: https://codereview.chromium.org/967733005 Cr-Commit-Position: refs/heads/master@{#318964}
-
dtu authored
They're both cross-platform binaries/packages and not 64-bit specific. We're looking for them in the correct place, but they're located in the wrong place. Potential follow-ups: - We should use support_binaries to find these files. - We should have support_binaries be more aware of cross-platform binaries. BUG=None. TEST=None. Review URL: https://codereview.chromium.org/964403005 Cr-Commit-Position: refs/heads/master@{#318963}
-
- 03 Mar, 2015 7 commits
-
-
derekjchow authored
BUG=internal b/19071054 Review URL: https://codereview.chromium.org/972393002 Cr-Commit-Position: refs/heads/master@{#318962}
-
ananta authored
The keyboard detection code is heuristic based as we don't have a reliable way to detect if a keyboard is attached. We use the Setup API's for keyboard class GUID's and look for specific prefixes in the device names like ACPI\PNP*, ACPI\MSF* and HID\VID*. If we find one of these we assume that a keyboard is present. Fixed a bug in the keyboard detection function where in the order of params for the StartsWith helper was flipped. This works on the Surface and Samsung touch screen laptops in my testing. BUG=335735 Review URL: https://codereview.chromium.org/969293002 Cr-Commit-Position: refs/heads/master@{#318961}
-
dpranke authored
This patch re-lands the original change plus the fixes I had to introduce the 'gn_all' and 'gyp_remaining' targets in the GYP build. This patch is thus reverting 378e940e (#318636). The code was actually correct at #318636 but was failing on the iOS bots due to problems w/ their recipes that have since been fixed. TBR=brettw@chromium.org BUG=461019 Review URL: https://codereview.chromium.org/977703003 Cr-Commit-Position: refs/heads/master@{#318960}
-
hanxi authored
To support dynamically added/removed content scripts in <webview>, we store these content scripts in the same shared memory where user scripts from declarative content API are stored, but the decision for injection will be made in the render once the url pattern is matched. Since render doesn't need to send IPCs to ask a decision from browser, it makes a precise time injection possible. Special to <webview>, once the content scripts are updated (added/removed), browser will only notify the render process of the given <webview>, rather than all of the renders (which is the case for user scripts). BUG=437566 Committed: https://crrev.com/f853287c95cf818d0b5b02d7f4a6588761096d1c Cr-Commit-Position: refs/heads/master@{#318774} Review URL: https://codereview.chromium.org/906493004 Cr-Commit-Position: refs/heads/master@{#318959}
-
miu authored
When stress-testing desktop resize (by running a CrOS Ash desktop in a window), a problem with the capture frame size calculations was revealed: The max frame size was being updated for each change in desktop size. This meant that once width or height were reduced, they could never be increased again. When the width or height were reduced to zero, Chrome would crash. This change fixes the size calculation (the max size is made constant from construction), adds a few extra sanity-checks to prevent crashes on OOM or zero frame sizes, and also adds re-scaling of the rendered mouse cursor bitmap whenever the desktop size has changed. BUG=462799 TEST=Resized CrOS Ash-desktop-in-a-window on my local dev workstation to confirm crash is resolved. Review URL: https://codereview.chromium.org/965123002 Cr-Commit-Position: refs/heads/master@{#318958}
-
rtenneti authored
them. "enable_truncated_connection_ids": "true", "load_server_info_time_to_srtt": "0.25" Deleted "load_server_info_timeout" field trial, because "load_server_info_time_to_srtt" field trial accomplishes the same in a better manner. R=rch@chromium.org Review URL: https://codereview.chromium.org/975613002 Cr-Commit-Position: refs/heads/master@{#318957}
-
dnicoara authored
Fixes the surfaceless renderer since it now has a specfic API for the creation of the GLSurface. BUG=none TEST=Run ./ozone_demo --ozone-platform=gbm --ozone-use-surfaceless Review URL: https://codereview.chromium.org/975733004 Cr-Commit-Position: refs/heads/master@{#318956}
-