GitLab

Follow-on to crrev.com/c/1823801.

From crbug.com/1000936, failures in doing conversion of PDF for Nup
caused the Print Preview UI to endlessly spin in the
"Loading preview ..." state without ever showing that it had failed.

Similar behavior can be replicated during development by inducing
crashes in PDF composition calls inside PdfCompositorImpl.

Wrap the PDF page composition calls' callbacks with
mojo::WrapCallbackWithDefaultInvokeIfNotRun() so that a status is
provided even if the utility process disappears before completing.

Update the On<composite-something>Done() callbacks to include a
notification call to the Print Preview UI to report errors.

Bug: 1003171
Change-Id: Id351cefd5d91b322a915fa635865969e1cbb1142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825661Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700021}

In UIA, buttons that set "HasPopup" to anything other than false are
not invokable. Instead the expectation is that buttons will implement
ExpandCollapse or Toggle patterns. Part of implementing those patterns
is ensuring that the correct state of the button (i.e. expanded or
collapsed) is also set appropriately. Otherwise, the default value will
be set to ExpandCollapseState_LeafNode which prevents screen reader
users from invoking the button.

ToolbarButton is a base class and calling
SetHasPopup(ax::mojom::HasPopup::kMenu) at this level seems misleading
(since they don't all have a menu popup), and does not allow us to
accurately set an expand/collapsed state.

This change sets HasPopup to the toolbar buttons that implement menu
model, and adds this property to the other subclasses that do have a
menu but do not implement menu model.

This fix also adds support for expanded/collapsed states in UIA if
HasPopup is set to kMenu.

Bug: 1004025, 1008052
Change-Id: I8a1fe0e8b13e91b469cf16cf5beecc24806bf3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803983
Commit-Queue: Maria Villarreal <mavill@microsoft.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700020}

Bug: 1008186
Change-Id: I34db88b3c3e70c3227ab552c83ec2a0bdb2d3de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825864Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700019}

We updated the liblouis source to v3.11.0, the latest
stable version. Recompile the wasm binaries from source,
updating the compilation instructions, and update the
braille table metadata and tests.

Bug: 985499

Change-Id: I25d8dc8158bad6e97ffa69be6ae6e5a8722cee47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785998
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700018}

Instead call them "after write checks", leaving it up to the embedder to
decide what kind of checks to do there (even though the spec will strongly
recommend implementations perform some kind of malware/safe browsing check
at that point in the operation).

Bug: 995963
Change-Id: I8dee7ba4d2c17019abdef183114f51258b730d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825778
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700017}

This adds CPU Frequency stats to ARC++ tracing tool.

TEST=Locally, unit_tests
BUG=b:141635977

Change-Id: Ib2645579d4d1be837f37ecacfd20364559768f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825823
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700016}

See also: b/135105339

Bug: 1004549
Change-Id: I7ae726e4e162173d63d3805b67b24ad90d1b8233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812103Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700015}

Switches use of PrintResult in command_buffer_perftests to
PerfResultReporter and whitelists the tests for conversion to histograms
before uploading to the perf dashboard.

Bug: 923564
Change-Id: I9e956a7a299b029201e1707dcfe1b0ba842866cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812092
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700014}

Provides ability to specify an alignment that kicks in after a child
view expands beyond its preferred size. The view can stretch to fill
the available flex space (kStretch), or float to the leading or
trailing edges or center of the container (kStart, kEnd, and kCenter,
respectively).

Change-Id: Iaeee58630ca4eab5a4f6a07554900cad0ad940f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825717Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700013}

Some extension browser tests are failing when split cache is enabled, because
the request is not considered as cacheable when the Network Isolation Key is
missing.

This CL fills in the Network Isolation Key for the factory used by request
from extensions. This factory is used for xhr and fetch requests from the
extension’s background script.


Bug: 1003882
Change-Id: If5ff7f159dbccb490b1f8ec5d5f98e08301ba1bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811477
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700012}

Change-Id: I107fe923f70f641a08fe13326aaea55c8da1a0a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823760Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700011}

BUG=None

Change-Id: I3ffb028e0f657cf986eca367be40f621a1d02c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824718Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700010}

This change creates a PredictionModelFetcher for fetching PredictionModels
from the Optimization Guide Service. The fetcher request specifies the
ModelTypes and features supported by the client. The fetch also requests
HostModelFeatures for the hosts the client is likely to request
predictions for.

Future CLs will populate the ModelInfo and hosts based on the
PredictionModels enabled on the client and the hosts that the client
engages with most frequently, captured by the
OptimizationGuideTopHostProvider.

Model fetches will only be enabled by a Finch Feature flag to be included
in a future change.

Bug: 1001194
Change-Id: Ic9b8418cb17e82c713888571de2da2a03c634754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818436
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Auto-Submit: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700009}

The parallel read experiment shows that cache match miss rate regresses
on android for some reason.  All other platforms show big progressions.
Therefore we are going to keep parallel reads disabled on just android
while enabling it by default for all other platforms.

Bug: 985379
Change-Id: I05c24f94f4ce2fe5246f2811ed605adf094412f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825398Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700008}

Received API_OWNERS LGTMs to ship this feature.
Received launch approval for Stable (crbug.com/1003925).

Bug: 966576
Change-Id: I099cec9ac6518a80df06b495cca26e45c5710664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804274Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700007}

Also fixes an RTL issue with promo icons.

Screenshots:
* screen/hehqtqE4ufa
* screen/b4oZ75qGFmS
* screen/5pTjRC4v6iq
* screen/wuMG0SOZ7Bj
* screen/zRA7bqZxCut
* screen/1ridYUv2oYj

R=mahmadi@chromium.org

Bug: 1003508
Change-Id: Ic3446f54fb28f9a5420f84780532525ac0f43752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824069
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700006}

Change-Id: I5aa79823c36380303e75b429774f64c710e9159b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799691Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Daniel Soromou <fosoromo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700005}

This method has no callers (outside of unittests).  The last caller
(ResourceDispatcherHostImpl::ShouldServiceRequest) has been removed in
r682144.

The removal is especially desirable, given that CanSetAsOriginHeader is
one of few places which used to call CanAccessDataForOrigin from an IO
thread (making it difficult to introduce Citadel-style Site Isolation
enforcements).

Bug: 764958
Change-Id: I9d38e00c29fc7d391cfdbbde17987b9c2e1b66a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824145
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700004}

Bug: 1001734
Change-Id: I3ba0d285a6bded1d103633a374f54b7ac0260425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819628Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700003}

https://webrtc.googlesource.com/src.git/+log/d63f8f88a1b0..30c2b66fbabe

git log d63f8f88a1b0..30c2b66fbabe --date=short --no-merges --format='%ad %ae %s'
2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision edf70056..489dde9b (699748:699869)
2019-09-25 danilchap@webrtc.org Implement TaskQueueBase interface by SingleThreadedTaskQueueForTesting
2019-09-25 srte@webrtc.org Cleanup of unused field trials and options in SendSideBandwidthEstimation

Created with:
  gclient setdep -r src/third_party/webrtc@30c2b66fbabe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I145c12b7e8bfd1b5850f5e87f0a7ac408bdd3a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825863Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700002}

Print preview UI expects the initial settings key to be in camelCase,
like |previewIsPdf|.

Bug: 989978
Change-Id: Ifcfee6f71e3dcdb4902054b7f9407c814898a481
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825897
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700001}

Renaming OpenXR location related variables/functions so their meanning
is more clear

Change-Id: I760b143b9f4d4a498741278b507b9608bca51b6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820022Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Zheng Qin <zheqi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700000}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d1d142297302..3ef6d975b402

git log d1d142297302..3ef6d975b402 --date=short --no-merges --format='%ad %ae %s'
2019-09-25 vapier@chromium.org pylint: enable docstyle checker
2019-09-25 vapier@chromium.org pylint: re-enable bad-builtins

Created with:
  gclient setdep -r src/third_party/chromite@3ef6d975b402

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iae9eb96a01e85226f3c9b331bc15ca99c0832d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699999}

Declare them as extern in .h files and have a single implementation
in .mm file. Nothing bad happened fortunately because this variable is
a const, but it's wrong.

Bug: None
Change-Id: Ia9bcb4121594fae9dd6c95679cdcdf6b67f411ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825170Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699998}

This CL restructures PAK inclusion for DevUI pages to be hierarchical:
* Each DevUI page has its own "atomic" PAK files (currently only done
  for chrome://bluetooth-internals).
* On *all* architectures, pages intended for the DevUI DFM are repacked
  into dev_ui_page_resources.pak.
* For non-Android, or if DevUI DFM is off, dev_ui_page_resources.pak is
  simply repacked with other resources to form resources.pak. This
  produces the same result as before.
* For Android with DevUI DFM on (APK and bundles):
  * dev_ui_page_resources.pak and DevUI support resources are repacked
    into dev_ui_resources.pak.
  * Remaining resources go into resources.pak.

This CL also centralizes atomic PAK files targets and deps into a single
target (dev_ui_paks) in chrome/browser/resources/BUILD.gn, making it
easier to edit dev_ui_page_resources.pak contents.

Change-Id: Ieeaa18a322b46ed5102b2cbec20fab44a2b4ab82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785007Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699997}

ChromeSerializedNavigationDriver::Sanitize may rewrite some session
restore entries stored in sessions::SerializedNavigationEntry.
Such rewrite needs to leave the data in a self-consistent state.
This becomes more important now, because r698995 introduced extra
DCHECKs that enforce the self-consistency.

Before this CL, ChromeSerializedNavigationDriver::Sanitize
would modify PageState (which contains the URL, Referrer and other
pieces of data), but would not modify the referrer stored in
the SerializedNavigationEntry.  This CL fixes this.

Bug: 1007532
Change-Id: I0e8722914f1d7a7283a1d87b26b645e058b1c18b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825461
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699996}

These are simple files to move so doing both in the same CL.

Bug: 995916
Change-Id: I67b61f9d3ffea0f66bd493f350f069affea708e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812117
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699995}

This re-lands:

https://chromium-review.googlesource.com/c/chromium/src/+/1699138

which was reverted by:

https://chromium-review.googlesource.com/c/chromium/src/+/1824081

due to asan failures.

The failures were test-only.  It used a base::Unretained in a mock
that, due to a posted callback, was being destroyed during test
teardown before the callback had a chance to run.  When it did run,
asan got mad.

This CL replaces the unretained with a weak ptr.  Changes are in
mock_shared_image_video_provider.* .

TBR=sandersd,vikassoni,mpearson

Change-Id: I85e6f85a6f81964a6c4b286d2b8219d0b4840958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825900
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699994}

Adds:

1. "enable_typescript_bindings" gn arg, which must be set to true
   to test Typescript bindings.
2. "use_typescript_sources" gn variable that can be set to opt-in a
   target into generating Typescript bindings.
3. Test interfaces folder where interfaces will be added as features
   are implemented.
4. A mojom gn target that includes the tests interfaces. This target is
   included as part of mojo_unittests
5. Basic template and generator implementation.
6. Script to compile generated Typescript bindings into JS bindings.

Bug: 1002798
Change-Id: Id8424d707ad4b2ec9a773b291fd4a41332623274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817860Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699993}

The following icons should be colored according to the current theme:
- search loupe
- globe

I've changed the functionality from setting properties in the model to
setting the resource values intermediate variables (icon/tint) and
settings those in the model at the end of the branch. This simplifies
the code a bit and makes it easier to read. To allow for this change,
I've altered the favicon fetching logic to post a task back to the
ui thread for the callback. This way the callback isn't invoked
immediately, which avoids crbug.com/997343 from resurfacing due to
this change.

Bug: 1004903
Change-Id: I6e8102f47e81d0037761d9b111b98d4f1999a225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818604
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#699992}

No change to logic, only docs. This adds navbar.md (supported by gitiles
markdown) to the mojo docs. This makes http://go/mojo-docs/ slightly
easier to navigate, as the top bar will link to some of the high-level
documents. This does not link to every mojo doc, to avoid
over-cluttering the navbar.

Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I2cad169397ae8a0d12b23da735fb9d641a1eff64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824062
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699991}

This CL is proposing to lift the call to FcInit to ensures the
font-config is initialized.

Currently, the FcInit(...) is lazily called on first use. On windows,
the DWrite is early initialized to avoid the lazy initialisation. We
proposed to do the same on Linux.

The behavior should be the same on Windows. On Linux, FcInit should
be called on startup, as we need fonts for any rendering.


The main goal of this change is to help collapsing the bugs / crashes
stack to point to a single culprit. Currently, they are spread over
multiple stackframes in incorrectly reporter.

  Memory leak with FcInit(...) - crbug/1000881, crbug/977249
  Iterator corrupt, initialisation - crbug/1004254

More signatures are available here:
  https://bugs.chromium.org/p/chromium/issues/detail?id=1004254#c11

Change-Id: I1f6d80c790829b1d9416b773d5c9cdba16f90eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808447Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699990}

Quick cleanup for ScreenCaptureNotificationUIViews in preparation for
Layout changes in http://crbug.com/1005568.

BUG=
TBR=pkasting@chromium.org
Trivial changes.

Change-Id: Ic2934537d91e05467429e11976fba5b0ef96604c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825728
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699989}

https://chromium.googlesource.com/angle/angle.git/+log/d4c75347e4d3..29f7916fd56e

git log d4c75347e4d3..29f7916fd56e --date=short --no-merges --format='%ad %ae %s'
2019-09-25 jmadill@chromium.org Vulkan: Store current Serial in RendererVk.
2019-09-25 ynovikov@chromium.org Temporarily disable SwiftShader everywhere.
2019-09-25 jonahr@google.com GLX: Forward XExposeEvents to parent window

Created with:
  gclient setdep -r src/third_party/angle@29f7916fd56e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:1008100,chromium:991577
Change-Id: Ib83f0b48defba45f982a0e9ab4e9af5a35c8b795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825627Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699988}

For https://bugs.chromium.org/p/chromium/issues/detail?id=1007570, I
can't reproduce the issue, but my best guess is that somehow we're
relying on DiscardPendingEntry getting called when we don't have a
pending entry to clear the failed_pending_entry_id_. This makes sure
that we don't skip calls to DiscardPendingEntry when we've set a
failed_pending_entry_id_.

Bug: 1007570
Change-Id: I3e1f46515247b99a0adbd68b3fea82aa719e474a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825592
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699987}

For a <section> element with an accessible name, change the
ControlType from Pane to Group and the LocalizedControlType
from "region" to "section".  <section> elements  with no accessible
name are not changed.

Spec reference: https://w3c.github.io/html-aam/#el-section

This change required the introduction of ax::mojom::Role::kSection.
kRegion had previously been used for <section>, but this no longer
works because we need to distinguish between these two cases:
<section aria-label='section'></section>
<div role='region' aria-label='region'></div>
Where only the former has LocalizedControlType == "section".

Introduction of the new kSection role also allows us to eliminate
dependencies on the kHtmlTag StringAttribute in a few places.

The UIA ControlType of the Region role is also updated to Group per
https://www.w3.org/TR/core-aam-1.1/#role-map-region

Bug: 999730
Change-Id: I1008d27b5744fe22b5fa5fefc58bb9d16dedcef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779430
Commit-Queue: Dan Clark <daniec@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#699986}

The code in ui/accessibility is designed to be used outside
of the browser process, it works with generic cross-platform
accessibility data structures.

The code in ui/accessibility/platform contains the implementation
of platform-specific accessibility APIs and the internal
abstractions of these. It doesn't make sense to include anything
from this directory from a renderer process, or on platforms
that don't have a native accessibility API.

AXTreeManager (in ui/accessibility) had two functions that
returned an AXPlatformNodeDelegate, which violates this
layering and  makes it impossible to use AXTreeManager
in places where we don't want to depend on
ui/accessibility/platform.

The underlying reason that these functions were added to
AXTreeManager were because there was no way to retrieve
an AXPlatformNode given a (tree id, node id) pair. So
instead, this change adds that interface to
AXPlatformNodeDelegate, which is a better place for this
than AXTreeManager.

That fix required two changes as a consequence:

First, AXRange was using AXTreeManager's hook into
AXPlatformNodeDelegate to call platform bounds rect code.
I fixed that by having GetScreenRects() take a helper class
as a parameter, so that the caller can provide an
implementation of the platform-specific logic that AXRange
needs. This enables the current usage of AXRange to work
without precluding using AXRange from elsewhere in the codebase
in the future.

Second, the autofill code was using AXTreeManager's APIs
to find the focused text field given its [AXTreeID, node id].
This change just required getting an AXPlatformNode from
WebContents, and then calling the new AXPlatformNodeDelegate
API.

Bug: 1006402

Change-Id: I640ecebf00baded00ae968197a8ecd7bffad0cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815221
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699985}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01c20b755102..95d5e25ad030


Created with:
  gclient setdep -r src-internal@95d5e25ad030

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ib36b15ec68e60e87947f924291092199d704be95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825626Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#699984}

This adds a timer histogram for all PalmDetectionFilter->Filter
executions. We'll keep the timer whenever we change the underlying
filter implementation.

Adds a unit test that ensures the timer is populated.

Bug: 982118
Change-Id: I410ca0348bca9c556f4dff05ab5e228a1f09516d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824796Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@google.com>
Cr-Commit-Position: refs/heads/master@{#699983}

base::Version::GetString() returned a `const std::string`; there's no
reason to do this, since it's a new string (and not a reference to a
member). Additionally, this could potentially result in invocations of
Version::GetString() creating a copy, if the caller did something like:

std::string version_string = version.GetString();

Since the result would be a `const std::string`, a copy might be made to
fit into the non-const std::string required by the caller. Hopefully,
the compiler is smart enough to optimize this out, but it's better to
just un-const the result altogether.

Bug: None

Change-Id: I5afb69b5e1e04dab03eb8629ea7e2d124e91f755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825460Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699982}