GitLab

BUG=16011
TEST=none
Review URL: http://codereview.chromium.org/151120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16018
TEST=None
TBR=jorlow
Review URL: http://codereview.chromium.org/155114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19993 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r19983.  Test failures on Mac and Windows.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15906
TEST=builds of Chromium should now be video/audio enabled

Review URL: http://codereview.chromium.org/149165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19987 0039d316-1c4b-4281-b951-d872f2087c98

If I start Chrome and shut it down quickly RenderViewHost
receives an IPC ViewHostMsg_RenderViewGone. We respond in
ExtensionHost::RenderViewGone by putting up an info bar on
the selected tab contents saying that an extension
crashed. 

Only problem is that ExtensionHost::GetBrowser() can
return NULL during startup and shutdown, as documented
in the function and so we should not try to put up the
Infobar if the browser is going away.

BUG=None
TEST=Open Chrome with extensions enabled and an extension
loaded and shut Chrome down as soon as it launches. It
should not crash. Might take a few trys to repro.

Review URL: http://codereview.chromium.org/149205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19986 0039d316-1c4b-4281-b951-d872f2087c98

(basically leaving only one pixel margin around the edges).

BUG=htt://crbug.com/15874
TEST=None, Find box should work as before.

Review URL: http://codereview.chromium.org/155061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19985 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/149144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19984 0039d316-1c4b-4281-b951-d872f2087c98

There are still a few issues, but that's a start.
- only windowed plugins
- we can't currently create the gtksocket in background tabs, because their gtkwidgets are not yet in the hierarchy, so they can't be realized (that's what gives the XID).
- the plugin process talks to the browser process through the renderer process to create/destroy the gtksockets, because the plugin doesn't know which renderer it's talking to. We need a bit more plumbing to be able to have direct IPC.
- some code is duplicated between chrome and test_shell. We should probably factor it, but I'm not sure where the common part should live.

Review URL: http://codereview.chromium.org/146078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19983 0039d316-1c4b-4281-b951-d872f2087c98

This removes the last dependency on tab_contents from the renderer_host code
and into the RenderViewHostDelegate. Some of the tests depended on tab_contents,
so I moved to a new directory with the tab_contents include allowed via DEPS.
Now DEPS can enforce that no additional tab_contents includes are added to
renderer_host.

RenderViewHost delegate is now pure virtual. After spending a while *again*
figuring out why my code didn't work, only to find it was because the default
implementation of a function was getting called instead of the real one, I
decided to make this pure virtual. It is implemented by TabContents, which
implements basically everything, and two other places that implement less. Only
two lists of duplicate functions seems not too bad, although long-term it would
be nice if this delegate was somehow more succinct.
Review URL: http://codereview.chromium.org/155071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9952
TEST=none

Review URL: http://codereview.chromium.org/155018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11392
TEST=Open the task manager and double click different processes.  Those tabs should be activated.
Review URL: http://codereview.chromium.org/155098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19980 0039d316-1c4b-4281-b951-d872f2087c98

As the user moves the mouse around. Check if the element has an xtitle
property. If it does, compare the scrollWidth and the clientWidth and
set the real title property as needed.

BUG=15769

TEST=Hover over items on the NNTP. Only items with ellipsis should show tooltips.

Review URL: http://codereview.chromium.org/149166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=1953127

Review URL: http://codereview.chromium.org/149135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19978 0039d316-1c4b-4281-b951-d872f2087c98

Chrome still doesn't run.

Review URL: http://codereview.chromium.org/155026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15449

Review URL: http://codereview.chromium.org/149136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19976 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation to add tests for limiting total number of sockets.

TEST=Covered by net_unittests.

http://crbug.com/15093

Review URL: http://codereview.chromium.org/149159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19975 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19974 0039d316-1c4b-4281-b951-d872f2087c98

Don't install the RWHVMac into the view hierarchy until everything has been properly sized. This avoids sending spurrious resize message with incorrect sizes to the renderer.
BUG=15717
TEST=pages should always be the correct size when loaded in bg or foreground. No more flashing a small size then redrawing.
Review URL: http://codereview.chromium.org/155099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19973 0039d316-1c4b-4281-b951-d872f2087c98

This is all mmentovai. I am just a copier/paster.

R=mark
BUG=15904
TEST=no more "macro names must be identifiers" errors during V8 bindings generation.

Review URL: http://codereview.chromium.org/149207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19972 0039d316-1c4b-4281-b951-d872f2087c98

Scale function cleaned up white spaces and removed comments that are no longer applicable to this module.
Removed openmp support, which is no longer necessary for high performance.

Review URL: http://codereview.chromium.org/150143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19971 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19970 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19968 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15607
TEST=CHECKs should not fire, unless we're about to crash anyway, in which case I want the crash report.

Review URL: http://codereview.chromium.org/149142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15897
TEST=get Glen to look at it

Review URL: http://codereview.chromium.org/155040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19966 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15874
TEST=looks good

Review URL: http://codereview.chromium.org/155041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19965 0039d316-1c4b-4281-b951-d872f2087c98

Add an exact search method to the Keychain adapter, and modify unit tests to us that instead of the raw keychain version.
Overhaul the single-item-search test to be shorter, clearer, and more complete.
Convert more namespaced methods that now have no public callers to private helpers of the Keychain adapter, and refactor the helpers.

BUG=none
TEST=none; no behavioral changes
Review URL: http://codereview.chromium.org/149160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19964 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19962 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 6c6d8665c114217a14fea346cca97006e4c3daa7.
BUG=none
TEST=none
TBR=nsylvain

Review URL: http://codereview.chromium.org/155097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19961 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit e0ff42dd35e02eae62f35043072ca23676577cac.

Did it break Vista tests? Let's see.

TBR=nsylvain

Review URL: http://codereview.chromium.org/155093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19958 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Add checks to track down crashes in URLRequestChromeJob."
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/155027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19956 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that some functions were parsing response lines, but without checking that they have the entire line available.

This change will also make it easier to handle multi-line greeting (230 welcome messages). I plan to do that afterwards.

TEST=Covered by net_unittests.

http://crbug.com/15259

Review URL: http://codereview.chromium.org/149043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19954 0039d316-1c4b-4281-b951-d872f2087c98

R=mark
BUG=15904
TEST=no more weird errors when generating bindings


Review URL: http://codereview.chromium.org/155089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19952 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/13924
TEST=none

Review URL: http://codereview.chromium.org/155011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15818
TEST=Valgrind-Mac green
Review URL: http://codereview.chromium.org/149201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19947 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19946 0039d316-1c4b-4281-b951-d872f2087c98