- 23 Sep, 2020 40 commits
-
-
sandromaggi authored
The definition states that the icon to activate is its index, not index +1. Bug: b/168611883 Change-Id: I83349198e0ca4b555e01e7d0a713d5ce580ef41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424138 Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#809863}
-
Matthew Mourgos authored
This change adds a new announcement which occurs when chromevox is enabled and an app list item with a notification badge is focused. Bug: 1126492 Change-Id: If581feecd46141dfa5027349c6e55575829d6b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423054Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809862}
-
David Benjamin authored
The sheet is currently being drawn on a transparent overlay when using remote Cocoa (e.g. PWA windows), which results in a number of UI issues. This was exacerbated by https://chromium-review.googlesource.com/c/chromium/src/+/2324112. Instead, add a ShowCertificateViewer() Mojo call and move the implementation to NativeWidgetNSWindowBridge. Along the way, simplify the implementation. We can now largely rely on Cocoa's built-in lifetime management for the SFCertificatePanel. Bug: 916815, 1130490 Change-Id: Ia33102417510d7c0fc6fb09cf55d9fa61efdfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421633Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#809861}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I9c3b6f06e7fd5c9e1bec009e0845bbbe2668bf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424886 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#809860}
-
Wenyu Fu authored
Changing fonts to fix the glitch on the welcome screen, as Google Sans might be not available yet for the first screen. Bug: 1119990 Change-Id: Ia0e939c651b105357215357db6038ab2d10a5031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425383 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#809859}
-
Peter Wen authored
Previously, blanket suppressions were added due to lint not working. Now that android lint is working well again, we no longer need these blanket suppressions. They have been removed/fixed/or moved to the specific files that require them. Bug: 1044658,1116130 Change-Id: I249afb500c49c13f35880311d04c51391ed8cbfa Fixed: 1044658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424543 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809858}
-
Tim Volodine authored
Extend expiration milestone for InertialSensor.* histograms. BUG=1088842 Change-Id: I890a9c2a139d123d4a9fca281067b219f5fb3997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424087Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#809857}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I627e1f0156ad7fbefadd58d832e67d121a28dc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424505 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Alan Cutter authored
This change migrates Callbacks in extensions::Blocklist to OnceCallbacks. Bug: 1007786 Change-Id: If463e8b8fb776bfd1b5fdaae5b415c0216f6419e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425863 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#809855}
-
Sammie Quon authored
Test: added Bug: 1111445 Change-Id: I0f79be1c09d4ef0eeff276e3c50f491efbe56244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380517Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809854}
-
Ken Rockot authored
This does not implement any support for 5G detection, but merely introduces the new enum value and ensures that consumers of the ConnectionType enum are aware of its existence. Bug: 1127134 Change-Id: I7fcc214958ad8a8132ac5b062b8af3559622b7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425164Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#809853}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I39f8d765f841aae135ed543f9fc2238ec8a1837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422184 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the screen wake lock WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: Iecc6d0ce8840013c9dc570e76b1c02510eb89fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424633 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#809851}
-
Stephen McGruer authored
Bug: 1127055 Change-Id: I3d44e0aecc593e4cb385c65461731d0f4a461bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425459Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809850}
-
dizg authored
to support Preserve mode correctly. Bug: 1122988 Change-Id: I2ec59f32a0e8c7b050300b78fe6336c1b12c2c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395403 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#809849}
-
Mustafa Emre Acer authored
Delayed Warnings feature delays certain interstitials until the user presses a key. It presently ignores ESC key as it can be used to exit from fullscreen mode. The user can also use browser shortcuts such as Control+T to open a new tab. This CL allows modifier keys (Control, Alt etc) so that browser shortcuts don't show the interstitial. There are two exceptions made by the CL: - Shift pressed with other character keys still show the interstitial as the user may be typing uppercase letters. - Ctrl+C and Ctrl+V still show the interstitial as they are shortcuts for copy & paste. Bug: 1131149 Change-Id: I5d3532b9296beef783e01e18d14e0b7a53309fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425206Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#809848}
-
cfredric authored
This cl causes the bindings generator to automatically collect UKM when these attributes are accessed. This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I29ea7ee1796c8152cab9f004229282b1b728b173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421638 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: I21eb1070750c92f59e89f288f63e385570dc966c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419621 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the generic sensor WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: I7ba5512c755816e5072dcb4aade3e13f4904456f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424654 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
If one of the Lengths was 'auto' while the other was a percentage or calc(...), the 'auto' Length would resolve to the corresponding viewport dimension (i.e like if it was 100%) rather than 0. Fixed: 1131324 Change-Id: Iec4e406d74b29551f417ab32caf3ef6cc627909b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426483Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#809844}
-
Elly Fong-Jones authored
They fail consistently on chromeos-kevin-rel. Bug: 1131304 Change-Id: Id26ed4a30fb7b27d2326d92ac6f7baa9f61395e9 Tbr: batrapranav@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426346 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80f8eba22fbb..faa49d773432 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,tschumann@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,tschumann@google.com Change-Id: I48a768699c56e0c9c2af0fb9ec2eda54cca04331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809842}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e0d5b2a8..399a0eba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77fd233cc5b46255635bffaa137fe314bcf51a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426543Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809841}
-
Pavol Drotar authored
The state of WebApks is split across android settings and chrome site settings. This change adds a dynamic android shortcut into WebApks to make site settings more accessible. The ManageDataLauncherActivity adds functionality for adding the shortcut, checking whether the version of Chrome supports site settings, and launching site settings through the chrome ManageTrustedWebActivityLauncherActivity. ManageTrustedWebActivityLauncherActivity was modified to include support for WebApk verification. Bug: 1119727 Change-Id: I90720ac83c4edf90056cc7b2692be1079b8643a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387764Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavol Drotár <pavoldrotar@google.com> Auto-Submit: Pavol Drotár <pavoldrotar@google.com> Cr-Commit-Position: refs/heads/master@{#809840}
-
Keren Zhu authored
* Allow focus on snoozable bubble. * Adjust focused button text and background color according to UX spec: go/desktop-iph-snooze-ux-spec The spec also stipulates a new set of font sizes and text alignment. I will submit a separate CL to address them. Bug: 1121399 Change-Id: Ifeb9caf51ba328697b930b4eba19106e83664f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423307Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809839}
-
Koji Ishii authored
This patch applies hanging trailing spaces logic to inline boxes. When `white-space: pre-wrap`, trailing spaces can hang. They should not affect scroll (layout) overflow though. This was fixed for LayoutNG in crbug.com/966773. When the fix was ported to FragmentItem, it was applied only to text runs. It should be applied to inline boxes too, because inline boxes that contain hanging trailing spaces can also hang. Bug: 1130310 Change-Id: Ie03e178eb26b2c7270f536974cd617feb38c9169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425553Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#809838}
-
Fredrik Söderqvist authored
Don't advance past the inner-most resource container and don't consider a resource container itself to be a <clipPath> descendant. Bug: 109224, 1131088 Change-Id: I87e766f6247e868b31eefba90ca35bf8b1a7bdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425055Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#809837}
-
evliu authored
This CL replaces the enable_soda GN flag with the kUseSodaForLiveCaption feature flag. Bug: 1128723 Change-Id: I8f46c85808d5744cfedca9b0141b5a8bcf1414ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419138Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#809836}
-
Dominic Mazzoni authored
If set call AccessibilityNodeInfo.setLiveRegion on an ARIA Live Region, TalkBack will announce changes to that portion of the screen. Unfortunately it always speaks the entire contents, which is often not the correct behavior. Instead, just use Chrome's own live region handling, which tells TalkBack what text to speak, and correctly only announces new text added to a live region. Long-term, more changes are needed to complete Chrome's live region handling, but this is an improvement for some important real-world live regions. would speak the entire region rather than only what was added Bug: 1042893, 1128193 AX-Relnotes: fixes issue where ARIA live regions on Android Change-Id: Icd8a0ec8247681862313f1620bbd5aa6567e4e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425747Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#809835}
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the WebSerial WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: I810cd5df06b89b0b5b2f2c160e0f9eac19dd67f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424655 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Piotr Bialecki authored
Change-Id: I87a6a19fba49d8d8719d189ea4be026eb36261bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425128Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#809833}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I649f0bbae5df1e84863710860ad7359a5d2130d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422162 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Make row views selectable. Make divider views unselectable. Bug: 1077766 Change-Id: I688acf9b3d8161ae4914a9417de961452a7bc47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424003 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#809831}
-
Alexandre Courbot authored
These unions members are not part of upstream and will be removed from our headers shortly, so use the void pointer member instead. BUG=b:161415741 TEST=Chromium builds for arm-generic. Change-Id: I4ac869d2cfc52d4c051e1a28e4eca2f83ec24264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423652 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#809830}
-
Stefan Zager authored
Change-Id: Ie81f70a0fc5db38806fc496cdb2b9c783a1daa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423043Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Joe Downing authored
We recently received a bug from the admin console folks who wanted to know how to enable a few policies listed in this file in ChromeOS. The problem is that they weren't applicable as they are only available for remote access hosts and we don't have a remote access implementation on ChromeOS. It looks like these were introduced in this CL: https://codereview.chromium.org/820133002 I think this was just a copy/paste mistake but it affected a number of the policies that we advertise as being supported. I've combed through our policies in the file and have removed / updated all of the entries that should not state they apply to ChromeOS. BYPASS_POLICY_COMPATIBILITY_CHECK=These policies were never supported on CrOS but were incorrectly marked that they were. Change-Id: I0b49496ee1129dfb309039afbb6ef124bbae2fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411409Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#809828}
-
Stephen Nusko authored
This is a reland of http://crrev/c/2182426 which was reverted in http://crrev/c/2413491. This was due to unintended side effect of non-blocking overscrolls causing throttled TouchMoves where developers were relying on them. See http://crbug/1123304 for details. This avoids turning a touch stream to passive until a scroll has been consumed in the renderer (i.e. scrolling has actually begun). Thus, this avoids the problem in the initial CL since a touch stream that starts by overscrolling will remain blocking and thus won't throttle touchmove notifications to the page. Bug: 1123304,1072364 Change-Id: I84ada1754c80f6c5254b21beabb8980c6043094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410531Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#809827}
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the WebUSB WPTs to use the allow attribute for delegation. Bug: 1095641 Change-Id: I278d5f3b9a105b5ed0ac556223908dc83524ef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424634 Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
This is a reland of dc3f7433 After talking with dmazzoni@, we decided to temporarily disable the failing test AXPlatformNodeAuraLinuxTest.TestAtkPopupWindowActive Original change's description: > Reland: Enhances editing event intents by surfacing the input event type from Blink > > This patch was reverted because it was believed that it had caused > a failure on the Linux Ozone bots. > However, after running this patch through all the Ozone bots, no failures were detected. > > Original description: > > For every editing operation in Blink, this patch exposes to the browser and to automation clients > the "type" property of its input event from Blink. > > The enumeration listing event intents was too long, and it included > intents such as paste, type and replace. > To make using intents simpler, the list of commands is now trimmed down to a few > generic ones, such as insert, delete, format and SetSelection. > For intents attached to text changed and text attributes changed events, more information > is now provided in the intent's input_type member. > Values are provided by a new enumeration that uses the same members as the > W3C Input Events Specification. > This makes the information more detailed, accurate, as well as standard's based. > > The TextBoundary and MoveDirection enums were also modified to add the "kNone" member > so that event intents such as "kClearSelection" that have no boundary information and no directionality > need not use them. > > Finally, the equivalent struct that is used by WebKit for event intents on Mac was added, as well as a conversion function. > > AX-Relnotes: n/a. > > Change-Id: I7bc25347e51fc18b730aab84ca01a9eddad8d54f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416459 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808849} TBR=dmazzoni@chromium.org, aleventhal@chromium.org, dtseng@chromium.org, rsesek@chromium.org Bug: 989156 AX-Relnotes: n/a. Change-Id: Ia9871471a0069aef9bd2e94172f04268a53371cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424166Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#809825}
-
Kevin McNee authored
The need to access the WebContents when selecting the UKM source id for ContactsManagerImpl appears to be from before the introduction of RenderFrameHostImpl::GetPageUkmSourceId. The WebContents is now only used to check whether there is a native window. This logic seems unrelated to UKM source id selection, since there is already code that checks for the existence of the native window to show a dialog in ContactsProviderAndroid. Noticed while auditing uses of WebContents::FromRenderFrameHost. Bug: None Change-Id: I68f652ad3c3cb2c40571bde59c7ea3e50618f7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422484Reviewed-by:
-
