- 06 Nov, 2020 40 commits
-
-
Andrew Grieve authored
javac prevents missing symbols via compiler errors, but they can still occur by including prebuilts with incomplete deps, or by using jar_excluded_patterns to remove a class that is actually used. Bug: 1142530 Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824739}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic216c9df51dd890013d31d64c28cd254636e3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522225Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824738}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5689d6741bc4..e3fee63a19d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I61f6f080e197bfbf86462a878d2219c90c04cd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824737}
-
Brandon Wylie authored
There's additional checks that AGSA needs to do before progressing, which need to be checked before continuing with voice search. There's an external content provider which exposes this information to Chrome. Bug: 1140765 Change-Id: I46fa2590484c3c4bc89427ef1cabf99ac69bd26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468308 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#824736}
-
Vikas Soni authored
Update expiry of media histograms Media.CodecImage.CodecBufferWaitCoordinator.* from M86 to M95. Bug: 1104950 Change-Id: I6a332f937563206b8a46d88b2ae21218a670ff3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517485 Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824735}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604599166-f98e71683e0c124b3da263294d166e72d717216d.profdata to chrome-mac-master-1604620781-6e005798045dacc8d1de821cf745cddceb8035b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0ee2b5d9da19986603c650dafc9968fbdf6b460f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824734}
-
Yicheng Li authored
These strings have been approved in UI concept review. Bug: b:156258540, b:144861739 Change-Id: I24ae19f39d686a79f0646f2bd6fa38ee3f1a6793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521166Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824733}
-
Hitoshi Yoshida authored
This reverts commit c498f582. Reason for revert: This revert seems to cause compile failures. Original change's description: > Revert "Remove ButtonListener in favor of callbacks. Other cleanup." > > This reverts commit 86ef81d7. > > Reason for revert: I suspect this causes test failures on CrOS. > > Original change's description: > > Remove ButtonListener in favor of callbacks. Other cleanup. > > > > Add metadata - remove manually overridden GetClassName. > > > > Add view builders and update view tree construction to use the builder. > > > > TBR=katie@chromium.org > > > > Bug: 772945, 938501, 1130078 > > Change-Id: Id105b26afb15138ee6e70e7ade5e43be11671a47 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505880 > > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > > Reviewed-by: Peter Boström <pbos@chromium.org> > > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > > Auto-Submit: Allen Bauer <kylixrd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824581} > > TBR=pkasting@chromium.org,pbos@chromium.org,kylixrd@chromium.org,tetsui@chromium.org,katie@chromium.org > > Change-Id: I5502a73a1f1f5870937efbbb2588f676748bbad1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 772945 > Bug: 938501 > Bug: 1130078 > Bug: 1146255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521980 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824702} TBR=pkasting@chromium.org,peria@chromium.org,pbos@chromium.org,kylixrd@chromium.org,tetsui@chromium.org,katie@chromium.org # Not skipping CQ checks because this is a reland. Bug: 772945 Bug: 938501 Bug: 1130078 Bug: 1146255 Change-Id: I608f8cb868f6d974e726014c736bf0fb1ed5704d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521984Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824732}
-
Gavin Williams authored
Import specific functions from scanning_app_test_utils Import the appropriate Scanning subpage for each test. Bug: 1059779 Change-Id: I9d0470a8955a892fa3820e55544097576e9c2118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522111 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#824731}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec0c770ad8b1..91bb7506bd20 2020-11-06 ehmaldonado@google.com [depot_tools][owners] Add owners client to depot_tools. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I81232205075f633a8cf705bc0717e24b311834e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824730}
-
tby authored
files still appear in the launcher. Tested: manually. Request format is valid, itemsuggest returns 200, and Bug: 1146254 Change-Id: I8f28e813af1c8453a54d8e8373ccf787420ad699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521978Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#824729}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aafe840ca245..073820cb20af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com,xialinyan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com,xialinyan@google.com Change-Id: I51000f9eaa2a4cf211e1780da477901c7b50f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522220Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824728}
-
David Bienvenu authored
This reverts commit 3de603ce. Reason for revert: <a user reported this affects win 1909> Original change's description: > remove WS_THICKFRAME for full screen in pre 1903 Windows > > Not doing so caused issues with playing videos in full screen mode on > older versions of Windows, when we stopped removing WS_THICKFRAME in > crrev.com/c/1972258. > > Bug: 1014720,1141059 > Change-Id: I57b01051c457b35b37c465ce3b38d60bf896c32e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510354 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824543} TBR=sadrul@chromium.org,robliao@chromium.org,davidbienvenu@chromium.org Change-Id: I30477800e3c32351ff6ab12cb0717a94c47e7a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014720 Bug: 1141059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522573Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824727}
-
Changwan Ryu authored
When the input is not focused but if you swipe horizontally on the input element, we still try to show the magnifier. This gesture seems to be silently ignored and it does not actually focus and move the cursor, but we still trigger the magnifier. This can be suppressed by checking the actual selection rect. Bug: 1134492 Change-Id: I47214d6d1c9610258dba5b7c162781a9c60f4258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522571Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824726}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604588329-37596c07bf301a8ab7d867a3b0140d934526b155.profdata to chrome-win64-master-1604609790-bc5437f446ee5ad42df312047e176901e766dccd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib3bdb9fa07756c4e3a571a74e0e5e8000bfab509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824725}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604599166-2d84463f431e41489c0f9ff841daf3c0f07e3415.profdata to chrome-linux-master-1604620781-8baad16a8ee2321f3de713350b41c3a35b5f14db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib20532629446db024e6807d74950988b4ff124d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824724}
-
Chong Gu authored
Since there's no minidumps in Fuchsia browser, we detect crashes through checking for system info. Filter one failing pixel test on Fuchsia Bug: 1080853 Change-Id: I6ef8b33b64b6e6292ec4adfe8fa9538dde496d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522115 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#824723}
-
Michael Thiessen authored
Long overdue cleanup of functions that should never have been in ChromeActivityTestRule. Change-Id: I0a88b9c8f322fe9ee70d6d0c637ec4b0fb0b0388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521362Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#824722}
-
Mason Freed authored
The WebUI pages should only require HTML Imports at this point, and not Shadow DOM v0 or Custom Elements v0. Limit to just that. Bug: 1111843, 937746 Change-Id: Ib61e38475957e045fb5ecd38dc761f156f55aa53 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512381Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#824721}
-
Sven Zheng authored
For local development, test owner don't need to actually upload anything. Bug: 1145334 Change-Id: I2b7f2808d6bc10c7e6dbcfb99805ea52d2b3f152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522611Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824720}
-
Aleks Totic authored
TablesNG code did not get moved over automatically. Bug: 958381 Change-Id: Ib18854483effb0c1ed547e3f531db0926977cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522503Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#824719}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3fee63a19d6..8b665312ca15 2020-11-05 bhamrick@google.com [fuchsia_importer] Add flow event support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I22e74edf27025b279881d64d9d59bc391f1af6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824718}
-
Livvie Lin authored
Change-Id: Ic8fa3a0a239c5ce05aabf545dcae3d8e35aa966e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521051Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824717}
-
Hiroki Nakagawa authored
This is mechanical rename. See the design doc for the overall plan: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing Change-Id: Ie58477758008327b276028b65437fe233b8d4ba3 Bug: 1144577 Tbr: jam@chromium.org, lazyboy@chromium.org, jkarlin@chromium.org, kinuko@chromium.org, sadrul@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517418 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#824716}
-
Josiah K authored
http://screen/34QzMY3vYbgrr6u Mocks: https://docs.google.com/presentation/d/1Pk3lKbEv40lzS9jMpTnlfXA5ifdaLDjdEYV8SrhmTHY/edit#slide=id.g91e9050266_0_39 This changes adds a toggle in Chrome OS Accessibility Settings for following keyboard focus in full-screen magnifier. In a later change, we will gate the actual focus following feature based on this pref's value. AX-Relnotes: Add Screen Magnifier Focus Following Pref and Settings Toggle Change-Id: I0f0b0c508e3aa83d228fa02d2cfe358947f34fc4 Bug: 1143793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506771 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824715}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7c6f3c70..e97171d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie8a3b7f225c52293fcaf15e416a4b56aae58d04c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521789Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824714}
-
chinsenj authored
This CL adds metrics for capture mode bar buttons, tracking the user interactions with buttons in the capture mode bar. Visit go/capture-mode-metrics to see other planned metrics. Test: manual + added Bug: 1140182 Change-Id: I430aca99840c078cdcaf7c1c83437920d6c53564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515699 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#824713}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I36a387916e62a13bda59b227b0a84a2690c23668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522891Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824712}
-
Joel Hockey authored
Change-Id: Ic6025326f0aaf5c173a2db650d512e0e4399e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520478 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824711}
-
Chris Hall authored
On an AXObject these would always return their default value, as they need a Node to get an Element to get the attribute. AX-Relnotes: n/a. Change-Id: Icb4a430a695e58fe70c7d7be1f6fc896ca38dc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520479Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824710}
-
Erik Chen authored
The banner is shown each time Lacros starts. It indicates to the user that Lacros is an experimental browser. Bug: 1144321 Change-Id: I509cdd3d39823d39922bc6b27f3aeae590369880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521302 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#824709}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/6rogLKoTPGyF47t Bug: 889763 Change-Id: I6b9a29e569db3c3b756599d20601313ce4fdc522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517166 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824708}
-
Glen Robertson authored
Note this will need https://crrev.com/c/2484038 (ListPurchases mojo) and a Clank-side implementation to land. Explainer: https://github.com/WICG/digital-goods/blob/master/explainer.md Bug: 1139795 Change-Id: Ia70a8af535b14943322d1c2bd671bcf1d2726744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486007 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#824707}
-
Eugene Zemtsov authored
Bug: 1139059 Change-Id: I1e142da5f9f1d6c7cfce42294b9022a0fab1e12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520080Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#824706}
-
Yusuf Sengul authored
Bug: 1143303 Change-Id: I10f7945a2a933b430ba4374b6e318a67f2b7d0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522127Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824705}
-
Darwin Huang authored
Bug: 1145787 Change-Id: Ia71ecf07d24f8d0f684c18a548da28e5b0b4c8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520325 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824704}
-
Nicholas Hollingum authored
We move the launcher code entirely into the borealis' directory and out of the apps service. Only a single call to the API's entrypoint remains. This also involves slightly redesigning the API, we have an AppLauncher as member of the BorealisService which can launch apps given the system is not running. Once the system is running it defers to the AppLauncher::Runtime to issue the relevant requests to cicerone. Bug: b/172401881 Change-Id: I79bd8b93e9c2cdcb2c59509a4192437162ab301d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517185Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#824703}
-
Hitoshi Yoshida authored
This reverts commit 86ef81d7. Reason for revert: I suspect this causes test failures on CrOS. Original change's description: > Remove ButtonListener in favor of callbacks. Other cleanup. > > Add metadata - remove manually overridden GetClassName. > > Add view builders and update view tree construction to use the builder. > > TBR=katie@chromium.org > > Bug: 772945, 938501, 1130078 > Change-Id: Id105b26afb15138ee6e70e7ade5e43be11671a47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505880 > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Auto-Submit: Allen Bauer <kylixrd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824581} TBR=pkasting@chromium.org,pbos@chromium.org,kylixrd@chromium.org,tetsui@chromium.org,katie@chromium.org Change-Id: I5502a73a1f1f5870937efbbb2588f676748bbad1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772945 Bug: 938501 Bug: 1130078 Bug: 1146255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521980Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824702}
-
Aleks Totic authored
Use box order to resolve intersection edge precedence. Makes 9 additional tests pass: css2.1/20110323/border-conflict-element-001d.htm external/wpt/css/CSS2/tables/border-conflict-element-001d.xht external/wpt/css/CSS2/tables/border-conflict-element-001e.xht fast/css/table-rules-attribute-groups-with-frame.html fast/table/colgroup-spanning-groups-rules.html fast/table/border-collapsing/002-vertical.html fast/table/border-collapsing/002.html tables/mozilla/core/table_rules.html tables/mozilla/marvin/x_table_rules_groups.xml Bug: 958381 Change-Id: I53f87d716aada00edec5f06129842fc1fc10eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519882 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#824701}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/88dc2a4895c3..cc2305dd9537 2020-11-05 rharrison@chromium.org [inspector] Extract Sampler resource binding information 2020-11-05 dj2@everburning.com Fixup emitting duplicate globals in HLSL. 2020-11-04 dsinclair@chromium.org [wgsl-reader][wgsl-writer] Update storage texture type name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I1f4200f5368a7f7b6cf94fa51941d04b59518163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824700}
-