GitLab

BUG=488290

Review URL: https://codereview.chromium.org/1136763004

Cr-Commit-Position: refs/heads/master@{#330253}

Fix a crash due to unsafe iterator usage in the DisplayColorManager
destructor.

BUG=488487
TEST=compile

Review URL: https://codereview.chromium.org/1127213007

Cr-Commit-Position: refs/heads/master@{#330252}

BUG=486739

Review URL: https://codereview.chromium.org/1135333006

Cr-Commit-Position: refs/heads/master@{#330251}

Before this CL, AppCacheDiskCache could delete inflight ActiveCalls without
any abort operation when the backend is disabled, so callbacks bound with
ActiveCall objects are invoked in broken state.

After this CL, ActiveCall hides its constructor and manages its own lifetime
using refptr, so AppCacheDiskCache no longer has to take care of their
lifetime. In addition, AppCacheDiskCache passes its weakptr to ActiveCall,
which in turn checks it when an operation is completed. If the backend is
closed, ActiveCall closes the entry and returns net::ERR_ABORTED.

BUG=488757
TEST=n/a

Review URL: https://codereview.chromium.org/1136373003

Cr-Commit-Position: refs/heads/master@{#330250}

Reading of views is now handled using ChromeVox Next with the automation API. The current Next background page fails on non-CROS because there's no commands block. We get an error like
getAll called on undefined.

(chrome.commands is undefined).

TEST=manually build ChromeVox; verify views reads properly.

Review URL: https://codereview.chromium.org/1138773006

Cr-Commit-Position: refs/heads/master@{#330249}

Revert of [Contextual Search] Remove opt-in code. (patchset #6 id:100001 of https://codereview.chromium.org/1103163004/)

Reason for revert:
It broke Clank bots.

Original issue's description:
> [Contextual Search] Remove opt-in code.
>
> This CL requires a downstream change:
> https://chrome-internal-review.googlesource.com/#/c/214963/
>
> BUG=482618
> R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b

TBR=donnd@chromium.org,mathp@chromium.org,dtrainor@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=482618

Review URL: https://codereview.chromium.org/1123313006

Cr-Commit-Position: refs/heads/master@{#330248}

On Windows, clang-cl only parses template methods that are
referenced (-fdelayed-template-parsing), so members traced from
unreferenced template methods weren't seen by the plugin, which
caused it to warn about them.

Explicitly parse delayed template methods that look like they
are trace methods and that aren't in system headers to work around
this. This is based on Kim Grasman's patch for the IWYU project:
https://code.google.com/p/include-what-you-use/source/detail?r=566

This fixes 3 of the 4 failing oilpan plugin tests on Windows.

BUG=486571
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1140443005

Cr-Commit-Position: refs/heads/master@{#330247}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/117dbc2..166b853

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1139543004

Cr-Commit-Position: refs/heads/master@{#330246}

card unmasking prompt.

BUG=487866

Review URL: https://codereview.chromium.org/1134793009

Cr-Commit-Position: refs/heads/master@{#330245}

BUG=462671

Review URL: https://codereview.chromium.org/1143663003

Cr-Commit-Position: refs/heads/master@{#330244}

This adds GN build rules for the AppRemoting sample app.
Some DesktopRemoting build rules were prettified as part of this
process (to make the App- and Desktop- remoting build rules more
similar).

This re-re-lands crrev.com/1126393002 without any additional changes
required. The original issues with the GN clobber builds are fixed in
crrev.com/1137753002. The 2nd attempt to land was rejected due to
a merge race (fixed in this cl).

BUG=471916

Review URL: https://codereview.chromium.org/1143643003

Cr-Commit-Position: refs/heads/master@{#330243}

MSan requires all code be instrumented.

This also rolls BoringSSL. Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/a07c0fc..9660032

BUG=488708

Review URL: https://codereview.chromium.org/1139263002

Cr-Commit-Position: refs/heads/master@{#330242}

Get the omnibox to show up again. Sky's changes from yesterday removed the window manager interface. This is a temporary interface to allow the omnibox app to ask the browser app to place its window.

R=sadrul@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1135933003

Cr-Commit-Position: refs/heads/master@{#330241}

BUG=472152

Review URL: https://codereview.chromium.org/1144543005

Cr-Commit-Position: refs/heads/master@{#330240}

BUG=318217

Review URL: https://codereview.chromium.org/1129643002

Cr-Commit-Position: refs/heads/master@{#330239}

The reason to stop using URL{Request,Response} for HTTP server interfaces: some
fields of those structs belong to a higher level, e.g., |auto_follow_redirects|.
It seems cleaner to define Http{Request,Response} which match the HTTP
request/response definitions.

BUG=478249
TEST=None

Review URL: https://codereview.chromium.org/1129143005

Cr-Commit-Position: refs/heads/master@{#330238}

The dialog was broken because of race condition between
https://codereview.chromium.org/1115993002 and
https://codereview.chromium.org/1129063003

BUG=488629
TEST=manually

Review URL: https://codereview.chromium.org/1124213004

Cr-Commit-Position: refs/heads/master@{#330237}

BUG=480733

Review URL: https://codereview.chromium.org/1131933005

Cr-Commit-Position: refs/heads/master@{#330236}

BUG=392232

Review URL: https://codereview.chromium.org/1130603006

Cr-Commit-Position: refs/heads/master@{#330235}

The bug is that chrome.runtime.sendMessage looks for when its callback is
garbage collected, and when it is, close the associated port. It's important to
close the port to notify the other end of the closure, cleanup renderer state
both locally and on that other end, and potentially browser state.

Unfortunately the port management is implemented in JS itself, and port
releasing needs to go through JS. The problem is that it's not possible to call
into JS while in the process of garbage collection, so we delay it, by which
point the JS context may have been destroyed and again it's not possible to
call into JS. We fixed the former case a while ago, and this patch fixes the
latter.

BUG=471599
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/1136953017

Cr-Commit-Position: refs/heads/master@{#330234}

This also starts logging CANCELED requests, since they are just as
likely as FAILED/ERR_ABORTED ones to be from what *would've* been
ERR_TIMED_OUT if the user had been more patient. :)

BUG=480565

Review URL: https://codereview.chromium.org/1095553004

Cr-Commit-Position: refs/heads/master@{#330233}

Prior to this change, desktop/window capture would emit frames of any
size, regardless of the resolution change policy; and tab capture would
always emit frames of a fixed resolution.  Both cause a problem where
some receivers of the captured video need to do scaling/letterboxing
themselves for proper UX, and other receivers require this be done on
by the capture pipeline.

This change builds upon https://codereview.chromium.org/1124263004,
which allows the client to specify capture constraints that configure
the capture pipeline to do (or not do) the scaling/letterboxing.  All
frame resolution calculation logic has been factored into one place in a
new CaptureResolutionChooser class, which also depends on new utility
functions added to media/base/video_util.*.

BUG=473336

Review URL: https://codereview.chromium.org/1135823004

Cr-Commit-Position: refs/heads/master@{#330232}

BUG=487351
TEST=manual

Review URL: https://codereview.chromium.org/1131683004

Cr-Commit-Position: refs/heads/master@{#330231}

Revert of Use BoringSSL in the implementation of ClearKey for Chromecast. (patchset #1 id:1 of https://codereview.chromium.org/1130893008/)

Reason for revert:
Temporary revert until Monday (blocked on some other internal changes).

Original issue's description:
> Use BoringSSL in the implementation of ClearKey for Chromecast.
> (Previously, this was used only with the "Chrome" branding).
>
> BUG= 488572
>
> R=gunsch@chromium.org
>
> Committed: https://crrev.com/defd2af08f3753687cb2d86b34bbec9da31ccbab
> Cr-Commit-Position: refs/heads/master@{#330156}

TBR=ddorwin@chromium.org,dougsteed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 488572

Review URL: https://codereview.chromium.org/1141243003

Cr-Commit-Position: refs/heads/master@{#330230}

Changes the basic showing test to show the banner and
simulate a user installing the app.

BUG=457414

Review URL: https://codereview.chromium.org/1137313005

Cr-Commit-Position: refs/heads/master@{#330229}

R=vabr@chromium.org,newt@chromium.org
BUG=486739

Review URL: https://codereview.chromium.org/1140713004

Cr-Commit-Position: refs/heads/master@{#330228}

This CL requires a downstream change:
https://chrome-internal-review.googlesource.com/#/c/214963/

BUG=482618
R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1103163004

Cr-Commit-Position: refs/heads/master@{#330227}

testUnregisterDomainWithUnregisteredDomain fails consistently, testUserAgent is flaky.

BUG=483212

Review URL: https://codereview.chromium.org/1143673002

Cr-Commit-Position: refs/heads/master@{#330226}

Prior IDBObjectStore.getAll implementation used zero as the sentinel value
for maxCount to mean unlimited. This change eliminates that check on the
Chrome side. It is now the callers (Blink's) responsibility to pass in a very
large number (MAXUINT) if the intent is to have the response be unbounded.

BUG=457450

Review URL: https://codereview.chromium.org/1138643007

Cr-Commit-Position: refs/heads/master@{#330225}

Ensure that sync still starts properly after signing out and back in.

BUG=480604

Review URL: https://codereview.chromium.org/1122373004

Cr-Commit-Position: refs/heads/master@{#330224}

BUG=488088
R=boliu

Review URL: https://codereview.chromium.org/1140253006

Cr-Commit-Position: refs/heads/master@{#330223}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db1f311..117dbc2

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1132123004

Cr-Commit-Position: refs/heads/master@{#330222}

For some downloaded items like Chrome apps, Chromium hides the download
bar once the download completes if there are no other download items in
it. However, if you cause the download item to display its context menu,
the context menu will remain visible even after the bar disappears.

BUG=480884

Review URL: https://codereview.chromium.org/1125423002

Cr-Commit-Position: refs/heads/master@{#330221}

BUG=488661
TEST=None

Review URL: https://codereview.chromium.org/1128963008

Cr-Commit-Position: refs/heads/master@{#330220}

Update tz db to 2015d

 Summary of changes available at:
 https://chromium.googlesource.com/chromium/deps/icu/+log/ce41627..5788e27

BUG=473288
TBR=jsbell@chromium.org
TEST=In JS console, run the following to get 1:00 PM for 2015
instead of 2:00 PM. In 2014, it should return 2:00 PM.
  may_25_2015_1100 = new Date("05/25/2015 11:00Z")
  may_25_2015_1100.toLocaleString("en", {timeZone: "Africa/Cairo"})
  may_25_2014_1100 = new Date("05/25/2014 11:00Z")
  may_25_2014_1100.toLocaleString("en", {timeZone: "Africa/Cairo"})

Review URL: https://codereview.chromium.org/1141973002

Cr-Commit-Position: refs/heads/master@{#330219}

The current implementation, in fact, doesn't support specifying both
"--v" and "--log-level" command line switches: only "--log-level" switch
will take an effect. This looks counterintuitive.

For example, browser_tests always start the browser with the
"--log-level" switch specified, so with current implementation there's
no way to enable vlogging in browser_tests using a command line.

The suggestion is, as both of the options refer to the same underlying
"min_log_level", to make the "--v" switch have a higher priority.

BUG=

Review URL: https://codereview.chromium.org/1136463009

Cr-Commit-Position: refs/heads/master@{#330218}

Added the Ash.Tab.TimeBetweenSwitchToExistingTabUserActions histogram to track time between tab switches.

TEST=Manually verified histogram data added on ChromeOS.

BUG=478930

Review URL: https://codereview.chromium.org/1124153007

Cr-Commit-Position: refs/heads/master@{#330217}

BUG=486739

Review URL: https://codereview.chromium.org/1128023008

Cr-Commit-Position: refs/heads/master@{#330216}

This CL classifies the following fallback triggers in BoringSSL ports:

- ClientHello intolerance.
- Microsoft's buggy AES-GCM implementation.
- CertificateVerify was rejected (some servers broke TLS 1.2 client auth).
- Resuming a session at the wrong version.
- F5's buggy NPN implementation.
- Other.

It also records how often each error code triggers the fallback.

Initial numbers for the fixed metrics are actually rather encouraging,
but put this in place for the same release if larger populations' numbers
are worse and we'd need to carve out large swathes of intolerance with
less problematic workarounds.

BUG=459690

Review URL: https://codereview.chromium.org/1127623005

Cr-Commit-Position: refs/heads/master@{#330215}

The functions being called already checks for NULL input.

Review URL: https://codereview.chromium.org/1131093004

Cr-Commit-Position: refs/heads/master@{#330214}