GitLab

This CL polishes InMemoryDownload and adds ResponseWriter to support
download pause and resume API.

Also avoid an unneccessary data copy from URLFetcher to InMemoryDownload
that the default StringWriter must copy out the data.

Bug: 809674
Change-Id: Ic86ce2a35109c21951c42d9e759b980eb116a42c
Reviewed-on: https://chromium-review.googlesource.com/918061Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537504}

Reverts part of https://chromium-review.googlesource.com/c/chromium/src/+/920326

If TypedOM doesn't ship in 66 this means that we won't break paint
worklet. (We still need to expose these two classes).

Bug: 812432
Change-Id: I358d49fecdf2169911c72dac758a745067dd5c96
Reviewed-on: https://chromium-review.googlesource.com/924604
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537503}

- D3D11CdmProxy allows injecting stream type GUID, protocol, function IDs
  for possible different implementations that use D3D11.
- D3D11 mocks for testing.

Bug: 787656
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id491699da9a03ab279f8cbc860007bc0ddc94695
Reviewed-on: https://chromium-review.googlesource.com/792590
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537502}

Implements
https://quirks.spec.whatwg.org/#the-html-element-fills-the-viewport-quirk
It computes percentage resolution size, and minimum size for HTML/BODY.

Bug: 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie8cd0ed44df10e753d8658bbe3f4a253d9d4c9f4
Reviewed-on: https://chromium-review.googlesource.com/912609
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537501}

https://pdfium.googlesource.com/pdfium.git/+log/53279b1dcaba..f51cdbd2bddd

$ git log 53279b1dc..f51cdbd2b --date=short --no-merges --format='%ad %ae %s'
2018-02-16 hnakashima Reland "Actually enable -Wimplicit-fallthrough for pdfium."
2018-02-16 rharrison Correct mapping text to characters for characters missing from font
2018-02-16 hnakashima Fix more fallthroughs before reenabling -Wimplicit-fallthrough.
2018-02-16 hnakashima Fix mouse pointer in XFA forms.
2018-02-16 thestig Roll DEPS for clang to a695c30c.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I31876b61beaf64714b0894852ed6a0631312ec66
Reviewed-on: https://chromium-review.googlesource.com/924612Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537500}

This change makes the Memex button (which replaces the tab switcher button if a
flag is enabled) open the Memex UI in a new tab if it's not currently open (to
avoid clobbering the current tab), or if a Memex tab is already open, switch to
that tab.

Change-Id: I71056e004bea7ad998d418d056aad298d71ba5b2
Reviewed-on: https://chromium-review.googlesource.com/922460Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537499}

ChromeBrowsingDataRemoverDelegateTest.RemoveSafeBrowsingCookie* are
flaking due to errors in the cookie store. It seems like the cookie
store is initialized incorrectly. Disabling until we can investigate
whether the problem is in the test setup or in the cookie store
initialization sequence.

TBR=msramek@chromium.org

Bug: 812589
Change-Id: I174790c0ed3518b88eca3e45304015113d5a5ba8
Reviewed-on: https://chromium-review.googlesource.com/924761Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537498}

The test produces too much output due to leaks in html parser.
https://crbug.com/804853

BUG=806988
TBR=bsep@chromium.org

Change-Id: I12b45a16bd25e320021dc495e6031924ba1ac3a5
Reviewed-on: https://chromium-review.googlesource.com/924462
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537497}

DomSerializerTests.SerializeHTMLDOMWithMultipleMetaCharsetInOriginalDoc

TBR=jam@chromium.org

Bug: 812904
Change-Id: Id1cc947c0135536229de1e73d595cdd4323a0759
Reviewed-on: https://chromium-review.googlesource.com/924686
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537496}

Until a pyobjc wheel can be provided in Chrome Infra's vpython
environment, which will require a few more steps, manually run this
test with the system Python which has pyobjc built in.

This will allow vpython-as-python to be deployed everywhere, and then
more changes to be made on top.

TBR=ccameron@chromium.org

Bug: 776804, 804174, 812693
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib6a3a19ff30f2ecb72f51a23ffa028b6789f3ddb
Reviewed-on: https://chromium-review.googlesource.com/924614
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537495}

outparam and compute the HTTP/2 weight in addition to the parent stream
ID, and exclusive bool so that callers do not need to.

Change-Id: I13ebd842f86b5aed9e517a0dc94612c8007af33f
Reviewed-on: https://chromium-review.googlesource.com/915108
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537494}

Allow CastWebView to be created and WebContents retrieved so that a
WebContentsObserver can be added before navigating to the URL.

Bug: internal b/73180315
Test: cast_shell_internal_browsertests
Change-Id: I0c47b5f3c1dca4fe9384c6675b3edf6acd51c793
Reviewed-on: https://chromium-review.googlesource.com/923714Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537493}

Bug: 755920
Change-Id: I00b0b7c195c94f2c8e967d4c85c8155073b9256e
Reviewed-on: https://chromium-review.googlesource.com/879177Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537492}

When HardwareDisplayController::RemoveCrtc is called, planes in old_plane_list,
that is the list of planes last committed for scanout, should be disabled.

Before this patch the planes would not be disabled and would unexpectedly show up
on displays where the old crtc would get reassigned.

Bug: b/72749390
Test: plugged in a secondary monitor while an overlay is displayed on the primary.
Change-Id: I76675a765d0ed9572baaf457060c2d7dac619614
Reviewed-on: https://chromium-review.googlesource.com/924347
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537491}

A TYPE_DEFAULT MessageLoop was previously backed by a native MessagePump, but
switched to a MessagePumpDefault in 8e6fc5fe.

Bug: 812572, 753544
Change-Id: I49c53766067fb69642d5835668c066861d21803f
Reviewed-on: https://chromium-review.googlesource.com/923584Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537490}

https://webrtc.googlesource.com/src.git/+log/1c9aa1ea6693..85904f4ee8b4

$ git log 1c9aa1ea6..85904f4ee --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I786b446201064f03ba687cad3780813359320e34
Reviewed-on: https://chromium-review.googlesource.com/924631
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537489}

For normal boxes, self hit test is done when HitTestAction is kHitTestForeground.
However, for blocks, it's done only when HitTestAction is kHitTestBlockBackground
or kHitTestChildBlockBackground (see LayoutBlock::IsInSelfHitTestingPhase()).

Our NG hit test implementation doesn't consider the latter case, which is fixed
in this patch.

This patch adds 200+ passes to NG layout test.

Bug: 812470
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I03f92444eb431151942eb582305ef63419090a35
Reviewed-on: https://chromium-review.googlesource.com/920687
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537488}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/455a5336..22ef1d88

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia31dc0be73fe985fd872d800cf2abe160c49c16b
Reviewed-on: https://chromium-review.googlesource.com/924343Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537487}

This is a performance optimization in the same vein as PaintLayer
(https://chromium-review.googlesource.com/854628).

Since EmbeddedContentView::FrameRect() now has to compute its location, this patch tries to
minimize the number of calls, in particular when only the size of the frame rect is needed.

BUG=811457
R=chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8285b91519d461ae5230796f4355e8b814f756cb
Reviewed-on: https://chromium-review.googlesource.com/923427Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537486}

Bug: 804496, 804497
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I05b6627c4eb9ab6ae33e337631b7f1e70466730c
Reviewed-on: https://chromium-review.googlesource.com/924650
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537485}

This reverts commit ef052a2f.

Reason for revert: this (with the previous CL 648979) brpoke builds for devices that do not have CUPS.

Original change's description:
> Add support for OOPIF printing in renderer
> 
> These mainly include painting placeholders for cross process subframes,
> sending messages to browser to inform printing such subframes,
> serialization and deserialization of printed content, and compositing
> these contents into the final result.
> 
> The high level design doc is at goo.gl/CF1RUy, and browser side change
> is at https:/crrev.com/c/822155.
> 
> BUG=455764
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I15066f46da41d416356cad7392efb669b5f9f024
> Reviewed-on: https://chromium-review.googlesource.com/838512
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Wei Li <weili@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537243}

TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org,vmpstr@chromium.org,alexmos@chromium.org,khushalsagar@chromium.org

Change-Id: I58a03469bf216957f190e23a3795de472ca58402
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 455764, 813246
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/924486Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537484}

dbus_unittests relies on the presence of /usr/bin/dbus-launch, which is provided
by the dbus-x11 package.  The absence of this package is currently causing
dbus_unittests to fail on the Linux Xenial bot.

BUG=789768
R=dpranke
NOTRY=true

Change-Id: Ic844648f3651e518e276c1fb764849b09145b34b
Reviewed-on: https://chromium-review.googlesource.com/924693
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537483}

Change-Id: Ia357ad7fcc51722ad6e2106d74bfaac569e94f13
Reviewed-on: https://chromium-review.googlesource.com/924652
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537482}

Really fixes the Android test failure this time, by delaying the DCHECK on
process type until after we've considered whether the OS is supported by the
profiler. This has been validated by running the test on Android hardware. The
suspected issue is that Android test is not setting the process type command
line switch, which is being DCHECKed in the profiler code.

This is a reland of 106dd071.

Original change's description:
> Second reland of "Encapsulate Chrome thread profiling setup into a single class"
>
> Fixes Android test failure by avoiding implicit creation of the render
> thread. Also moves the decision on whether to profile extension processes into
> the StackSamplingConfiguration, and cleans up comments.
>
> This is a reland of f8ad6e3e.
>
> Original change's description:
> > Reland "Encapsulate Chrome thread profiling setup into a single class"
> >
> > This is a reland of aa63fc1d.
> >
> > Original change's description:
> > > Encapsulate Chrome thread profiling setup into a single class
> > >
> > > Creates a simple abstraction around the fairly complex profiling setup.
> > > This CL switches over the GPU and renderer process usage to this class.
> > > The browser process usage will be converted to use this class after it
> > > is extended to support periodic profiling (in a follow-on CL).
> > >
> > > Bug: 808588
> > > Change-Id: I6195571bf3ddd08291f288f475569bd9a88795ef
> > > Reviewed-on: https://chromium-review.googlesource.com/905451
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#535125}
> >
> > TBR=sky
> >
> > Bug: 808588
> > Change-Id: I34f1910116c4e7a500e353c27b85bf7534be43c7
> > Reviewed-on: https://chromium-review.googlesource.com/907508
> > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#535170}
>
> Bug: 808588
> Change-Id: Id34e6a3e57c144697413ecced43146bf3e6521e9
> Reviewed-on: https://chromium-review.googlesource.com/917197
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537023}

Bug: 808588
Change-Id: Id93da3a3699b364e3d592823d4326b903b0c5a40
Reviewed-on: https://chromium-review.googlesource.com/923217Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537481}

This was added to support closing the app list bubble on Windows.
At the time, Windows bubbles were constructed of two nested HWNDs.
The app list bubble no longer exists and bubbles are now one HWND.

Bug: 189112
Test: No Min/Max/Restore/Close windows system command behavior changes.
Change-Id: I0a3ead068a54cb7c2a3ba44c4b7af7e38bcba2a7
Reviewed-on: https://chromium-review.googlesource.com/924315Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537480}

_AddNmAliases() updates raw_symbols by adding symbols that have the
same address as existing ones, but with different names. For example,
let raw_symbols be:
  [A1, X, B1, B2, B3, Y, C1, C2],
and suppose X can be replaced with [X1, X2, X3] and Y with [Y1, Y2].
The old code modifies raw_symbols in place by adding gaps first:
  [A1, X, B1, B2, B3, Y, C1, C2, ?, ?, ?],
then move elements to gaps (! are overwritable, including Y):
  [A1, X, B1, B2, B3, !, !, !, ?,  C1 ,C2],
then writes the new symbols in reverse order:
  [A1, X, B1, B2, B3, !, !, Y2, Y1, C1 ,C2].
Repeating (X writable):
  [A1, !, !, !, B1, B2, B3, Y2, Y1, C1 ,C2],
  [A1, X3, X2, X1, B1, B2, B3, Y2, Y1, C1 ,C2].

The code works but is rather complex, and it reverses the order of
new symbols inserted. This CL simplifies the code by allocating a new
array, and insert new symbols in order (of whatever |names_by_address|
returns). The obtained result for the example would now be:
  [A1, X1, X2, X3, B1, B2, B3, Y1, Y2, C1 ,C2].

Note the change of new elements' order. As a result, this CL affects
patch content, and requires change in test data. The computation time
of _AddMnAliases() is negligible (~0.1s).

Change-Id: I5bfb7cceb9e1ebbdf493cea55c92144581721b40
Reviewed-on: https://chromium-review.googlesource.com/922986Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537479}

Issue 61674 and 515257 shows web developer want to call js scroll to
prevent browser scroll restoration. Currently Chrome don't support this.
This patch is to Measure how many pages try to do that.

Bug: 515257, 61674
Change-Id: I7773c1db6f85d1da0f196a2e43fce5faba35e5a9
Reviewed-on: https://chromium-review.googlesource.com/889184Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537478}

Bug: 812947
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If2a653a7784b464d44bbde72d42df0ca719c2e90
Reviewed-on: https://chromium-review.googlesource.com/923580Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537477}

The PrefetchedPagesTracker is used to see if suggestions have corresponding
offline pages, in which case they may be given longer lifetime before expiration.
The check is done after remote provider does a "Fetch", which brings new suggestions
and starts suggestions integration. The whole thing is asynchronous and can trigger
load of offline pages database right after the fetch rather than at the moment of
creation, as it does it currently.

Loading Offline Pages database on Chrome startup becomes too expensive as number
of offline pages grows so it needs to become more on demand.

TBR: vitaliii@chromium.org
Bug: 793109
Change-Id: I919c5c777e8363c194c49cce1fd86076b87ead4d
Reviewed-on: https://chromium-review.googlesource.com/906103Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@google.com>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537476}

This avoids code having to hold on to a raw pointer only. At the same time, it's safe to pass a
pointer to the SharedURLLoaderFactory to other code which doesn't know about it and only expects
a URLLoaderFactory*.

Change StoragePartition::GetURLLoaderFactoryForBrowserProcess to return a SharedURLLoaderFactory as
an example. This avoids consumers, which may be in components and don't know about
StoragePartition, from holding on to the raw pointer past the lifetime of profile. The returned
implementation always calls back to StoragePartition, which allows it to work across restarts of
the network services.

A future change will modify URLLoaderFactoryGetter (used on IO thread). Keeping it separate because
this change is already large.

Bug: 773295
Change-Id: I885a0c3771d78d9daa16c767c7e7dc085cdbfb55
Reviewed-on: https://chromium-review.googlesource.com/924173
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537475}

Also changes the refactors the creation of the ShareParams instance for
the offline page to accept a callback for the send the result and run
the needed IO operation in a background task (avoiding strict-mode
violations).

Bug: 758690
Change-Id: I57cd200961b851dc384ee11ca118a791244a3d7c
Reviewed-on: https://chromium-review.googlesource.com/923361
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537474}

The old keychain wrapper doesn't handle multiple keychain entries and
can't deal with the new keychain schema.

This CL implements a new keychain wrapper for committing
(Key, Account, Security Value) entry and doing
(Key, Account)->Security Value lookup.

BUG=811380

Change-Id: Id2ea073fb5b171fa105a7379a29f7884a0a2f57d
Reviewed-on: https://chromium-review.googlesource.com/917523
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537473}

re-land d70e8035 which broke the mac compile
(message_center_unittests are apparently not built on mac on the CQ)

TBR=rdevlin.cronin@chromium.org

Bug: 578868
Change-Id: I9e07913e4145034a97744c6ad67cf5c59ae961fa
Reviewed-on: https://chromium-review.googlesource.com/923571Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537472}

This test is failing with a pending WebRTC change. It will be
re-enabled and fixed once that change rolls in.

Bug: 813215
Change-Id: I448ba431da7d00b2b04fab2c471d301ecf18310c
Reviewed-on: https://chromium-review.googlesource.com/924610Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537471}

On Cocoa and mobile platforms we would ask the user if they want to
enable "Always Translate" on the initial prompt after they accepted the
translation enough times. This patch adds that capability, in the form
of a checkbox on the translate bubble, to Views platforms.

Bug: 808754
Change-Id: I70149c0e077d70d64a6b6e26f5599a6c39cefda4
Reviewed-on: https://chromium-review.googlesource.com/917641
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537470}

This extracts DevToolsNetworkInterceptor as an interface between
NetworkHandler and the implementation of network request interceptor.
The only current implementation is DevToolsURLRequestInterceptor, but
the URLLoader-based implementation will share the interface.

Bug: 812464
Change-Id: I3c3c00fce2bae7e9278b05eb688f3dda1e8b10c3
Reviewed-on: https://chromium-review.googlesource.com/920795
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537469}

BUG=810917

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I76d2bbae723009eabb528d6ff50f3aa98a739e4f
Reviewed-on: https://chromium-review.googlesource.com/924452Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537468}

The test case passes in SPv175 (enabled by default), fails otherwise.

Bug: 809102
Change-Id: Ic83e3ad785f1b10fb8c359fddb61c5672a6f8e33
Reviewed-on: https://chromium-review.googlesource.com/924622Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537467}

Cause ... why bother keeping two different limits? It can only create
bugs. And does.

Bug: 807833
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0bd136cbfe844a8ce1729c51991f360fca0fe7d5
Reviewed-on: https://chromium-review.googlesource.com/919493Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537466}

On Android, we can expose EXTRA_DATA_TEXT_CHARACTER_LOCATION_KEY
on accessible nodes in order to allow services like Select To Speak
to get the bounding box of individual characters or character
ranges.

When we implemented support for this, we exposed it on almost any
element, but this leads to Select To Speak not being able to
distinguish between real text, and things like images with no
visible text that it might be able to OCR.

Fix this by exposing this character location key only on nodes
that are static text or have a static text descendant.

Add a test that covers some common cases.

BUG=812772

Change-Id: I48941edfaa7522fdd36a5bd7fc88a0a4054713f3
Reviewed-on: https://chromium-review.googlesource.com/922688
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537465}