- 08 Nov, 2018 40 commits
-
-
Darren Shen authored
The virtual keyboard extension is responsible for choosing the size of the keyboard window. In test code, we mock out the extension but we don't set a size. This means that test code has to manually set the bounds of the keyboard window, which is a bit weird. Failing to set the size result in very confusing test failures too. Therefore, we set a default virtual keyboard size in the test KeyboardUI implementations. If test code need a specific size, they can always resize the window themselves. Bug: 849995 Change-Id: I3794f11719bcfe722317174d43492141e6f75b80 Reviewed-on: https://chromium-review.googlesource.com/c/1278462 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#606642}
-
Thomas Tangl authored
When sync is paused, a button to signin again is shown in the sync account control on the main settings page. Bug: 902949 Change-Id: I818034d4d6980ff3d26c4eb8429a13fe20a6fbf2 Reviewed-on: https://chromium-review.googlesource.com/c/1324399Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#606641}
-
Tony de Luna authored
It's not clear what preferring Ethernet or cellular means. Users can just disable WiFi if they want to 'prefer' their cellular network. Bug: 881557 Change-Id: I7e53ca9e4fac2be8f952f0081868a3c255f17f0e Reviewed-on: https://chromium-review.googlesource.com/c/1325150Reviewed-by:
-
Eric Roman authored
Change-Id: Ib616de76fcaca95b252183e85cc1d595b2b8d9fb Reviewed-on: https://chromium-review.googlesource.com/c/1323627 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606639}
-
dpapad authored
Bug: 902959 Change-Id: I6a5bfde6b6b81f16b34d0ae6b728a0aa26f869a3 Reviewed-on: https://chromium-review.googlesource.com/c/1327566Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606638}
-
Saman Sami authored
Currently this method earlies out and returns an empty SkBitmap if OOP-D is enabled. It should just proceed the same way as the non-OOP-D case. Bug: 903453 Change-Id: I0943279e2d98885682f5b8d4e619413293575b5a Reviewed-on: https://chromium-review.googlesource.com/c/1327418Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606637}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/edcefdcf7d5a..fc810ab24daa git log edcefdcf7d5a..fc810ab24daa --date=short --no-merges --format='%ad %ae %s' 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@fc810ab24daa The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I16312640a0f5faf7de821b917869b9f0c2127eae Reviewed-on: https://chromium-review.googlesource.com/c/1327346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606636}
-
Xiyuan Xia authored
Suspect http://crrev.com/c/1259296 fixed it. Bug: 888188 Change-Id: I40d9246fa5ad777cb91fd5aa9e740c1c550643bf Reviewed-on: https://chromium-review.googlesource.com/c/1327552Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606635}
-
dpapad authored
This is in preparation of fully removing neon-animation from the repository (although there is a long way to get there). Bug: 902959 Change-Id: Ia1444651b96fba4316f69cfeb65bf92177acb389 Reviewed-on: https://chromium-review.googlesource.com/c/1324993Reviewed-by:
-
Alexander Alekseev authored
This CL converts discover App flag to feature and enabled it by default. Bug: 864686 Change-Id: Idf8dcce4982a16f92ed7b012525484963f799710 Reviewed-on: https://chromium-review.googlesource.com/c/1326221 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
Regan Hsu authored
of enabling and disabling features. Bug: 870138 Change-Id: Ia4e517b191d08ef906d359bf8e8decd627096f63 Reviewed-on: https://chromium-review.googlesource.com/c/1324852Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606632}
-
Peter Wen authored
Update lint to version 26.4.0-alpha03+. This is the first lint update since 2017 September, thus a long list of TODOs is expected. TBR for mechanical fixes to existing lint errors that are only exposed due to update. TBR=mheikal@chromium.org Bug: 900912 Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3 Reviewed-on: https://chromium-review.googlesource.com/c/1327157Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606631}
-
Alexander Alekseev authored
This Cl delays showing sync settings screen to prevent race with restored tabs. Bug: 900697 Change-Id: Ia23c867974c5f7b80fedc73d71c29968e354c168 Reviewed-on: https://chromium-review.googlesource.com/c/1325210Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#606630}
-
Alexander Alekseev authored
Bug: 864686 Change-Id: I7032bd335ea625683176fc4d71c5285edecfc117 Reviewed-on: https://chromium-review.googlesource.com/c/1326224Reviewed-by:
-
Sam Maier authored
Bug: 898251 Change-Id: I552b1dfbe7d1cdd86f5cfdbf0116b895d255b903 Reviewed-on: https://chromium-review.googlesource.com/c/1320023Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606628}
-
mark a. foltz authored
This addresses comments by palmer@ in Bug 749700. Specifically: 1. Remove XML scrubbing as it's fragile and only used for debug logging. 2. Allow http: and https: for DIAL application URLs. 3. Consolidate validation logic for DIAL application URLs. In addition some IWYU and other minor cleanups. Bug: 749700 Change-Id: Iddde911f2c2848708fcd2854acf98e26e0be8eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1322351Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606627}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/625c7d270c1b..b8b52b46f8db git log 625c7d270c1b..b8b52b46f8db --date=short --no-merges --format='%ad %ae %s' 2018-11-08 thestig@chromium.org Make CPDF_RenderOptions::m_Flags a struct of booleans. Created with: gclient setdep -r src/third_party/pdfium@b8b52b46f8db The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6aa9882d3aa7ce11dfc6dfd079cbbfb1fc3787cb Reviewed-on: https://chromium-review.googlesource.com/c/1327602Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/993edbb4..511e861d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6200203ffc2b808e91daa255e006f7db41df119e Reviewed-on: https://chromium-review.googlesource.com/c/1327547Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606625}
-
Sebastien Marchand authored
Bug: 839878 Change-Id: I045921f965486b19efc67a0a2628e2907936f501 Reviewed-on: https://chromium-review.googlesource.com/c/1277273 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#606624}
-
David Jacobo authored
IntentPickerAutoDisplayService is a KeyedService (including a factory class) so intent picker UI can locally (i.e. within Chrome) check if such UI has been displayed before without the user taking action. The user ignoring the UI should be remembered, so we stop auto-displaying the UI and instead only show an entry icon in the omnibox, where the UI will be one-click away. Bug: 902657 Test: Build. Change-Id: I2e0333b8c7eba3af78a671a4f119b7c26fcc5283 Reviewed-on: https://chromium-review.googlesource.com/c/1303653 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#606623}
-
Reid Kleckner authored
Previously, alignof(int64_t) was 8 on i686, but now it is 4. This is true in GCC 8+ and the latest version of clang. These types have always only been aligned to 4 bytes in struct layout, so this should not have wide ranging implications for ABI stability. Bug: 900406 Change-Id: Ia2f0d87300679148d7ca653b7cc52fe9cf910bbc Reviewed-on: https://chromium-review.googlesource.com/c/1327606Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606622}
-
Victor Miura authored
In Telemetry on Desktop, various toast messages can change the window height dynamically and make layers in the test that should be out of viewport be visible. Double the padding height to ensure they're not visible in these cases. BUG=878951 Change-Id: I19a3990ebd3b577fc19ac73cf72db4e6ecfae3db Reviewed-on: https://chromium-review.googlesource.com/c/1292812Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#606621}
-
Peter Boström authored
Uses 12% opacity of white / black for the placeholder depending on contrast instead of hard-coding GoogleBlue100. For the bouncing pill, use theme colors previously used for the spinner. Bug: chromium:903457 Change-Id: I6dd46ac516a8fef874ecdf95bcaef3b57d7a5974 Reviewed-on: https://chromium-review.googlesource.com/c/1327422Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#606620}
-
Leonard Grey authored
This is a really longwinded way for me to fix some NOTIMPLEMENTED spam, though I'm pretty sure the thing that happens right now when you open a certificate prompt and drag a tab into the parent window is bad. This introduces a new method because we're not sure if it matches the Aura semantics, and this is better than the nothing we were doing previously. Bug: 825834 Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d Reviewed-on: https://chromium-review.googlesource.com/c/1315956 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Robert Ogden authored
This basically turns out to a manual revert of https://chromium-review.googlesource.com/c/chromium/src/+/1091499 Bug: 902063 Change-Id: I83a206ef53793f776fa04704f960dc44b4a158f1 Reviewed-on: https://chromium-review.googlesource.com/c/1324931Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#606618}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca7f9d6defef..aa347dd67ba1 Created with: gclient setdep -r src-internal@aa347dd67ba1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5dedca1f27235ff076b508d96a1bea1f15e266cd Reviewed-on: https://chromium-review.googlesource.com/c/1327603Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606617}
-
BUG=762641 TBR=xiyuan@chromium.org Change-Id: I6477014740f67fb69c6e2684022944b487d484f2 Reviewed-on: https://chromium-review.googlesource.com/c/1327442Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606616}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6721478ef112..1e9fc1aac107 git log 6721478ef112..1e9fc1aac107 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 greg@lunarg.com Add base and core bindless validation instrumentation classes (#2014) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1e9fc1aac107 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia1d79b6d530b7c562c659703b1b11240dd1a15f5 Reviewed-on: https://chromium-review.googlesource.com/c/1327343Reviewed-by:
-
Antoine Labour authored
After switching one-copy to SharedImageInterface, TileResourceFreedIfLostWhileExported lost its meaning as it's only counting staging textures instead of resource textures. This restores the behavior by making sure we ask the SharedImageInterface on the worker context (where they are created now) instead of the GLES2Interface on the compositor context. Bug: 882513 Change-Id: I1257c9e130bfa615d56602b0ce74f2830d5a55f5 Reviewed-on: https://chromium-review.googlesource.com/c/1325087 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606614}
-
Scott Graham authored
Bug: 883496 Change-Id: Ic8973eb46a68ecf09a57572b1d694cb4812c897f Reviewed-on: https://chromium-review.googlesource.com/c/1324209 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606613}
-
Samuel Huang authored
Update includes and comments, and remove some unused code. In particular, remove TODO comments for figuring out whether ARM abs32 references can be 4 bytes long: Turns out ARM absolute references are 8 bytes long. It's rel32 refereneces that can be 4 bytes long. Change-Id: I02dc905885f6cb5ff929efe0fb1f9a6593ee05a8 Reviewed-on: https://chromium-review.googlesource.com/c/1327559Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606612}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2d061b16ea6c..365e59b9d0c3 git log 2d061b16ea6c..365e59b9d0c3 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 treehugger-gerrit@google.com Merge "trace_processor: Improve parsing of json traces" Created with: gclient setdep -r src/third_party/perfetto@365e59b9d0c3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I646e80b134fe28fe928272a8294ce34532aec3e2 Reviewed-on: https://chromium-review.googlesource.com/c/1327345Reviewed-by:
-
Eric Roman authored
It is no longer necessary as ProxyBypassRules now implicitly bypasses loopback addresses. Change-Id: Ia6c480870458e63a70e6ba753137f9169d58ba9e Reviewed-on: https://chromium-review.googlesource.com/c/1327143Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f04a3a61ad90..5d5091665700 git log f04a3a61ad90..5d5091665700 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 dtu@chromium.org [pinpoint] Let users with tryjob access launch Pinpoint jobs. Created with: gclient setdep -r src/third_party/catapult@5d5091665700 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895738 TBR=sullivan@chromium.org Change-Id: Ie7de7636281943d07faae602d9e54132a5cce7dc Reviewed-on: https://chromium-review.googlesource.com/c/1327601Reviewed-by:
-
Alex Oldemeier authored
To avoid other people stumbling over potentially unexpected behaviour of Time::FromString, add a visible WARNING about the underlying converter being very permissive. Change-Id: I86c590eaacf6e2f429baaa66113e9c34b44cdd08 Reviewed-on: https://chromium-review.googlesource.com/c/1323093Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1379508a3a57..06a477c3300d git log 1379508a3a57..06a477c3300d --date=short --no-merges --format='%ad %ae %s' 2018-11-08 mtklein@google.com remove old name for SkCodec::kNoFrame 2018-11-08 reed@google.com Revert[4] "hide nested hinting enum" 2018-11-08 brianosman@google.com Added GrMeshDrawOp::WriteVertexData 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-08 mtklein@google.com Reland "simplify disabling effect deserialization" 2018-11-08 mtklein@google.com exclude RAW codec code from Google3 build Created with: gclient setdep -r src/third_party/skia@06a477c3300d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: If4e4beb7d418f607d61f3ca894c2e0010b419c13 Reviewed-on: https://chromium-review.googlesource.com/c/1327241Reviewed-by:
-
Sahel Sharify authored
This cl resolves the regression that is caused by the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1313270 The previous cl calls UnregisterFlingSchedulerObserver() twice when a fling gets cancelled: once from gesture_event_queue while handling the generated GSE and once from FlingScheduler::DidStopFlingingOnBrowser. When there is only one active fling and the fling is not interrupted by another scroll/fling this works fine since the second Unregister call does nothing. However sometimes when a new fling replaces an active fling (e.g. starting a fling in the opposite direction of the currently active fling) the second Unregister call unregisters the observer that is added for the new fling. Since the observer is unregistered for the new fling no ProgressFling will get called till the user does a third fling. on the first ProgressFling call for the third fling, the controller tries to cancel the second fling and calls unregister which unregisters the observer for the third fling and the same thing happens for the rest of the flings from now on. This cl fixes the issue by not calling UnregisterFlingSchedulerObserver() in FlingScheduler::DidStopFlingingOnBrowser since it will get called once the generated GSE of the fling cancel is processed. Bug: 901831 Change-Id: I4d52f512ea38764fc64c580f6cac5ed4a32c1bee Reviewed-on: https://chromium-review.googlesource.com/c/1327145Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606606}
-
Thoren Paulson authored
The Android implementation of the CMA backend depends on APIs added in Android N. This change uses the default Android AudioManager on earlier versions. Bug: internal b/117838318 Test: audio with GPMusic and Spotify, video with Hulu & GPMovies. Change-Id: Ic59c37e103e098638c861efd8b350c29c028e64d Reviewed-on: https://chromium-review.googlesource.com/c/1327226Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#606605}
-
Pedro Amaral authored
This is the bottom toolbar refactor to allow for 5 buttons in browsing mode and moving the tab switcher toolbar to the bottom. This CL breaks the old bottom toolbar MVC component into 2 components: BrowsingModeBottomToolbar and TabSwitcherBottomToolbar. Those components have a common root coordinator called BottomToolbarCoordinator. I've also added two new providers. The first is the TabCountProvider. It notifies its listeners when the tab count changes. This is useful for the tab switcher button and the HTS tab layout icon. The other provider is the IncognitoStateProvider. It notifies its listeners when incognito mode is entered or exited. It also provides the tint and color for that state. Bug: 900759 Change-Id: Idced9f29ff4e5f3b0c6516b761416f32af78efe3 Binary-Size: Overhead from MVC Change-Id: Idced9f29ff4e5f3b0c6516b761416f32af78efe3 Reviewed-on: https://chromium-review.googlesource.com/c/1292405 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#606604}
-
David Jean authored
Bug: 845472 Change-Id: Id8d909eb12468774b52b74e0684b6ab1e72ad1f2 Reviewed-on: https://chromium-review.googlesource.com/c/1318975 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606603}
-
