- 07 Dec, 2018 40 commits
-
-
Etienne Bergeron authored
This CL is changing the kind of observer used by the sampling profiler wrapper class. The proposed implementation is to use the sync version which is fixing early startup tracing/sampling. The previous code was using a Async observer to keep the class thread-safe. Unfortunately, the sampling profiler is not able to start early enough on startup. The hooks are at the right place. The reason why it's not working on startup is because the tasks queue is already loaded of startup tasks to be executed on the main thread. Thus, after activating tracing, there is a long gab between the point where the tigger occurs and when the sampling profiler got created and start to collect samples (e.g. OnTraceLogEnabled). To avoid this delay, we prefer using a Sync observer. That forces the class to be thread-safe. R=oysteine@chromium.org CC=ssid@chromium.org, wittman@chromium.org Change-Id: I02a1deb2f8aa705ccbf5fb6e7026f4588ca1b319 Reviewed-on: https://chromium-review.googlesource.com/c/1359293Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#614784}
-
Michael Thiessen authored
On O+, Android draws a translucent grey overlay over focused views when the device is not in touch mode (as in, the user is using keyboard to navigate rather than touch/mouse). Drawing this overlay over the entire ContentView doesn't make sense, so we should just disable it. We also have to disable it for the CompositorViewHolder, or when we go between NativePages (like NTP) and WebContents, we animate into and out of the grey overlay, because the CompositorViewHolder briefly gains focus. Bug: 912724, 908917 Change-Id: I97b7f688f06581e872898028a48e6e7b4546d710 Reviewed-on: https://chromium-review.googlesource.com/c/1367926Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#614783}
-
Hector Carmona authored
This CL adds the missing metric combination as well as factoring out to make metrics gathering code shareable with the google apps module. Bug: 874154 Change-Id: Iba2a10264630185b5de236b58cee7b204f2f3054 Reviewed-on: https://chromium-review.googlesource.com/c/1344998 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614782}
-
Andrew Grieve authored
They have: A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18 (Raw: "24") Rather than just: A: http://schemas.android.com/apk/res/android:minSdkVersion(0x0101020c)=(type 0x10)0x18 Change-Id: Ib397ff275a58e7d0595be8d1611c99e4421b6364 Reviewed-on: https://chromium-review.googlesource.com/c/1367112Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#614781}
-
Tibor Goldschwendt authored
This prevents hitting the dex method count limit. TBR=yfriedman@chromium.org Change-Id: I0c53dae4cf7244d55976f42e58ce4de4ff891855 Reviewed-on: https://chromium-review.googlesource.com/c/1368033Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#614780}
-
Eugene But authored
IOSChromeLocalSessionEventRouter will observe multiple WebState objects without using deprecated GlobalWebStateObserver. Also removed browser state check in OnWebStateChange. This check was needed because each WSO callback was called for both BrowserState objects. So the router had to check if the call belongs to correct browser state. After this CL there are no extra calls, hence no need for check. Bug: 910894, 782269, 720786 Change-Id: Ie25ae62efea9edd4a981800d1a43b6ef28b35b14 Reviewed-on: https://chromium-review.googlesource.com/c/1359863 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#614779}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c38fee64ace..de797ddcb5d0 git log 7c38fee64ace..de797ddcb5d0 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 ale64bit@users.noreply.github.com Check that certain decorations cannot be used more than once and/or are mutually exclusive (#2171) 2018-12-07 afdx@google.com Replace loop with selection (#2164) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@de797ddcb5d0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4fd77a288a5c3b6f50bc0d334f2d1f91d4179f37 Reviewed-on: https://chromium-review.googlesource.com/c/1368206Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614778}
-
Boris Sazonov authored
This CL adds SigninHelper.resetSharedPrefs call to OAuth2TokenServiceIntegrationTest.tearDown method. OAuth2TokenServiceIntegrationTest has been causing many test failures in different tests because of the state it has been leaving in shared preferences. Bug: 908542 Change-Id: I10df9d0ab1d268c7da3352ca87ae07659bfa55d2 Reviewed-on: https://chromium-review.googlesource.com/c/1368147Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#614777}
-
Wez authored
Also adds ability for test to supply a mock NavigationController to FakeFrame instances. Bug: 893229 Change-Id: I63ddffcd4a13b49b9e67232161255bd72a11a0cb Reviewed-on: https://chromium-review.googlesource.com/c/1334561Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#614776}
-
Toni Barzic authored
This was used for testing the lock screen apps apis before note taking app supported lock screen. It should not be needed anymore given that the actual note taking app can be used for testing. Change-Id: I3c678018bfb4e1dacb537fb7e3c58dcad2a4b92c Reviewed-on: https://chromium-review.googlesource.com/c/1347770Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#614775}
-
Yiming Zhou authored
This change adds support for testing the presence of Chrome Password Manager's save fallback. The validation function checks if Chrome is showing the save fallback, and waits up to 5 seconds for Chrome to show the save fallback. Bug: 847905 Change-Id: I1a55a170c89ff0384c647d8e7646de256f4f15d8 Reviewed-on: https://chromium-review.googlesource.com/c/1334552Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#614774}
-
Quan Nguyen authored
When the lock screen is shown, the existing system Clipboard is replaced with an empty version. Once the lock screen is destroyed, the old Clipboard state is restored. Bug: 902516 Change-Id: Ifc5b3cee992abd701fe1c80349f8d8ec84f91546 Reviewed-on: https://chromium-review.googlesource.com/c/1354332Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614773}
-
Tomasz Wiszkowski authored
Change-Id: I06250421bf2ba402795eb171aa25860f45601db2 Reviewed-on: https://chromium-review.googlesource.com/c/1366780 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#614772}
-
Dean Liao authored
Extend V4L2Device::PreferredInputFormat() by adding |single_planar| arg so that it can also return single-planar preferred input format. BUG=b:73752373 TEST=pass VEA test Change-Id: Iaabdf3d7a2239bbd4043c000193e52207fab8e10 Reviewed-on: https://chromium-review.googlesource.com/c/1361742 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#614771}
-
Max Moroz authored
Bug: 701825 Change-Id: Ib4e789ec1237782d9a6a65da6c24dac02713095b Reviewed-on: https://chromium-review.googlesource.com/c/1367870 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#614770}
-
Philip Rogers authored
The leak detector bot is more flaky on virtual/android/fullscreen tests for unknown reasons (see: https://crbug.com/769885). With BGPT, virtual/android/fullscreen/video-scrolled-iframe.html recently got more flaky, though it flaked before BGPT was enabled too. This patch marks virtual/android/fullscreen/video-scrolled-iframe.html as skipped due to 2px of flakiness. Bug: 912979, 769885 Change-Id: I941413dcd52b36401703ffdf85f52114aa7600aa Reviewed-on: https://chromium-review.googlesource.com/c/1368107Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614769}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3dde0186457b..2e480713da7d git log 3dde0186457b..2e480713da7d --date=short --no-merges --format='%ad %ae %s' 2018-12-07 fmayer@google.com Changes needed to run on OSS-Fuzz. Created with: gclient setdep -r src/third_party/perfetto@2e480713da7d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:69150303 TBR=perfetto-bugs@google.com Change-Id: Iee2cd94c09707ae7f19eb34433fe9f001581e24c Reviewed-on: https://chromium-review.googlesource.com/c/1367867Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614768}
-
Samuel Huang authored
Culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1361598 Bug: 912772 Tbr: danakj@chromium.org Change-Id: I6262ca1623dc23e6004131fd60c86c62b13c593f Reviewed-on: https://chromium-review.googlesource.com/c/1367928 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#614767}
-
Caleb Rouleau authored
Without this flag, I get the error: Stdout: BigQuery error in query operation: Cannot start a job without a project id. Change-Id: I2480e312dc8934fa8d3f4de215bbb8803a98f6cc Reviewed-on: https://chromium-review.googlesource.com/c/1366937Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#614766}
-
Dan Harrington authored
Introduced OfflinerClient - Moves handling of the watchdog timer into a smaller class, so it easier to reason about. - Consolidates return paths of offliner -- cancellation now results in a completion callback. Reorganized offliner completion handling in RequestCoordinator. Hopefully making it easier to follow. Using switch instead if if/then so that enum values added later are sure to be considered. To go further, code to stop processing was simplified. StopOfflining() was removed, and replaced with calls to StopProcessing(). How to continue after processing stops is entirely determined by the RequestStatus of the stopped request. PauseRequests() and RemoveRequests() were changed to wait until the items are updated before cancelling the in-flight request if it happens to match. This was done to simplify the code: execution is more sequential, and we can now depend on StopProcessing to continue request processing if appropriate. Also this prevents a potential bug, where RemoveRequests() calls TryNextRequest while the offliner is still in the middle of cancellation. StopProcessing() is now private. Added CancelProcessing() to make it clear which statuses callers can inject. Bug: 906651 Change-Id: I89f3705e6bcfbc18599041b4ce2fb8add1b220af Reviewed-on: https://chromium-review.googlesource.com/c/1361633Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#614765}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a3805c348c3..a63593a10c1b git log 7a3805c348c3..a63593a10c1b --date=short --no-merges --format='%ad %ae %s' 2018-12-07 brianosman@google.com Remove sample shading and dest color override Created with: gclient setdep -r src/third_party/skia@a63593a10c1b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I67d0db329a251d3c1ada1bc12a84edb1a75aaf6f Reviewed-on: https://chromium-review.googlesource.com/c/1367966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614764}
-
James Cook authored
The chromeos_* unit test suites are designed to run on Linux, not on real hardware or in VMs. On the Chromium waterfall they are built with the linux-chromeos configuration. Developers using the "cros chrome-sdk" sometimes think they need to build these targets and run them, either on their host workstation or on device. The tests aren't expected to work in these environments, so prevent them from being built. Bug: 909073, 865693 Test: ninja -C out_eve/Release chromeos_unittests won't compile Change-Id: Idf8c366f7001ea5bbc744ccba6e627d70f5efebb Reviewed-on: https://chromium-review.googlesource.com/c/1358509 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#614763}
-
Hiroshige Hayashizaki authored
To reduce GetDocument() usage. As https://github.com/w3c/webappsec-csp/issues/146 has already been closed and the Blink implemetation has been changed, this UseCounter is no longer needed. Bug: 878274 Change-Id: Icb55058d369b29992436229a9b971bc6f0b8f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1192303Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#614762}
-
Madeleine Barowsky authored
We can significantly speed up WebP rendering and reduce memory footprint per image by decoding and storing lossy WebP images into their native YUV format instead of unnecessarily converting to RGB. This flag will be used to safely hide changes to the image decoding paths until the feature is completely landed. See bit.ly/webp-decoding-into-yuv for the design document and crrev.com/c/1338461 for a working prototype CL in the GPU rasterization case. Bug: 900264 Change-Id: I611d17199cae4724332d73a5606f20d4eedf9010 Reviewed-on: https://chromium-review.googlesource.com/c/1366858 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#614761}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6f0e1f9d8235..67737f1d4a6c git log 6f0e1f9d8235..67737f1d4a6c --date=short --no-merges --format='%ad %ae %s' 2018-12-07 cwallez@chromium.org WireServer: Don't allow freeing the Device 2018-12-07 cwallez@chromium.org WireServer: on destruction, free all objects. Created with: gclient setdep -r src/third_party/dawn@67737f1d4a6c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:907278,chromium:911155 TBR=cwallez@chromium.org Change-Id: I5bd2d58ab3b7c21546f6cd52baa9f60eda9bba87 Reviewed-on: https://chromium-review.googlesource.com/c/1368204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614760}
-
Ben Wagner authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/6ad3fcddaf2b..59345cdef38c $ git log 6ad3fcdda..59345cdef --date=short --no-merges --format='%ad %ae %s' 2018-12-06 ariza [CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460) 2018-12-06 behdad Fix likely check 2018-12-06 behdad Add default value to first argument of sub_array() 2018-12-06 behdad Add sub_array to hb_vector_t 2018-12-06 behdad Add default-value for second arg of sub_array() Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I43da06c24f22509b8ad010191c630e833a15a235 Reviewed-on: https://chromium-review.googlesource.com/c/1368044 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#614759}
-
Alexei Svitkine authored
Bug: 912320 Change-Id: I2f6367902a43a211459442897ec277effd8fc402 Reviewed-on: https://chromium-review.googlesource.com/c/1368032 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614758}
-
Xianzhu Wang authored
The BGPT result is correct, though with subpixel differences along rounded corners. Before BGPT, the bottom-left corner was not clipped with rounded border. Change-Id: I17fd469f5ed29354a6d1dcd76970b07c88bbe4ea Reviewed-on: https://chromium-review.googlesource.com/c/1366768 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614757}
-
yileili authored
This is a reland of 29dca9fe Remove an unnecessary include to fix the compile break: ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: None. Test: Compiled Original change's description: > Enable warmer welcome during Assistant launch. > > 1. It is guarded by a finch flag AssistantWarmerWelcome. > 2. WW only shows 3 times. > > Bug: b:112495005 > Test: Manual > > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1355174 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#614553} Bug: b:112495005 Change-Id: I9c67fd0c85b216e17408056c6d7df35e6f205c6f Reviewed-on: https://chromium-review.googlesource.com/c/1367185Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yilei Li <yileili@google.com> Cr-Commit-Position: refs/heads/master@{#614756}
-
Jeremy Roman authored
Previously, AudioNodeOutput::RemoveInput could call AudioHandler::BreakConnectionWithLock at a time when one of the mutual sets of raw pointers has been updated but the other has not. This causes the Disable logic to go awry, leading to DCHECK failures and, after another recent change, ASAN violations, since it can be entered as part of AudioHandler::DisableOutputsIfNecessary during BreakConnectionWithLock. This was not obvious by inspection in part because this logic was distributed across several methods in different classes. To make the order in which these adjustments are made more clear, factor out the wiring logic from AudioNodeInput and AudioNodeOutput (and strictly for consistency, AudioParamHandler) into a collection of dedicated functions. Call sites are rewritten to call this code, which manages all changes to inputs_, outputs_ and disabled_outputs_ centrally. Bug: 910098 Change-Id: Ide367d89cf6601e823169082833d7a41f1019f81 Reviewed-on: https://chromium-review.googlesource.com/c/1359134 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614755}
-
Zhuoyu Qian authored
As the comment left by jsbell@, replace IndexedDBContext::GetFilePathForTesting to use url::Origin instead of GURL. Change-Id: I50de11bbbc4b4bd582d3c7ad0031e43734c567c3 Reviewed-on: https://chromium-review.googlesource.com/c/1364992 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#614754}
-
Nicolas Pena authored
The timeout used to bail out early is causing flakiness, so this change removes that timeout since it is not needed for the test. It also increases the timeout used in cross-origin-iframe-element.html to give chance for the entry to be dispatched. Since this test passes when such entry is NOT dispatched, that test is not currently flaky. Bug: 879270, 896765 Change-Id: Ie02a9787d721e6c0d1f347b0d08dd9dbd985ca79 Reviewed-on: https://chromium-review.googlesource.com/c/1363960Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614753}
-
Sam Maier authored
Bug: 908988 Change-Id: I170702d077cd0d3f07894afb084a1d3a20a87de1 Reviewed-on: https://chromium-review.googlesource.com/c/1367934Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#614752}
-
Xiaohui Chen authored
Increase the contrast for a11y. Bug: 910560 Test: locally build and run Change-Id: I1b8bb4d000902cd2db7349a4ca6cc63fd02f6853 Reviewed-on: https://chromium-review.googlesource.com/c/1366324Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#614751}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6df6194db8b5..7c38fee64ace git log 6df6194db8b5..7c38fee64ace --date=short --no-merges --format='%ad %ae %s' 2018-12-07 zoddicus@users.noreply.github.com Restrict mask bits for memory semantics in WebGPU (#2180) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7c38fee64ace The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icf2a54dc52cae0bb288bfac7e7ef8890cf1960a1 Reviewed-on: https://chromium-review.googlesource.com/c/1367868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614750}
-
Xianzhu Wang authored
Some tests have already been passing since BlinGenPropertyTrees is promoted to experimental. Change-Id: I3f99c22550461b096199cef9bbda458f5fcac1d8 Reviewed-on: https://chromium-review.googlesource.com/c/1366277 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614749}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f7ba919cedb..92795e7e949d Created with: gclient setdep -r src-internal@92795e7e949d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7be99a4a0ca55640be8b582e31d5f2d5ee09bcc5 Reviewed-on: https://chromium-review.googlesource.com/c/1367869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614748}
-
Akihiro Ota authored
This change only reflects updates to Android-specific code. Substituting recently implemented AXNode::GetPosInSet() and AXNode::GetSetSize() functions when posinset and setsize computations are necessary. Change-Id: I6cd876921cd1ab8cc6f47f058dcfc88d7c365897 Reviewed-on: https://chromium-review.googlesource.com/c/1361654 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#614747}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f10ca8145d9..10b051083c0d git log 3f10ca8145d9..10b051083c0d --date=short --no-merges --format='%ad %ae %s' 2018-12-07 mbonadei@webrtc.org Disable hermetic toolchain when building on macOS 10.14. Created with: gclient setdep -r src/third_party/webrtc@10b051083c0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I696e0aa56bd9afd0f8548ce08d25bca532a52332 Reviewed-on: https://chromium-review.googlesource.com/c/1367965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614746}
-
Ben Pastene authored
And add a test notification for a couple builders. R=nodir, tandrii Bug: 903591 Change-Id: Ic034e8729a9dfdea522ea720e26bddc7466fd6cf Reviewed-on: https://chromium-review.googlesource.com/c/1367113 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#614745}
-