Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 12 Feb, 2020 37 commits
  3. 11 Feb, 2020 3 commits
    • Sergey Ulanov's avatar
      [Fuchsia] Make namespace parameter in fidl_library GN template optional · 441ccbcb
      Sergey Ulanov authored 
      Previously fidl_library GN template required namespace parameter. It was
separate from library_name mainly to workaround the lack of
string_replace() function in GN. But that's not a problem anymore. This
change updates fidl_library template to make namespace parameter
optional. Now library_name can contain complete name of a FIDL library,
e.g. "fuchsia.ui.gfx". namespace is still supported and works as before.

Also updated all FIDL targets to specify namespace as part of
library_name.

Bug: 1050252
Change-Id: I3de83e244b3ef32449e170f06933beb58198aa0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045000
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740475}
      441ccbcb
    • Nektarios Paisios's avatar
      Removed static SetTree method from AXNodePosition · 1c445a88
      Nektarios Paisios authored 
      This patch starts the long journey of combining AXNodePosition and BrowserAccessibilityPosition into one class.
It also takes a small step in combining AXTreeManager and AXTreeManagerMap into a single interface that will be used to manage a forest of AXTrees across Web, Views and chrome.automation.

For now, this patch introduces TestAXTreeManager, which implements AXTreeManager and encapsulates AXTreeManagerMap.
Currently, this class is used only in tests.
The static method in AXNodePosition that is used to set a single AXTree as the tree to which the position belongs has been removed.
This enables AXNodePosition to rely on the same tree ID as BrowserAccessibilityPosition at all its calls sites, especially in tests.

An additional overload "GetNodeFromTree" has been added in AXTreeManager, that makes it easier to retrieve a node from the current tree without the need to always specify the tree ID.

Some cleanup fixes have been introduced in test fixtures that now inherit from TestAXTreeManager.
The constructors, destructors and move + assign operations have been fixed where they were missing or erroniously implemented,
and some class comments have been cleaned up.

R=dmazzoni@chromium.org, kschmi@microsoft.com, kbabbitt@microsoft.com

Change-Id: I3d5e86e6e5ae77c2b47469d2c9eb44ae5093350e
Bug: 1049261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039310
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: default avatarKurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: default avatarEthan Jimenez <ethavar@microsoft.com>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740474}
      1c445a88
    • Brandon Wylie's avatar
      Disable flaky test #testRightSwipeNavigateForwardOnRenderedPage · 40733c4a
      Brandon Wylie authored 
      TBR=jinsukkim@chromium.org

Bug: 1051221
Change-Id: I57fdf8c492208c2cdd70ac0008c37f921dac450c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050578Reviewed-by: default avatarBrandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740473}
      40733c4a