- 01 Sep, 2020 40 commits
-
-
Robert Ma authored
Bug: 1122581 Change-Id: I80e42994300d4785a8b79ad6d6f3bcda61441dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386391Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#803505}
-
mhasank authored
This reverts commit b57c4658. Reason for revert: The work has been abandoned and the change is not needed anymore. TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Bug: b:133248517 Change-Id: I46df509f1f364924a2a1da5bd9fe6fc4f3b85848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386101Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#803504}
-
Maksim Ivanov authored
Fix double-callback-call crash and use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2da08b89a3dbab954caee4aa273f19ea958fa226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383019 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#803503}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1598874892-73206483eae1decbe634d34fb148ae3f49e172dd.profdata to chrome-win64-master-1598939551-51febd9296737e06a064f51f5c719578c85be72c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie9856837abcdbfd8d0b4ad1beb14ffbcd8a509e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803502}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/ui/views/web_apps This CL was uploaded by git cl split. R=mgiuca@chromium.org Bug: 1110266 Change-Id: I452196d7fb9de8634c2c8b6044d9b0bafb4691ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371282Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#803501}
-
Garrett Beaty authored
The recipe code has been updated to skip analysis and run all tests if any of the test spec files are affected by the CL under test, so removing this exclusion will allow builders that don't consume the affected spec files to exit without running any tests if no other files in the CL affect the test targets. Bug: 1123187 Change-Id: I5fb196af879e36d3fe68d65fc6d39ab95116ed6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386327Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#803500}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/f70065f62227..11eda3cc3e50 $ git log f70065f62..11eda3cc3 --date=short --no-merges --format='%ad %ae %s' 2020-08-31 rharrison Rolling 5 dependencies 2020-08-31 dneto [spirv-reader] Set some source locations 2020-08-31 tommek [spirv-writer] Generate texture type 2020-08-31 tommek [spirv-writer] Convert ast image format types to spv 2020-08-31 tommek [type-determination] Adding builtin texture operations 2020-08-31 tommek [ast] Determining subtype of StorageTextureType 2020-08-31 dsinclair [msl-writer][hlsl-writer] Pull loop variables out with continuing. 2020-08-31 dneto [spirv-reader] Uses in phis count as uses 2020-08-29 dneto [spirv-reader] Don't hoist pointers that are already in scope. 2020-08-28 dneto [spirv-reader] Track line numbers 2020-08-28 dneto [spirv-reader] Avoid certain hoisting cases 2020-08-28 dneto [spirv-reader] Follow non-canonicalized SPIR-V type for composite extract 2020-08-28 dneto [spirv-reader] Follow non-canonicalized SPIR-V type for access chains 2020-08-27 dsinclair [wgsl-parser] Consume empty struct closing brace. 2020-08-27 sarahmashay [validation] check if at least one of vertex, fragment or compute shader is peresent 2020-08-27 sarahmashay [validation] Add a helper function to create a fake entry point 2020-08-26 dsinclair Add missing doc comments. 2020-08-26 dsinclair [hlsl-writer] Move test helper to a template. 2020-08-26 dsinclair [hlsl-writer] Support matrices in storage buffers. 2020-08-26 dsinclair [hlsl-writer] Emit numthreads for compute shaders. 2020-08-26 dsinclair [hlsl-writer] Emit zero matrix values. 2020-08-26 dsinclair [hlsl-writer] Extract storage buffer index generation. 2020-08-26 dsinclair Emit structs when emitting the aliases. 2020-08-26 dsinclair [hlsl-writer] Refactor output emission. 2020-08-25 dsinclair [hlsl-writer] StorageBuffer support. 2020-08-25 sarahmashay [validation] implement the pair of entry point stage and name must be unique 2020-08-25 sarahmashay [valdiation] Add disable test for v-0020, the <entry point name, pipeline stage> must be unique 2020-08-25 sarahmashay [validation] validates if global variables have a storage class 2020-08-25 dsinclair [wgsl-parser] Set max recursion depth on const_expr 2020-08-25 rharrison Ran 'git cl format' over an empty CL 2020-08-25 sarahmashay [validation] clean up: using ValidatorImpl member instead of creating one 2020-08-25 sarahmashay [validation] Add a validator test helper class 2020-08-24 tommek [wgsl-reader] Adding for loops 2020-08-24 rharrison Rolling 6 dependencies Created with: roll-dep src/third_party/tint/src Change-Id: I63be3138a23f1f8b0c2299fcf369d5c2497476c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387133 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#803499}
-
James Vecore authored
Fixed: 1123395 Change-Id: I2fc3b5965e0e0ac8b1f3774660d2db5ffe672c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387117Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803498}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c2302e8e2eb6..090049c54646 2020-09-01 danilchap@webrtc.org Remove usage of webrtc::RTPFragmentationHeader from objc wrappers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7de3c36ed4b5da7a2027014e0b58a87bac8b4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387943Reviewed-by:
-
Etienne Pierre-doray authored
Most Chrome unwinding failures can be correctly handled bu applying the default step (using lr) when no cfi is present at the top of stack. Change-Id: I0349688dcafa3973f1f77f230660312a4140dc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381730 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#803496}
-
Martynas Sinkievic authored
Change-Id: Ib1a1dc848604ef9fb49e4a4f6946bf6f888db8e9 Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346246Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Martynas Sinkievič <marsin@google.com> Cr-Commit-Position: refs/heads/master@{#803495}
-
Aaron Leventhal authored
Ensure that the name of a document with an empty title is '', as opposed to no name at all. This is similar to the difference between alt="" and not alt attribute. Bug: 1123535 Change-Id: I13e35de86f7e1185465950f191b5047513779192 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385655 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803494}
-
Tommy Martino authored
TBR=mamir@chromium.org Bug: 1123907 Change-Id: I5b50e8cf2b1947d2d94bb7fec906266b19e0ddc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386389Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#803493}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: Ied981248389b38caee411d09ff4a6cb207e540b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372427 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#803492}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I1ed09045ae6dce5dd2957bf84df5b554a5b2f6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377553Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#803491}
-
Ren-Pei Zeng authored
Remove DecodeWithFD() Mojo interface from MJPEG Decode Accelerator because CrOS camera service has migrated to use DecodeWithDmaBuf(). Bug: b:165883754 Test: camera preview in CCA Change-Id: I6c58a9abe2c6a4775829ccbd8c62cb67ddedb33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384710 Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803490}
-
Maksim Sisov authored
Wayland drag and drop tests rely on this feature. That is, this feature is used to decide what OSExchangeDataProvider should be created. When the tests are run locally, the feature list is not automatically passed and these tests fail. In contrast, our bots pass --enable-feature=UseOzonePlatform based on the "variant" configuration. So, in order to make these Wayland tests work locally as they should, automatically prepend the UseOzonePlatform feature. Bug: 578890 Change-Id: I10394420c55a6fdf871ea4dd04aae21c02551e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387762Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#803489}
-
Kent Tamura authored
- Move LayoutSlider::kDefaultTrackLength to LayoutSliderContainer. - Remove unused LayoutObject::IsSlider() and IsSliderThumb(). This CL has no behavior changes. Bug: 1040826 Change-Id: I875cf6d11988221ea4413733449501d045c8522a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387043 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803488}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I02b0dab841d1efbb7efd73b97b269f7e39c56e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387057Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803487}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba80574e. With Chromium commits locally applied on WPT: ec83f499 "Add tests for background-color of inline boxes in RTL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I16421f08cafad921c7b0b8fef6b452955170d3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386764Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803486}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4efbe326b48b..4977f960c950 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-01 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityModel.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9e08e3cb7c7ff3bdcf3d47796f1e5452f3b792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387940Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e2645e44ad6b..64e4b1e8e2e8 2020-09-01 lalitm@google.com ui: ensure resolution of at least 1ns If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:166684163 Tbr: perfetto-bugs@google.com Change-Id: Ie42af652adc4f5d14810d3e24ee4186b72355421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387941Reviewed-by:
-
Arthur Sonzogni authored
This reverts commit 0a7f5359. Reason for revert: This confirmed the android bot was not overriding the origin trial key. Once confirmed, this patch isn't useful anymore. Hence reverting it. Original change's description: > Check the android bot do not override default origin trial key. > > The origin trial "CrossOriginOpenerPolicyReporting" is not properly > recognized on the Android bot. > > I suspect the default origin trial test key is overriden. This patch > adds a check to ensure this isn't the case. > > Bug: 1119555 > Change-Id: I86e8f1fe6b5e2cc7b8ffd301bc96c0d4d810a844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374788 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802147} TBR=clamy@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119555 Change-Id: Ie091eeec36c38e72d992d124246022aa8cd2a5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386742Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803483}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0b89b27263b1..1c4a7f780f10 2020-09-01 jiawei.shao@intel.com Fix the initialization of the buffers with MapRead and MapAtCreation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ib469a1854e8743242b0a9308fd4aaeed49d3aaa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387661Reviewed-by:
-
Nela Kaczmarek authored
[Passwords] Redirect to change password url fetched from AffiliationService in WellKnownChangePasswordNavigationThrottle. This change modifies the navigation in WellKnownChangePasswordNavigationThrottle. It prefetches change password URL from AffiliationService if /.well-known/change-password is not supported and feature flag kChangePasswordAffiliationInfo is enabled. The change covers browser integration tests. Bug: 1108279 Change-Id: I3cac54891e62b718ddec0aa46c1fd727cee24dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382810 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803481}
-
Ewann authored
This CL adds the following user actions: - MobileTabGridCloseAllTabsConfirmationConfirmed - MobileTabGridCloseAllRegularTabsConfirmationPresented - MobileTabGridCloseAllIncognitoTabsConfirmationPresented - MobileTabGridCloseAllTabsConfirmationCanceled Bug: 1119319 Change-Id: Ifebaca830bcf52e0c526a32acb90b82d376db33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367094Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#803480}
-
Jesse Schettler authored
Hook up the Mojo interface provider to the scanning UI and generate js-lite bindings from scanning.mojom. A subsequent CL (http://crrev/c/2378138) uses the ScanService Mojo interface to get the connected scanners and add them to a dropdown in the UI. Bug: 1059779 Change-Id: I4270721ac585d668ee1ad5405695590ba78e7711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368238Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#803479}
-
Marc Treib authored
Every type of UserEvent must specify whether it should or should not come with navigation IDs (or that either is okay). kFlocIdComputedEvent did not specify any of these options (instead falling through to a default case with a NOTREACHED()). This CL fixes this by specifying that Floc events should not have navigation IDs. It also adds a comment to the relevant "switch" to make this clearer, and hopefully prevent the same thing from occurring again. Bug: 1116628 Change-Id: I7f8fd9a4ec008ee65dc606619bd2a8247123ca6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387573Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#803478}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19157ee4a2fd..e2645e44ad6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5bf2a80e244acadc2d556541da3be1d397c47cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387623Reviewed-by:
-
James Cook authored
This allows us to avoid creating a test mojo service and simplifies the code. Follow up from review comments in: https://chromium-review.googlesource.com/c/chromium/src/+/2368484 Bug: 1116652 Change-Id: I02206df8f1213beb264068e2a8b818d93ef2cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386378 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#803476}
-
Fredrik Söderqvist authored
Regular/non-fast-path parsing limits <quirky-color> to a limited number of properties (based on the list in the quirks spec [1]). The fast-path however did not limit based on property but only considered the parser mode. This meant that some parsing code-paths would allow <quirky-color> even when they shouldn't have. [1] https://quirks.spec.whatwg.org/#the-hashless-hex-color-quirk Bug: 1024491, 998400 Change-Id: I88acb102c434c1a73c79eeb1eb94ad06c0677b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385357Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#803475}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. Tbr: hkamila@chromium.org Bug: 1104836 Change-Id: Ic598ca409d1a0634abb9b99c8186a8d92c28b260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367075 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#803474}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e464bb1096d27bda8da2a9637b0906dbb2422da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387450Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib5ea3151f87a385b27b37cb5944c981a124b9dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383017Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803472}
-
Nektarios Paisios authored
AXPosition now uses the deprecated text iterator class for translating DOM offsets to text offsets, and for calculating text lengths with all uncompressed white space removed. A text offset in the accessibility tree might not have the same value as the DOM offset for an equivalent position in the DOM tree, because the DOM may have extra white space that should be collapsed. This patch switches to using the NGOffsetMapping class in Layout NG for all such calculations. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1008031 Change-Id: I6953355e83b0953ffa341207bbdde0249cd1b74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384471 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803471}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic193475f84e8f43193ad141477a5265ea81e458f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382077Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803470}
-
Andrew Grieve authored
Bug: 1123778 Change-Id: I5c0b7b4e91c7b01907ae5b59523f7d3db1b0ca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387341 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#803469}
-
Javier Ernesto Flores Robles authored
I found 2 users crashing in this util. Instead of crashing this will return an empty string and log an error. This will fill an empty string, but will also help diagnose the cause of the issue. Bug: 1122639 Change-Id: I648398811388225382bb0a039736b9eff5f538b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379843Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#803468}
-
Claude van der Merwe authored
Add Phone Hub, Phone Hub Notifications, Phone Hub Notifications Badge and Phone Hub Task continuation feature item summaries to Multi Device sub page. Bug: 1106937 Change-Id: Ib1b99e6d1187220eceb365e97b1177c15f1cad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386420Reviewed-by:
-
Erik Språng authored
These are used to monitor WebRTC performance over time, and is not part of any particular experiment setup. As such, it does not make sense to have expiry dates for them, that needs to be maintained. Bug: 1109878, 1109877, 1105014, 1091162, 1089987, 1089667, 1087422, 1075638, 1072675, 1068041, 1066086, 1053185, 1041092, 1037408, 1018112, 1008000, 1000023, 988738, 988737, 988727, 988718, 988701, 988698, 988685, 988680, 988637, 988632, 974250, 1121219 Change-Id: I5433c5187e0f51b418dca446570b14b34f563bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362701 Auto-Submit: Erik Språng <sprang@chromium.org> Reviewed-by:
-
