GitLab

Update flatbuffers to enable pending tflite addition to third_party.

WIP of tflite integration: https://chromium-review.googlesource.com/c/chromium/src/+/2486389

https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/136d75fa6580..6df40a247173

$ git log 136d75fa6..6df40a247 --date=short --no-merges --format='%ad %ae %s'
2020-03-12 aardappel pre-tag version bump for 1.12
2020-03-12 mustii Removes the inner loop in the endtable check written tables (#5803)
2020-03-13 mockbutler Escape characters in jsonschema descriptions (#5644)
2020-03-13 31897320+vglavnyy Remove `noexcept` qualifier copy-ctor of `union` type (#5800) (#5802)
2020-03-13 31897320+vglavnyy Replace 'assert' by 'FLATBUFFERS_ASSERT' inside idl_parser.cpp (#5799)
2020-03-12 jakub Add non-nullable modifier to return type of functions never returning null (#5797)
2020-03-12 qqlddg [C++] Generate code for vector force_align attribute. (#5796)
2020-03-09 25088801+jean-airoldie rust: pub export the VectorIter type (#5736)
2020-03-09 aardappel Fix Python min alignment
2020-03-08 lee.mracek [Rust] Add gen-name-strings for Rust (#5757)
2020-03-05 aardappel Removed assert that wasn't backwards compatible.
2020-03-05 aardappel [C#] add ObjectAPI Serialization Utility (#5785)
2020-03-02 aardappel Fixed docs on how to obtain parser error.
2020-03-02 dbaileychess Added --filename-suffix and --filename-ext to flatc (#5778)
2020-02-27 derekbailey Fixed refractoring issue in reflection/generate_code.sh. Also, mv deletes the original file, so I don't need to clean it up manually in that case. (#5777)
2020-02-24 derekbailey Skip writing reflection_generated.h if not changed (#5776)
2020-02-24 mustii [Swift] Adds GRPC to Swift (#5758)
2020-02-21 paulovictor.pinheiro [Java][FlexBuffers] Abstract buffer access from ByteBuffer (#5743)
2020-02-21 mustii Adds cocoapods and a readme of how to get the package (#5771)
2020-02-13 om26er [snap] Fix versioning (#5727)
2020-02-12 joseph [Python] Fixed potential allignment issue (#5768)
2020-02-12 afonso.tfaria21 Fix memory leak on cpp object api (#5761)
2020-02-11 joseph [Python] Fixed issue #5499 (#5764)
2020-02-10 dpacbach [C++] Use strong enum type for vectors when scoped-enums is on. (#5750)
2020-02-11 51015092+mugisoba [C#] support Json Serialization (#5752)
2020-02-06 aardappel FlexBuffers: C++: scalar-only typed vectors were not aligned.
2020-01-30 rw Bump Rust port to 0.6.1 (#5747)
2020-01-31 51015092+mugisoba [C#] support Object API (#5710)
2020-01-27 mustii Adds min and max, comments, and all of swift's keywords + fix docs (#5737)
2020-01-27 dnfield Use VS 2017 and 2019 on CI, fix cast issue in dart_idl (#5740)
2020-01-25 mustii Creates a flatbuffers validation function + small fix (#5725)
2020-01-24 anders.sjoblom Added the code to embed the binary schema to the source (--bfbs-gen-embed). (#5701)
2020-01-24 paulovictor.pinheiro [Java][FlexBuffers] Deprecate typed vector strings due to design flaw (#5722)
2020-01-24 mustii [Go] Implements a SharedStrings function (#5733)
2020-01-25 vkill.net [Swift] Fix padding function overflow when bufSize is 0 (#5721)
2020-01-24 20694052+PhoebeHui Add vcpkg installation instructions (#5732)
2020-01-23 dnfield [Dart] Fix deprecated field support, inf/nan (#5724)
2020-01-20 max [typescript] Size-prefixed root accessors not taking into account size prefix (#5717)
2020-01-19 max [rust] Add use declarations to Rust-generated bindings for imported FB definitions (#5645)
2020-01-16 somombo [Go] Replace references to hardcoded ”Monster" etc with idiomatic go wherever possible (#5716)
2020-01-17 31897320+vglavnyy [C++] Fix for printing of enum in case output_enum_identifiers=1. (#5706)
2020-01-17 vkill.net [Swift] Support create long string (#5709)
2020-01-13 mustii Added create function for swift (#5707)
2020-01-09 mustii [Swift] Swift implementation 🎉🎉 (#5603)
2020-01-09 aardappel Changed direct calls to strtod to use StringToNumber
2020-01-09 emkornfield Document JSON compatibility guarantees. (#5704)
2020-01-07 31897320+vglavnyy Add CMake 'generated_code' target to simplify resolution of build dependencies (#5697)
2020-01-06 beardsworth (Optionally) add an additional suffix namespace to generated fbs files. (#5698)
2020-01-07 dreifachstein [Java] Replace Table.UTF8_CHARSET with StandardCharsets.UTF_8 (#5696)
2020-01-02 rw Rust: Temporarily disable 2 endianness unit tests (#5695)
2020-01-02 dpacbach [C++17] Add Traits class for Tables and Factory function within it. (#5678)
2020-01-02 aardappel Removed code_generators.cpp from library targets
2019-12-31 max [rust] Make enum names public (#5690)
2019-12-30 beardsworth Correct inverted logic around include prefixes. (#5689)
2019-12-26 47436172+lu-wang-g Optimize Pack method using numpy (#5662)
2019-12-26 AustinSchuh [C++] Add Builder and Table typedefs (#5685)
2019-12-26 aardappel Minor doc updates: FlexBuffers C#, Discord, CppUsage.
2019-12-26 AustinSchuh Upgrade rules_go (#5684)
2019-12-26 AustinSchuh Fix --incompatible_load_cc_rules_from_bzl (#5683)
2019-12-26 AustinSchuh Add support for absl::string_view when available (#5682)
2019-12-26 AustinSchuh [Bazel] Add support for compatible_with and restricted_to (#5681)
2019-12-24 rw CI: New Docker tests for Python with numpy (#5677)
2019-12-23 aardappel Fixed struct initialization error on older versions of C#
2019-12-23 aardappel Fixed warnings in FlexBuffers.java
2019-12-23 aardappel Fixed out of date licenses on gRPC Python files.
2019-12-23 aardappel Removed test proto output.
2019-12-24 31897320+vglavnyy Add flatc '--cpp_std' switch (#5656)
2019-12-23 aardappel Fix for FlexBuffers FBT_VECTOR_STRING size bit-width.
2019-12-23 32997632+stefan301 Added Check to VerifyAlignment (#5675)
2019-12-23 michael.beardsworth Improve import handling for proto conversion (#5673)
2019-12-19 lxrite [Dart] Fix prepare space for writeListInt64 and writeListUint64 (#5654)
2019-12-17 mbrubeck Make Rust constants public (#5659)
2019-12-17 stein Add namespace qualification to union types (#5666)
2019-12-15 max Bugfix for Rust generation of union fields named with language keywords (#5592)
2019-12-14 i wrap multiple statements in do {} while(!IsConstTrue(true)) (#5655)
2019-12-09 gautham.bangalore [gRPC] Uncomment MessageBuilder (#5658)
2019-12-09 bjornharrtell Supress unsigned-integer-overflow for PaddingBytes (#5647)
2019-12-06 stein Add --force-empty-vectors option (#5653)
2019-12-05 aardappel Fixed enum min/max values not properly escaped.
2019-12-02 bttk Split Bazel targets into multiple packages (#5640)
2019-12-02 security-tps Remove a static_assert (#5643)
2019-12-02 47436172+lu-wang-g Flatbuffers Python Object API (#5616)
2019-12-03 chronoxor [Clang 10]: definition of implicit copy constructor for 'TableKeyComparatoris deprecated #5649 (#5650)
2019-12-02 nilsocket [docs]: add missing semicolon (#5648)
2019-11-26 3629062+tigrato [GO] Fix support for enums with underscores and Unions with imported members (#5600)
2019-11-26 31897320+vglavnyy Fix ambiguity of a type deduction in TEST_EQ macro if arguments have `enum class` type. (#5630)
2019-11-26 31897320+vglavnyy Simplify declarations of x-macro FLATBUFFERS_TD (#5638)
2019-11-26 i read vtable size through ReadScalar() (#5636)

Created with:
  roll-dep src/third_party/flatbuffers/src

Bug: 1141211
Change-Id: Ife27c510b6457dc8b1c95bfc0b56372a4de687c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490851
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820413}

https://quiche.googlesource.com/quiche.git/+log/37c5f8fa5ffc..867ef5f63787

$ git log 37c5f8fa5..867ef5f63 --date=short --no-merges --format='%ad %ae %s'
2020-10-22 renjietang Replace client side TLS 0-RTT flag with protocol flag FLAG_quic_disable_tls_zero_rtt.
2020-10-22 fayang Downgrade QUIC_BUG to DLOG(WARNING) when idle network deadline has passed during liveness testing.
2020-10-22 ianswett Delay the first Initial ACK sent by the server so it can be bundled with the server's first Initial packet.
2020-10-22 nharper Always enable session tickets in IETF QUIC
2020-10-22 fayang Shorten PTO when a HANDSHAKE or 1-RTT packet is received prior to the INITIAL. Client only.
2020-10-22 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I5fcc90640f95e2f59448feddd472fbd80637a266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493252
Commit-Queue: Bence Béky <bnc@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820412}

Fixing by removing the AssistContent dependency from tests. Only TranslateAssistContentTest.java has been modified from the original CL.

AssistContent and onProvideAssistContent are only present in M+ SDKs, which was causing some bots to fail to enumerate tests due to a NoClassDefFoundError.

Rather than calling onProvideAssistContent, call getTranslateDataForTab directly in tests.

This is a reland of commit 243dbcb1, which was reverted by commit fa5127d2. The original CL description:

> Include translate information in onProvideAssistContent.
>
> Assistant will use this information to determine whether or not to show a translate prompt when Assistant is opened over Chrome.
>
> This is controlled by the "TranslateAssistContent" Feature and is off by default.
>
> Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit

Bug: 1110943, 1135658, 1136112
Change-Id: I9a769f6670fc7278bcdc08b995965241610034d9
Tbr: isherman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459106
Commit-Queue: Josh Simmons <jds@google.com>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820411}

Previously these two IPH directly created a FeaturePromoBubbleView.
One of them would potentially display at the same time as other IPH
since it isn't registered with the IPH backend. This specific promo is
important to show to users immediately, hence why it is treated
differently.

To support this use case a notion of a "critical promo" is added to
FeaturePromoControllerViews. These promos will preempt any normal IPH
promo. This is reserved for very important promos that must be shown
immediately.

With this support, both promos are invoked through
FeaturePromoControllerViews.

Bug: 1133016
Change-Id: Ifb3b2273c108bc342698faa61adb4b54d5f7072d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487874
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820410}

This is called when the AC matches change. The result will be used in
the future to check top result, all results gone (i.e., we can cancel
ongoing prefetches).

Bug: 1138631
Change-Id: I7b6bad212888eac36756f41f2f534233df596b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493461
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820409}

Bug: 1141936
Change-Id: I9c1d9c61d55f3c862e791dc071011a215e68c945
Fixed: 1141936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495519Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820408}

Move the internal chromium large blob tests to web platform tests. The
tests are designed to be able to run without testdriver support (i.e
using a real authenticator) if support is not available.

Bug: 1114875
Change-Id: Ie87053bd97b8b25b80f8613c366778ea287b909c
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490278
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#820407}

Bug: 1077217
Change-Id: I57457b30f2f4592c91d92799b7c2be2bc9f11c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490784
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820406}

Removes CalculatePreferredSize() use for a chunk of remaining dialogs
that specify a fixed preferred width.

Bug: 1128500
Change-Id: Ib8c072f758a1ae7e3532c5472181be8229e1f53b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493666
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820405}

This CL creates the auto-nav tool, which navigates between a given
list of URLs a specified number of times. This can be used to automate
local benchmarking for navigations.

The tool expects to be run with `vpython`, and requires both `chrome`
and `chromedriver` to be present in the provided out directory.

Example usage: the following command navigates 5 times through 2 URLs
(10 total navigations):

`vpython tools/auto-nav.py out/Default 5 https://chromium.org https://crbug.com`

Bug: 894253
Change-Id: I4492ef3eb30652a8bc1278ff584b7c2ecbe7f7d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320136Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#820404}

Instead of binding a mojo reply callback into a lambda, we can post
a Closure to RenderViewImpl::Destroy() and chain the mojo reply after
it by using Then().

R=dtapuska@chromium.org

Change-Id: I20189699e9699a56276f1cc1d8b576fa2f7d3341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495269
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820403}

DragDropController::Drop() can be reentrant since exo::DataDevice
creates a nested RunLoop (crbug.com/1141745), and referencing
|drag_data_| after it has been moved causes a crash.

This is fixed by checking |!!drag_data_| in IsDragDropInProgress().

Bug: 1141745
Change-Id: Ide2b376d2b6d8dff3ba820c308e1cc1faffbe7e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494189Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820402}

Using wpt-import in Chromium f6657788.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: I19918b89ed4f89c4a21e7d1799405f53a092b66f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494381Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820401}

BUG=1128033
TEST=test only change
TBR=ryansturm@chromium.org

Change-Id: I271de37305ee5714f2a46e29f71b4ebbd5d9fb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495641
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820400}

The v8 binding target has generated sources like
gen/third_party/blink/renderer/bindings/modules/v8/v8_media_recorder.cc
that then includes third_party/blink/renderer/modules/mediarecorder
headers. These headers use buildflags.h and all buildflags.h files are
generated. Thus for v8_media_recorder.cc to build, it needs to depend
on //third_party/blink/renderer/modules/mediarecorder:buildflags, but
that dependency is missing.

To fix this, add a dependency from
//third_party/blink/renderer/core:prerequisites, which is responsible
for generating all necessary C++ source code to
//third_party/blink/renderer/modules/mediarecorder:buildflags.

Bug: 1139543
Change-Id: If48a33cf4b5deb5bc66a8c21612eff924da774f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482030
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820399}

https://webrtc.googlesource.com/src.git/+log/9d69cbeabf5d..3d2593512740

2020-10-23 mbonadei@webrtc.org Rename RoboCaller to CallbackList.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I16167a90241ce2f76c89f729e91a58915a4a49ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820398}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0ce7bcc8e296..5f4e51f38e3e

2020-10-23 yich@google.com cros_flash: add clear-tpm-owner to flash options
2020-10-23 chrome-bot@chromium.org Update config settings by config-updater.
2020-10-22 ahassani@chromium.org cros_flash: Handle App ID mismatch between device and payload
2020-10-22 bhthompson@google.com Make bvt-installer suite asynchronous on release builders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: Ibeeb390c40e63e2607abb49309f50092522b1d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494981Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820397}

Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 to 88-4280.20-1603104419-benchmark-88.0.4300.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: If8fbdaf9574d237e95cca676dfa7561dbe2df820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820396}

This allows us to link with protobuf protos and not have the component builds fail during tests.

Refactored registry related flags and operations from mdm_utils to reg_utils.
Modified fakes usage for cloud policies since in component builds they need to be installed differently.

Bug: 1134817
Change-Id: Icfa40921d82e64d1a905273693cf569d108ff31b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493725
Commit-Queue: Robin Lewis <wrlewis@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#820395}

Update the title for launcher's window when the launcher changes states.
This will give Chomevox the information needed to read the title of the
window when the user is navigating through the launcher and presses
search + a, w.

For a partially shown launcher (peeking), the title will be "Launcher,
partial view".

For the fullscreen launcher, the title will be "Launcher, all apps".

If the searchbox or the assistant is displaying results, the title will
be "Launcher"

Bug: 1111165
Change-Id: I6715ea095b568f72466182ed20a33b7fffde8538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476618
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820394}

Unfortunately, deferring uninstallation until after the RPC server
starts up means the test must pay the 10s between task handling and
server shutdown (& uninstall).

This CL also adds some basic functionality to print the updater log in
the case of a failed test, and speeds up Windows integration tests by
moving the sleep to only happen for --uninstall launches.

Bug: 1141659
Fixed: 1141659
Change-Id: Iba90261c402966fe1ddb814d01b5521c94da0a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493043
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820393}

CheckedPtr<SomeClass> => SomeClass* implicit cast won't kick in when the
pointer is used as an argument of an implicitly invoked constructor.
After this CL, the rewriter will append |.get()| to make sure that such
code still builds after the rewrite.

This CL should help ensure that the build is successful, once we
stop excluding |const char* fields| from the rewrite.

Bug: 1069567
Change-Id: I85c15639c3d15ccbd834298ee4866ed64a053848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495716Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820392}

* When user clicks dismiss on the real Notification Setup UI in phonehub
  they can now show the UI again by clicking a button.
* When user dismisses the real onboarding UI, they can now show the UI
  again by clicking a button.

Other-
* When user dismisses the fake onboarding UI, it will be reflected to
  the toggle accurately as off.

Screenshots:
https://screenshot.googleplex.com/6eofiCBa3afSUMT
https://screenshot.googleplex.com/3YLYNsHkA6aGVKo

Bug: 1106938
Change-Id: I2fb56e1864905602a9ae769d0d9b007294fa7441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490513Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820391}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/805ba2eff0e1..751a6ed6316a

2020-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: If2976134bc78416dfe4e14d48da6f0330cacc76c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820390}

Tab search WebUI source migration effort. Will be followed by a CL that
removes tab_search references from src-internal/DEPS and another CL to
rename the tab_search_merge references back to tab_search.

Bug: 1134167
Change-Id: I4d44201b651b60c13125ffaffece668ce66df28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492544Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820389}

This is a reland of dca1afe8

This is an interesting failure point due to the difference between
official builds and non official builds. In official builds, the
Sync Consent screen is shown and it will not exit until we interact
with it. The waiters timeout waiting for the Parental Handoff Screen
to be shown.

Original change's description:

> Adds parental handoff login screen in oobe.
>
> The description and mock can be seen in the comments in the bug report.
>
> Bug: 1134567
> Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618
> Commit-Queue: Yilkal Abe <yilkal@chromium.org>
> Reviewed-by: Aga Wronska <agawronska@chromium.org>
> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819158}

Bug: 1134567
Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820388}

Adding a fuchsia deterministic try builder with the intent of using it in Fuchsia SDK rolls.

Bug: 1135171
Change-Id: I353631041e449f28c61368d5afbf6412174f0644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494660
Auto-Submit: Chong Gu <chonggu@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820387}

This should be a no-op to definition as fleet has moved, but
let's us keep things clean.

Bug: 1124829
Change-Id: I9975c20e5e14bbe510f39acebb5d2e7170d629db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493098Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#820386}

Add some polymer bindings to share the discovery page's SendPreview
with the confirmation page. This allows showing the correct filename
on the confirmation page, and also paves the way for using the
appropriate icon depending on the file type.

Bug: 1123942
Change-Id: Iff779c2fa681f85ff3fd7435cce3a38706ff5c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493376
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820385}

Two webgl_conformance_gl_passthrough_tests have begun failing on Linux AMD bots.
With driver related errors. A reboot of the bot did not resolve the issue, and we have no good candidate to revert.

The consistently failing conformance/renderbuffers/renderbuffer-initialization.html will be suppressed. The flaky conformance/context/deleted-object-behavior.html will be retried.

Bug: angleproject/5213
Change-Id: I373979662c70a202d5c3cb65a8f5d9b97bd77774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495420Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820384}

https://chromium.googlesource.com/angle/angle.git/+log/4791cf2cde52..7a0263547cda

2020-10-23 jmadill@chromium.org Link C++ histogram support into angle_perftests.
2020-10-23 courtneygo@google.com Re-enable dEQP-EGL.functional.fence_sync.*
2020-10-23 jmadill@chromium.org Clean up test runner TODOs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jonahr@google.com
Change-Id: I035ca9a75055502321f6384d11f03d961b07e6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495045Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820383}

This adds a paragraph explaining what action we have actually taken
(adding the tests to expectations/adding a baseline file), and what
action the bug recipient should undertake (investigate/triage).

Bug: 1140476#c7
Change-Id: I20d2c1bb50ab6bf46c6430416599e24fee4b8a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495011
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820382}

This adds a section to explain how to out-of-line methods which return
or accept new types. This isn't generally necessary for implementation
code, but this is important for external-facing classes (such as
WebView's glue layer).

Fixed: 1112420
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: Ia5f835663780c50e1d1601e969a5a6d550e9fbf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493430
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820381}

Check the system setting instead of using Chrome's

Bug: 1141646
Change-Id: I43d8bfc8dd3462da21cc040d2c5e4bc3b7469bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492964Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820380}

Forms that do not have a <form> tag are treated by Passwordmanager as
one synthetic form. This might negatively affect websites that allow
navigation via JS scripts, without committing the actual navigation.
Password fields might be added/changed, but the already existing
PasswordFormManager can store outdated server predictions and treat
the form as previously filled.

This CL makes sure that the valid server predictions are used when
the form changes.

Bug: 1140480
Change-Id: I68475dc0c55e8878781351f3f28b3f3f70429271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489990
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820379}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1315d1d2d5a5..1bec20b5b70c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sky@google.com,mohsen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1141127
Tbr: sky@google.com,mohsen@google.com
Change-Id: I889b09de8551b518b95d0512e08987229fa8165e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495046Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820378}

Enables the component updater logic to be moved into a component and
used in iOS.

Bug: 1140271
Change-Id: If3714b26d9a0dc02f540b67f071a3774d49e94ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486700Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820377}

This is a reland of 55f62f27

BUG=1140857,1140980

Original change's description:
> [CrOS PhoneHub] Disable Locate Phone button when Silence Phone is on.
>
> - Add an observer for state change in Silence Phone so that Locate Phone
> can be disable when Silence Phone is on.
> - Refactor InitQuickActionsItems() since Locate Phone and Silence Phone
> is no longer independent.
>
> BUG=1106937,1126208
>
> Change-Id: I6f015e868d6d00df6a40447de62f3efd0b2f2ad0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480662
> Reviewed-by: Tim Song <tengs@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Andre Le <leandre@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819161}

Bug: 1106937
Bug: 1126208
Change-Id: I3bcae322124af80f0947a26c7b0e776757f2ccfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490380
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820376}

The SerialPort close() method internally calls this.readable.cancel()
and this.writable.abort() to close its data streams before closing the
port itself. When either of these streams is already erroring the
Promises returned by these methods can be resolved before the underlying
source or sink has actually finished closing the stream.

This patch adds logic to wait until the streams are actually closed
before continuing the close process.

Bug: 1137563
Change-Id: Ic2c1fd10524292f5b33dfc8279804fe89b00ce7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462711
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820375}

This will still work after git "master" branch is renamed to "main",
and makes inclusive language dashboards easier to interpret right now.

Bug: none
Change-Id: I628be29ce14257b82aa0f88448a9650b56671359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493186Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Zork <zork@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820374}