- 22 Jun, 2018 40 commits
-
-
Dirk Pranke authored
This reverts commit 53235652. Reason for revert: Build is no longer reporting failures correctly. Original change's description: > Update json test results for webkit_layout_tests. > > This brings the test results more into compliance with the > current test result standard in bit.ly/chromium-json-test-results-format. > > Notable changes: > - If a test is run multiple times, we explicitly return every > `actual` result. Previously, if the test produced the same result every > time, we'd only return a single value for `actual` > - If a test is skipped unexpectedly, that will be considered a regression > and an unexpected result. > - The test results will contain `is_unexpected`, `is_flaky`, and > `is_regression` fields for the matching conditions. > > Bug: 837047, 822078 > Change-Id: I4896e61469d3b576ea9e7dbbe16fac709f74b6b9 > Reviewed-on: https://chromium-review.googlesource.com/1103611 > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569466} TBR=qyearsley@chromium.org,dpranke@chromium.org,seanmccullough@chromium.org,robertma@chromium.org Change-Id: Icf1882e8eea328b115a458afa6378b35bb11a638 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837047, 822078 Reviewed-on: https://chromium-review.googlesource.com/1112178Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569703}
-
Michael Spang authored
The OverlayPlane struct uses the ScanoutBuffer class, which was originally a DRM platform implementation detail. This struct was moved into common code with the intent to share it with other linux platforms. However, exposing ScanoutBuffer is probably not what we want to do - it contains several methods that are specific to DRM. Instead, a public ui::OverlayPlane should be using the gfx::NativePixmap interface, which is already public. Move ui::OverlayPlane back into DRM, and rename it to DrmOverlayPlane. A followup CL will add a new version of ui::OverlayPlane that uses gfx::NativePixmap instead. Bug: 851997 Test: compile Change-Id: I1f4dbc11419aaacabb2a63eb692eb6a3892a3be3 Reviewed-on: https://chromium-review.googlesource.com/1097208 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569702}
-
Daniele Castagna authored
For Night Light we tried to always apply the color transform matrix in linear color space when using the display controller for the transformation. On Rockchip we'd get the BT.709 degamma/gamma automatically. On Intel we used the split gamma pipeline and we set degamma/gamma manually. Unfortunately intel split gamma doesn't do interpolation of values and introduced banding. This patch exposes to the browser if a display color correction matrix will be applied in linear color space or in a gamma compressed one. In this way we'll be able to change the night light matrix and avoid setting gamma/degamma on intel. Bug: 851156 Test: display_unittests Change-Id: Ia0d385697747afb42c5dbb1b939be661c4fdd559 Reviewed-on: https://chromium-review.googlesource.com/1108362Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#569701}
-
chrome://discardsFrancois Doray authored
There was an invalid access when the site engagement score of a WebContents that was never navigated was obtained in chrome://discards. With this CL, we return 0 as the engagement score of never-navigated WebContents, instead of doing an invalid access. Creating a new tab or opening a link in a new tab are actions that create a WebContents a briefly keep it in a non-navigated state. Bug: 854497 Change-Id: I204509b7c41445ac4b524f9a652f006189e4fcd9 Reviewed-on: https://chromium-review.googlesource.com/1111908Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569700}
-
Kevin Schoedel authored
This reverts commit 05654b06. Reason for revert: Name error causes conflict. Original change's description: > Add definition of window.speechSynthesis for cast > > This is used by Chromevox. > > Bug: b/110195060 > Test: manual > Change-Id: I9e22aacf0c3335d70eb92ea9b66f6e11a7ef2f7c > Reviewed-on: https://chromium-review.googlesource.com/1105028 > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568493} TBR=alexst@chromium.org,kpschoedel@chromium.org,rmrossi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/110195060 Change-Id: I35230adbfdb5042f622900335c96f62bff17a3c8 Reviewed-on: https://chromium-review.googlesource.com/1112161Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569699}
-
David Grogan authored
wpt.fyi showed Safari passing these recently-added tests because the scrollbars don't show in either the tests or their refs. https://wpt.fyi/css/css-tables/height-distribution/percentage-sizing-of-table-cell-replaced-children-001.html Aside: Edge matches Safari's current and Chrome's previous behavior. But they've confirmed it's a bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17505131/ Firefox has a mostly-unrelated incompatibility that doesn't allow us to check it. Bug: 837408,838144 Change-Id: I82058d3c22d7668711e9a9a1c977047033d64b46 Reviewed-on: https://chromium-review.googlesource.com/1054770 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569698}
-
rajendrant authored
Bug: 782233 Change-Id: I4e0e8d06dd8d2be5613fd221a541fec67a9857c2 Reviewed-on: https://chromium-review.googlesource.com/1111471Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#569697}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/20eea3c..a9969b2 BUG=chromium:854817 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I13d0fab6a29ba96f13f0e74c07b011db36abbeed Reviewed-on: https://chromium-review.googlesource.com/1112047Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#569696}
-
Jacob Dufault authored
Bug: 855650 Change-Id: Ib9abc4447eb81365439611953e641d30f97cc58d Reviewed-on: https://chromium-review.googlesource.com/1112344Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#569695}
-
Xi Han authored
In this CL, we refactor the ServiceManagerContext to make sure all of the services can be registered without any dependency of BrowserMainLoop. It includes the following changes: 1) Add API StartBrowserConnection() in ServiceManagerContext to start the browser connection to the ServiceManager. This API must be called after the BrowserMainLoop starts. 2) Make OutOfProcessServiceInfo takes a RepeatingCallbacks to get the process name. 3) ServiceMangerContext owns the DeferredSequencedTaskRunner for audio service. It was owned by BrowserMainloop before this CL. BUG=846846,729596 Change-Id: I29725a383e2662fccd8a2fba5fedddc52a8c565c Reviewed-on: https://chromium-review.googlesource.com/1093021 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569694}
-
Max Moroz authored
When ICF (Identical Code Folding) is enabled, the linker has hard time figuring out all identical code patterns inserted by compiler's instrumentation. That is why this option is disabled when we use sanitizers. It also should be disabled for code coverage instrumented build, as it has even more instrumentation code. This change allows code coverage bots to use use_sanitizer_coverage=false which would result in much faster and much smaller builds. Performance improvements: - builds 2x faster - binaries 2x smaller - run time 2x smaller (or even more on some targets, up to 6x) Bug: 851337 Change-Id: I20d4ad1e55730daf813e0f26060dd5830351dbcf Reviewed-on: https://chromium-review.googlesource.com/1112199 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569693}
-
edchin authored
The completion handler was not properly being run in history coordinator when the coordinator was previously stopped. Bug: 854597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3a317f8776ea10452889c39a69cb257d4a8e7073 Reviewed-on: https://chromium-review.googlesource.com/1111619Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569692}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5741a5ba7f36..5e0909776e81 git log 5741a5ba7f36..5e0909776e81 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 borenet@google.com Fix pylint check in presubmit Created with: gclient setdep -r src/third_party/skia@5e0909776e81 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I026786bf5f90ef67061ae997e377ab8954415bfb Reviewed-on: https://chromium-review.googlesource.com/1111922Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569691}
-
Esmael El-Moslimany authored
Bug: 850239 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ica4416b091ca406cd99de47ce331ed6f45b492b1 Reviewed-on: https://chromium-review.googlesource.com/1108500Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#569690}
-
Scott Chen authored
Bug: 854936 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id5e2f544cf2425e641c68d042b88b40230ba471c Reviewed-on: https://chromium-review.googlesource.com/1110856Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569689}
-
Marc-Antoine Ruel authored
Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes need to be updated. Change analyze to not ignore changes to isolate. R=tandrii@chromium.org Bug: 851596 Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 Reviewed-on: https://chromium-review.googlesource.com/1097623 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569688}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a327030ca50b..0a49103801e3 git log a327030ca50b..0a49103801e3 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 hnakashima@chromium.org CPDF_PageObjectHolder::GetDirtyStreams() returns const ref. Created with: gclient setdep -r src/third_party/pdfium@0a49103801e3 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6e4c739291fd48bf9d1d6cbb105ac1e00fed6c52 Reviewed-on: https://chromium-review.googlesource.com/1112137Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569687}
-
Ken Rockot authored
Moves some POSIX socket utilities into mojo/public/cpp/platform, moves ConnectionParams into mojo/edk/system, deletes TransportProtocol. Bug: 753541 Change-Id: I1575af268e89c0424e618f2a0974693f610f5969 Reviewed-on: https://chromium-review.googlesource.com/1109199 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569686}
-
George Burgess IV authored
This test caused blink to recurse to stacks > 4,000 frames deep. This is caused crashes for Android on ARM64, which has a standard stack limit of 1MB. Since it appears that this benchmark's depth is somewhat arbitrary (e.g. the crashes we're seeing when running the benchmarks aren't indicative of a problem in the real world), turning down the recursion seems reasonable here. Bug: 851539 Test: Ran blink_perf.events on ARM64 Android; no crashes observed. Change-Id: I71290e7d2ddc4786aa1ba09c5030375d2027b39e Reviewed-on: https://chromium-review.googlesource.com/1111565Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#569685}
-
Michael Spang authored
The OverlayPlane struct uses the ScanoutBuffer class, which was originally a DRM platform implementation detail. This struct was moved into common code with the intent to share it with other linux platforms. However, exposing ScanoutBuffer is probably not what we want to do - it contains several methods that are specific to DRM. Instead, a public ui::OverlayPlane should be using the gfx::NativePixmap interface, which is already public. Move ui::OverlayPlane back into DRM, and rename it to DrmOverlayPlane. A followup CL will add a new version of ui::OverlayPlane that uses gfx::NativePixmap instead. Bug: 851997 Test: compile Change-Id: I7d4c0c7633f06356be24642a9a26339a9fec284a Reviewed-on: https://chromium-review.googlesource.com/1104857Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0d4ee0a96946..87e447992446 git log 0d4ee0a96946..87e447992446 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 buildbot@webrtc.org Roll chromium_revision 72ef4e47..ecf8a613 (569500:569618) Created with: gclient setdep -r src/third_party/webrtc@87e447992446 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c56fed52c2022cbb6b2e116dddcd87ba6aaf031 Reviewed-on: https://chromium-review.googlesource.com/1112118Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569683}
-
Carlos IL authored
As part of committed interstitials, the MergeSessionLoadPage interstitial was removed, the wait for MergeSession now happens directly in the MergeSessionNavigationThrottle. Bug: 854628 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib5c73824d08de8733b9b47e113587a552aa9a828 Reviewed-on: https://chromium-review.googlesource.com/1108186Reviewed-by:
-
David Roger authored
The Gaia server needs to be able to distinguish between Dice and Mirror calls. This CL sets a new different source for Dice calls. Bug: 854743 Change-Id: Id697d5aad326283b0002c6ce76dde4e619b9885e Reviewed-on: https://chromium-review.googlesource.com/1109898Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569681}
-
Orin Jaworski authored
New tab button ink drop effect is made less opaque for touch and more opaque for non-touch interfaces. Bug: 851041 Change-Id: I2243a44f3d98899eace803a0681e1b060014e08e Reviewed-on: https://chromium-review.googlesource.com/1109459 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#569680}
-
Alexis Hetu authored
On ChromeOS, for both gbm and wayland platforms, SwiftShader had been added to the list of allowed GL implementations without being added to their corresponding GetGLOzone functions. This adds the missing entries. Also, on gbm, the GetGLOzone function had a thread checker, which no other platform has. Since it was making the SwiftShader implementation fail, I removed it. It may have been a mistake in the conversion process and had been added here: https://codereview.chromium.org/2327813002/diff/20001/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc Bug: chromium:848035 Change-Id: I8c88dcd84974668b935c96e669a4b2c642a3ba21 Reviewed-on: https://chromium-review.googlesource.com/1111332Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8a4c49fb794e..fec92a6f89f1 git log 8a4c49fb794e..fec92a6f89f1 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 geofflang@chromium.org Temporarily skip MakeCurrentMultiContext test on Windows AMD OpenGL. 2018-06-22 jmadill@chromium.org Vulkan: Add RenderTargetVk::getImageForRead. 2018-06-22 jie.a.chen@intel.com ParallelCompile: Update gl.xml 2018-06-22 jmadill@chromium.org Vulkan: Fix mixed descriptor pool updates. 2018-06-22 jmadill@chromium.org Vulkan: Fix releasing Programs that are in use. Created with: gclient setdep -r src/third_party/angle@fec92a6f89f1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849576 TBR=cwallez@chromium.org Change-Id: I6da5c85a59eec62213a0c8be714f27daf855666d Reviewed-on: https://chromium-review.googlesource.com/1112217Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569678}
-
wutao authored
This patch add the AddObserver method to voice interaction controller mojom. Bug: b/110094434, b/80431063 Test: manual. Change-Id: I15853b1cea5cc11c3228f59f80df2bd634616c60 Reviewed-on: https://chromium-review.googlesource.com/1111645Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569677}
-
inglorion authored
Ran `tools/clang/scripts/upload_revision.py 335091`. Change-Id: If33c2ba0fdfe2df9d0fee042a2aec2460a7c9e8e Reviewed-on: https://chromium-review.googlesource.com/1109394Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bob Haarman <inglorion@chromium.org> Cr-Commit-Position: refs/heads/master@{#569676}
-
Carlos IL authored
This enables reporting for subframe navigations that involve a redirect and are upgraded due to CSP policy. Bug: 615885 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibcd0160ba0825d5d5d2f2f2a58ecfe9fb51c4688 Reviewed-on: https://chromium-review.googlesource.com/1096360Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#569675}
-
Allen Bauer authored
Bug: 853240 Change-Id: I8112807df34779c78e2d96ce15e391eb1863d8d1 Reviewed-on: https://chromium-review.googlesource.com/1112198Reviewed-by:
-
chrome://safe-browsingDaniel Rubery authored
All events in the sync Event Log are now displayed in the chrome://safe-browsing PhishGuard event log. Render: https://screenshot.googleplex.com/N6UOBVpmx95 Bug: 849351 Change-Id: I49509231f6dcab76122eb6218b26d8bb6630a22b Reviewed-on: https://chromium-review.googlesource.com/1106966Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#569673}
-
Ioana Pandele authored
Automatic password generation is offered for password fields that Chrome perceives as being eligible for generation. When such a field is focused, a button to trigger generation is presented in the keyboard accessory.Tapping on this button brings up a modal dialog that displays a generated password with confirm and cancel buttons. Once the user taps the "Use password" button in the dialog, the generated password is filled in the field and can be edited in place. Bug: 835234 Change-Id: I2f0e5dc3a0f9153109207a4fd8624cd4eb6e03c3 Reviewed-on: https://chromium-review.googlesource.com/1097478Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#569672}
-
Stefan Zager authored
This reduces the number of .cc files that include the PLSA header from 196 to 107. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I846a7b5e3120e5cf60ba59002ba53c82d8099d88 Reviewed-on: https://chromium-review.googlesource.com/1111011Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#569671}
-
Kevin Bailey authored
We were measuring the tab switch button size before setting all the relevant aspects. When we requested a size, it was therefore too big. This corrects that and, since the size is more appropriate, we don't need the left justification, which was broken when there wasn't any text anyways. Bug: 780835 Change-Id: I72bd6aedc84837864dc6fe764e4ce865f9170cb4 Reviewed-on: https://chromium-review.googlesource.com/1108452Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569670}
-
dpapad authored
- Use enable_extensions flag for extensions tests. - Merge multiple is_chromeos conditionals to one. - Eliminate logic to first add a dependency, then remove it on certain platforms. Bug: None Change-Id: Ic0dd490f4672dbb23317e9743c25d9fd1d081ead Reviewed-on: https://chromium-review.googlesource.com/1085901Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569669}
-
David Tseng authored
This fixes custom text fields of type="tel" that insert whitespace as padding. Change-Id: I054a1713f5a3bfba8f412e18fc93ecea7155afde Reviewed-on: https://chromium-review.googlesource.com/1111112 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
We need to be able to change this later without a merge. Bug: 848420 Change-Id: Ie4f50f6a919e5e4e761c364776c702d40513637d Reviewed-on: https://chromium-review.googlesource.com/1111209Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569667}
-
Christian Fremerey authored
The video capture service shuts down when not in use. The current logic triggers a 5 second timer when the last client disconnects. When the timer expires, it either stays alive if there now is a client connect or it shuts down if there still is no client connected. This logic is not very suitable for usage patterns where clients may connect frequently but only for very brief periods of time. If that happens, the service may end up shutting down and starting back up again frequently. This CL changes the logic such that when a new client connects, any previous timers are cancelled. Also part of this CL: * Move tests that are concerned with verifying when the service does or does not quit closer to the implementation. This allows eliminating the need for dynamically configuring a timeout for testing, and instead looking for ref counts. Bug: 829581 Test: services_unittests --gtest_filter=DeviceFactoryProviderConnectorTest.* Change-Id: I788775aaf6e77159a9142994d4772200ab42a14d Reviewed-on: https://chromium-review.googlesource.com/1089921Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7a97eefa81c7279d12e2827fedb6765fc866d65 Reviewed-on: https://chromium-review.googlesource.com/1112205 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Sandra Sun authored
Intent-to-ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/K4m85YRD1II/discussion Bug: 497851 Change-Id: Iae62b81fda3b6dab683833d61937b8a4b134fb4a Reviewed-on: https://chromium-review.googlesource.com/1110852Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#569664}
-
