- 20 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e75ecf38f24b..7acbae90a490 2021-01-20 tsepez@chromium.org Only instantiate XFA when installing FormFillEnv. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Idde10cefa91870e1b58f0da267211f94758ac783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845012}
-
Edward Lesmes authored
Bug: 1167342 Change-Id: I28b78f16f53c8b997c1d30c53ff9049135be5d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634012Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#845011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6bed55becc6..06576b56764f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yhirano@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128105,chromium:1150968 Tbr: yhirano@google.com,dbertoni@google.com Change-Id: I8a1fca691c1139e85a555b0c2dbeb62bc1162f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845010}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611078768-7ecf7fe9cdf533d2ba0fd4fcea641cfa29b8dba9.profdata to chrome-win64-master-1611089910-e382f188ebed1bc5635a69a9ec6a180850db4c4f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic4087f2c5fe23ffd8cbedae8c3394716a8ca068d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845009}
-
Michael Thiessen authored
Implements LaunchCauseMetrics for the Search and Bookmarks widgets. Bug: 1163961 Change-Id: I87427a11be245fbb990377cf02da00b408c8fe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635447Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845008}
-
Sorin Jianu authored
Change-Id: I7a62bd6ff4a0758f6d0553463021280313499385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588288 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#845007}
-
Jing Wang authored
1. Uprev mojo api of grammar check from chromeos. The mojom interface is generated with the script "chromeos/services/machine_learning/public/mojom/roll_mojoms.sh" from https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2611147 this change need to be submitted after it. 2. The new api will return correction fragments, so update the service client accordingly, now the grammar correct results are parsed from fragments. 3. Don't show grammar error when the proposal is to delete the whole sentence, i.e. when result->candidates.at(0)->text.empty() is true. 4. Update unit tests, in ServiceConnectionTest, move LoadGrammarModel test before soda test so that it won't crash. Bug: 1132699 Test: Passed unit tests, also manually tested on nocturne. Change-Id: I85529f3a26f134e5eea7785bae5ac9c7f9e776f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612788 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Honglin Yu <honglinyu@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#845006}
-
Caitlin Fischer authored
The server-side config shows that this study has ended. Bug: 1126640 Change-Id: I49732d19f6bd15e020cda40c6745094a6ac25478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632205Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845005}
-
Fabrice de Gans-Riberi authored
In https://crrev.com/c/2613649, a call to google_apis::SetAPIKey() was added in the main() function. However, there is no AtExitManager registered by that point, resulting in a crash in builds with dchecks enabled. This moves the call to google_apis::SetAPIKey() to be done in WebEngineMainDelegate::BasicStartupComplete() instead. Bug: 1168325 Change-Id: Iee034fb20c7d4d8563cbd9973943d87339619b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638634 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845004}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6181c222..69c461e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2c946eb187217d7150ecefe9c0fec90262a020f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845003}
-
Andrey Kosyakov authored
... for a user-agent override to be applied. BUG=1070568 Change-Id: Ifba5b72b15d9edd2f14e9a0c7f9860e15fa6f3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628313 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#845002}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611078768-a6f5b9bbbe47c14760aa754313a33dbc3d6dd128.profdata to chrome-win32-master-1611089910-6a1c1563417281aed9ef8f312b971a0aa6f126b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d23f2eed17a8d05e7de6f6d0fe1b573dcf555fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845001}
-
rajendrant authored
Fixed: 1165194, 1165048 Change-Id: I59df4e483b19762baad1c005adf8a5e31de93c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634862 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845000}
-
Zhenyao Mo authored
This reverts commit c2dd88a3. Reason for revert: broke Meet on Mac Canary, crbug.com/1168301 Original change's description: > Remove the enabling of RTP data channels. > > This is the minimum change to prevent the use of RTP datachannels in Chrome, > designed to be easily rolled back if needed. > > Feature link in Chrome dashboard: > https://chromestatus.com/feature/6485681910054912 > > Bug: webrtc:6625 > Change-Id: I19c78f703c8e322d8fa21c120c255942cd2bbd3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632953 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844489} TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:6625 Change-Id: I3cea1636b68ee206c5107a1a8d2c55404236028e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638598Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844999}
-
Luciano Pacheco authored
This is a preparation to run the foreground page as JS modules. Bug: 1133186 Change-Id: Iad424b0d91985015bc1cf746866c996c3334fe88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637167 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844998}
-
Hiroki Nakagawa authored
This CL... - adds "Trigger" in the terminology section in README.md. - adds how to watch relevant code changes in README.md. - removes the no_state_prefetch directories from the WATCHLISTS entry for prerendering. The new prerendering implementation deviates from the NoStatePrefetch implementation. Probably watchers are no longer interested in changes for them. Bug: 1126305 Change-Id: Ia07a60f1ae0c6f26de54c4cfa75dadf64386b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636979 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#844997}
-
Victor Costan authored
The method currently follows an unfortunate maybe-async pattern established in //net whereby operations may either report an outcome synchronously by returning a net::Error other than net::ERR_IO_PENDING, or report the outcome asynchronously by invoking a callback. This CL changes the method to unconditionally run the callback with the operation outcome. This is intended to simplify the mental model and control flow around the method. Change-Id: I4337cb5e93820596510b02c0b6bde75a6f3111f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632853Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844996}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/tether. Bug: 1148570 Change-Id: Ic3b780c5714af71aae25691f77aad3fb69f5986d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638571 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#844995}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I1023b188d5cd372654f9f843e23f8000792885b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639394Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844994}
-
Sam Goto authored
The idp_endpoint property today of the .well-known/webid response is now taken as an absolute URL, which makes it inconvenient for deployment. In this CL we resolve the idp_endpoint URL as a relative URL to the file that it is contained in, allowing both absolute URLs and relative URLs to co-exist. Bug: 1141125 Change-Id: I224274634e5eaf7f7d66d044931fe5823f346829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631295 Auto-Submit: Sam Goto <goto@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844993}
-
Jan Krcal authored
This CL fixes a regression that (for both the old and the new design), light mode illustrations are used when in dark mode. This happened by moving the dark mode css into one selector in the beginning. This CL moves that till the end of the css to get precedence over the light mode css specified before. Bug: 1167092 Change-Id: I04783bb5aa34794c107cc846017accb140dea692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632680 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#844992}
-
Dale Curtis authored
A review of similar Blink classes shows we should be returning nullptr during the ::Create() method if there are exceptions. I've updated the fuzzers to handle a null return value here now. Fixed: 1167511, 1167532, 1167534 Change-Id: Idbbfaeac2e93eb1f4b8f02ad880724ac5454eac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638397 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#844991}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/13d0f7c03fe3..5dbc16c0c6bd 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idcd06707f3234b07843d7fcec30591c0cb6b4733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844990}
-
Zequan Wu authored
To disable merging multiple ~CheckError() destructor for accurate crash logs. Bug: 1153188 Change-Id: If6d153661667a63f13b645f6d284eb3d5ea3a300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611331 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844989}
-
Canon Mukai authored
Get() does the same thing as View() and it is recommended to use Get() instead of View(). So replaced View() with Get() and deleted View(). Change-Id: I4f9b407b6ea6b27f79c4d52049a647db4e9a874a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636097Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#844988}
-
Takuto Ikuta authored
This reverts commit 3fd9ba25. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071 Original change's description: > trigger_scripts: support go client in chromeos_device_trigger > > This scripts needs json conversion similar to > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 > when using go client. > > This is fix for breakage like > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Bug: 1127205 > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844979} TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844987}
-
Yutaka Hirano authored
This reverts commit 6ea5c38d. Reason for revert: build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/30058/overview Original change's description: > Reland "Force Python 3 to be used in build." > > This reverts commit b6172196. > > Reason for revert: We rolled GN to a new version with a fix for > the win dev issues, so hopefully is good to go now. > > Original change's description: > > Revert "Force Python 3 to be used in build." > > > > This reverts commit bb97ab9b. > > > > Reason for revert: Various breakages. > > > > Original change's description: > > > Force Python 3 to be used in build. > > > > > > This CL makes Python 3 be the default script executable used by Ninja > > > to run action() and action_foreach()'s during the build. > > > > > > This does *not* mean that everything works with Python3; many targets > > > may still use Python 2 via the python2_action() and > > > python2_action_foreach() targets or via custom logic. > > > > > > However, it does mean that it should prevent regressions from > > > creeping in. > > > > > > This CL should not be taken to imply that we can start to write > > > Python3-specific code that can run during the build; we should > > > still be trying to ensure that everything is compatible with Python2. > > > > > > Also, this CL does not enable the use of vpython in actions; we should > > > still avoid that because vpython is slower than direct Python > > > invocations. > > > > > > Bug: 1112471 > > > Change-Id: I472b032b500715156d955b0758640a7ed0384305 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 > > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > Cr-Commit-Position: refs/heads/master@{#836234} > > > > TBR=dpranke@google.com,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > Change-Id: I72039140f401f1fefc1b515dcfe34f1984b0d914 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1112471 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587576 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#836284} > > TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1112471 > Change-Id: I55ee8ccb381b5aeeac58a85a6168765ed40457ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630725 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844885} TBR=dpranke@google.com,brucedawson@chromium.org,tikuta@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I01ac20d80f5fe38a1f8113010f803509df0d7861 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637169Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#844986}
-
Michael Thiessen authored
Change-Id: I5451d561fb455956bb876683e5784a296419c199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637085 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#844985}
-
Meilin Wang authored
This CL is the part 1 of moving |SendVoicelessInteraction| calls to Libassistant Mojom service. It defines and implements four more APIs (listed below) under |ConversationController| Mojom service, and hooks them up in the browser process by replacing |SendVoicelessInteraction| calls in |AssistantManagerServiceImpl| with the corresponding Mojom method. * StartEditReminderInteraction * RetrieveNotification * DismissNotification * SendAssistantFeedback Note that in the CL, |ConversationControllerProxy| will forward all calls through Mojom to the service implementation, where the actual proto message gets encoded. In this way, we can remove Libassistant dependencies from the Assistant service side (classes under /chromeos/services/assistant). Bug: b/171748795 Change-Id: I350cf49b898fffa798b73bb7720ae1583ce84ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625327Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#844984}
-
Xing Liu authored
When the more icon in BookmarkRow is disabled in selection mode, let talkback ignores this view. Bug: 1166730 Change-Id: I657892b0c7c297b5bf5254440ab41ff0d20453a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637082Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844983}
-
Olivier Robin authored
When using loadData, the html has access to the cookies of the URL. It is necessary to pass the URL of the distilled page to avoid cross domain leak. This CL breaks the workflow of user following a new redirection on reloading the page. Bug: 1167901 Change-Id: I6cb01a6580ed511de19f55b35acf91f7f3c7493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637584 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844982}
-
Sorin Jianu authored
This is a reland of e1f49aca Original change's description: > Move installer.cc file to updater/win directory. > > The installer API code is Windows-specific and it would be desirable > to isolate //chrome/updater from its implementation details. > > This change uses public_deps and visibility to make > updater:lib and updater/win:lib act as a unit, to resolve the issue > of the circular includes as suggested by the GN documentation. > > Bug: 1014630 > > Change-Id: Ib47dc9041af08651549d0feaf35790f336dfe193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588508 > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842765} Bug: 1014630 Change-Id: I84d717aad974254f5daf24547888c8bf880cf9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635202Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844981}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611068186-6acea0a5e8e4dcb5129946657add72ff4aa0a2a2.profdata to chrome-win32-master-1611078768-a6f5b9bbbe47c14760aa754313a33dbc3d6dd128.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6da16ae022c812e736c4f9039c67f38ea8c094ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844980}
-
Takuto Ikuta authored
This scripts needs json conversion similar to https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 when using go client. This is fix for breakage like https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Bug: 1127205 Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844979}
-
Caitlin Fischer authored
The server-side config shows that this study ended. Bug: 1126640 Change-Id: Ib731ca75db831a4a54b9ba3bcd7b63391723f056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631934Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844978}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3087d8297fe..b7e836cee99b 2021-01-19 mtklein@google.com Revert "Support indexing by loop variables in SkVMGenerator" 2021-01-19 bsalomon@google.com Reland "Test all YUVA image factories with different encoded origins." 2021-01-19 brianosman@google.com Support indexing by loop variables in SkVMGenerator 2021-01-19 csmartdalton@google.com Extract some GrPathTessellatoOp logic into virtual helper classes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I9d52bbdffdc4c0547f4d4c8fc6163b8e2d1fdc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844977}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bcb61f96b8c..b6bed55becc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: dbertoni@google.com Change-Id: Ia95cf7379a7c7217e8a0ef114d5f03a56696bd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844976}
-
Rune Lillesveen authored
The current rules for media controls should only apply to elements in the UA shadow dom for media elements, but were added to the ruleset for all html UA style. Since the media controls styling adds a bunch of rules in the universal tag bucket, once we add a media element to our renderer, we were stuck with having to reject a bunch of these rules for every html element. Instead, create a different set of styles for media controls and only try applying rules from that set for elements inside the UA shadow tree for media elements. Bug: 1166198, 1032957 Change-Id: I5b2fa635558a28a29bf69538f94763d158c7d2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631490 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#844975}
-
David Black authored
Previously relied on intrinsic icon size which was sometimes correct, sometimes wrong. Bug: 1167365 Change-Id: Iaf2b3454bde9eb340913fc552f936d59d204f0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638519Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#844974}
-
Xing Liu authored
BookmarkBridge.addToReadingList is not covered. This is also part of a reland for: https://chromium-review.googlesource.com/c/chromium/src/+/2625276 Bug: 1166251 Change-Id: Ib6ad34b4daa935151c4895d43fc0eee292727787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627771 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#844973}
-