- 09 Oct, 2020 40 commits
-
-
Steven Bennetts authored
Some removal of DictionaryValue and unique_ptr<Value> usage in onc::ReadDictionaryFromJson and related ONC code. Bug: None Change-Id: I92446aca5bc3e1922a5a6bdfb0776e5cd18a242c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453798 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815550}
-
Omar Morsi authored
Before this CL, PlatformKeysService::GetAllKeys might return keys that belong to the arc-oemcrypto daemon. These are now being explicitly left out. Bug: 1135081 Change-Id: Ie3f321ee789e0dc4d18476d2316897cb4a6514bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448494 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815549}
-
Zhaoliang Ma authored
This CL replaces memcpy with libyuv::CopyPlane since the copy processing is the same as libyuv::CopyPlane. Bug: None Change-Id: Ib9f4e476ea2e18de5cf99c8c97e665f7ed3d1996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439679Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#815548}
-
rbpotter authored
This overrides the file path for the resource (i.e. the |name| property in the GritResourceMap struct) when constructing the resource map, if it is provided. Bug: 1132403 Change-Id: I7ef57c6b037fe6b5c4019da8bc0927e4fac9645b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454631 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#815547}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/952149303d06..51b03d58fb17 2020-10-09 bclayton@google.com SpirvShaderDebugger: Fix store() of arrays 2020-10-09 bclayton@google.com SpirvShaderDebugger: Improve ASSERT() messages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8239f8698386ccf8183d55249328c1b9b6e7c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815546}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/898333a6b68f..fd9afd0a756b 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-09 szuend@chromium.org [ts] Type-check network/EventSourceMessagesView.js with TypeScript 2020-10-09 szuend@chromium.org [ts] Type-check network/ResourceWebSocketFrameView.js with TypeScript 2020-10-09 szuend@chromium.org [ts] Type-check network/NetworkSearchScope.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I270744b07986bc5eb36b4a4294566a442a608886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815545}
-
Tomasz Tylenda authored
TESTED=build Bug: 730593 Change-Id: Icecb1ce729c82ec02538ed04d642841be12d0799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463025Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#815544}
-
sandromaggi authored
The namespace was in CamelCase by accident. Bug: b/168107066 Change-Id: Id434bc76aebe2d6c548b61a218e01bbd1772e34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461120Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#815543}
-
Jazz Xu authored
This CL fix the issue where volume slider is hidden in CrOS file manager quick view. This CL also removes pointer CSS as it was implemented in native controls. Bug: 945799 Change-Id: I944b6fc921e55d82c9b016a9338420b7f9a17fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462050 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815542}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602201537-8720b3c79a1854f8e56100a84c355502c0dbbf4a.profdata to chrome-linux-master-1602223197-364fdfa1722fdc996604dcc9a9de521cd4c0c0ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6b61ba970637d18e90549c254c53266d089a7d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815541}
-
Victor Costan authored
Chrome used the default SQLite configuration where databases were first opened in the NORMAL (not exclusive) locking mode, and then databases that opt in were switched to the EXCLUSIVE locking mode via a "PRAGMA locking_mode" statement. This CL switches the default. Databases are first opened in EXCLUSIVE mode by changing the SQLITE_DEFAULT_LOCKING_MODE build configuration macro. Databases that don't opt into exclusive mode are switched to the NORMAL locking mode via a "PRAGMA locking_mode" statement. This CL should not introduce any behavior changes in most cases. The result of the "PRAGMA locking_mode" statement was previously ignored, and is now checked. So, if the desired locking mode cannot be set, sql::Database::Open() will now fail. In the long run, Chrome's SQLite usage should be migrated to use the exclusive locking mode, for the benefits outlined in https://crbug.com/1120969. When that happens, the "PRAGMA locking_mode" can go away. Bug: 56559, 1120969 Change-Id: Ia9ac996fae45890bb5ca11168422e15e594087ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460982 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815540}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ib93e421e0b119ca2acb4541d926d73d6bc352996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458910 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#815539}
-
Peter Kasting authored
Bug: 772945 Change-Id: I81d45dbfefbf4b4f0e66ece5a815c729cba01c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461208 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#815538}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602201537-11aed398f2fb6b4c095a189eb8886f38c679c48f.profdata to chrome-mac-master-1602223197-d9c33dbbd5ccae4e4a4bd70010f4c3ef94132fb3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iec61f1b791181451f11445715c1049291849ca21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815537}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5cbb8488..4fe27472 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I92a0a9c32f9e1da7566f17f03343f77c81e8867e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815536}
-
Aga Wronska authored
This policy allows adding Family Link accounts additionally to accounts listed in DeviceUserAllowlist policy and is dedicated for school use. Bug: 1126155 Change-Id: Ia0f34b97b31dd143db3a0c2d839e2b4a314ac086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448671Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#815535}
-
Anton Bikineev authored
This implements probabilistic conservative heap scanning for normal bucket pool. The CL doesn't include the followings things (they'll be addressed in followup CLs): - scanning and quarantining directly mapped pages; - increasing size of empty page pool for scannable partitions; - zapping. Design doc: https://bit.ly/2RC8f6z Bug: 11297512 Change-Id: I019aa39ee3de73347ff50ee975548ba5a534cae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424285 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815534}
-
Maggie Chen authored
Bug: 1088820 Change-Id: Ibc8fca88c90bff4699ccaf95296d261d73683a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462724 Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815533}
-
Colin Blundell authored
We are targeting the ads blocked infobar for componentization and reuse by WebLayer. To facilitate that componentization this CL eliminates the infobar's dependence on ChromeSubresourceFilterClient. To do so, we make ChromeSubresourceFilterClient::OnReloadRequested() an API on the SubresourceFilterClient interface. There is no behavioral change. In the future we plan to move the *implementation* of ChromeSubresourceFilterClient::OnReloadRequested() into the throttle manager for sharing with //weblayer. However, that is for a later stage, as it is dependent on first bringing awareness of content settings into the component. We have put a TODO in the code to this effect. Bug: 1116095 Change-Id: Iff57d3a3fe382d0371fc983084e75d3eb8fb7909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461006 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#815532}
-
Yuki Yamada authored
Add LayoutObject::is_destroyed which will be used in NOT_DESTROYED() to find Use-after-Free bugs. Bug: 1030176 Change-Id: Id793366fa732e57b179f637abb46e884c5913e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444672 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815531}
-
Bruce Dawson authored
Chrome's handling of latency sensitive tasks such as video playback can easily be affected by the frequency of the Windows timer interrupt. This timer interrupt is a global resource and any process can raise its frequency. Previously this would affect thread scheduling for all processes but with Windows 10 2004 Microsoft appears to try to simulate "normal" thread scheduling in processes that did not themselves alter the timer interrupt frequency. This is suspected of causing frame drops during video playback. The easiest way to rule out this as the cause is to get all Chrome processes to raise the timer interrupt frequency to the maximum level so that they will all get scheduled according to that raised frequency. This flag should not be generally used and may be removed in the future. Bug: 1128917 Change-Id: I97fddebab251240fdb6181d6960b0dea86b9f0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458854 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815530}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c09fd66372e1ad8456b1c9ebd832cfee5bff92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815529}
-
Sigurd Schneider authored
Bug: chromium:1135143 Change-Id: I1646dd57e0a6255d6437a58645737f2a17c9e64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461014 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815528}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.13-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I58c572e932f4affaf1a6de8017505450534c1456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815527}
-
Glen Robertson authored
No functional changes. Change-Id: I0868bbd38bac1e1fd1fe366a844ae01390af40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454553 Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#815526}
-
Jan Krcal authored
This CL adds another information to the Profile.Status.* collection of histograms, namely the is-sync-enabled boolean. Bug: 1136483 Change-Id: Ibd589d9f6fb75b3732abcf83279f6f2345f39969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461274 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#815525}
-
Koji Ishii authored
When |NGBoxFragmentPainter::HitTestLineBoxFragment| ported the logic from |InlineFlowBox::NodeAtPoint()|, it missed the early return by using |InkOverflow()|. This patch adds this. Test case: blink_perf/layout/culled-inline-hittest Before r793989: 420ms Before r807114: 9,064ms ToT: 374ms ToT (PaintFragment): 421ms ToT (legacy): 4.5ms This patch: 2.9ms crbug.com/1127976 added a heuristic switch, which is effective when there are many lines (and therefore |IsDescendantsCursor| is very small subset), but it may have negative effects in other cases. The root problem is NG calls it too much because of the lack of this early return. I'll remove the heuristic switch in a separate patch because it is probably no longer necessary with this numbers. Bug: 1128937, 1127976 Change-Id: Icb26007d90461c0e763d5af424704e56489e626f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463086 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815524}
-
Paula Vidas authored
This CL adds tests that check if interested data types and FCM token are included in device info when relevant feature flags are enabled. For now, FakeInstanceID::GetToken() always returns the same token, but that will be changed when FakeServerSyncInvalidationsSender is added. Bug: 1135167 Change-Id: Ide98c9371ad788be804342899b6a561ef2b30e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450150 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#815523}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: If2f121ff622e2cc86ca6d2352307543e41e1ab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458911 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815522}
-
Aya ElAttar authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: altimin@chromium.org Bug: 1136766, 1136683 Change-Id: I8a55ab837dd54858e2a9a46485023574edef58bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461313Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815521}
-
Yoshifumi Inoue authored
This reverts commit c00ca060. Reason for revert: EditingNG is ready on Canary. Original change's description: > Change EditingNG from experimental to test > > This patch changes runtime enabled feature EditingNG from experimental > to test to avoid users who turn on "Experimental Web Platform features" > not to hit EditingNG issues. > > Bug: 707656, 1125477 > Change-Id: I81b56ff56c44da74b0702e4e2f2d81355a0a0c2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437834 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812020} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 707656 Bug: 1125477 Change-Id: Idd23638d2d3c028d3452f237c35288915154691a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463045Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815520}
-
Victor Hugo Vianna Silva authored
These tests were disabled a while ago by previous sync owners, let's try re-enabling them. Bug: 597319 Change-Id: Id66800f53f2af4ae0accb368f06dbf8c33642e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462257Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#815519}
-
dpapad authored
Bug: 1132403 Change-Id: I8a7d2c9c9fb54cbb7394d89afa7e91398a3ce1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460710Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815518}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.13-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1b41d7f35ea1df9c659d14601f83a277ef631dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815517}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602179909-b26649051a7d8d0314e04dcc1e82c76ad349e786.profdata to chrome-win32-master-1602201537-a14eb3c04e9257cb13970f54aebda7b1af96d2f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I46d12e9fe2b68b5a94e32c61db6729a276a778f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815516}
-
Shakti Sahu authored
This CL adds : 1 - Unit test for NewTabPageVideoIPHManager 2 - Fixed video duration string and added test Bug: 1117157 Change-Id: I2026c78fcc78c90da639499c3fba799fce31c2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448109Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd8eb564689a..e078093198e5 2020-10-09 kainino@chromium.org Suppress gl_test failures on Mac ARM64 (Apple DTK) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132295 Tbr: timvp@google.com Change-Id: Iffac9c8227b46f4c03d489b3befe59a47c67bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815514}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 87-4265.0-1601890590-benchmark-87.0.4280.13-r1 to 87-4265.0-1601890590-benchmark-87.0.4280.14-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3e9bbfc4f6a80f246ca84e8da970ba5787b0a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815513}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie74c3e151fbb69f1e07d167341a5e8dfc1adceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462773Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815512}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/528ecb920d34..898333a6b68f 2020-10-09 szuend@chromium.org [ts] Type-check network/NetworkFrameGrouper.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36ec58707b558cbd904423a048ecc36f398efdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815511}
-