- 26 Jul, 2018 4 commits
-
-
Peter Kvitek authored
Change-Id: Iaf007e192df6f094583545db9c18b60573404bb1 Reviewed-on: https://chromium-review.googlesource.com/1149414Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578138}
-
Darren Shen authored
The base class KeyboardUI doesn't call ShouldWindowOverscroll, so it doesn't really need to be on the base class. ShouldWindowOverscroll is only used by ChromeKeyboardUI, so we just move it to be a private method on that class. TBR=yhanada@chromium.org Change-Id: I5b95c83d64f6e2d8d2c8d50ac42bb34416a06aaa Reviewed-on: https://chromium-review.googlesource.com/1150014Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#578137}
-
Paul Miller authored
There were 4 mechanisms for enabling/disabling variations in WebView: - a command-line flag (mEnabledByCmd) - the AGSA experiment in m67 (mEnabledByExperiment) - the hard-coded setting (sVariationsAlwaysEnabled) - the hold-back experiment in m68 & m69 (sEnableState) Remove all of them, so that variations is always enabled. Set the hold-back experiment histogram, VariationsEnableState, to expire after m69. Don't mark it as obsolete yet, because we'll want to watch it for the lifetime of m68 & m69. BUG=851045 Change-Id: I44bd36789019074f422ec0c25be2afadba95b8c4 Reviewed-on: https://chromium-review.googlesource.com/1150772Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578136}
-
Miguel Casas authored
This CL homogeneises the if-else bracketing style in said file: these blocks get {} if either the condition or the body in either branch is > 1 line. Otherwise, no brackets. Simplified the logic of a few service methods too, and extracted the calculation of CanvasResourceProvider::ResourceUsage |usage| in GetOrCreateCanvasResourceProvider() so that it looks similar\ on both sides of the branch. No new functionality intended. Bug: 839970 Change-Id: I6e275a330f145aea861ae9344aa172ffc5840a27 Reviewed-on: https://chromium-review.googlesource.com/1150437 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578135}
-
- 25 Jul, 2018 36 commits
-
-
Nate Chapin authored
* Have a single public constructor, instead of separate constructors for sync and async requests. This means sync requests now need to call Start(). * Determine sync/async based on the ResourceLoaderOption parameter's synchronous_policy * Before this change, the constructor took a ThreadableLoaderOptions parameter, which was just a single-member struct for setting a timeout. Remove the unnecessary struct wrapper, and change the timeout from an unsigned long specifying the timeout in milliseconds (where 0 means no timeout) to a base::Optional<TimeDelta>. TBR=peter@chromium.org,yhirano@chromium.org Change-Id: If312cfeec7494a8f74ca28992e2688eec8e923a1 Reviewed-on: https://chromium-review.googlesource.com/1150570 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#578134}
-
Vladimir Levin authored
This patch ensures that if we've changed mix-blend-mode property, then we call SetNeedsPropertyTreeUpdate. R=pdr@chromium.org Bug: 867403 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idcd6e54c1d6ca3db0d0e088038cc144def2789b8 Reviewed-on: https://chromium-review.googlesource.com/1150687 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578133}
-
dpapad authored
This not only results to smaller file size, but also makes the code more portable, since it is less dependent on chrome:// URLs, and can eventually lead to running those elements and tests outside the context of a browser_tests and without js2gtest. For example this makes it easier to keep maintaining the following WebUI demo https://freshp86.github.io/chromium-webui/demo.html, and potentially move it within the Chromium repo itself. Bug: 866236 Change-Id: I1459789177ba5ede252c3ade3e0952686f4f01b5 Reviewed-on: https://chromium-review.googlesource.com/1144610 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578132}
-
Tommy C. Li authored
The tab management system saves and restores the last-focused control for each tab. However, if the last-focused control is destroyed, the browser focuses the Omnibox by default. In those cases, the edit model's saved focus state will be incorrect. This CL prevents that weird state from occurring by cross-checking the edit model's saved focus state with the actual focus state restored by the tab management system. This state de-syncing was always there, but has been recently made visibly apparent because of: https://chromium-review.googlesource.com/c/chromium/src/+/1144211 Bug: 866781 Change-Id: I0e85be9f650ae896021096e6c546b9f085d528d6 Reviewed-on: https://chromium-review.googlesource.com/1149191 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#578131}
-
Ross McIlroy authored
Only suppress streaming in the cases where V8 will actually consume the code code cache. It is no longer necessary to suppress it when we might want to produce a code cache. BUG=865098 Change-Id: I5ac4e798d7c7a732f87e0520ec4221da2646ae3e Reviewed-on: https://chromium-review.googlesource.com/1149360 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578130}
-
Tommy C. Li authored
Favicons for suggestions have been getting incorrectly rounded. This led to a discrepency in how they appeared on the tab and location-bar vs. the Omnibox suggestions. This CL does a few things: 1) Changes the icon_view_ member of OmniboxMatchCellView from the OmniboxImageView class (which rounds corners) to a plain ImageView. This fixes the heart of the bug. 2) Renames OmniboxImageView => RoundedCornerImageView, to make things more explicit. 3) Renames image_view_ to answer_image_view_ to make things more explicit. Also updates the comment to clarify that it's used for all suggestion answers, not just rich entities. As a followup, we should investigate eliminating / refactoring RoundedCornerImageView, as it appears (in the code) to apply the entity image corner radius to all answers-in-suggest images. But that's a less noticeable and separate concern. Bug: 866187 Change-Id: Ib35528e109d484dfca6013569c6cd52f71a8f6ae Reviewed-on: https://chromium-review.googlesource.com/1147503Reviewed-by:Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#578129}
-
Matt Menke authored
This method was previously unused, but with the network service moving out of process, the speech recognition code will now need to use it. No idea if we use speech recognition on headless (Though it does seem unlikely), so this may not be needed? Bug: 841445 Change-Id: I2c75a53663f46ddfbbd14aeac4ab3d6686d7d6e0 Reviewed-on: https://chromium-review.googlesource.com/1145711Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c27ac5c..ee658ba8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6d0cb617a7d34844a0c18e6214e42c08aee4aa8 Reviewed-on: https://chromium-review.googlesource.com/1150765Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578127}
-
Wenzhao Zang authored
1) Change style.hidden to style.visibility = "hidden" so that offsetWidth/offsetHeight are non-zero. 2) In addition to the absolute positioning, need to use "clip-path" to clip the thumbnail, so that it remains square after being selected (transform: scale(0.8) is applied to the thumbnail). Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 Bug: 867299 Change-Id: I6becad4fc0384c1e20c2069d4f1b89c8203ec01b Reviewed-on: https://chromium-review.googlesource.com/1150454Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578126}
-
Tien-Ren Chen authored
This reverts commit 05d439ba. Reason for revert: Perf regression crbug.com/867670 Original change's description: > [Blink] Unify replaced element clipping > > Prior to this CL each replaced element type implemented its own clipping. > This CL refactors it so that a clip node will be applied in the common > path, ReplacedPainter::Paint(), so the specialized > XyzPainter::PaintReplaced() won't need to apply their own clips. > > Note that ImagePainter still mutates its internal painting for changed > clip rect. This behavior should be changed in a follow-up CL, and > changing only the content box of a replaced element should only result > in incremental invalidation. > > BUG=730284 > > Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ia5c1412b1bd3182a22849d0b3196f3e72d52248a > Reviewed-on: https://chromium-review.googlesource.com/1147617 > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577741} TBR=trchen@chromium.org,pdr@chromium.org Change-Id: Ib91981e97c8558a462336f98f5ad219ef48bcef4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730284 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150255Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578125}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c7d74cd68934..c829a63538ba git log c7d74cd68934..c829a63538ba --date=short --no-merges --format='%ad %ae %s' 2018-07-25 benjhayden@chromium.org Add API support for the new ReportTemplate system. 2018-07-25 dtu@chromium.org [pinpoint] Hack to use performance_test_suite for patch jobs. 2018-07-25 benjhayden@chromium.org Allow anonymous /api/test_suites requests. Created with: gclient setdep -r src/third_party/catapult@c829a63538ba The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867521 TBR=sullivan@chromium.org Change-Id: I0350fffd262ed295aaae1a1c71c662cdbc7d249c Reviewed-on: https://chromium-review.googlesource.com/1150365Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578124}
-
Anna Offenwanger authored
Changing all the WebXR internal tests to use the test API specified in https://github.com/immersive-web/webxr-test-api. This will make tests more maintainable as changes to the backend mocking need only be made once. Bug: 863557 Change-Id: I4b8740269c0faa74073ef9294b6b27b78b18715a Reviewed-on: https://chromium-review.googlesource.com/1136982 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578123}
-
Weidong Guo authored
We used to check whether login status is USER to decide whether user signed in, which is wrong. So check IsActiveUserSessionStarted() instead. Bug: 867662 Change-Id: I2c71f494ab2698d063697395e609cad69a962444 Reviewed-on: https://chromium-review.googlesource.com/1150800 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578122}
-
Jinsuk Kim authored
ContentViewCore is still mentioned in many comments and names of methods/classes though it's gone. This CL replaces it with WebContents or content layer appropriately to the context. Also did some accidental clean up discovered by build/lint. There is no functional changes. Bug: 598880 Change-Id: I87e325a9c1b930ea1ceb462c842be28bf96a21e6 Reviewed-on: https://chromium-review.googlesource.com/1149677 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578121}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f7db295b1de..a5d2bf1131fe git log 1f7db295b1de..a5d2bf1131fe --date=short --no-merges --format='%ad %ae %s' 2018-07-25 thestig@chromium.org Remove CFX_MemoryStream uses in tests. 2018-07-25 tsepez@chromium.org Use struct {Single,Range}Cmap in FPDFAPI_CIDFromCharCode(). 2018-07-25 hinoka@google.com README.md: Update waterfall location 2018-07-25 thestig@chromium.org Change CFX_BufferSeekableReadStream to take a span. 2018-07-25 thestig@chromium.org Only build cfx_fileaccess_windows.cpp on Windows. 2018-07-25 thestig@chromium.org Move CPDF_SyntaxParser init methods into ctor. 2018-07-25 hnakashima@chromium.org Disable submit in XFA forms. 2018-07-25 tsepez@chromium.org Introduce ToXMLElement() checked downcast helper function Created with: gclient setdep -r src/third_party/pdfium@a5d2bf1131fe The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860896,chromium:842503 TBR=dsinclair@chromium.org Change-Id: If7bcdd2cc19be54976a33cb521e5fe2717fae483 Reviewed-on: https://chromium-review.googlesource.com/1150362Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578120}
-
James Cook authored
Now that we always have a CursorManager we don't need a virtual IsCursorVisible method and we can simplify the unit test. Bug: 631103, 840391 Test: ash_unittests Change-Id: I1af8a8f0d88df2da03147deb779cf41a13763dde Reviewed-on: https://chromium-review.googlesource.com/1150806Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578119}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5188a2747b40..eb4b86975848 git log 5188a2747b40..eb4b86975848 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 theoking@google.com Introduced eglMakeCurrent Perf Test Created with: gclient setdep -r src/third_party/angle@eb4b86975848 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ied1c8c3bcff842c9c65e9a3f0fc9b4ed1f03c423 Reviewed-on: https://chromium-review.googlesource.com/1150621Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578118}
-
Christopher Cameron authored
Two changes - Remove all use of GLFence in backpressure - In case GLFence objects were responsible for crashiness - Move the glFlush from SwapBuffers to ScheduleOverlay - ScheduleOverlay is a regular GL call, so it may be executed in a more "safe" context than SwapBuffers - This results in many more glFlush calls, but almost all are no-ops Possible outcomes - Crashes just change signature to ScheduleCALayer - Not very helpful - Crashes are reduced - Tells us that either - Our GLFence use was the cause of crashes - Making GL calls from inside SwapBuffers caused crashes TBR=kbr Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I23342b190a0d8b652dde8f96f1cb1169b577764c Reviewed-on: https://chromium-review.googlesource.com/1150569Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#578117}
-
Matt Wolenetz authored
This is a reland of 568cc6a9, which had been reverted in 8fba4f3d (bug 867520) due to failing link on windows builders with proprietary_codecs in their build configuration (bug 867536). Versus the original change, this one includes an additional MEDIA_EXPORT on the inner type "media::mp4::BitstreamConverter::AnalysisResult". Original change's description: > MSE: refactor mp4 AnnexB validation to also report keyframe-ness > > In preparation for logging when there appears to be a mismatch between > MSE MP4 keyframe metadata and the encoded video bitstream's keyframe > metadata, this change incorporates basic analysis of the latter as part > of the existing Annex-B bitstream validation for MSE MP4 video. > > Note that mp4::BitstreamConverter::AnalysisResult contains > base::Optional<bool> for each of conformance and keyframe-ness fields. > If a field doesn't have a value, that portion of the result was not > analyzed. > > Note that keyframe analysis is implemented only for AVC currently, but > even that is skipped if the frame is detected as non-conformant before > enough indications of whether or not it is a keyframe are detected. > Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis, > since such was either skipped or not yet implemented previously, > respectively. > > A subsequent CL will use the newly reported MSE MP4 video bitstream > converter's keyframe analysis results, if that analysis was done, in > reporting to chrome://media-internals when the bitstream keyframe-ness > mismatches that of the mp4 container for a coded frame. > > BUG=860420,584384 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I169c7774070ad232c86658bcd7803160323993ad > Reviewed-on: https://chromium-review.googlesource.com/1144456 > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577717} Bug: 860420, 584384 Change-Id: I8bbb3abc2079b53a14db8babbf04d5bad9e94767 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1150247Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578116}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/afdbf84ebc72..d81364a25e1e git log afdbf84ebc72..d81364a25e1e --date=short --no-merges --format='%ad %ae %s' 2018-07-25 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@d81364a25e1e The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2e50930270b933746d168d616218edcb0afce153 Reviewed-on: https://chromium-review.googlesource.com/1150780Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578115}
-
Devlin Cronin authored
Extension content scripts have permission to make cross-origin requests to hosts they have permission to access. On extension unload, remove these heightened permissions. Add a test to cover the same. Bug: 843381 Change-Id: Ib24e6593c423177f2a3993413c3d4695fe8efe7c Reviewed-on: https://chromium-review.googlesource.com/1120641Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578114}
-
Sebastien Marchand authored
Bug: 775644, 773382 Change-Id: I8c0426728b31644797e6e641d16ac049ab61a8ce Reviewed-on: https://chromium-review.googlesource.com/1148950Reviewed-by:
-
Shubhie Panicker authored
This will be used for Off Main Thread: to benchmark payloads for app models being validated. Doc: https://docs.google.com/document/d/1SghPBAYxy04O58hBnQ4Mv1dSEXCwpliMMkZxlRZAL78/edit# Change-Id: I32fb278ea69cd6c0f0889680462f5c973f64c6b3 Reviewed-on: https://chromium-review.googlesource.com/1149322 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578112}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6668a514ac5d..e1789af3378c git log 6668a514ac5d..e1789af3378c --date=short --no-merges --format='%ad %ae %s' 2018-07-25 bungeman@google.com Don't double check in SkArenaAlloc. Created with: gclient setdep -r src/third_party/skia@e1789af3378c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I98069463657788b964dee1751928ed7a5f650ad9 Reviewed-on: https://chromium-review.googlesource.com/1150364Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578111}
-
Min Chen authored
See recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiS3V6blozUTRDNWkwMDQ1WE1jQkdodmVMakxF/view?usp=sharing Bug: 847587 Change-Id: I4823ca758208249ac9f1de52c1aa967584694e49 Reviewed-on: https://chromium-review.googlesource.com/1148649 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#578110}
-
Sky Malice authored
While modifying usage_time_limit_processor*, also fixed lint issues. Change-Id: I9ab5bb049c4278539c89a3bf001815b8dc8cfd06 Reviewed-on: https://chromium-review.googlesource.com/1145461Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#578109}
-
Ryan Hamilton authored
Remove code differences in QUIC's ServerThread class by adding two new platform APIs QuicNotification and QuicThread. Change-Id: I7fb68f2b42613aa47a17953b16ae618ca431a60e Reviewed-on: https://chromium-review.googlesource.com/1149159 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578108}
-
chrome://accessibilityJames Wallace-Lee authored
Allow users to specify a ms delay before calling requestNativeUITree. This is useful for getting the accessibility tree for UI elements that disappear when focus is lost. Change-Id: Ib1668cd00caa4a1a0379c7f424f929b3c6d7350d Reviewed-on: https://chromium-review.googlesource.com/1150441 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#578107}
-
Douglas Creager authored
The include_subdomains field in a NEL policy triggers special behavior: the policy can only be used to generate reports about DNS errors (and not about other kinds of errors, or about successful requests) — but only if the policy and report have different origins! If they have the same origin, the policy would have matched even if include_subdomains weren't set, and the special logic shouldn't apply. Bug: 867605 Change-Id: Iaa72c9dd2dc8e634f8b10acda8acc5e012bb460b Reviewed-on: https://chromium-review.googlesource.com/1150663Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#578106}
-
Sahel Sharify authored
This reverts commit e459c6e9. Reason for revert: I re-wrote the flaky test. Original change's description: > Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > This reverts commit 8faf0805. > > Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 > > Original change's description: > > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > > > Bug: 846424 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > > Reviewed-on: https://chromium-review.googlesource.com/1144230 > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577727} > > TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1150180 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577856} TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I204f36b80ca421f85b6c375968a1134935fb3337 Reviewed-on: https://chromium-review.googlesource.com/1150094 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578105}
-
Vladislav Kaznacheev authored
Also replace in a few places outside app_list where app_list classes are instantiated. Bug: None Test: compile locally Change-Id: I21d26644275ea44c4d1610ffc034bda80225eaf8 Reviewed-on: https://chromium-review.googlesource.com/1149147Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Johann authored
Document location of prerequisites. Print error messages when cmake fails. R=urvang@google.com Change-Id: Id4dbc614a1bfb708d916eb0da861f79ae0d9b264 Reviewed-on: https://chromium-review.googlesource.com/1150674 Commit-Queue: Urvang Joshi <urvang@chromium.org> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578103}
-
Dirk Pranke authored
When running `mb analyze` on the builders, we want to make sure we correctly catch changes to files included by grit but not explicitly mentioned as inputs in the BUILD.gn files. Unfortunately, we weren't passing along the -D flags we're using to actually run grit, and so we were not catching the files that are conditionally included. R=ddorwin@chromium.org BUG=862731 Change-Id: I68b98e5786a2dd44e9ee5404aa4de3b0b1feaf33 Reviewed-on: https://chromium-review.googlesource.com/1150612Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#578102}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a3df0f2d05c7..d9e4a06374b3 git log a3df0f2d05c7..d9e4a06374b3 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 steveanton@webrtc.org Add CreateSessionDescription overload which takes a cricket::SessionDescription Created with: gclient setdep -r src/third_party/webrtc@d9e4a06374b3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I69b28bdab8b3d6f4b7eccee135b2857726cf2f73 Reviewed-on: https://chromium-review.googlesource.com/1150249Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578101}
-
Devlin Cronin authored
Add the ability to edit or remove existing runtime host permissions in the chrome://extensions page. Reuse the existing runtime hosts dialog with extra information about a current entry, and add controls to trigger editing or removal of a current permission entry. Add JS tests for the same. Bug: 844128 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0b1ad8bfcde167d6fa7c11a794ad04a8cb278e91 Reviewed-on: https://chromium-review.googlesource.com/1144532 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578100}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bce35f2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21745 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents TBR=lukebjerring No-Export: true Change-Id: I54642867f4081a1547147946096e88aa1e032024 Reviewed-on: https://chromium-review.googlesource.com/1150611 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#578099}
-
