- 12 Nov, 2020 40 commits
-
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/a1662b3f0e92..442f894c74b5 $ git log a1662b3f0..442f894c7 --date=short --no-merges --format='%ad %ae %s' 2020-11-11 danzh Move const declarations into quic_stream_sequencer_buffer.cc 2020-11-11 renjietang In QUIC, use using for alias declaration. 2020-11-11 wub Internal QUICHE change 2020-11-11 bnc Send QUIC GOAWAY after given time even if connection not idle. 2020-11-11 wub Change --quic_bbr2_default_inflight_hi_headroom from 0.01 to 0.15. 2020-11-11 bnc Use maximum stream ID in GOAWAY frame for graceful shutdown. 2020-11-10 quiche-dev Prevent QUIC handshake messages from flooding GFE logs 2020-11-10 bnc Implement new PRIORITY_UPDATE frame. 2020-11-10 danzh Fix QUICHE build issue in Chromium. 2020-11-10 quiche-dev Unify gfe2::RecordingHeadersHandler and spdy::TestHeadersHandler to spdy::RecordingHeadersHandler. 2020-11-10 quiche-dev Include prefix in SSL_early_data_reason_string. 2020-11-10 haoyuewang Replace absl::variant constructor call with emplace to fix clang10 compilation error. 2020-11-10 nharper Internal QUICHE change 2020-11-09 haoyuewang Allocate the size of stream sequencer buffer block pointer container on demand. This should save 16K bytes memory per stream on the server side, as currently blocks_ in QuicStreamSequencerBuffer starts with 2048 nullptr as soon as there is any data to read. 2020-11-09 renjietang Replace gfe2_reloadable_flag_quic_split_up_send_rst with gfe2_reloadable_flag_quic_split_up_send_rst_2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I508120bb0d0858acd948f1b5a3fe5a9a1cf54021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533540 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826752}
-
Changhao Han authored
Bug: chromium:1140914 Change-Id: I5c9a30162a63424b8be5afbee07be96c0f8450c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532259 Commit-Queue: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#826751}
-
Yoav Weiss authored
Currently, Viewport-Width hints send the display width for navigation requests, rather than the actual viewport width. This CL fixes that for iframes and for new windows that have the same viewport as their opener. Bug: 825892 Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494876 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826750}
-
Johann Koenig authored
The GarbageCollected<> template takes the class name as a parameter. Change-Id: I118947d646c97c84534b218820af9b2c7e0a60db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531840 Auto-Submit: Johann Koenig <johannkoenig@google.com> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#826749}
-
Mohamed Amir Yosef authored
TBR=mkwst@chromium.org Bug: 1148259 Change-Id: I9e6b67e8d2ec0a860b69616ad233419c97d1c456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534476 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#826748}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ab1aba2f4d5..40e2a6830ac5 2020-11-12 mbonadei@webrtc.org Trigger try and CI bots. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I85f5f1c9336cd201dca83c9cdae0fa6b14e1e8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826747}
-
Leo Lai authored
crypthome used to do the job but attestaion only judges the EMK/EUK type with emptiness of account id, so we have to filter out the account id for EMK. BUG=b:173060033 TEST=chromeos_unittests with the added test items to check if account id is not passed to attestation client. Change-Id: Ib4d4323462fd9fcc74f83b7650caa66bb9a6b6aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531806 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#826746}
-
Denis Kuznetsov authored
Bug: None Change-Id: I154a018d8ca88dc5fb2cb1b7e4237e1949c7d3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532585 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826745}
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: I84fddd0353aedea9d9fd1878dfb04b24e550fa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532251 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#826744}
-
Eugene But authored
Updated method names to follow Coding Style for Cocoa, where 'get' prefix should only be used when result is returned indirectly. Bug: None Change-Id: I99f1a178af897563e90630ea73492d578c8852bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527513 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826743}
-
Tibor Goldschwendt authored
Previously, the check failed if the default value was set to None explicitly. This CL changes the check to fail only if the default value is not set. Change-Id: I2eb179f306e340b73e24a08f9bfe63bc07706b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533288 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826742}
-
Simon Zünd authored
This change enables the removal of widgetSymbol and replacing it with a WeakMap. R=tvanderlippe@chromium.org Bug: chromium:1011811 Change-Id: I36434c734cc89df5b7c9d5eed4bf1a588d77b36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532777Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#826741}
-
Brandon Jones authored
When Tick() returns false, it means there is no need to call tick further. This commit changes chromium to only call tick when there is polling work to be done. Bug: dawn:119 Bug: chromium:940985 Change-Id: I792837b83f4d0da1d478e3876c9a2af8b1505c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485037 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#826740}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53d3c085a784..4fb2d48fe563 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieddbffe5425183257f6c7b7d5992a1e42c295a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534391Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826739}
-
Rakina Zata Amni authored
We've removed all cases where this happens (empty-body HTTP error, sandbox error) so we don't need this anymore. See doc: https://docs.google.com/document/d/1hf7b7OWlJMCpfFBk3xgxzHnskyNx3X8qjNWg6M1hr_0/edit Bug: 1133115 Change-Id: I50e92a0e73d7cca708c109af3626b62e095ab1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491285 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826738}
-
Daniel Cheng authored
This converts PaintTiming and ScriptLoader metrics to use the macro helper, and WorkerThread termination metrics to use the function helper. The distinction between function vs macro was made based on a guess on how performance sensitive the code recording the metric appears to be. In addition, the recorded enumerations have been updated to use the kMaxValue convention, allowing: - clang to enforce kMaxValue correctness - autodeduction of the max value by the enum histogram macro/function helpers. Bug: 742517, 1047547 Change-Id: I24f51cde75880c6ac42675724bc0fad321bcaf33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524933Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826737}
-
Henrik Boström authored
This CL makes "InCaptureConvertToNv12" enabled-by-default. Because this path is only used by the "AVFoundationCaptureV2" path, the result of this is that our "AVFoundationCaptureV2" experiment will transform all frames to NV12 in M88. Performance impact indicated below when running: https://webrtc.github.io/samples/src/content/getusermedia/resolution/ This is comparing AVFoundationCaptureV2 with or without InCaptureConvertToNv12. Logitech C920 Full HD (MJPEG): Old path MJPEG -> I420 SW buffer: 8.71 W New path MJPEG -> NV12 IOSurface: 7.88 W (-0.83 W) Logitech C920 VGA (YUVS): Old path YUVS -> I420 SW buffer: 6.62 W New path YUVS -> NV12 IOSurface: 6.49 W (-0.13 W) Facetime HD (NV12): Triggers pass-through path, same as before. Bug: chromium:1132299 Change-Id: Iede80be8407373a39c87a9b042168fbb43a15809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532558 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Evan Shrubsole <eshr@google.com> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#826736}
-
Amr Aboelkher authored
This CL add unit tests that tests all different scenarios for PSM + Hash dance. See go/cros-psm-client-unittests-coverage for an overview of the test cases for the different cases. BUG=chromium:1136866 Change-Id: Ia6a90617d33fdbc50cc8c1a9c06d214cb89f37e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529155Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Cr-Commit-Position: refs/heads/master@{#826735}
-
Viktor Semeniuk authored
This change adds a new feature kUseOfHashAffiliationFetcher. This feature will allow using Affiliation service for all users. Bug: 1108279 Change-Id: Id8331eaa2d4d5128d2ef270a8a07802653e60149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527140Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#826734}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b1513dc094d..5dec87fb9844 2020-11-12 jec@google.com Update What's New UI for Chrome 88 2020-11-12 changhaohan@chromium.org Fix <angle> keydown issue 2020-11-12 alexrudenko@chromium.org Clear label container in reset() 2020-11-12 szuend@chromium.org [issues] Introduce substitutions in markdown issue descriptions 2020-11-12 tonykostowny@gmail.com Support expanding uppercased shorthand CSS properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125465,chromium:1148183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I91d175d0f98df227ce56db8680a89b883370d2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826733}
-
Bettina authored
The Chrome Cleanup Tool may start to clean up shortcuts, and the prompt that is opened from the profile resetter should also update to reflect this change. http://screen/5TAo37jMzqSMPHu.png Bug: 1116017 Change-Id: I8269b7ce8da123587734a3cd7fa8f9810bbace12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531656 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#826732}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b638dfe160a1..4804ac8724ff 2020-11-12 capn@google.com Implement MemorySanitizer instrumentation of Reactor routines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I93486a692873ac764c586b5b992ebce5404bdbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533584Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826731}
-
Lutz Vahl authored
This is a roll-back to 8.8.278. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org,hablich@chromium.org Change-Id: Id46522e00600559681ed4740c61c7edd9be62f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532583 Auto-Submit: Lutz Vahl <vahl@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#826730}
-
Illia Klimov authored
As part of the Flash/Plugins deprecation, the resource identifier becomes obsolete. This CL removes resource_identifier from the content_settings::ProviderInterface Bug: 1134547 Change-Id: Id17a43b9896c48a500995d7854b92ffa3f169640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529889Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#826729}
-
Henrik Boström authored
As detailed in https://crbug.com/1147867, after rebooting Logitech C920 produces a single invalid MJPEG sample buffer frame that we are unable to transform into I420 or NV12. Subsequent frames are valid, and this issue cannot be reproduced again until the computor is rebooted. Prior to this CL the invalid MJPEG frame causes a DCHECK crash inside SampleBufferTransformer. This CL makes it fail gracefully instead by returning null if this happens. There is no known way to cause non-MJPEG transformations to fail, so all other code paths still DCHECK. This fix is verified in both unit tests that use a clearly invalid MJPEG frame, and manually using the Logitech C920 camera. This CL unblocks making InCaptureConvertToNv12 enabled-by-default. Bug: chromium:1147867 Change-Id: Iefb6f5407918b4a8ea81f9ce41acc211ef80bdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532556 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Evan Shrubsole <eshr@google.com> Reviewed-by:
Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#826728}
-
Nazerke authored
This CL moves TabGrid and TabStrip to the common folder in order to share the reusable code. Bug: 1128249 Change-Id: Ibac6573dfa1828882828ff2c699985c6c5af2fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521531Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#826727}
-
Mihai Sardarescu authored
Before using the cookie jar APIs to add and remove CHROME_CONNECTED cookie, |IOSChromeSigninClient| used to call the AccountConsistencyService::RemoveAllChromeConnectedCookies to delete these cookies. This was removed as part of CL https://chromium-review.googlesource.com/c/chromium/src/+/2421669. This CL fixes the AccountConsistencyService service to actually remove the CHROME_CONNECTED cookie when the user signs out of Chrome as this is no longer called by IOSChromeSigninClient. Bug: 1148200 Change-Id: I336a420d42f9cb2e653441be61c3adc14e5be095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532001 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#826726}
-
Tanmoy Mollik authored
This cl adds a test for checking SyncPromo in NewTabPageTest when MOBILE_IDENTITY_CONSISTENCY flag is on. Signin promo was not being updated when signed in state had changed. This cl also fixes that issue. Bug: 1100895 Change-Id: I760f563d4ae54813e3cf06d7cf88d4c601be91fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513218 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826725}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: Ia528cbd3595da7f7b2459e0f0ea475235b491f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533773 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#826724}
-
Guido Urdaneta authored
Prior to this CL, if a mic was opened, it could not be opened again with different settings, except for echoCancellation when already opened using a ProcessedLocalAudioSource. After this CL, some of the restrictions are removed for getUserMedia: 1. If the mic is opened using a ProcessedLocalAudioSource, it can be opened again with a different ProcessedLocalAudioSource with a different echoCancellation setting (same as before), but now it can also be opened with a non-processed source. 2. If the mic is opened with a non-processed source, it can be opened again with any type of source and settings. As before, if, after constraints processing, a new track requests the same settings as an existing source, the existing source is reused. Note that these changes apply only to getUserMedia. applyConstraints stays unmodified and still cannot change source properties. Bug: 1082049 Change-Id: I18f124eca40a9461691a67ac7b2c2d0cde6fb494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532078Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#826723}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06bbeb3398af..3ab1aba2f4d5 2020-11-12 mbonadei@webrtc.org Trigger bots on CI. 2020-11-11 ssilkin@webrtc.org Make SEA to be codec agnostic. 2020-11-11 landrey@webrtc.org Add possibility of upload check for pc perf tests 2020-11-11 jakobi@webrtc.org Add delay manager config options. 2020-11-11 alessiob@webrtc.org RNN VAD: pitch search optimizations (part 4) 2020-11-11 sprang@webrtc.org Avoids potential rounding of -inf time delta in TaskQueuePacedSender. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5d3c149baae82da6c0c7e9f7db383905ddd5ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533543Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826722}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a61d07a72763..1cda495274bb 2020-11-11 dneto@google.com Use less stack space when validating Vulkan builtins (#4019) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: Ie426b6a2aff145650ee26c12ee446802921a491a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826721}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53d3c085a784..4fb2d48fe563 2020-11-12 eseckler@google.com Merge "docs: Add docs about branching Perfetto for a Chrome milestone" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3a8ee24ab1a69abb8103a3402ee1dd7c637195e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533427Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826720}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ifc027928982c4e6e9272e0d149fd19410c5c61de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494603 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#826719}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6067e9ce8bb3..62c10c170bb3 2020-11-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ca966cfb to a927c079 (518 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibedbee6a56e2fc08287d042e855ea0ae34606af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826718}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I3b6f490991001a9d8e5caafd5cb04d5f68651891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826717}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=tschumann@chromium.org Bug: 1145565 Change-Id: Iecd38a26630d7a6565455c42942b4b61144f1d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532719 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#826716}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: Iadcb930d49e905dcf94511f3fb213e06f0cce547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505704Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#826715}
-
Vincent Boisselle authored
... card in Feed V2" This is a reland of 6fe88955 after fixing the issue of uninitialized notice_card_acknowledged Original change's description: > Feature to locally auto-dismiss the notice card in Feed V2 > > Bug: 1146458 > Change-Id: Ibca4559552d991667ea5043687845e845b251db1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527719 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826640} TBR=harringtond@chromium.org,vincb@google.com Bug: 1146458,1148208 Change-Id: Id35d072feee01609c21c82fcb46f698132df7ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532223Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#826714}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e48f06fb0cca..2b1513dc094d 2020-11-12 szuend@chromium.org TypeScript-ify profiler/ProfileView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I260b3ec17ec89eb2106278fe4cb75f5314edebd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533541Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826713}
-