- 04 Dec, 2019 40 commits
-
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: I169be83055526d06615f2002dd09a7f89ed6b8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947045Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721612}
-
Francois Doray authored
This CL adds a boolean argument to base::TaskObserver::WillRunTask(), to indicate whether the task that is about to run was at any point in a queue that was disabled, blocked by a fence or low priority. The purpose of this change is to allow the creation of an histogram that reports when tasks that were never blocked or low priority are queued for a long time. TBR=sky@chromium.org,avi@chromium.org,zmo@chromium.org,marq@chromium.org,mattm@chromium.org,jochen@chromium.org Bug: 1029137 Change-Id: If63e2a5cd5690e04663399643ba2a3f7d928cedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943538 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721611}
-
Daniel Hosseinian authored
Edit the templates of CloudPrintSubmitEnabled and PrinterTypeDenyList. Bug: 487875 Change-Id: I640d8e27451734b0129659e00a88758ca228087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945083 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721610}
-
yu han authored
This is a regression introduced by my fix to HTMLAnchorElement when the <a>, with embedded inline element, is placed inside a <summary> tag. https://chromium.googlesource.com/chromium/src/+/4eb4df63f17ee0f22cd17472fa6ae92311e49900 The regression is caught by fuzz test: https://clusterfuzz.com/download?testcase_id=4577041865113600. The fuzz test create a click event on the document object which gets handled by node.cc::DefaultEventHandler(). It creates an DOMActivate event and propagate down to HTMLAreaElement. However, the event target is set to NULL by dom/events/event_dispatcher.cc. https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_dispatcher.cc?q=event_dispatcher.cc&sq=package:chromium&dr&l=391 Comment indicates the reason is that the event is crossing the shadow DOM boundary. Eventually, inside HTMLAnchorElement::HandleClick -> HTMLAnchorElement::AppendServerMapMousePosition() expects target to be non NULL and Null dereference exception is thrown. The fix is to check the event target for null before handling the underlying event. I went through the call stack to ensure no other event members are needed. I verified that both newly created anchor test and fuzz test pass. Bug: 1029197 Change-Id: I19a3b2811c1d562f4c563bed54ae380d7849b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945852 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#721609}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ff7c98ede3e..1d23e728fb93 git log 7ff7c98ede3e..1d23e728fb93 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 perezju@chromium.org [devil] Update markdown docs Created with: gclient setdep -r src/third_party/catapult@1d23e728fb93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029008 Tbr: sadrul@google.com Change-Id: I9d63436c0bb35eadeeb496aa0a14cf6dcdef0f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721608}
-
Yang Guo authored
Fixed: 1028931 Change-Id: Ib26155ca9769495458f4fa0e1a5ba0bfc77b8e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939288Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721607}
-
Ken Buchanan authored
RenderWidgetHostInputEventRouter sends a special MouseMove event with the kRelativeMotionEvent flag set to a frame if the mouse cursor is over it but another frame had been holding mouse capture. This allows the mouse cursor to update properly for the current location on the page. See https://crrev.com/693342. The test for whether the cursor is over a different frame can have false positives when HitTestRegions have the kHitTestAsk flag set, indicating that an asynchronous hit test is required. This CL provides a partial solution by preventing the extra MouseMove from being sent in that situation. In future it might be desirable to actually perform the asynchronous hit test when capture is being released at this point. Bug: 1021508 Change-Id: I59367f11e992a57203387ed8b9daccee57d0a414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944311 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721606}
-
Kurt Horimoto authored
This CL also adds no-op functions to return supported overlay coordinator classes. Bug: 1030357 Change-Id: I77c48fd1833509044a8c440d45e7f82218f06ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949288 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721605}
-
Samuel Huang authored
This CL move to the DFM 4 page totalling ~27.8 kB that are low-hanging fruits because they already have their own GRD files. Also taking the opportunity to reorganize: * Move the pages' grit() targets to separate BUILD.gn files. * Move chrome://invalidations resources to its own directory. Bug: 927131 Change-Id: Ic31bd86e09312c8137661432788b2b58eade0bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949056Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721604}
-
Joe DeBlasio authored
This CL adds a null check to autofill client's check of the page security. It was causing crashes. Bug: 1030482 Change-Id: Ie6a4bf4674b42c0f76994cc13cc22b22c38a6083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949207 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721603}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b3800c4..1e65162c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e21c85cd241cd71e4a7c77b25781764f91172bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950883Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721602}
-
Sorin Jianu authored
Some constexpr static class members still require definitions in C++14 but it is not clear why this build break occurred on Android only. Change-Id: I3e0d04d765f02ce37db2f7b4df90bb4d85fcab6d BUG: 1030716 Change-Id: I3e0d04d765f02ce37db2f7b4df90bb4d85fcab6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950749Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721601}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a213018b475..a06f9d0787ca git log 4a213018b475..a06f9d0787ca --date=short --first-parent --format='%ad %ae %s' 2019-12-04 halcanary@google.com SkQP: model-creation improvements 2019-12-04 mtklein@google.com work around GCC false positive warning? 2019-12-04 egdaniel@google.com Handle failures in submission of vulkan command buffers. 2019-12-04 mtklein@google.com replace SkIRect[1] with SkIRect 2019-12-04 bsalomon@google.com Fix for 420/422 chroma subsampling of odd dimension images when 2019-12-04 reed@google.com Reland "remove legacy SkPath enum guards" 2019-12-04 robertphillips@google.com Add onPrePrepareDraws to GrFillRectOp 2019-12-04 mtklein@google.com simpler tmp arrays in GrGLPath 2019-12-04 senorblanco@chromium.org Update dawn.h -> webgpu.h, dawn_cpp.h -> webgpu_cpp.h. 2019-12-04 rosasco@google.com Notes on how to build SKQP for Fuchsia. 2019-12-04 reed@google.com Revert "remove legacy SkPath enum guards" Created with: gclient setdep -r src/third_party/skia@a06f9d0787ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I2905b64641a8d83d471063cb75f3d8eb047a95be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950231Reviewed-by:
-
Nate Chapin authored
This removes the need for special-case pausing/unpausing in Document, as well as custom Document::Shutdown() logic. Bug: 1029822 Change-Id: I2c9cda5bb3720626cdc1f3fcadb7876422ca375e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949275 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82f68bc205dc..b92f8d81cac4 Created with: gclient setdep -r src-internal@b92f8d81cac4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4a355d97782969bc94f3fe8d392a5dfb38412baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949708Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721598}
-
Matt Menke authored
The method was returning opaque origins for IP literals and effective TLDs, since GetDomainAndRegistry() returns an empty string in those cases. This CL makes it instead leave those hostnames intact. Also remove a couple unnecessary "net" namespace prefixes. Bug: 1030499 Change-Id: I5e7715a090e5bc30378579acef166a967483af8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950685Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721597}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6ba98ff60144f60aba589b4d6121689528fbae76..243b5cc9e33979ae2afa79eaa4e4c8d59db161d4 Bug: none Change-Id: I895b7e380c0359ea2c2bb9fde423b0f79e26ba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951086 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#721596}
-
Garrett Beaty authored
This reverts commit b46672aa. Reason for revert: crbug.com/1030521 Original change's description: > Add branched versions of Phase B CI builders. > > All branch CI builders have been moved to be scheduled once per day. As > we get capacity and get the builds into a good state, we will move them > to be continuously triggered. > > Bug: 1024641, 922150 > Change-Id: Ie066240907dd581175c94cbca431e5a6bf37deb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948050 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721218} TBR=agable@chromium.org,gbeaty@chromium.org Change-Id: I717e2f06feba96a3d3b64b89f92a4821b9368c00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024641, 922150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951363Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#721595}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9777ab3619c7..0e60ecd30efa git log 9777ab3619c7..0e60ecd30efa --date=short --first-parent --format='%ad %ae %s' 2019-12-04 kmarshall@chromium.org [git-cl] Add graceful error handling to "git cl archive". Created with: gclient setdep -r src/third_party/depot_tools@0e60ecd30efa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibeebc5c3cb6884d0f723e958e71353dadad23579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951143Reviewed-by:
-
John Rummell authored
It appears that the test license server is not copied over when running Widevine tests, so updating the target to copy over the folder containing it if it's available. Bug: 976083 Change-Id: I987beb4506b5cba7d3ed9a02edc5a91a5c327d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947361 Commit-Queue: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721593}
-
Sophie Chang authored
Bug: 999541 Change-Id: I64a6626cc807ac668a271746770d5d0690f752ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929635Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721592}
-
Avery Musbach authored
Whether an overview window is eligible for split view depends upon work area dimensions in relation to the window's minimum size. Therefore it can change with display orientation. So the unsnappable indicator shall be updated when the display is rotated. Test: ash_unittests All/SplitViewOverviewSessionTest.* Test: ash_unittests All/SplitViewOverviewSessionInClamshellTest.* Fixed: 1027806 Change-Id: I666c9fb16c0b64931d538bc9d8b80f3af7392da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949193 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721591}
-
Ted Choc authored
From the failed screenshots, it appears the omnibox is not fully visible before attempting to focus the URL bar. This waits to ensure the URL bar is shown before attempting focus. BUG=1030246 Change-Id: I9f2c4659eca6b70d4d66b73f4abc40a6e2474d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949562Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721590}
-
Maksym Onufriienko authored
Parent cl - http://crrev/c/1940752 Bug: 1026279 Change-Id: I9e24f6f889ab72c66b800fb307ed775fa171cb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949292 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721589}
-
Lei Zhang authored
Some platforms have both struct stat and struct stat64. On these platforms, calls to stat() and related functions may fail with EOVERFLOW if struct stat cannot properly represent the information in a struct stat64. Parts of base/ already deals with this correctly by using stat_wrapper_t and wrappers for stat() and related functions. Expose these wrapper functions in base/files/file.h, which defines stat_wrapper_t, and use them throughout base/ in POSIX code that may trigger EOVERFLOW. Change-Id: I201507e440b1c80f6a24a86aad496c4b4793fdae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947912 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#721588}
-
David Tseng authored
This is a small partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1947643 The check in desktop_automation_handler.js -> range_automation_handler.js onEventIfInRange helped prevent processing of repeated attribute changes that come from the subtree of ChromeVox's current range. For example, Gmail's threadlist where focus is on a row. Any attribute changes within cells or on individual cells caused output. TBR=dmazzoni@chromium.org Change-Id: I696cd506a2c8d33bfa343d36df76f7551c79bb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951085Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#721587}
-
Maksim Sisov authored
This reverts commit a71959ba. Reason for revert: causes crashes if buffers are submitted twice and Wayland compositor releases the buffer Original change's description: > ozone/wayland: Complete submission of a buffer submitted more than once > > This CL fixes a corner use case that was caught by one of the users > of Ozone/Wayland. > > The problem appeared when the Chromium compositor sent a next frame into > the same buffer that had just been submitted and a OnSubmission callback > had been sent to the viz process located WaylandBufferManager. This > happened only when the remote inspector was attached and the screencast > was enabled. > > In this case, Wayland compositor will not send an OnRelease callback > and we should not wait for that. Instead, we must complete the > submission immediately and set the |WaylandBuffer::released| > member to be false. Once another buffer is committed, Wayland compositor > will release the previous buffer. > > Bug: 1029777 > Change-Id: Ib74c16f41f128298998bc9699f8d9ded3697cd43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946479 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720878} TBR=rjkroege@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029777 Change-Id: I14dc61f4dad186a17e5b657d87143cb61a24f48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950972Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#721586}
-
Kevin Marshall authored
Allows for creation of HEADLESS Contexts, for browsing sessions without graphical output. Implements EnableHeadlessRendering() and DisableHeadlessRendering() on Frames, which is used for processing DOM animation events in non-graphical Contexts. Bug: 1025045 Change-Id: I2cd8e428f4b6eadaafe17631b36b6d42b8d4ea25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918036Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#721585}
-
Herb Derby authored
Bug: chromium:625191 Change-Id: Iecad57e6ba8d11db5a9faf0b868d39ed3db3e34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947357 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Herb Derby <herb@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#721584}
-
John Budorick authored
Bug: 1030253 Change-Id: I0f06df54c45523212f7333b3f8e447cefe2ecf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948514 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#721583}
-
Aran Gilman authored
Bug: 1027612 Change-Id: Ic4fe44c88ceac6db749336830c6f0abe15dbc68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931105Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#721582}
-
John Z Wu authored
Change-Id: I823b0892c4eaeac5555b51e4d753311c191b7cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949699Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#721581}
-
Yue Li authored
If all the sequences has been detached, the observer should be notified, otherwise it might wait forever. Also added unit test cases for this scenario. Bug: b/141997678 Test: Run CallbackLayerAnimationObserverTest.* in compositor_unittests Change-Id: I3a025de8e635a383910ef4a3e650683478e8d3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938459Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#721580}
-
Sean Harrison authored
Changes between original submission and reland: 1.) Privacy-page subpages are now in lazy_load.html 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings. 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled. 4.) Reordered a few settings rows to match the most current mocks. > Revert "Friendly Privacy Setting Initial Redesign" > This reverts commit 544412a4. > Reason for revert: Performance and functional regressions > https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 > Original change's description: >> Friendly Privacy Setting Initial Redesign >> >> This CL does 3 things: >> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. >> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. >> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. >> >> Bug: 1014143 >> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 >> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> >> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> >> Cr-Commit-Position: refs/heads/master@{#714287} Change-Id: If3fa33801604491b8648672ff53d37a818f2cd08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929443Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#721579}
-
Arthur Wang authored
R=carlosk@chromium.org, harringtond@chromium.org Bug: 1028976 Change-Id: I63e361cae052c1fb274cfefa9791b20ea9f596cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949449Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721578}
-
Alexander Hendrich authored
The permissions for the chrome.usb API was already removed earlier (https://crrev.com/c/1916860). Bug: 995294 Change-Id: I73468cf202f0d4137744aa5d127e663839569e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949796 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#721577}
-
Ioana Pandele authored
The method called to show the dialog used to take 9 parameters and the list was growing. This CL bundles the parameters into a separate contents object which requires the mandatory values to be passed in the constructor and offers reasonable defaults and setters for the rest of the values. In addition, some properties of the model are not actually meant to be changed on the fly, so they are now marked readonly and set before building the model. This requires a separate initialization step in the coordinator and mediator. Bug: 1028947 Change-Id: I4f121e5fee88d095d6c31add59111639e85faedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948931 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721576}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/576b9e489dca..c4eacc1612b6 git log 576b9e489dca..c4eacc1612b6 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 brgoddar@microsoft.com Coverage: Add title for visualization in coverage tool 2019-12-04 obrufau@igalia.com [css-pseudo] Expose ::marker pseudo-element in devtools tree (front end) 2019-12-04 yangguo@chromium.org Remove outdated extract_module script Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4eacc1612b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:457718,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ica48896b556d628525500cc39608aa3b3cd389d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950845Reviewed-by:
-
rbpotter authored
- Replace CallJavascriptFunctionUnsafe('deleteHistory') with a FireWebUIListener() call. - Remove global deleteHistory function in history.js and forwarding in app.js, and directly listen for the event in history_list.js. - Add a test verifying that the event is correctly handled. Bug: 1022212 Change-Id: If6f2f62dbe1bfa8c94313c32e448f892e8072c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947906 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Daniel McArdle authored
This commit adds -Wno-deprecated to the relevant target's cflags for non-mac builds. If we ever update XCode's bison version to 2.7 or better, we will be able to replace '%pure-parser' with '%define api.pure full' in xpath_grammar.y. Change-Id: Ib0390d7c91828c095a86eb07acb854f09fa13060 Bug: 1028421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948245Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#721573}
-
