- 20 Oct, 2020 40 commits
-
-
Evan Stade authored
Instead of using a command line flag, the feature is toggled by an AndroidManifest entry. This is more ergonomic for developers as they don't need to use a debug build of Android to toggle the feature. Bug: 1057100 Change-Id: Icdc6676d1b15e43a46ebb6d14276cef89ff4942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480705 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818779}
-
calamity authored
This reverts commit ed0b0d99. Reason for revert: Consistently failing on linux-chromeos-chrome First failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9267 Original change's description: > Emit a UKM event on client connection to a ServiceWorker > > Whenever an execution context (whether a window or worker) becomes a > client of a service worker, the renderer will now inform the respective > ServiceWorkerContainerHost of the client's ukm::SourceId once it is > execution ready. This id will be passed to SWIdentifiabilityMetrics, a > new SWContextCoreObserver. This observer will them emit a UKM event > (Worker.ClientConnected) in order to associate the ServiceWorker's > ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are > not included as they exactly match that of their parent execution > context. > > This association is required both for attributing entropy consumption of > workers to sites, but will also help to gain insight into the cross- > connectivity between first-party contexts via shared and service > workers. Design doc (internal-only): > https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing > > Bug: 1085645, 1134193 > Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818555} TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,shimazu@chromium.org,asanka@chromium.org,alexmt@chromium.org Change-Id: I2ebcaa9e70fd3347b71fac297436569166e2af79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085645 Bug: 1134193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486901Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#818778}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9dd6e5039558bf716432d58647a45d2bb9a45719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818777}
-
Aaron Leventhal authored
Make [de]serialization errors fatal for any kind of build used to debug Chromium errors. This also restores the fail fast behavior in ADDRESS_SANITIZER, which was removed in CL:2468238, because it was mistakenly believed the address sanitizer builds had DCHECks on. TBR=dmazzoni@chromium.org,sadrul@chromium.org AX-RelNotes: n/a Bug: None Change-Id: I3a3651bf8732071cfb25f25eb4fc88ffa6a13855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486119Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818776}
-
Sylvain Defresne authored
In preparation of adding support for target_environment="catalyst" replace all uses of `use_ios_simulator` with the corresponding check of the value of `target_environment`. Bug: none Change-Id: I23b0e9c05c6a427de0e5cb82d7937905b64028c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476278 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818775}
-
Gyuyoung Kim authored
This is a reland of 6ddff235 This CL fixes the build error caused by exceeding the max token limit using the function overloading in text_link_colors.h. This CL makes the file include forward.h files instead of shared.h using below change. FooColor(ColorScheme color_scheme = ColorScheme::kLight) const; => FooColor() const; FooColor(ColorScheme color_scheme) const; Original change's description: > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > This CL replaces the existing uses of native ColorScheme > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > in order to remove unnecessary type conversion. > > Bug: 919392 > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#817773} Bug: 919392 Change-Id: Iaac4bec9df6ee4e68b682658c996618571eb3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476695Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#818774}
-
Aaron Colwell authored
This function primarily relied on internal details of SiteInfo and didn't really depend on anything in RenderProcessHostImpl so it seemed reasonable to move this to SiteInfo. Also created a helper method with the same name on SiteInstanceImpl to reduce some code duplication. There are no behavior changes in this CL. Bug: 1085275 Change-Id: Idfed5bbbffbe2eeb7621b6e285c1a28f08d1a76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482426Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#818773}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5b99b448b3db..3ead01191215 2020-10-19 johnkslang@users.noreply.github.com Merge pull request #2422 from ben-clayton/gn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I5428b6ad7b23d863c7196a94eccbaaa3969ee010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486055Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic02463d5e30d6776a935c97ba0862cc8384303f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486658Reviewed-by:
-
Lambros Lambrou authored
WebRTC sometimes provides selected-candidate-changed notifications with invalid IP addresses. The host process normally records these in the system event log, but only if both IPs are valid. With this CL, route-change events are generated even if the local or peer IP address is invalid. These appear in the event log as "unknown". Bug: 1128667 Change-Id: I9329092bdb7f7e4cf6d845303f321bff3eb3177b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485576 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#818770}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves //content/renderer/history_entry.{cc, h} and //content/renderer/history_serialization.{cc, h} to blink. Bug: 1110246 Change-Id: I0eca1730f9c81e44e4f992b89864992f5249c199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473700Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#818769}
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_UpdatePrintSettings message to UpdatePrintSettings() in mojom::PrintManagerHost. It introduces several helper functions to access PrinterQuery which runs on IO thread like GetDefaultPrintSettings(). UpdatePrintSettings() is called on UI thread and posted to IO thread for PrintViewManagerBase to update the settings. It removes NupPrintingTestDelegate and PrintingMessageFilter::TestDelegate. Instead, it adds TestPrintViewManager to override UpdatePrintSettings() for N-up setting. Bug: 1008939 Change-Id: I2f5d876c9139122673e103fb31a425a61398bdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452129Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#818768}
-
Kenichi Ishibashi authored
This CL removes //content dependencies from service_worker_storage_unittest.cc so that it can be moved to the Storage Service directory. Summary: * Replace EmbeddedTestHelper with ServiceWorkerStorage * Replace BrowserTaskEnvironment with base::TaskEnvironment * Remove helper functions which are no longer used * Rename some helper functions Bug: 1016064 Change-Id: Ia458ccb9da23ed722051aae6c72bfb5efb81e31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473785 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818767}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/84fb34e2d..715ec351 715ec35 Do not use check_thin_archive in the Fuchsia build TBR=jshin@chromium.org Bug: fuchsia:61405 Change-Id: I6887abcc108c0e01a68d6b810318c5fad203ccd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477092Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818766}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia2798d1efe7d650eea269b2df8ffef82abcb4c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486275Reviewed-by:
-
calamity authored
This reverts commit 73a80a9e. Reason for revert: Suspected cause of failure at https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/29327 Diff of vi.pak.info is: < IDS_NTP_MODULES_SHOPPING_TASKS_INFO_TITLE,7397,../../chrome/app/generated_resources.grd < IDS_NTP_MODULES_SHOPPING_TASKS_INFO_1,7398,../../chrome/app/generated_resources.grd < IDS_NTP_MODULES_SHOPPING_TASKS_INFO_2,7399,../../chrome/app/generated_resources.grd < IDS_NTP_MODULES_SHOPPING_TASKS_INFO_CLOSE,7400,../../chrome/app/generated_resources.grd --- > IDS_NTP_MODULES_TASKS_INFO_TITLE,7397,../../chrome/app/generated_resources.grd > IDS_NTP_MODULES_TASKS_INFO_1,7398,../../chrome/app/generated_resources.grd > IDS_NTP_MODULES_TASKS_INFO_2,7399,../../chrome/app/generated_resources.grd > IDS_NTP_MODULES_TASKS_INFO_CLOSE,7400,../../chrome/app/generated_resources.grd Original change's description: > WebUI NTP: add recipe task module > > The recipe task module is mostly the same as the shopping task module. > This CL is mostly a copy of the shopping task module. Removing the > duplication will be addressed in a follow-up. > > Renamed the UI string IDs. No change to the strings. > Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM > > Bug: 1138011 > Change-Id: Ib709c1dd35a7f05058570ba4c1bf1bc7dddb7d32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469401 > Commit-Queue: Esmael Elmoslimany <aee@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818686} TBR=sky@chromium.org,rkaplow@chromium.org,tiborg@chromium.org,aee@chromium.org,nicolaso@chromium.org,ajgo@chromium.org Change-Id: Ieeab4b09afdcf00417c3a9eec921adbffc96aa92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486900Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I553458d74a248901715fd560ac0057349d29255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485401Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818763}
-
Peter Kasting authored
Bug: 772945 Change-Id: I2de0099c2287b5d9412a9c3ffa190efe29559817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485133 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#818762}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603107412-fb64dfead80726fe49a6a8dd27a12a049b69e6ae.profdata to chrome-mac-master-1603151856-f47d024d838dc85b63fc569bff574a3f3aa4f83b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8f86213440188c8138febf4abad54fdece5f86b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486654Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/55926e1a..afab06b2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I299fb82a8e0ae19685c36bc03edfe0c59e675593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485762Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818760}
-
Lan Wei authored
http/tests/devtools/network/network-filter-service-worker.js and virtual/threaded/external/wpt/web-animations/timing-model/animations/ updating-the-finished-state.html fails on Linux Tests and Mac, https://ci.chromium.org/p/chromium/builders/ci/ Linux%20Tests%20%28dbg%29%281%29/92362, and https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/30802 disable it for now until it is fixed. TBR=tvanderlippe@chromium.org NOTRY=True Bug: 1140329 Change-Id: I5b1af44db603f25718a57795cd82bd836e84c78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485779Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818759}
-
Rachel Wong authored
The Suggested Content toggle has been approved in https://bugs.chromium.org/p/chromium/issues/detail?id=990279#c148. This CL enables the feature by default, and updates tests that need to take this into account. Bug: 990279 Change-Id: Icc2c8bdf72cff8734aa5941f3fbc2774b38e4c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462752Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#818758}
-
Fergus Dall authored
guest_os::GetHandler can be called on incognito and guest profiles which do not have a GuestOsRegistryService. This causes a null pointer deref crash. Fix this by returning base::nullopt in this case. Ran new unit test without change to verify the crash, and again with the rest of the change to verify the fix. Bug: 1139821 Change-Id: I943d2d7c06b2f897607784a046978a981ed2613e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485414 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#818757}
-
David Schinazi authored
R=renjietang@chromium.org Change-Id: I22beaebb6c757818f8c28129d63ae48ba8bdad8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485345 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818756}
-
Xing Liu authored
Chime needs to be initialized during ChromeApplication.java's startup code. This CL adds ChimeSession.initialize() entry point API, and a upstream placeholder function for Chime DFM. Also clean up the feature flag JNI call for Chime, now it can directly depends on chrome/browser/flags:java. Bug: 1136305 Change-Id: Id8424fc22d2f419860318b12bd8753da448cd50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466897Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818755}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c81dc527120b..f7dcbb7b3498 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com,rdcronin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117343 Tbr: calamity@google.com,rdcronin@google.com Change-Id: I7e569125522bc3e2f6af1dfd0efc10b9643ef094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818754}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows Buffer class within tests, as well as basic unit tests to validate the test class behaviors. Bug: 1035527 Change-Id: Ib4507c66d7b9c975e7580b2053f23b1dc54f3402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485553Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818753}
-
Sammie Quon authored
There is similar OverviewAnimationStateWaiter which has a wrapper in ShellTestApi. Test: existing tests Bug: none Change-Id: I90755f59e4f246641f7b0fa1c1701ceb68651f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476617Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Gang Wu authored
Bug: 1136677 Change-Id: Ia14627cfae1832710a8652b942718173abc7487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482429Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818751}
-
minch authored
Bug: 1131543 Change-Id: Ib58a9069b740f692038d8031a55da74a0dfc3b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477525 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818750}
-
Eugeny Aristov authored
For GCC it's important, otherwise in this specific case std::underlying_type is taken for incompatible types (int, char, etc.) before std::enable_if_t throws out inproper template. Error example (GCC 8.4.0): /usr/include/c++/8/type_traits: In instantiation of 'struct std::underlying_type<long unsigned int>': ../third_party/blink/public/common/privacy_budget/identifiable_token.h:121:13: ../chrome/browser/privacy_budget/privacy_budget_ukm_entry_filter.cc:61:73: required from here /usr/include/c++/8/type_traits:2009:38: error: 'long unsigned int' is not an enumeration type Bug: 819294 Change-Id: Ic4b329d12ca2c8899e62c65b2a327b227caa2c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480442Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#818749}
-
Yury Khmel authored
This adds ability to enforce throttling mode and adds obsever to receive throttling change updates. DD: go/arc_power_control TEST=Unit test + locally in context of prototype. BUG=b:170982650 Change-Id: I1fe3633ff5792355917c890280155a8b5d73892f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477454 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99620c4bfcfc..6bc78433f44f 2020-10-19 jalyn@microsoft.com Settings: Remove old ShortcutsScreen If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib54491ee10697045b9d3e5b36db27dcf8d8c80df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486468Reviewed-by:
-
Tomasz Wiszkowski authored
This change addresses the problem, where the reordering suggestions in Java causes suggestions to be mis-reported by Native. The change enforces ordering consistency between Java and Native pools by forwarding the call to partially group suggestions by search vs URL to Native. The expected location that will be responsible for partial grouping is the Native AutocompleteResult class, where Java AutocompleteResult will simply serve as an interface, so this change aligns with our broader plan to move the suggestion ordering to Native. Bug: 1050813 Change-Id: I4b08d7c41dce4e4a580c8d0490fd4cfe6c11091b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481830 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#818746}
-
Jamie Madill authored
Sample approximate summed test run improvements: win-angle-deqp-rel-64: 100 shards, 300 minutes -> 27 shards, 50 minutes win-angle-deqp-rel-32: 8 shards, 45 minutes -> 2 shards, 5 minutes linux-angle-rel: 70 shards, 80 minutes -> 21 shards, 27 minutes Android should be unchanged. In total this may save almost 6 hours of bot time per ANGLE CQ run. Bug: angleproject:5124 Change-Id: I3be354058e32293c1360a2ed279666ecf19e41fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454401 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#818745}
-
James Zern authored
libwebp @ v1.1.0-37-g9f6055fc + sync fuzz_seed_corpus w/libwebp-test-data and delete unused local copy animdecoder_fuzzer.cc isn't built as all its dependencies aren't imported currently; WebPAnimDecoder is unused in chrome NOPRESUBMIT=true (due to include/nullptr warnings in third_party code) Bug: webp:409 Change-Id: Id41fd215652d0339af3410e7948350456ddce2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482388 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818744}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iad4f08b81d86af1b455105bedfaa0abfa859cbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486446Reviewed-by:
-
Vadim Bendebury authored
This information is of interest, especially in case of Board ID flags misconfiguration incidents. BUG=chromium:1089267 TEST=none Change-Id: Ib93b0df5b58d08e72a1075a56c1bff24df53f6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446196Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadim Bendebury <vbendeb@chromium.org> Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#818742}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/aff4c0366314..c4593127cbdd 2020-10-19 dsinclair@chromium.org Include compiler header 2020-10-19 cwallez@chromium.org Roll third_party/swiftshader/ 2014e7b92..df17a7610 (79 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ife1ab7429ea37ad4ea138e777cee6e39a8e678fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486283Reviewed-by:
-
Frank Tang authored
ICU 68, to work with C++20, remove the #define of TRUE since the usage in libxml is as an int, use 1 instead. Bug: 1138555 Change-Id: I4c5955b3e80beccc8de071a129172af07c0ae0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478027Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818740}
-
