GitLab

Bug: 890054
Change-Id: I91cb2f1365ba5eb0ead2440fbc08e785eb5a58c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601688
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659739}

BUG=941120

Change-Id: I9aa263f404dcb4d673298823ddaa3b202521dbae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612218Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659738}

WebXR browser tests now verify that no WebXR gamepads are attached to
the navigator array and that the expected number or XRInputSources are
attached to the XRSession.

This fixes an issue that caused webxr gamepad browser tests to
consistently fail on some Windows machines because the gamepad API
would detect random USB devices and think they are gamepads and attach
them to the navigator array.

Also consolidated the gamepad-related tests in WebXrVrInputTest.java
because the WebXRGamepadSupport flag no longer exists.

Bug: 961371, 947581
Change-Id: I348a455c44b37a813409af9bf4a7e5fefb68a51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602097
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659737}

This functionality was added purely for mus and is no longer necessary.

BUG=958241
TEST=purely dead code removal
TBR=estade@chromium.org

Change-Id: Ifc6905dc078d51584fc49cb5dd21654efc438e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610988Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659736}

It appears that the default "rotate" animation for dialogs fails to
handle layer visibility correctly and thus triggers DCHECKs and other
issues. Using "fade" works around this until "rotate" can be fixed.

That fix is happening on
https://chromium-review.googlesource.com/c/chromium/src/+/1610462

Change-Id: I062035c52142f054cd9032a0b785db314d442d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612217
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#659735}

Expiration is left at the default (M76).

Bug: 959086
Change-Id: I7c87dc520bbb5a310e5a36120c3e3add7ead23b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610495
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659734}

Bug: 958997
Change-Id: I5508e191ac7767a8f1266e66157d59e08047c5e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612277Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659733}

This is because the reference_view is a BrowserAppMenuButton which
is no longer a MenuButton.

Bug: 962442,960952

Change-Id: I00c40561290c21c13dbad250017a0d09756b8cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610542
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659732}

The code is no longer in use, since variations now uses the network
service's URLLoader interface, instead of URLFetchers.

Bug: None
Change-Id: If506394f8abbdc4bc5ea166652dbdabcda8f172d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612046
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659731}

The FormControlsRefresh feature will make macOS use the Aura theme (and
the refresh theme, where it is implemented).

Add a runtime feature, FormControlsRefresh, to control this in blink.

Bug: 846357, 956778
Change-Id: I4eefee7ef06748b95d4f2df361a38001a4989b0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611108Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659730}

This change adds a test for the Serial API similar to the ones added
to exercise issue 723503 for WebUSB and Web Bluetooth and duplicates
the fix used to resolve this issue for Web Bluetooth.

Change-Id: If6efaf9a0105b48fc158dd7f52762fb23c8634ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606591
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659729}

Add logic to set FeaturePodsContainer Layout according to page numbers
Add PageIndicatorView in UnifiedSystemTrayView

The SystemTray will be limited to show 3x3 FeaturePodButtons at a time.
Additional Buttons will be added to additional pages.
The available pages will be signified by small buttons under the
feature pods container.

Bug: 914077
Change-Id: I8e2e1a51b0503bda251e409f7ce77d81f57f136e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590610
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659728}

The WebXR Spec requires that select events be fired in the order:
1) SelectStart
2) Select
3) SelectEnd

The current implementation in chrome flips the order of events 2 and 3.
This change flips that order to match the spec.

Bug: 960997
Change-Id: I3a8aca683898515102999d86b7bcee6c6e74ef24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607180
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659727}

This reverts commit c29b91d2.

Reason for revert: making CQ tests very slow crbug.com/962601

Original change's description:
> Relandx2 "Do not create PrefetchGCMAppHander in reduced mode"
> 
> This reverts commit 63893bf5.
> 
> Reason for reland: fix performance regression outlined in crbug.com/950549.
> This was done by scheduling the gcm token refresh to after the browser has
> started fully (i.e. after the critical path, which ends after first page load).
> 
> Original change's description:
> > Do not create PrefetchGCMAppHander in reduced mode
> >
> > If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the
> > prefetch service a closure to create the gcm app handler on demand.
> >
> > This cl also changes the signature of the getter for PrefetchGCMHandler in
> > PrefetchService to require a profile to be passed in. This ensures that:
> > 1) the getter can only be called in full browser mode (there is no profile in
> > reduced mode).
> > 2) if PrefetchGCMHandler hadn't been created yet, then it can be
> > created on demand using the aforementioned profile.
> >
> > Bug: 934337
> > Change-Id: I7e813f425e0ba8687f9b519b4300fa7eec014929
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737
> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Xi Han <hanxi@chromium.org>
> > Reviewed-by: Jian Li <jianli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#640470}
> 
> Bug: 950549, 934337
> Change-Id: Id8824fa087e31ac7b875a828318af5a4ca9afd47
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588164
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
> Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656215}

TBR=carlosk@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 934337, 962601
Change-Id: I2f4013a801ef6c7359df79a73b0dec3e90471f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612378Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659726}

As of r626853 SerialChooserController no longer owners its own
connection to the SerialPortManager. Since this connection can now
outlive the controller instance it is not safe to bind an raw pointer
to |this|. This patch adds a WeakPtrFactory so that callbacks arriving
after the controller has been destroyed are safely discarded.

Bug: 952709
Change-Id: I1994b0aa3e7514bb200c304e70accce4b17e0b9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606588Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659725}

Bug: 958938
Change-Id: Ia6dd28f199732906327a2ca6b7d2d45053690ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600626Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659724}

Bug: None
Change-Id: Id2c3d0305531d6da3b58847fa9d9c0e3836943cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611905
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659723}

Allow the backgrounds and shortcuts menus to be opened
via keyboard navigation - enter/space.

Screencast: http://go/scrcast/NTc1MjEyMzE5NTEyOTg1Nnw1NTNkYjkwZS0yYg

Bug: 937570
Change-Id: Ie62b14a64e766cb82d59ab381c97b6e9bfdc2b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611091
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659722}

This reverts commit 0e1e6eb3.

Reason for revert:
 - gzipped_resource_* Grit output no longer exists.
 - the feature added by this CL is not actually used.
 - if it ends up needed, an alternative exists (inspect gzip header)

Original change's description:
> Use cpp file map to unpack gzipped resources
>
> We can get gzipped flag from gzipped_resource_map_source or
> gzipped_resource_file_map_source and use it to unpack gzipped resources
> with unpack.py.
>
> Bug: 738243
> Change-Id: I1bf56126f702fa6efbd2b3e8806ade9bdf904d1f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518520
> Commit-Queue: Dmitry Guketlev <yavanosta@yandex-team.ru>
> Reviewed-by: Dan Beam <dbeam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#640738}

TBR=dbeam@chromium.org,dpapad@chromium.org,aee@chromium.org,yavanosta@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 961063
Change-Id: If5f277929127207d018e9da30b7b6714000db2ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612088
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659721}

This PRESUBMIT would have prevented the bug of
https://chromium-review.googlesource.com/c/chromium/src/+/1610484


Bug: 961830
Change-Id: If6a2d4d5073c7333d1a0aec56bb8f7a2bb21f0d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612049
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659720}

Use enum class instead of enum for BoxLayout::MainAxisAlignment
enum class is more type safety.

Bug: 940736
Change-Id: I8e113988003f2efb9783ad4ad5b347eef69e2825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605252
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659719}

Start listening for restart event before clicking on the guest
signin button.

Bug: 963123
Change-Id: Ie28aacac3ccfa675ab194c2f497ca6d0a67dadb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612380
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659718}

The merge_web_test_results.py script used to use the current working
directory when --output-directory isn't specified but --output-json is
(which is the case on Swarming). This could be dangerous as the script
will clean everything in the output directory.

This CL changes the behaviour to always create a temporary output
directory if it's not specified.

Bug: 960994
Change-Id: If1dd0f060557e7fb7014ea0a1dc2ba0bf234e1e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606820Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659717}

In preparation for a follow up CL that moves UninstallApp into
InstallFinalizer, make UninstallApp async.

Bug: 916381
Change-Id: Id8e053cb6708c210a3221bfcdce39efa6a7a34ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608866
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659716}

The CSS WG resolved [1] to add a new value 'anywhere' to the 'line-break'
CSS property in order to allow additional breaking opportunities not
considered in the definition of the 'word-break: break-all'. See the
intent-to-implement request [2] for further details.

This patch implements the feature for LayoutNG too.

[1] https://github.com/w3c/csswg-drafts/issues/1171
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/r7PkIqQDvlU/X0aocVo9BQAJ

Bug: 720205, 959131
Change-Id: I8938e3c2216b130f0bfafa7a3f132b5dac194fb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497133
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659715}

https://skia.googlesource.com/skia.git/+log/69258ffdb88a..c8a84d2b7ff9


git log 69258ffdb88a..c8a84d2b7ff9 --date=short --no-merges --format='%ad %ae %s'
2019-05-14 robertphillips@google.com Move compute_combined_buffer_size behind GR_TEST_UTILS
2019-05-14 mtklein@google.com preserve comments past the #include ""
2019-05-14 bungeman@google.com Remove GpuLayerCacheTest
2019-05-14 mtklein@google.com remove SkMiniPicture and co.
2019-05-14 robertphillips@google.com Remove some uses of GrBytesPerPixel (take 2)
2019-05-14 mtklein@google.com remove SkLiteDL
2019-05-14 csmartdalton@google.com Clear and discard stencil buffers on tilers
2019-05-14 egdaniel@google.com Reduce use of GrPixelConfig inside of GrVkCaps.
2019-05-14 bungeman@google.com Remove SK_ALLOW_STATIC_GLOBAL_INITIALIZERS from tests.
2019-05-14 brianosman@google.com Fix stack indexing bug in vectorized unsigned -> float conversion


Created with:
  gclient setdep -r src/third_party/skia@c8a84d2b7ff9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Change-Id: Ibf705db9e8bf7884f36fe1ab2061789f52fb9932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612207Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659714}

Bug: 914500
Change-Id: Icd2173d32a40b1038c5ce8efd8f4cdff03632660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610298Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659713}

Bug: 956954
Change-Id: I6478ba316c02b46e93c30135e6f7077f680d57dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609595Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659712}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f1377b76560..3d86f06bc794


git log 9f1377b76560..3d86f06bc794 --date=short --no-merges --format='%ad %ae %s'
2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@3d86f06bc794

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ie6249eca0b9f0254d3af567acc627a6f8dc76c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612201Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659711}

UX provided some final strings for the Remove dialog, and this CL adds
those strings.

This CL also updates the RemoveSuggestionBubbleDialogDelegateView by
giving the buttons translated text, providing a translated title,
and reordering some labels.

It also plumbs in TemplateURLService to fetch the shortname of the
default search provider.

Bug: 929477
Change-Id: I56d38c006faa51f921b5a054ae5443b3d1656acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610503
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659710}

https://swiftshader.googlesource.com/SwiftShader.git/+log/69c37491787a..3d7b7ea134d1


git log 69c37491787a..3d7b7ea134d1 --date=short --no-merges --format='%ad %ae %s'
2019-05-14 bclayton@google.com Implement a2b10g10r10_unorm_pack32.
2019-05-14 amaiorano@google.com CMake: apply the warning treatment to msvc builds


Created with:
  gclient setdep -r src/third_party/swiftshader@3d7b7ea134d1

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/131896622,chromium:b/131171141,chromium:b/132445520
TBR=swiftshader-team+autoroll@google.com

Change-Id: Ife9cc94d88f345f0a4786174563c45e8da6e10f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612204Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659709}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddf034cde9e9..01010b5cd43c


Created with:
  gclient setdep -r src-internal@01010b5cd43c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com

Change-Id: Ie382fe548472694185ecdcc9acbb424a5b91e06f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612203Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659708}

Updated field trial config to separate features into the individual groups
that are used in the study. This should resolve issues raised by Finch
analyzers.

Bug: 956164,956613
Change-Id: I7b07f0cab091f39aed7bd9ecce17126322c81287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612257Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659707}

This is needed by Cast to change the values of the constants when Multizone is
enabled.

Bug: 124402185
Change-Id: I4563ec0c9de875cf998ffc8ebedc7b2b701b80e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610842Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Alex Leung <alexleung@google.com>
Cr-Commit-Position: refs/heads/master@{#659706}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/40748dc575b7..ea6122f18e6a


git log 40748dc575b7..ea6122f18e6a --date=short --no-merges --format='%ad %ae %s'
2019-05-14 akeshet@chromium.org skylab create-test: don't capture stderr
2019-05-14 evgreen@chromium.org cros_build_lib: Ignore false parted failures
2019-05-14 gbiv@google.com cros_tidy: point at our parser's new home


Created with:
  gclient setdep -r src/third_party/chromite@ea6122f18e6a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I63bf4d7cb5de3a0a0342603775f6aa658fbe0190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612206Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659705}

In general, threads shouldn't care if they're not the first one to
initialize OLE or COM.

BUG=961019

Change-Id: I4ea87d67a2f2693b54d845d71bfc241f526ba96c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612317
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659704}

R=ellyjones@chromium.org

Change-Id: Iebb76f3643c63ba41a3414986d8f6847a20b4948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612318
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659703}

Bug: 941516
Change-Id: If61199c999f6018d4993eaa2bd6c1fb02006845a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611870Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659702}

1. In order to collect the anchors between the start and end positions
   of an `AXRange`, an incorrect condition is evaluating if the start of
   the current anchor is equal to its end position, expecting such case
   to only be present when we reach the end of the `AXRange`.

   Such assumption does not hold for anchors of objects invisible to
   the text representation (such as checkboxes, images, etc.), since the
   anchor is empty and its start and end positions are the same.

   Refactoring `AXRange::GetAnchors` to cover such case.

2. Introducing unit tests for `AXRange::GetAnchors`.

3. Adding unit test coverage in `AXPlatformNodeTextRangeProviderTest`
   for the issue in `GetBoundingRectangles` which led to this bug.

Bug: 928948
Change-Id: I73ef429b7fb5043cfb535ce05909ac243b31aef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595545
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659701}

This testcase hit a DCHECK while rebalancing split inlines

LayoutInline::SplitInlines
  LayoutBoxModelObject::MoveChildTo

Layout tree looks like it should work. I think that our previous
fix of not splitting any anonymous inlines was incorrect.
This reverts my older fix at
https://chromium-review.googlesource.com/c/chromium/src/+/1610522/1

to a more conservative skip:

if (o->IsLayoutNGInsideListMarker())

instead of

if (o->IsAnonymous())

clusterfuzz layout tree looks like this:

    LayoutNGBlockFlow 0x71c8ea202a0  	FORM id="el0"
        LayoutNGBlockFlow (anonymous) 0x71c8ea20530
          LayoutInline (anonymous) 0x71c8ea303d0
*           LayoutInline 0x71c8ea30250 continuation=0x71c8ea203e8	Q id="el2"
              LayoutInline 0x71c8ea30310	<pseudo:before>
                LayoutQuote (anonymous) 0x71c8ea3c2f8
                  LayoutTextFragment (anonymous) 0x71c8ea40370 """
            LayoutInline 0x71c8ea30190 	Q id="el5"
              LayoutInline 0x71c8ea300d0	<pseudo:before>
                LayoutQuote (anonymous) 0x71c8ea3c108
                  LayoutTextFragment (anonymous) 0x71c8ea40130 "'"
              LayoutInline 0x71c8ea30490	<pseudo:after>
                LayoutQuote (anonymous) 0x71c8ea3c010
                  LayoutTextFragment (anonymous) 0x71c8ea4001

Bug: 962841
Change-Id: I5165089499c2ff7856f999d2926e07d4a992960d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611866Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659700}