- 04 Jul, 2018 40 commits
-
-
Matt Falkenhagen authored
This is only called by ServiceWorkerVersion::StartInternal, which already assumes the context is alive (since it passes it to ServiceWorkerProviderHost which uses it). The motivation is removing the callback passed to Start. This is currently invoked in only two places: * When context_ was null (removed in this CL) * When a OnScriptEvaluated IPC is received from the renderer. The callback isn't invoked when startup failed before script evaluation, and in success cases it is invoked before startup finishes (OnStarted()). It can even be invoked with failure when startup succeeds, when an uncaught runtime error occurred during script evaluation. I aim to improve the code by first eliminating the callback then adding back one when the implementation is capable of calling it in a more sensible manner. Bug: 859912 Change-Id: I74643f1a64ef6a637ccd9db6bf1f9e889c814b3a Reviewed-on: https://chromium-review.googlesource.com/1124722 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572534}
-
Vasilii Sukhanov authored
- "Use password for:" title isn't used anymore in the password dropdown. - The dropdown should have a footer "Manage passwords" leading to the settings. Bug: 851021 Change-Id: I24696fffa7c2db7bc21c6b9ec7fcb3aa9c277429 Reviewed-on: https://chromium-review.googlesource.com/1125061 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572533}
-
Sami Kyostila authored
NOTRY=true TBR=perezju@chromium.org CC=johnchen@chromium.org,crouleau@chromium.org BUG=859175 Change-Id: I9fe4d4d5f2b28c13b8840a0a8c1b4567f1512512 Reviewed-on: https://chromium-review.googlesource.com/1125060Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#572532}
-
Tatsuhisa Yamaguchi authored
Bug: 850437 Test: manually tested Change-Id: I36952d2962dc46ea0d9867fd89a7841d02fc1bbe Reviewed-on: https://chromium-review.googlesource.com/1125583Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572531}
-
Sami Kyostila authored
NOTRY=true TBR=perezju@chromium.org CC=wangxianzhu@chromium.org BUG=859979 Change-Id: Iaf61159ca9115ecced3c1598fd1934bae54461de Reviewed-on: https://chromium-review.googlesource.com/1125059Reviewed-by:
-
Sasha Morrissey authored
Also added integration tests for checking this in the context menu. Test: browser_test --gtest-filter="ContextMenu/FilesApp*" Bug: 719959 Change-Id: Ieea3d5d97a4ce47b47812ef64a79325c6d1f1b7a Reviewed-on: https://chromium-review.googlesource.com/1105211 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572529}
-
Mihai Sardarescu authored
This CL adds namespace unified_consent to all c++ files in folder //components/unified_consent Bug: NONE Change-Id: I93dbfe89f97b69e23d4da3cc5f770c03a56b47c0 Reviewed-on: https://chromium-review.googlesource.com/1122861 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572528}
-
Egor Pasko authored
Makes it possible to --use-live-sites when invoking from command line. Support for tools/perf/record_wpr was not tested, hence placing an assert there to avoid surprises at a later stage. Documentation about record_wpr [1] seems outdated as it does not mention wprgo, but I am not sure how much outdated it is, could be only this tiny detail. [1] Documentation page: "Telemetry: Record a Page Set" https://www.chromium.org/developers/telemetry/record_a_page_set Bug: 760498 Change-Id: I2278eba06eeceb724c5ae6779409df00add90a4e Reviewed-on: https://chromium-review.googlesource.com/1124857Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#572527}
-
Greg Kraynov authored
When we're in a nested RunLoop we can't run tasks in a batch. This comment update explains why. Bug: 828835 Change-Id: I8dcdf7f06d519f0e8087232b2d3c660e26510b60 Reviewed-on: https://chromium-review.googlesource.com/1124694Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#572526}
-
Tetsui Ohkubo authored
UnifiedSystemTray should not be hidden on the last notification removal, which is different behavior from old NotificationTray. TEST=manual BUG=857336 Change-Id: I083d48455be19d591833a17c9514ca1dbfe6903b Reviewed-on: https://chromium-review.googlesource.com/1124261Reviewed-by:
-
Mohamed Amir Yosef authored
This is more aligned with what other data types have and also better describes what this method is actually doing. Bug: 516866 Change-Id: I8eb93d645f49427f4e8bf071aaaaa527d63d6772 Reviewed-on: https://chromium-review.googlesource.com/1124855 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#572524}
-
Tetsui Ohkubo authored
This CL adjusts animation curves of some UnifiedSystemTray elements so that the animation looks more natural and elements would not overlap each other. Detailed spec of the animation curves is still WIP on UX side. TEST=manual BUG=858941,857346 Change-Id: Ibdcf9371d5436c5bd7ad6e094dab4b6b88bcf945 Reviewed-on: https://chromium-review.googlesource.com/1124259Reviewed-by:
-
Christopher Lam authored
This CL fixes an issue where the search field was not focused on load after a CSS change. This seemed to happen because the transition caused a frame of 'visibility: hidden' to race with the toolbar focus() call. Bug: 857370 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id4ac3b15e1f1a886b6fb1c3af4512a878fb87150 Reviewed-on: https://chromium-review.googlesource.com/1122027Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#572522}
-
Henrik Boström authored
Prior to this CL, MediaStreamTrackMetrics hooked up to streams, tracking not only all of the streams' tracks (CONNECTED/DISCONNECTED) but also any tracks that might be added or removed from the stream. This has not been necessary to do for a long time, since the RTP Media APIs are track-based, not stream-based, and the legacy addStream()-streams are shimmed on top of addTrack(). Adding a track to such a stream causes addTrack(), and there is no need for the MediaStreamTrackMetrics class to observe the streams. With this CL, MediaStreamTrackMetrics only care about tracks (direction, kind and id). This also covers the Unified Plan use case of tracks not necessarily belonging to any stream. There is room for improvements in this area, such as counting tracks added through replaceTrack(), but that should be handled separately. This CL removes the dependency on streams which unblocks RTCRtpTransceiver/Unified Plan work. Bug: 810708, 777617 Change-Id: I347e729560717be83b7b1a3571f25a8497d65e46 Reviewed-on: https://chromium-review.googlesource.com/1117691Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#572521}
-
Peter K. Lee authored
It seems awfully strange that location_bar_coordinator_unittest.mm is testing LocationBarLegacyCoordinator. It might have been a copy/paste error from http://crrev/c/941131 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0b9bf8d1cfa800fc2075618f9f98cb56ccfa86fd Reviewed-on: https://chromium-review.googlesource.com/1125399 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572520}
-
Yoshifumi Inoue authored
This patch introduces |TextIteratorTextState::GetTextForTesting()| as replacement of |Substring()|, because it is called only one place and it takes whole text, for improving code health. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id71f35c82c1906dfea9503a77506a6a437246bae Reviewed-on: https://chromium-review.googlesource.com/1125584Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572519}
-
Michael van Ouwerkerk authored
* Add setBottomBarHeight to IActivityHost * Hide the bottom bar shadow for dynamic modules Bug: 859819 Change-Id: Iab6e0d61326a76d32b4cd913061f85797197d7cc Reviewed-on: https://chromium-review.googlesource.com/1123837Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#572518}
-
Yutaka Hirano authored
CreateLoaderAndStart used in TryCreateDuplicateRequestIds created network::mojom::URLLoaderPtr and network::TestURLLoaderClient in it and hence the request got aborted. That will lead to flakiness because on a slow system the first request got aborted before the second request arrives. This CL fixes that. Bug: 799516 Change-Id: I4767d7f98185e633f229315074a9361b14e47e3b Reviewed-on: https://chromium-review.googlesource.com/1125581Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572517}
-
Luciano Pacheco authored
Putting this CL through to help because orodley@ can't TBR on the following CL. https://chromium-review.googlesource.com/c/chromium/src/+/1125704 TBR=dcheng@chromium.org Bug: 860168 Change-Id: I3673161fbfcd6940bbb508c149fa68c63c546822 Reviewed-on: https://chromium-review.googlesource.com/1125706Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#572516}
-
Vaclav Brozek authored
A space between two sentences was missing in a comment, so this CL adds it. Bug: 795462 Change-Id: Iaa1e92b411f919e34cd8a3737dcd289f85fecdf6 Reviewed-on: https://chromium-review.googlesource.com/1125660 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#572515}
-
Mohamed Amir Yosef authored
This CL extracts the logics for handling remote updates and committing local updates into BookmarkRemoteUpdatesHandler and BookmarkLocalChangesBuilder respectively. This is to simplfy the BookmarkModelTypeProcessor. Before this CL: processor scheduled metadata save only if there is a change in the metadata without change in the model, because the model would trigger the save in such cases. After this CL: processor schedules metadata save every time remote updates are processed regardless from they entailed a change in the model or not. This simplifies the code, and the bookmark storage should squash subsequent save requests, so consecutive save requests from the model and the processor should result in only one actually save on disk. Bug: 516866 Change-Id: I7918086b31b11f7a72804b152f23af2b059cca3d Reviewed-on: https://chromium-review.googlesource.com/1124854 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This is amazing. Essentially if an element has "default" quirky start margins, and it is an empty block, the end margin (regardless of if it is quirky or not), becomes quirky. This doesn't propagate to other elements however, see: https://www.software.hixie.ch/utilities/js/live-dom-viewer/?saved=6016 A bigger fix might be to change the default stylesheet to make all of these elements with quirky margins to have quirky margins on each side, then change the logic for the bottom quirkyness. But this is a pretty scary change. (This may however match other browsers better eventually). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5895a148211a5a1291e9b0a935fea08e094d4ec0 Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1124071Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#572513}
-
Nicholas Verne authored
Prior to this change, the lower illustration would change position when label strings changed size or the progress bar became visible. This is prevented by creating two container views, the lower of which is "bottom aligned", and in which the illustration is the only child view. Bug: 848118 Change-Id: I17ff9309152482ea718ed1eb13bf65d823a79bcf Reviewed-on: https://chromium-review.googlesource.com/1125597 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572512}
-
Matt Falkenhagen authored
We expect the precreated AppCacheHost to exist in AppCacheNavigationHandleCore once navigation starts on the IO thread. But we know it doesn't exist at some point. This CL add more logging to try to narrow down possibilities of where the host was lost, if it was ever created. Bug: 857005 Change-Id: I0804b6dd972daf6e28e6ee5bf403e30b94df0b1a Reviewed-on: https://chromium-review.googlesource.com/1125649Reviewed-by:
-
Makoto Shimazu authored
TBR=luoe@chromium.org NOTRY=true Bug: 859064 Change-Id: I2c8478e61a3680d2a170afa70bd5e689e7e2e97e Reviewed-on: https://chromium-review.googlesource.com/1125657Reviewed-by:
-
tzik authored
This CL replaces most MockTimer with MockOneShotTimer or MockRepeatingTimer as a preparation of OnceCallback support of base::Timer. Bug: 850247 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I949bc78c5e103baa610a8a2d1197901ceb090c50 Reviewed-on: https://chromium-review.googlesource.com/1105812 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#572509}
-
yiyix authored
BeginMainFrameIntervalCritical assume that the browser is at 60 fps, but browser has a slower fps rate comparing to Renderer. So spikes in this metrics doesn't mean regression in system. Bug: 656849 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12b6e7d7fe9aa080ea5267445826ac54b3fb3938 Reviewed-on: https://chromium-review.googlesource.com/1124761 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#572508}
-
Luciano Pacheco authored
Add My Files parent on navigation tree, navigation_list_model.js creates the "My Files" entry as a EntryList and EntryListItem on directory_tree.js is the UI element to display it. This is a continuation of: * crrev.com/c/1086680 * crrev.com/c/1116400 * crrev.com/c/1116517 Some changes required to display EntryList: * isDescendantEntry: Inspect on each of EntryList's children. * FileManager.initializeUI: Fetch asynchronously the flag to be able to use before displaying the navigation tree. * extract the switch (modelItem.type) to its own function, to be able to reuse it. Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0 Bug: 846587, 846592, 846591, 846590, 846589, 846588, 846586 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id8f27f09763d4478b93d52dd32e4ed851c7e448d Reviewed-on: https://chromium-review.googlesource.com/1113258 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572507}
-
Noel Gordon authored
Shave about 500ms off per test by only loading the file(s) the tests require. Remove getExpectedFileEntryRows helper as a side-effect: it is now unused so git-mv it to /dev/null. Bug: 859008 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id49678e63d2160cbf7ce4daee45d36edaa124b97 Reviewed-on: https://chromium-review.googlesource.com/1125639Reviewed-by:
-
Jochen Eisinger authored
Replaces the two distinct implementations of CryptAuthAccessTokenFetcher with having CryptAuthClientImpl directly construct a PAATF. Those two implementations are each identical in functionality to using a PAATF in kImmediate mode: the first simply wraps PAATF used in kImmediate mode, while the second just makes an immediate request on ProfileOAuth2TokenService. Also eliminates a //chromeos implementation of CryptAuthClientFactory, as that implementation is now identical with the //components/cryptauth implementation, which is used instead in the //chromeos context. BUG=809433 R=blundell@chromium.org,khorimoto@chromium.org Change-Id: I93ee9e736395bc71a1e741fc45d027ff32787536 Reviewed-on: https://chromium-review.googlesource.com/1107715 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#572505}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6784ffa78e70..233c65202e69 git log 6784ffa78e70..233c65202e69 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@233c65202e69 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I7944b5466e69d1c3eb7667ed506622f8cc1a5c0e Reviewed-on: https://chromium-review.googlesource.com/1125619Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572504}
-
Luciano Pacheco authored
This is a continuation of crrev.com/c/1086680 and crrev.com/c/1116400. isFakeEntry changed the logic to not use operator "in" since Closure compiler was failing for FilesAppEntry types: "ERROR - Cannot use the IN operator with structs". Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I34914893d01bba43fdbcfc9e4b197031e50c662a Reviewed-on: https://chromium-review.googlesource.com/1116517 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
TBR=reveman@chromium.org Bug: 856145 Change-Id: I8280cf4c382282237d24bd6c4f432104c5f023aa Reviewed-on: https://chromium-review.googlesource.com/1125645Reviewed-by:
-
Nicholas Verne authored
Crostini Terminal icon now has a Shut Down Linux item, which is enabled if and only if the default vm is running for this user. CrostiniManager now tracks |running_vms_| and updates this multimap when vms start and stop. Bug: 848116 Change-Id: I1130f0ff2e122828c81c286fa3a4362e3cb3138d Reviewed-on: https://chromium-review.googlesource.com/1124065Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#572501}
-
Trent Apted authored
Although it doesn't flake in Release, the presense of DCHECKs makes this test fail. Waiting just for the gallery element could read the button state in the static gallery.html DOM, so wait for the first image to be fully loaded. Bug: 857021 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4e07384b105489410a73894b4a9e0a58bdae287d Reviewed-on: https://chromium-review.googlesource.com/1125589Reviewed-by:
-
Luciano Pacheco authored
This is a preparation for crrev.com/c/1113258 which uses this deps. Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9fc23fa6a137df4256420464384ac3366d260b3c Reviewed-on: https://chromium-review.googlesource.com/1116400 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I147efd9556ff6dad0a5afb08f29f791dd6ef0547 Reviewed-on: https://chromium-review.googlesource.com/1125533Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22bb66f2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20740 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=markdittmer No-Export: true Change-Id: Idc755344530ed753097aea477e632b001b51d615 Reviewed-on: https://chromium-review.googlesource.com/1125530 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572497}
-
Luciano Pacheco authored
Add interface FilesAppEntry which is the base interface that moving forward the app UI will converge as base type that can be displayed on different UI components such as: navigation tree, file list and breadcrumbs, eventually superseding Entry type. Add VolumeEntry which implements interface FilesAppEntry to represent a Volume, this will allow to display Volumes on file list/Right Hand Side (RHS). Add EntryList which implements interface FilesAppEntry to represent a list of entries. This will be used to implement "My Files" which will contain a list of VolumeEntry for the volumes: Downloads, Linux Files (Crostini) and Play Files (ARC++). Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0 Bug: 846587, 835203 Test: Unit-test for the new types. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2fce233338f8b8e0969b77daf4c77139852c441 Reviewed-on: https://chromium-review.googlesource.com/1086680 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Tarun Bansal authored
This separates out the code for parsing accept-ch and accept-cl-lifetime header. This makes it easier to parse http-equiv accept-cl-lifetime header which will be added in the next CL. Previously, when only accept-ch header was present, it was handled using a different code path then when both accept-ch and accept-cl-lifetime headers are present. This CL changes it to handle the two headers separately. That also makes it possible to unify the two code paths. Change-Id: I1013419a55360249718855677678356f8446ec11 Bug: 852484 Reviewed-on: https://chromium-review.googlesource.com/1125083 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
